Re: Deltifying directories on the server

2011-02-01 Thread Branko Čibej
You do know that diff and delta are two different beasts, and that the diff optimizations have no effect on deltas? :) The problem with directory deltification lies in the length of the delta chain and the frequency of directory lookup compared to file access. The sad fact is that our directory

RE: [PATCH] New XFail tests for issue 3609

2011-02-01 Thread Bert Huijben
-Original Message- From: Noorul Islam K M [mailto:noo...@collab.net] Sent: dinsdag 1 februari 2011 5:58 To: dev@subversion.apache.org Subject: Re: [PATCH] New XFail tests for issue 3609 Noorul Islam K M noo...@collab.net writes: Log [[[ New XFail tests for issue 3609.

Re: [PATCH] New XFail tests for issue 3609

2011-02-01 Thread Noorul Islam K M
Bert Huijben b...@qqmail.nl writes: -Original Message- From: Noorul Islam K M [mailto:noo...@collab.net] Sent: dinsdag 1 februari 2011 5:58 To: dev@subversion.apache.org Subject: Re: [PATCH] New XFail tests for issue 3609 Noorul Islam K M noo...@collab.net writes: Log [[[

RE: [PATCH] New XFail tests for issue 3609

2011-02-01 Thread Bert Huijben
-Original Message- From: Noorul Islam K M [mailto:noo...@collab.net] Sent: dinsdag 1 februari 2011 12:41 To: Bert Huijben Cc: dev@subversion.apache.org Subject: Re: [PATCH] New XFail tests for issue 3609 Bert Huijben b...@qqmail.nl writes: -Original Message- From:

Re: Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir)

2011-02-01 Thread Johan Corveleyn
On Mon, Jan 24, 2011 at 3:21 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: Johan Corveleyn wrote on Mon, Jan 24, 2011 at 02:42:11 +0100: Hi, Already for some time now, update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir) crashes on my machine:     svn: In file

RE: Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir)

2011-02-01 Thread Bert Huijben
-Original Message- From: Johan Corveleyn [mailto:jcor...@gmail.com] Sent: dinsdag 1 februari 2011 13:28 To: Daniel Shahaf Cc: Subversion Development Subject: Re: Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir) On Mon, Jan 24, 2011

Re: Deltifying directories on the server

2011-02-01 Thread C. Michael Pilato
On 02/01/2011 04:43 AM, Branko Čibej wrote: You do know that diff and delta are two different beasts, and that the diff optimizations have no effect on deltas? :) The problem with directory deltification lies in the length of the delta chain and the frequency of directory lookup compared to

Re: Deltifying directories on the server

2011-02-01 Thread Greg Hudson
On Tue, 2011-02-01 at 10:29 -0500, C. Michael Pilato wrote: I can only really speak for the BDB side of things, but... what he said. I'll elaborate a little bit. API issues aside, we're used to putting artifacts from different versions in different places. More so in FSFS, where it was baked

Re: Deltifying directories on the server

2011-02-01 Thread Hyrum K Wright
On Tue, Feb 1, 2011 at 10:54 AM, Greg Hudson ghud...@mit.edu wrote: On Tue, 2011-02-01 at 10:29 -0500, C. Michael Pilato wrote: I can only really speak for the BDB side of things, but... what he said. I'll elaborate a little bit.  API issues aside, we're used to putting artifacts from

Re: svn commit: r1064905 - in /subversion/branches/ignore-mergeinfo-log/subversion: libsvn_ra_svn/client.c svnserve/serve.c

2011-02-01 Thread Hyrum K Wright
Done in r1066137. -Hyrum On Fri, Jan 28, 2011 at 8:17 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: What about libsvn_ra_svn/protocol ? hwri...@apache.org wrote on Fri, Jan 28, 2011 at 21:59:14 -: Author: hwright Date: Fri Jan 28 21:59:14 2011 New Revision: 1064905 URL:

Re: svn commit: r1066087 - in /subversion/trunk/subversion/libsvn_subr: dirent_uri.c target.c

2011-02-01 Thread Stefan Sperling
On Tue, Feb 01, 2011 at 04:42:10PM -, cmpil...@apache.org wrote: Author: cmpilato Date: Tue Feb 1 16:42:10 2011 New Revision: 1066087 URL: http://svn.apache.org/viewvc?rev=1066087view=rev Log: Upgrade some uses of deprecated path functions to the new dirent/uri/etc. interfaces. *

Re: svn commit: r1066087 - in /subversion/trunk/subversion/libsvn_subr: dirent_uri.c target.c

2011-02-01 Thread Stefan Sperling
On Tue, Feb 01, 2011 at 08:14:13PM +0100, Stefan Sperling wrote: And here, we use it: +*pcommon = svn_uri_get_longest_ancestor(*pcommon, absolute, pool); See http://ci.apache.org/builders/svn-slik-w2k3-x64-ra/builds/1628/steps/Test%20fsfs%2Bserf/logs/faillog Actually,

Re: svn commit: r1066143 - /subversion/trunk/subversion/libsvn_subr/target.c

2011-02-01 Thread C. Michael Pilato
On 02/01/2011 02:13 PM, s...@apache.org wrote: Author: stsp Date: Tue Feb 1 19:13:24 2011 New Revision: 1066143 URL: http://svn.apache.org/viewvc?rev=1066143view=rev Log: Follow-up to r1066087: * subversion/libsvn_subr/target.c (svn_path_condense_targets): Initialise *pcommon in case

Re: EDEADLK in svn_repos_fs_begin_txn_for_commit2

2011-02-01 Thread Blair Zajac
On 1/26/11 5:24 PM, Blair Zajac wrote: On 01/26/2011 11:39 AM, Blair Zajac wrote: On 01/26/2011 11:15 AM, Philip Martin wrote: Blair Zajacbl...@orcaware.com writes: I'm now thinking of putting the retry in svn_io_file_lock2() instead of handling a deadlock in libsvn_fs_fs itself. It

Re: EDEADLK in svn_repos_fs_begin_txn_for_commit2

2011-02-01 Thread Blair Zajac
On 2/1/11 11:53 AM, Blair Zajac wrote: On 1/26/11 5:24 PM, Blair Zajac wrote: On 01/26/2011 11:39 AM, Blair Zajac wrote: On 01/26/2011 11:15 AM, Philip Martin wrote: Blair Zajacbl...@orcaware.com writes: I'm now thinking of putting the retry in svn_io_file_lock2() instead of handling a

Re: Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir)

2011-02-01 Thread Johan Corveleyn
On Tue, Feb 1, 2011 at 3:08 PM, Bert Huijben b...@qqmail.nl wrote: -Original Message- From: Johan Corveleyn [mailto:jcor...@gmail.com] Sent: dinsdag 1 februari 2011 13:28 To: Daniel Shahaf Cc: Subversion Development Subject: Re: Assertion failure during update_tests.py 58 (XFAIL:

Re: svn commit: r1066203 - /subversion/trunk/subversion/libsvn_repos/commit.c

2011-02-01 Thread Hyrum K Wright
It looks like this triggers another abort: (gdb) r 8 --allow-segfaults Starting program: /Users/Hyrum/dev/svn-trunk3/subversion/tests/libsvn_repos/repos-test 8 --allow-segfaults Reading symbols for shared libraries ... done Assertion failed:

Re: svn commit: r1066203 - /subversion/trunk/subversion/libsvn_repos/commit.c

2011-02-01 Thread C. Michael Pilato
On 02/01/2011 04:28 PM, Hyrum K Wright wrote: It looks like this triggers another abort: (gdb) r 8 --allow-segfaults Starting program: /Users/Hyrum/dev/svn-trunk3/subversion/tests/libsvn_repos/repos-test 8 --allow-segfaults Reading symbols for shared libraries

Re: Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir)

2011-02-01 Thread Johan Corveleyn
On Tue, Feb 1, 2011 at 10:10 PM, Johan Corveleyn jcor...@gmail.com wrote: On Tue, Feb 1, 2011 at 3:08 PM, Bert Huijben b...@qqmail.nl wrote: -Original Message- From: Johan Corveleyn [mailto:jcor...@gmail.com] Sent: dinsdag 1 februari 2011 13:28 To: Daniel Shahaf Cc: Subversion

Roadmap : 1.7 Release Status : Test Review : XFails

2011-02-01 Thread Paul Burba
Hi All, One of the roadmap items yet to be started was a 'test review' to 'Determine which XFail and WIP tests should remain so, and which need to be fixed before release.' I took a look at this today. We currently have 61 tests set to XFail (2 of these are WIPs). Here is how they break down:

Re: Roadmap : 1.7 Release Status : Test Review : XFails

2011-02-01 Thread Daniel Shahaf
[ http://svn.apache.org/repos/asf/subversion/trunk/notes/xfail-status ] Paul Burba wrote on Tue, Feb 01, 2011 at 21:53:34 -0500: Hi All, One of the roadmap items yet to be started was a 'test review' to 'Determine which XFail and WIP tests should remain so, and which need to be fixed before

Re: Roadmap : 1.7 Release Status : Test Review : XFails

2011-02-01 Thread Daniel Shahaf
LISTING: export_tests.py 20XFAIL exporting a file refuses to silently overwrite Issue #: None Target Milestone: N/A Thread: N/A Log: r1037998 Point Person: danielsh I'm not sure the test is valid --- doesn't it need a --force added to the 'export' invocation? I

Re: Roadmap : 1.7 Release Status : Test Review : XFails

2011-02-01 Thread Daniel Shahaf
LISTING: merge_tests.py You missed: merge_tests.py: XFail(SkipUnless(merge_change_to_file_with_executable, merge_tests.py-svntest.main.is_posix_os)), which Daniel Becroft (CC'd) recently added, and has submitted a patch that seeks to fix the

Re: [PATCH] New XFail test case for issue 3013

2011-02-01 Thread Noorul Islam K M
Noorul Islam K M noo...@collab.net writes: Daniel Shahaf d...@daniel.shahaf.name writes: Noorul Islam K M wrote on Fri, Jan 28, 2011 at 12:27:46 +0530: Daniel Shahaf d...@daniel.shahaf.name writes: Looks good, but I have a question: Noorul Islam K M wrote on Wed, Jan 26, 2011 at

Re: Roadmap : 1.7 Release Status : Test Review : XFails

2011-02-01 Thread Noorul Islam K M
Paul Burba ptbu...@gmail.com writes: Hi All, One of the roadmap items yet to be started was a 'test review' to 'Determine which XFail and WIP tests should remain so, and which need to be fixed before release.' I took a look at this today. We currently have 61 tests set to XFail (2 of

Windows Makefile (was: Re: Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir))

2011-02-01 Thread Daniel Shahaf
Johan Corveleyn wrote on Tue, Feb 01, 2011 at 13:28:24 +0100: So: I've tried removing SVN_USE_WIN32_CRASHHANDLER from gen_win.py (put it in comment, ran nmake config and rebuilt everything), then ran update_tests.py again: same result. It still crashes, and shows the ugly blocking popup. I

Re: Assertion failure during update_tests.py 58 (XFAIL: update a nonexistent child of a copied dir)

2011-02-01 Thread Lieven Govaerts
Johan, On Tue, Feb 1, 2011 at 11:16 PM, Johan Corveleyn jcor...@gmail.com wrote: On Tue, Feb 1, 2011 at 10:10 PM, Johan Corveleyn jcor...@gmail.com wrote: it continues until test nr 58, and then gives the popup. Hm, I'm confused. I guess I'm going to fire up my debugger and set a

Re: svn commit: r1066276 - /subversion/trunk/subversion/libsvn_subr/io.c

2011-02-01 Thread Blair Zajac
On 2/1/11 3:47 PM, s...@apache.org wrote: Author: stsp Date: Tue Feb 1 23:47:37 2011 New Revision: 1066276 URL: http://svn.apache.org/viewvc?rev=1066276view=rev Log: Follow-up to 1066249: Unbreak build with thread-less APR. * subversion/libsvn_subr/io.c (FILE_LOCK_RETRY_LOOP): Declare