Re: FSFS format 6

2011-02-21 Thread Stefan Fuhrmann
On 20.02.2011 21:02, Johan Corveleyn wrote: On Sun, Feb 20, 2011 at 6:35 PM, Mark Mielke wrote: That said, I'm also (in principle) against implementing cache of open file handles. I prefer architectures that cache intermediate data in a processed form that the application has made a determined

[l10n] Translation status report for trunk r1073220

2011-02-21 Thread Subversion Translation Status
Translation status report for trunk@r1073220 lang trans untrans fuzzy obs -- de2045 132 249 216 es1984 193 282 354 fr2168 9 19 22 it1837 340 476 174 ja1975

Re: svn commit: r1073102 - /subversion/trunk/subversion/include/private/svn_debug.h

2011-02-21 Thread Noorul Islam K M
Branko Čibej writes: > On 22.02.2011 02:50, Noorul Islam K M wrote: > >> danie...@apache.org writes: >> >>> Author: danielsh >>> Date: Mon Feb 21 18:14:02 2011 >>> New Revision: 1073102 >>> >>> URL: http://svn.apache.org/viewvc?rev=1073102&view=rev >>> Log: >>> * subversion/include/private/svn_de

Re: svn commit: r1073102 - /subversion/trunk/subversion/include/private/svn_debug.h

2011-02-21 Thread Branko Čibej
On 22.02.2011 02:50, Noorul Islam K M wrote: > danie...@apache.org writes: > >> Author: danielsh >> Date: Mon Feb 21 18:14:02 2011 >> New Revision: 1073102 >> >> URL: http://svn.apache.org/viewvc?rev=1073102&view=rev >> Log: >> * subversion/include/private/svn_debug.h >> (SVN_DBG): Merge docstrin

Re: svn commit: r1073102 - /subversion/trunk/subversion/include/private/svn_debug.h

2011-02-21 Thread Noorul Islam K M
danie...@apache.org writes: > Author: danielsh > Date: Mon Feb 21 18:14:02 2011 > New Revision: 1073102 > > URL: http://svn.apache.org/viewvc?rev=1073102&view=rev > Log: > * subversion/include/private/svn_debug.h > (SVN_DBG): Merge docstring with the documentation comment elsefile. > Is this ty

Re: apr_file_flush and short writes

2011-02-21 Thread Branko Čibej
On 21.02.2011 23:55, Blair Zajac wrote: > On 2/9/11 10:30 AM, Blair Zajac wrote: >> On 2/9/11 1:38 AM, John Szakmeister wrote: >>> On Mon, Feb 7, 2011 at 4:26 PM, Blair Zajac wrote: [I sent this to d...@apr.apache.org but haven't received a response. Thread here: http://mail-arc

Re: apr_file_flush and short writes

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 02:55:50PM -0800, Blair Zajac wrote: > On 2/9/11 10:30 AM, Blair Zajac wrote: > >On 2/9/11 1:38 AM, John Szakmeister wrote: > >>On Mon, Feb 7, 2011 at 4:26 PM, Blair Zajac wrote: > >>>[I sent this to d...@apr.apache.org but haven't received a response. Thread > >>>here: > >>

Re: apr_file_flush and short writes

2011-02-21 Thread Blair Zajac
On 2/9/11 10:30 AM, Blair Zajac wrote: On 2/9/11 1:38 AM, John Szakmeister wrote: On Mon, Feb 7, 2011 at 4:26 PM, Blair Zajac wrote: [I sent this to d...@apr.apache.org but haven't received a response. Thread here: http://mail-archives.apache.org/mod_mbox/apr-dev/201102.mbox/%3cf7b1928d-d32f-48

Re: [PATCH] Fix issue #3686 - executable bit not set during merge

2011-02-21 Thread Daniel Becroft
On Sun, Feb 13, 2011 at 2:15 AM, Daniel Shahaf wrote: > Daniel Becroft wrote on Sat, Feb 12, 2011 at 08:37:12 +1000: > > On Sat, Feb 12, 2011 at 7:31 AM, Daniel Shahaf >wrote: > > > > > Daniel Becroft wrote on Sat, Feb 12, 2011 at 06:27:31 +1000: > > > > On Fri, Feb 11, 2011 at 11:26 PM, Daniel

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 5.1)

2011-02-21 Thread Gavin Beau Baumanis
Hi Everyone, I have logged this submission in the issue tracker. #3817 refers. http://subversion.tigris.org/issues/show_bug.cgi?id=3817 On 21/02/2011, at 3:31 AM, Danny Trebbien wrote: > On Mon, Feb 14, 2011 at 12:38 AM, Daniel Shahaf > wrote: >> Danny Trebbien wrote on Sun, Feb 13, 2011 at

RE: svn commit: r1073043 - in /subversion/trunk/subversion: include/svn_delta.h mod_dav_svn/mod_dav_svn.c svnserve/main.c

2011-02-21 Thread Bert Huijben
> -Original Message- > From: phi...@apache.org [mailto:phi...@apache.org] > Sent: maandag 21 februari 2011 17:08 > To: comm...@subversion.apache.org > Subject: svn commit: r1073043 - in /subversion/trunk/subversion: > include/svn_delta.h mod_dav_svn/mod_dav_svn.c svnserve/main.c > > Auth

Re: [PATCH] New XFail test case for issue 3013

2011-02-21 Thread Gavin Beau Baumanis
Ping. This thread has received no new comments. On 28/01/2011, at 6:40 PM, Noorul Islam K M wrote: > Daniel Shahaf writes: > >> Noorul Islam K M wrote on Fri, Jan 28, 2011 at 12:27:46 +0530: >> >>> Daniel Shahaf writes: >>> Looks good, but I have a question: Noorul Islam K

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-21 Thread Keith Palmer Jr.
Thanks. --- - Keith Palmer ConsoliBYTE, LLC Ask for a quote! - QuickBooks Integration and Software Development ke...@consolibyte.com 1-860-341-1464 http://www.ConsoliBYTE.com/ Follow us on Twitter at: https://twitter.com/consolibyte AIM: consolibyte MSN: supp...@consoliby

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-21 Thread Keith Palmer Jr.
When I asked last week (and on many, many forums and in the users list) everyone told me it only encrypts the authentication, not the data, despite what the docs seem to indicate. --- - Keith Palmer ConsoliBYTE, LLC Ask for a quote! - QuickBooks Integration and Software Development k

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 02:48:49PM -0500, Keith Palmer Jr. wrote: > > Nothing in what you just copy-pasted indicates whether it's *the actual data > stream* that's being encrypted, or just the *authentication*. I need to know > if the checked-out files that are being transferred are encrypted or

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-21 Thread Greg Hudson
On Mon, 2011-02-21 at 14:48 -0500, Keith Palmer Jr. wrote: > Nothing in what you just copy-pasted indicates whether it's *the > actual data stream* that's being encrypted, or just the > *authentication*. I need to know if the checked-out files that are > being transferred are encrypted or not. Th

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-21 Thread Philip Martin
"Keith Palmer Jr." writes: > Nothing in what you just copy-pasted indicates whether it's *the > actual data stream* that's being encrypted, or just the > *authentication*. I need to know if the checked-out files that are > being transferred are encrypted or not. SASL provides encryption if negog

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Johan Corveleyn
On Mon, Feb 21, 2011 at 1:50 PM, Noorul Islam K M wrote: > "Bert Huijben" writes: > >>> -Original Message- >>> From: Branko Čibej [mailto:br...@xbc.nu] On Behalf Of Branko Cibej >>> Sent: maandag 21 februari 2011 13:19 >>> To: Philip Martin >>> Cc: dev@subversion.apache.org >>> Subject: R

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-21 Thread Keith Palmer Jr.
Nothing in what you just copy-pasted indicates whether it's *the actual data stream* that's being encrypted, or just the *authentication*. I need to know if the checked-out files that are being transferred are encrypted or not. --- - Keith Palmer ConsoliBYTE, LLC Ask for a quote! - Quic

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-21 Thread Philip Martin
"Keith Palmer Jr." writes: > So there's no one out there that knows whether SASL encrypts the data > stream, or just the authentication (or which SASL modules encrypt the > data, and which don't)? That depends on how you have configured your repository via svnserve.conf: [sasl] ### This option

RE: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Bert Huijben
> -Original Message- > From: Hyrum K Wright [mailto:hy...@hyrumwright.org] > Sent: maandag 21 februari 2011 18:40 > To: Noorul Islam K M; Subversion > Cc: Stefan Sperling > Subject: Re: [PATCH] cat_tests.py: Modify expected error string to use only > error codes. > > On Mon, Feb 21, 2011

Re: Is the svn:// protocol secure when encrypted via SASL?

2011-02-21 Thread Keith Palmer Jr.
So there's no one out there that knows whether SASL encrypts the data stream, or just the authentication (or which SASL modules encrypt the data, and which don't)? --- - Keith Palmer ConsoliBYTE, LLC Ask for a quote! - QuickBooks Integration and Software Development ke...@consolibyte

Re: svn commit: r1072431 - /subversion/trunk/subversion/include/private/svn_debug.h

2011-02-21 Thread Daniel Shahaf
Done and done: r1073102. Thanks. Hyrum K Wright wrote on Mon, Feb 21, 2011 at 09:53:37 -0600: > Perhaps combine with the comment on line 40 of svn_debug.h? (One or > the other feels quite redundant.) > > It might also be worth noting that lines produced this way won't > interfere with test sui

Re: svn commit: r1072084 - /subversion/trunk/subversion/svn/util.c

2011-02-21 Thread Daniel Shahaf
Hyrum K Wright wrote on Mon, Feb 21, 2011 at 12:18:19 +: > On Fri, Feb 18, 2011 at 5:53 PM, wrote: > > Author: danielsh > > Date: Fri Feb 18 17:53:36 2011 > > New Revision: 1072084 > > > > URL: http://svn.apache.org/viewvc?rev=1072084&view=rev > > Log: > > * subversion/svn/util.c > >  (svn_cl

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Hyrum K Wright
On Mon, Feb 21, 2011 at 4:19 AM, Stefan Sperling wrote: > On Mon, Feb 21, 2011 at 12:46:25PM +0530, Noorul Islam K M wrote: >> >> Modify expected error string to use only error codes and also restrict >> one of the lines to less than 80 characters. >> >> Log >> [[[ >> >> * subversion/tests/cmdline

Re: svn commit: r1072431 - /subversion/trunk/subversion/include/private/svn_debug.h

2011-02-21 Thread Julian Foad
> > * subversion/include/private/svn_debug.h > > (SVN_DBG): Add a docstring. [...] > > +/** Debug aid macro that prints the file:line of the call and printf-like > > + * arguments to the #SVN_DBG_OUTPUT stdio stream. Typical usage: > > + * > > + * > > + * SVN_DBG(("path='%s' rev=%ld\n", diren

Re: svn commit: r1072431 - /subversion/trunk/subversion/include/private/svn_debug.h

2011-02-21 Thread Hyrum K Wright
Perhaps combine with the comment on line 40 of svn_debug.h? (One or the other feels quite redundant.) It might also be worth noting that lines produced this way won't interfere with test suite expectations. -Hyrum On Sat, Feb 19, 2011 at 2:05 PM, wrote: > Author: danielsh > Date: Sat Feb 19 2

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Noorul Islam K M
"Bert Huijben" writes: >> -Original Message- >> From: Branko Čibej [mailto:br...@xbc.nu] On Behalf Of Branko Cibej >> Sent: maandag 21 februari 2011 13:19 >> To: Philip Martin >> Cc: dev@subversion.apache.org >> Subject: Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple >

Re: Inconsistent indentation in python code across code base

2011-02-21 Thread Hyrum K Wright
On Mon, Feb 21, 2011 at 9:56 AM, Noorul Islam K M wrote: > > I think we have in consistent python indentation. I can see that we use > 2 space in test/ and 4 in bindings/ctypes-python. Is it not a good idea > to stick to common indentation?  I can fix it.  Fixing ctypes-python > will be easier bec

RE: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@xbc.nu] On Behalf Of Branko Cibej > Sent: maandag 21 februari 2011 13:19 > To: Philip Martin > Cc: dev@subversion.apache.org > Subject: Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple > checkouts. > You could argu

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 12:19:34PM +, Philip Martin wrote: > Stefan Sperling writes: > > > Fair enough, but why not write a specific test for this instead of testing > > it as a side effect of making the code of other tests harder to read? > > The assumption is that translation only affects

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Philip Martin
Stefan Sperling writes: > Fair enough, but why not write a specific test for this instead of testing > it as a side effect of making the code of other tests harder to read? The assumption is that translation only affects output to the user, not the internal behaviour of the commands. We have so

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Branko Čibej
On 21.02.2011 13:12, Philip Martin wrote: > Branko Čibej writes: > >> We should not be optimising tests for performance over clarity, ever. In >> other words -- don't combine them. Anyone who has trouble with tests >> taking too long can use a RAMdisk, --bdb-txn-nosync, and other tweaks to >> make

Re: svn commit: r1072084 - /subversion/trunk/subversion/svn/util.c

2011-02-21 Thread Hyrum K Wright
On Fri, Feb 18, 2011 at 5:53 PM, wrote: > Author: danielsh > Date: Fri Feb 18 17:53:36 2011 > New Revision: 1072084 > > URL: http://svn.apache.org/viewvc?rev=1072084&view=rev > Log: > * subversion/svn/util.c >  (svn_cl__edit_string_externally): >    Preserve the edit log message file if the edito

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Philip Martin
Branko Čibej writes: > We should not be optimising tests for performance over clarity, ever. In > other words -- don't combine them. Anyone who has trouble with tests > taking too long can use a RAMdisk, --bdb-txn-nosync, and other tweaks to > make the tests run faster. I do that. The time to r

Re: Unable to compile since r1072302

2011-02-21 Thread Hyrum K Wright
2011/2/20 Branko Čibej : > On 20.02.2011 22:05, Daniel Becroft wrote: >> ... >> /subversion/libsvn_fs_fs/.libs/libsvn_fs_fs-1.so.0: undefined >> reference to `svn_temp_serializer__add_string' >> collect2: ld returned 1 exit status >> >> I've narrowed it down to r1072302, and if I update back to -1,

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 11:57:50AM +, Philip Martin wrote: > Stefan Sperling writes: > > > On Mon, Feb 21, 2011 at 11:21:10AM +, Philip Martin wrote: > >> Stefan Sperling writes: > >> > >> > But I think there is value in seeing the error message in the test code. > >> > It makes it much

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Philip Martin
Stefan Sperling writes: > On Mon, Feb 21, 2011 at 11:21:10AM +, Philip Martin wrote: >> Stefan Sperling writes: >> >> > But I think there is value in seeing the error message in the test code. >> > It makes it much easier for those reading the test code to follow >> > what kind of error the

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Branko Čibej
On 21.02.2011 12:04, Philip Martin wrote: > Stefan Sperling writes: > >> On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: >>> This patch reduces checkout by around 23 times. >> On my system the difference is 43 seconds vs. 30 seconds. > On my low-end Linux desktop it's 7.5 seconds

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Branko Čibej
On 21.02.2011 11:32, Noorul Islam K M wrote: > Noorul Islam K M writes: > >> Stefan Sperling writes: >> >>> On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: >>> This patch reduces checkout by around 23 times. >>> On my system the difference is 43 seconds vs. 30 seconds. >>>

Re: Inconsistent indentation in python code across code base

2011-02-21 Thread Branko Čibej
On 21.02.2011 11:20, Philip Martin wrote: > Noorul Islam K M writes: > >> I think we have in consistent python indentation. I can see that we use >> 2 space in test/ and 4 in bindings/ctypes-python. Is it not a good idea >> to stick to common indentation? I can fix it. Fixing ctypes-python >> wi

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 11:21:10AM +, Philip Martin wrote: > Stefan Sperling writes: > > > But I think there is value in seeing the error message in the test code. > > It makes it much easier for those reading the test code to follow > > what kind of error the test is expecting. If all people

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Philip Martin
Stefan Sperling writes: > But I think there is value in seeing the error message in the test code. > It makes it much easier for those reading the test code to follow > what kind of error the test is expecting. If all people can go by > is the error code, then they'll have to keep looking up erro

Re: Pristine store - spec

2011-02-21 Thread Julian Foad
On Fri, 2011-02-18, Daniel Shahaf wrote: [...] > In other words, the lower-layer API is oblivious of WC locks. I see. > > That said, I just noticed that your bullet points have both a "wc lock" > and an "exclusive wc lock" --- I had overlooked that distinction > earlier. I assume that an 'exclus

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Philip Martin
Stefan Sperling writes: > On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: >> >> This patch reduces checkout by around 23 times. > > On my system the difference is 43 seconds vs. 30 seconds. On my low-end Linux desktop it's 7.5 seconds and 3.5 seconds, run sequentially on a SAT

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Noorul Islam K M
Stefan Sperling writes: > On Mon, Feb 21, 2011 at 03:58:00PM +0530, Noorul Islam K M wrote: > >> Stefan Sperling writes: >> > But I think there is value in seeing the error message in the test code. >> > It makes it much easier for those reading the test code to follow >> > what kind of error th

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 03:58:00PM +0530, Noorul Islam K M wrote: > Stefan Sperling writes: > > But I think there is value in seeing the error message in the test code. > > It makes it much easier for those reading the test code to follow > > what kind of error the test is expecting. If all people

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Noorul Islam K M
Noorul Islam K M writes: > Stefan Sperling writes: > >> On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: >> >>> >>> This patch reduces checkout by around 23 times. >> >> On my system the difference is 43 seconds vs. 30 seconds. >> >> We lose the ability to easily spot which of

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Noorul Islam K M
Stefan Sperling writes: > On Mon, Feb 21, 2011 at 12:46:25PM +0530, Noorul Islam K M wrote: > >> >> Modify expected error string to use only error codes and also restrict >> one of the lines to less than 80 characters. >> >> Log >> [[[ >> >> * subversion/tests/cmdline/cat_tests.py >> (cat_lo

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Noorul Islam K M
Stefan Sperling writes: > On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: > >> >> This patch reduces checkout by around 23 times. > > On my system the difference is 43 seconds vs. 30 seconds. > > We lose the ability to easily spot which of the subtest is failing > if we do this

Re: Inconsistent indentation in python code across code base

2011-02-21 Thread Philip Martin
Noorul Islam K M writes: > I think we have in consistent python indentation. I can see that we use > 2 space in test/ and 4 in bindings/ctypes-python. Is it not a good idea > to stick to common indentation? I can fix it. Fixing ctypes-python > will be easier because it has less number of lines.

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 12:46:25PM +0530, Noorul Islam K M wrote: > > Modify expected error string to use only error codes and also restrict > one of the lines to less than 80 characters. > > Log > [[[ > > * subversion/tests/cmdline/cat_tests.py > (cat_local_directory, cat_remote_directory, ca

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: > > This patch reduces checkout by around 23 times. On my system the difference is 43 seconds vs. 30 seconds. We lose the ability to easily spot which of the subtest is failing if we do this. I.e. instead of: ... PASS: input_val

Re: Inconsistent indentation in python code across code base

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 03:26:26PM +0530, Noorul Islam K M wrote: > > I think we have in consistent python indentation. I can see that we use > 2 space in test/ and 4 in bindings/ctypes-python. Is it not a good idea > to stick to common indentation? I can fix it. Fixing ctypes-python > will be e

Inconsistent indentation in python code across code base

2011-02-21 Thread Noorul Islam K M
I think we have in consistent python indentation. I can see that we use 2 space in test/ and 4 in bindings/ctypes-python. Is it not a good idea to stick to common indentation? I can fix it. Fixing ctypes-python will be easier because it has less number of lines. Any thoughts? Or is it already k

[PATCH] Fix ctypes-python tests by clearing pool

2011-02-21 Thread Noorul Islam K M
This patch fixes some minor issues with ctypes-python. Now we are explicitly clearing the pool. Log [[[ Fix ctypes-python tests by explicitly clearing pool. * subversion/bindings/ctypes-python/csvn/wc.py, subversion/bindings/ctypes-python/csvn/repos.py (WC.clear_pool, LocalRepository.clear_

[PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Noorul Islam K M
This patch reduces checkout by around 23 times. Log [[[ Combine input validation tests to reduce the overhead of multiple checkouts. * subversion/tests/cmdline/input_validation_tests.py: (invalid_targets): Build sandbox once and make following methods local. (invalid_wcpath_add, invalid_wc