Re: svn commit: r1103578 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/update.c libsvn_wc/deprecated.c libsvn_wc/update_editor.c

2011-05-16 Thread Daniel Shahaf
stef...@apache.org wrote on Mon, May 16, 2011 at 00:02:06 -: > Author: stefan2 > Date: Mon May 16 00:02:05 2011 > New Revision: 1103578 > > URL: http://svn.apache.org/viewvc?rev=1103578&view=rev > Log: > Eliminate unnecessary stat calls during checkout, part 1 of 2. > Most c/o will be to an ot

Re: svn commit: r1103771 - in /subversion/trunk/subversion: libsvn_client/prop_commands.c svn/propedit-cmd.c svn/propget-cmd.c

2011-05-16 Thread Daniel Shahaf
hwri...@apache.org wrote on Mon, May 16, 2011 at 15:36:24 -: > Author: hwright > Date: Mon May 16 15:36:24 2011 > New Revision: 1103771 > > URL: http://svn.apache.org/viewvc?rev=1103771&view=rev > Log: > Convert a bit of the recursive propget to use absolute paths, by doing path > relativifcat

Re: svnrdump revision inconsistency bugs

2011-05-16 Thread Mark Eichin
Great, thanks (in a fixing-broken-windows sense; svnrdump itself is still unusable-or-unsafe without sane revision number handling.) (I did discover "Tailor", http://progetti.arstecnica.it/tailor/ which was actually the first tool to *work* on the original task, I'm surprised it doesn't get more a

Re: [PATCH] Have serf send Content-Length request bodies

2011-05-16 Thread Konstantin Kolinko
2011/5/17 Justin Erenkrantz : > On Mon, May 16, 2011 at 10:48 PM, Konstantin Kolinko > wrote: >> HTTP/1.0 does not support keep-alive, and thus the connection will be >> closed after each request. You will need HTTP/1.1 to keep the >> connection open. > > Correct - in this particular set of circum

Re: [PATCH] Have serf send Content-Length request bodies

2011-05-16 Thread Justin Erenkrantz
On Mon, May 16, 2011 at 10:48 PM, Konstantin Kolinko wrote: > HTTP/1.0 does not support keep-alive, and thus the connection will be > closed after each request. You will need HTTP/1.1 to keep the > connection open. Correct - in this particular set of circumstances, httpd is going to either select

Re: 1.7 Performance via HTTP

2011-05-16 Thread Justin Erenkrantz
On Mon, May 16, 2011 at 5:52 PM, Mark Phippard wrote: > I rebuilt using latest HEAD of Serf and SVN (no patches applied) and > re-ran the tests using a 1.7 serf client and both a 1.6 and 1.7 SVN > server. > > While the server was configured according to your recommendations for > KeepAlive, I did

Re: [PATCH] Have serf send Content-Length request bodies

2011-05-16 Thread Konstantin Kolinko
2011/5/16 Justin Erenkrantz : > So...at my hotel in Ljubljana, they have a silly Squid proxy that > doesn't understand chunked request bodies.  I know this has been a > huge detriment for some people with serf - so, here's a patch for serf > that will try to send C-L bodies for basic HTTP request b

[PATCH] -r { DATE } with words

2011-05-16 Thread Stefan Sperling
Back before 1.0 we had a date parser written in Yacc that could parse all sorts of fancy strings such as "yesterday", "last month", or "two fortnights ago". This was dropped in r848401/r848402 because of maintenance concerns. The parser was missing some desired features and also did a lot more than

Re: JavaHL - setConfigDirectory() method working?

2011-05-16 Thread Konstantin Kolinko
2011/5/16 Mark Phippard : > Looking at the code in trunk, it seems like this is coded properly and > should be working.  I am seeing unexpected behavior.  Maybe I just do > not understand how it works? > > In Subclipse we expose UI to tell us the config directory location. > Most people just leave

Re: svn commit: r1102775 - /subversion/site/publish/docs/community-guide/issues.part.html

2011-05-16 Thread C. Michael Pilato
r1103919. (Fixed the inconsistent capitalization of the header title, too.) Thanks for the review. On 05/14/2011 02:44 AM, Daniel Shahaf wrote: > Can you please update the "table of contents" at the top of that file too? > > cmpil...@apache.org wrote on Fri, May 13, 2011 at 14:57:05 -: >> A

Re: 1.7 Performance via HTTP

2011-05-16 Thread Ivan Zhakov
On Mon, May 16, 2011 at 23:15, C. Michael Pilato wrote: > On 05/16/2011 07:52 PM, Mark Phippard wrote: >> One thing I am a little confused about, but maybe it is a question for >> C-Mike.  When Serf is used, the number of HTTP requests does not go >> down very much.  81,938 -> 80,928  I imagine th

Re: 1.7 Performance via HTTP

2011-05-16 Thread C. Michael Pilato
On 05/16/2011 07:52 PM, Mark Phippard wrote: > One thing I am a little confused about, but maybe it is a question for > C-Mike. When Serf is used, the number of HTTP requests does not go > down very much. 81,938 -> 80,928 I imagine this is because Serf > already did not do all of the PROPFIND no

JavaHL - setConfigDirectory() method working?

2011-05-16 Thread Mark Phippard
Looking at the code in trunk, it seems like this is coded properly and should be working. I am seeing unexpected behavior. Maybe I just do not understand how it works? In Subclipse we expose UI to tell us the config directory location. Most people just leave this as the default, which is same as

Re: svn commit: r1103838 - in /subversion/trunk/subversion/bindings/javahl/native: Prompter.cpp Prompter.h

2011-05-16 Thread Mark Phippard
On Mon, May 16, 2011 at 2:50 PM, wrote: > Author: markphip > Date: Mon May 16 18:50:40 2011 > New Revision: 1103838 > > URL: http://svn.apache.org/viewvc?rev=1103838&view=rev > Log: > JavaHL: Fixed JNI code to look for the new UserPasswordCallback class > in place of the old PromptUserPasswordN c

Re: 1.7 Performance via HTTP

2011-05-16 Thread Mark Phippard
On Sun, May 15, 2011 at 6:37 AM, Justin Erenkrantz wrote: > On Thu, May 12, 2011 at 5:57 PM, Justin Erenkrantz > wrote: >> Are you by chance using SSL? >> >> I'm seeing something like a 2x perf drop on ra_serf with SSL to an SSL >> server on the other side of the US from where I am now.  But, ove

Re: svn commit: r1103414 - /subversion/trunk/subversion/libsvn_fs_fs/caching.c

2011-05-16 Thread Julian Foad
On Sun, 2011-05-15, stef...@apache.org wrote: > Don't give the impression that init_txn_callbacks might fail. > > * subversion/libsvn_fs_fs/caching.c > (init_txn_callbacks): void is the appropriate return type. > Modified: subversion/trunk/subversion/libsvn_fs_fs/caching.c > ===

Re: [RFC] let old svn's error properly in some 'svn1.7 checkout && svn1.6 status' scenarios

2011-05-16 Thread Julian Foad
On Mon, 2011-05-16 at 17:34 +0200, Daniel Shahaf wrote: > Julian Foad wrote on Mon, May 16, 2011 at 15:49:52 +0100: > > Daniel Shahaf wrote: > > > Daniel Shahaf wrote on Mon, May 16, 2011 at 15:36:25 +0200: > > > > [[[ > > > > % wc-format.py > > > > .: 11 > > > > > > It said '28' originally. > >

RE: svn commit: r1103771 - in /subversion/trunk/subversion: libsvn_client/prop_commands.c svn/propedit-cmd.c svn/propget-cmd.c

2011-05-16 Thread Bert Huijben
> -Original Message- > From: hwri...@apache.org [mailto:hwri...@apache.org] > Sent: maandag 16 mei 2011 17:36 > To: comm...@subversion.apache.org > Subject: svn commit: r1103771 - in /subversion/trunk/subversion: > libsvn_client/prop_commands.c svn/propedit-cmd.c svn/propget-cmd.c > > Au

Re: svn commit: r1103765 - in /subversion/trunk/subversion: libsvn_wc/update_editor.c libsvn_wc/wc_db.c libsvn_wc/wc_db.h tests/libsvn_wc/db-test.c tests/libsvn_wc/op-depth-test.c

2011-05-16 Thread Hyrum K Wright
On Mon, May 16, 2011 at 3:24 PM, wrote: > Author: stefan2 > Date: Mon May 16 15:24:59 2011 > New Revision: 1103765 > > URL: http://svn.apache.org/viewvc?rev=1103765&view=rev > Log: > Finding the w/c base folder using svn_wc__db_wcroot_parse_local_abspath > can be expensive if being called for man

Re: [RFC] let old svn's error properly in some 'svn1.7 checkout && svn1.6 status' scenarios

2011-05-16 Thread Daniel Shahaf
Julian Foad wrote on Mon, May 16, 2011 at 15:49:52 +0100: > Daniel Shahaf wrote: > > Daniel Shahaf wrote on Mon, May 16, 2011 at 15:36:25 +0200: > > > [[[ > > > % wc-format.py > > > .: 11 > > > > It said '28' originally. > > > > > % svn --version -q > > > 1.5.1 > > > % svn st -q > > When I try

Re: [RFC] let old svn's error properly in some 'svn1.7 checkout && svn1.6 status' scenarios

2011-05-16 Thread Julian Foad
Daniel Shahaf wrote: > Daniel Shahaf wrote on Mon, May 16, 2011 at 15:36:25 +0200: > > [[[ > > % wc-format.py > > .: 11 > > It said '28' originally. > > > % svn --version -q > > 1.5.1 > > % svn st -q When I try with 1.5.9 and 1.6.16, they say "svn: warning: '.' is not a working copy" which is d

RE: SQLite and the LIKE operator

2011-05-16 Thread Bert Huijben
> -Original Message- > From: Hyrum K Wright [mailto:hy...@hyrumwright.org] > Sent: maandag 16 mei 2011 11:18 > To: Bert Huijben > Cc: Branko Čibej; dev@subversion.apache.org > Subject: Re: SQLite and the LIKE operator > > On Mon, May 16, 2011 at 8:28 AM, Bert Huijben wrote: > > > > > >>

Re: [RFC] let old svn's error properly in some 'svn1.7 checkout && svn1.6 status' scenarios

2011-05-16 Thread Daniel Shahaf
Daniel Shahaf wrote on Mon, May 16, 2011 at 15:36:25 +0200: > [[[ > % wc-format.py > .: 11 It said '28' originally. > % svn --version -q > 1.5.1 > % svn st -q > % echo 11 > .svn/format > % echo 11 > .svn/entries > % svn st -q > svn: This client is too old to work with working copy '

[RFC] let old svn's error properly in some 'svn1.7 checkout && svn1.6 status' scenarios

2011-05-16 Thread Daniel Shahaf
[[[ % wc-format.py .: 11 % svn --version -q 1.5.1 % svn st -q % echo 11 > .svn/format % echo 11 > .svn/entries % svn st -q svn: This client is too old to work with working copy '.'. You need to get a newer Subversion client, or to downgrade this working copy. See http://subversion.ti

Re: svn commit: r1103391 - /subversion/trunk/notes/meetings/berlin-11-agenda

2011-05-16 Thread Daniel Shahaf
Ivan Zhakov wrote on Mon, May 16, 2011 at 15:17:50 +0200: > On Mon, May 16, 2011 at 14:49, Justin Erenkrantz > wrote: > > On Mon, May 16, 2011 at 11:52 AM, Hyrum K Wright > > wrote: > >> We can. > >> > >> HTTP access has *always* been an optional bit of the Subversion > >> client, and using neo

Re: svn commit: r1103391 - /subversion/trunk/notes/meetings/berlin-11-agenda

2011-05-16 Thread Ivan Zhakov
On Mon, May 16, 2011 at 14:49, Justin Erenkrantz wrote: > On Mon, May 16, 2011 at 11:52 AM, Hyrum K Wright > wrote: >> We can. >> >> HTTP access has *always* been an optional bit of the Subversion >> client, and using neon, either as the default or not, should not pose >> a problem with ASF guid

Re: svn commit: r1103391 - /subversion/trunk/notes/meetings/berlin-11-agenda

2011-05-16 Thread Justin Erenkrantz
On Mon, May 16, 2011 at 11:52 AM, Hyrum K Wright wrote: > We can. > > HTTP access has *always* been an optional bit of the Subversion > client, and using neon, either as the default or not, should not pose > a problem with ASF guidelines (so long as we don't distribute neon, > which we no longer d

Re: svn commit: r1103391 - /subversion/trunk/notes/meetings/berlin-11-agenda

2011-05-16 Thread Daniel Shahaf
Ivan Zhakov wrote on Mon, May 16, 2011 at 13:48:43 +0200: > On Mon, May 16, 2011 at 13:45, Daniel Shahaf wrote: > > serf is Apache licensed, neon is LGPL licensed, ASF projects must not > > require non-AL-compatible defaults for non-optional features. > Could you please provide a link for such req

Re: svn commit: r1103391 - /subversion/trunk/notes/meetings/berlin-11-agenda

2011-05-16 Thread Hyrum K Wright
On Mon, May 16, 2011 at 11:48 AM, Ivan Zhakov wrote: > On Mon, May 16, 2011 at 13:45, Daniel Shahaf wrote: >> i...@apache.org wrote on Sun, May 15, 2011 at 14:24:46 -: >>> Author: ivan >>> Date: Sun May 15 14:24:45 2011 >>> New Revision: 1103391 >>> >>> URL: http://svn.apache.org/viewvc?rev=1

Re: svn commit: r1103413 - /subversion/trunk/subversion/libsvn_subr/cache-membuffer.c

2011-05-16 Thread Daniel Shahaf
stef...@apache.org wrote on Sun, May 15, 2011 at 14:52:22 -: > Author: stefan2 > Date: Sun May 15 14:52:22 2011 > New Revision: 1103413 > > URL: http://svn.apache.org/viewvc?rev=1103413&view=rev > Log: > If an in-place modification of some cache entry failed, we must remove > that entry becaus

Re: svn commit: r1103391 - /subversion/trunk/notes/meetings/berlin-11-agenda

2011-05-16 Thread Ivan Zhakov
On Mon, May 16, 2011 at 13:45, Daniel Shahaf wrote: > i...@apache.org wrote on Sun, May 15, 2011 at 14:24:46 -: >> Author: ivan >> Date: Sun May 15 14:24:45 2011 >> New Revision: 1103391 >> >> URL: http://svn.apache.org/viewvc?rev=1103391&view=rev >> Log: >> * notes/meetings/berlin-11-agenda >

Re: svn commit: r1103391 - /subversion/trunk/notes/meetings/berlin-11-agenda

2011-05-16 Thread Daniel Shahaf
i...@apache.org wrote on Sun, May 15, 2011 at 14:24:46 -: > Author: ivan > Date: Sun May 15 14:24:45 2011 > New Revision: 1103391 > > URL: http://svn.apache.org/viewvc?rev=1103391&view=rev > Log: > * notes/meetings/berlin-11-agenda > (): Add notes to discuss. > > Modified: > subversion/

Re: SQLite and the LIKE operator

2011-05-16 Thread Julian Foad
Branko Čibej wrote: > On 16.05.2011 11:17, Hyrum K Wright wrote: > > On Mon, May 16, 2011 at 8:28 AM, Bert Huijben wrote: > >>> 2011/5/16 Branko Čibej : > On 16.05.2011 03:13, Hyrum K Wright wrote: > > Several places in wc_db we use the following pattern to select all > > nodes with a

Re: SQLite and the LIKE operator

2011-05-16 Thread Branko Čibej
On 16.05.2011 11:17, Hyrum K Wright wrote: > On Mon, May 16, 2011 at 8:28 AM, Bert Huijben wrote: >> >>> -Original Message- >>> From: Hyrum K Wright [mailto:hy...@hyrumwright.org] >>> Sent: maandag 16 mei 2011 9:39 >>> To: Branko Čibej >>> Cc: dev@subversion.apache.org >>> Subject: Re: SQL

Re: [PATCH] in-process packed-offset cache broken in 1.6.16 (on 64-bit architectures)

2011-05-16 Thread Hyrum K Wright
Committed to the 1.6.x branch in r1103680. This fix will be in the next release of Subversion. Thanks again, -Hyrum On Mon, May 16, 2011 at 10:05 AM, Hyrum K Wright wrote: > It turns out that on trunk, we are using apr_int64_t which Daniel > tells me is still incorrect, so r1103665 applies your

Re: [PATCH] in-process packed-offset cache broken in 1.6.16 (on 64-bit architectures)

2011-05-16 Thread Daniel Shahaf
Hyrum K Wright wrote on Mon, May 16, 2011 at 10:05:50 +: > It turns out that on trunk, we are using apr_int64_t which Daniel > tells me is still incorrect, For the record, Roderich pointed it out too: > >> Patch below. The problem is still present in branches/1.6.x, while trunk > >> has > >>

Re: [PATCH] in-process packed-offset cache broken in 1.6.16 (on 64-bit architectures)

2011-05-16 Thread Hyrum K Wright
It turns out that on trunk, we are using apr_int64_t which Daniel tells me is still incorrect, so r1103665 applies your patch there, and I've nominated it for 1.6.x (with Daniel's vote) in r1103668. Thanks! -Hyrum On Mon, May 16, 2011 at 10:39 AM, Daniel Shahaf wrote: > +1 from Hyrum and I; we'

[PATCH] Have serf send Content-Length request bodies

2011-05-16 Thread Justin Erenkrantz
So...at my hotel in Ljubljana, they have a silly Squid proxy that doesn't understand chunked request bodies. I know this has been a huge detriment for some people with serf - so, here's a patch for serf that will try to send C-L bodies for basic HTTP request bodies. With this patch, ra_serf only

Re: [PATCH] in-process packed-offset cache broken in 1.6.16 (on 64-bit architectures)

2011-05-16 Thread Daniel Shahaf
+1 from Hyrum and I; we'll apply to trunk and nominate a backport. Roderich Schupp wrote on Sun, May 15, 2011 at 19:50:53 +0200: > Hi, > > while looking at strace's of Subversion operations on a repository > using packing > I noticed the following behavior: > > 20829 open(".../db/revs/2.pack/pac

Re: svn commit: r1094150 - in /subversion/trunk/subversion/libsvn_fs_fs: caching.c fs.h fs_fs.c fs_fs.h tree.c

2011-05-16 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Sun, May 15, 2011 at 18:17:22 +0200: > On 14.05.2011 03:54, Daniel Shahaf wrote: >> stef...@apache.org wrote on Sun, Apr 17, 2011 at 14:48:34 -: >>> Author: stefan2 >>> Date: Sun Apr 17 14:48:33 2011 >>> New Revision: 1094150 >>> >>> URL: http://svn.apache.org/viewvc?re

RE: svn commit: r1102843 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2011-05-16 Thread Julian Foad
On Sat, 2011-05-14 at 08:28 +0200, Bert Huijben wrote: > > > -Original Message- > > From: Bert Huijben [mailto:b...@qqmail.nl] > > Sent: zaterdag 14 mei 2011 8:06 > > To: Greg Stein; dev@subversion.apache.org > > Subject: RE: svn commit: r1102843 - > > /subversion/trunk/subversion/libsvn_w

Re: SQLite and the LIKE operator

2011-05-16 Thread Hyrum K Wright
On Mon, May 16, 2011 at 8:28 AM, Bert Huijben wrote: > > >> -Original Message- >> From: Hyrum K Wright [mailto:hy...@hyrumwright.org] >> Sent: maandag 16 mei 2011 9:39 >> To: Branko Čibej >> Cc: dev@subversion.apache.org >> Subject: Re: SQLite and the LIKE operator >> >> 2011/5/16 Branko Č

RE: SQLite and the LIKE operator

2011-05-16 Thread Bert Huijben
> -Original Message- > From: Hyrum K Wright [mailto:hy...@hyrumwright.org] > Sent: maandag 16 mei 2011 9:39 > To: Branko Čibej > Cc: dev@subversion.apache.org > Subject: Re: SQLite and the LIKE operator > > 2011/5/16 Branko Čibej : > > On 16.05.2011 03:13, Hyrum K Wright wrote: > >> Seve

RE: SQLite and the LIKE operator

2011-05-16 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@xbc.nu] On Behalf Of Branko Cibej > Sent: maandag 16 mei 2011 9:46 > To: dev@subversion.apache.org > Subject: Re: SQLite and the LIKE operator > > On 16.05.2011 09:38, Hyrum K Wright wrote: > > 2011/5/16 Branko Čibej : > >> On 16.05

Re: SQLite and the LIKE operator

2011-05-16 Thread Branko Čibej
On 16.05.2011 09:38, Hyrum K Wright wrote: > 2011/5/16 Branko Čibej : >> On 16.05.2011 03:13, Hyrum K Wright wrote: >>> Several places in wc_db we use the following pattern to select all >>> nodes with a common tree ancestor: >>> WHERE wc_id = ?1 AND (local_relpath = ?2 OR local_relpath LIKE ?3 ES

Re: SQLite and the LIKE operator

2011-05-16 Thread Hyrum K Wright
2011/5/16 Branko Čibej : > On 16.05.2011 03:13, Hyrum K Wright wrote: >> Several places in wc_db we use the following pattern to select all >> nodes with a common tree ancestor: >>  WHERE wc_id = ?1 AND (local_relpath = ?2 OR local_relpath LIKE ?3 ESCAPE >> '#') >> >> While this works, there was s