Re: [PATCH] Simplify and optimize RA-svn's string marshalling

2011-06-03 Thread Stefan Fuhrmann
On 03.06.2011 10:52, Julian Foad wrote: Hi Stefan2 and others. This patch simplifies code in RA-svn/marshal.c by using a single code path to read both short and long strings efficiently. Using a single code path is beneficial for test coverage. It is an alternative to r1028352 which merged r98

Re: svn commit: r1131183 - in /subversion/tags/1.7.0-alpha1: ./ subversion/include/svn_version.h

2011-06-03 Thread Greg Stein
On Fri, Jun 3, 2011 at 16:12, wrote >... Can we get rid of some of these properties on the 'trunk' directory? >... > Propchange: subversion/tags/1.7.0-alpha1/ > -- >    bzr:file-ids = > > Propchange: subversion/tags/1.7

[RFC] [PATCH] Use console, not stdin/stderr, for prompting

2011-06-03 Thread Peter Samuelson
[Peter Samuelson] > Hrrrmph. I think libsvn_subr/prompt.c could use a large dose of > "/dev/tty". Right now it mostly uses stderr and stdin, but for > password prompts it uses /dev/tty on modern Unix ... indirectly, > by calling apr_password_get() which calls getpass(), an OS library > function.

RE: status cmd in mixed-rev nested copies

2011-06-03 Thread Bert Huijben
> -Original Message- > From: Stephen Butler [mailto:sbut...@elego.de] > Sent: zaterdag 4 juni 2011 0:07 > To: Subversion Development > Subject: status cmd in mixed-rev nested copies > > Hello WC-NG gurus, > > I ran into a strange problem while working on issue 3899 "auto-resolve > confl

status cmd in mixed-rev nested copies

2011-06-03 Thread Stephen Butler
Hello WC-NG gurus, I ran into a strange problem while working on issue 3899 "auto-resolve conflicts at wc-wc copy/move destination". The 'svn status' command and the entries-dump utility (for 1.6 compatibility) disagree. See stat_tests.py 35 for details. It's quite short, so I'll paste it into

1.7.0-alpha1 tarballs up for testing/signing

2011-06-03 Thread Hyrum K Wright
All, At long request, we now have tarballs for the first 1.7.0 pre-release: 1.7.0-alpha1 ("phoenix-hatchling"). These were cut from trunk, and the magic rev is r1130808. The buildbots were green at that rev, and all tests pass for me locally. You can find them here: http://people.apache.org/~hw

Re: Stuck between relocate and upgrade

2011-06-03 Thread Hyrum K Wright
On Fri, Jun 3, 2011 at 7:27 AM, Daniel Shahaf wrote: > Bert Huijben wrote on Fri, Jun 03, 2011 at 14:17:47 +0200: >> And if one of those users doesn't manage its own installed applications >> (Read: typical corporate environment), then the only thing a user could do >> is delete all relevant worki

Re: API review - svn_checksum, svn_client

2011-06-03 Thread Greg Stein
On Fri, Jun 3, 2011 at 13:33, Julian Foad wrote: >... >  * svn_client_upgrade() - What versions can it upgrade from and to? Any version prior to the current. > What upgrade-specific error conditions can it encounter? Dunno > Document the > 'dir' parameter: e.g. does it need to be the root of a

Re: svn commit: r1131109 - /subversion/trunk/subversion/tests/cmdline/stat_tests.py

2011-06-03 Thread Philip Martin
"Bert Huijben" writes: > I think we need an op_depth test for this case to verify all layers of > the result. That would be: subversion/tests/libsvn_wc/op-depth-text.c:test_mixed_rev_copy -- Philip

Re: packages.html: s/professional/commercial/ ?

2011-06-03 Thread C. Michael Pilato
On 06/03/2011 01:20 PM, Blair Zajac wrote: > Looking at the package page: http://subversion.apache.org/packages.html, > the word "professional" bugs me, because I help out on the MacPorts' > support and it's not like we're not "software development professionals" > in our project, so I would like t

API review - svn_checksum, svn_client

2011-06-03 Thread Julian Foad
REVIEWED HERE svn_auth.h - no comments svn_base64.h - no comments svn_checksum.h svn_client.h (except group 'Patch') NEW APIS * svn_checksum_mismatch_err() - Private? Doesn't say how the formatted string is combined with some generic description of the mismatch. * svn_client_commit

Re: can't we use "svnrdump load" in interactive mode?

2011-06-03 Thread Stefan Sperling
On Fri, Jun 03, 2011 at 04:48:50PM +0100, Philip Martin wrote: > Stefan Sperling writes: > > > svn patch does not accept this familiar syntax for the same reason: > > svn patch < patchfile > > > > The only command we have that works like this is svnadmin, > > which never prompts interactively.

packages.html: s/professional/commercial/ ?

2011-06-03 Thread Blair Zajac
Looking at the package page: http://subversion.apache.org/packages.html, the word "professional" bugs me, because I help out on the MacPorts' support and it's not like we're not "software development professionals" in our project, so I would like to change professional to commercial, which is te

Re: can't we use "svnrdump load" in interactive mode?

2011-06-03 Thread Peter Samuelson
[Stefan Sperling] > svnrdump should not be using stdin for input. > It should accept the file on the command line instead because > using stdin interferes with prompting. Hrrrmph. I think libsvn_subr/prompt.c could use a large dose of "/dev/tty". Right now it mostly uses stderr and stdin, but f

RE: svn commit: r1131109 - /subversion/trunk/subversion/tests/cmdline/stat_tests.py

2011-06-03 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: vrijdag 3 juni 2011 19:11 > To: sbut...@apache.org > Cc: dev@subversion.apache.org; comm...@subversion.apache.org > Subject: RE: svn commit: r1131109 - > /subversion/trunk/subversion/tests/cmdline/stat_tests.py >

RE: svn commit: r1131109 - /subversion/trunk/subversion/tests/cmdline/stat_tests.py

2011-06-03 Thread Bert Huijben
> -Original Message- > From: sbut...@apache.org [mailto:sbut...@apache.org] > Sent: vrijdag 3 juni 2011 18:57 > To: comm...@subversion.apache.org > Subject: svn commit: r1131109 - > /subversion/trunk/subversion/tests/cmdline/stat_tests.py > > Author: sbutler > Date: Fri Jun 3 16:57:22 2

Re: First 1.7.0 prerelease: June 1

2011-06-03 Thread Hyrum K Wright
On Fri, Jun 3, 2011 at 2:54 AM, Stefan Fuhrmann wrote: > On 03.06.2011 04:16, Hyrum K Wright wrote: >> >> On Wed, May 18, 2011 at 5:17 AM, Hyrum K Wright >>  wrote: >>> >>> Fire up your testing environments: they're going to get some use over >>> the next couple of months. >>> >>> In an effort to

API review - svn_client_status_t

2011-06-03 Thread Julian Foad
The new client status reporting with 'svn_client_status_t' could do with some more eyes on it. This was introduced in r955542, with the log message: "Introduce a new svn_client_status_t structure to separate the public client status api from the implementation of status in libsvn_wc, to allow f

Re: can't we use "svnrdump load" in interactive mode?

2011-06-03 Thread Philip Martin
Stefan Sperling writes: > svn patch does not accept this familiar syntax for the same reason: > svn patch < patchfile > > The only command we have that works like this is svnadmin, > which never prompts interactively. Standard patch allows me to use '<' and still prompts interactively: $ patc

Re: can't we use "svnrdump load" in interactive mode?

2011-06-03 Thread Stefan Sperling
On Fri, Jun 03, 2011 at 08:22:50PM +0530, vijay wrote: > I think it checks for "yes or no" in the stdin(the dump file). As it > could not find one, it prompts the user repeatedly and fails the > error. Ouch 8-/ > Is there any open issue for this? I don't think so. Please file one. Thanks! svnrd

Re: can't we use "svnrdump load" in interactive mode?

2011-06-03 Thread Daniel Shahaf
vijay wrote on Fri, Jun 03, 2011 at 20:22:50 +0530: > Hi, > > whenever I run "svnrdump load" in *interactive mode*, it ends up > with the following weird behaviour. > > > vijayaguru@maverick:/tmp$ svnrdump load > http://localhost:1234/svn/testrepo < .dump > Authentication realm:

Re: Stuck between relocate and upgrade

2011-06-03 Thread Arwin Arni
On Friday 03 June 2011 05:47 PM, Bert Huijben wrote: -Original Message- From: Mark Phippard [mailto:markp...@gmail.com] Sent: vrijdag 3 juni 2011 14:13 To: Bert Huijben; dev@subversion.apache.org Subject: Re: Stuck between relocate and upgrade I do not get the impression that 1.4 is

Re: Stuck between relocate and upgrade

2011-06-03 Thread Daniel Shahaf
Bert Huijben wrote on Fri, Jun 03, 2011 at 14:17:47 +0200: > And if one of those users doesn't manage its own installed applications > (Read: typical corporate environment), then the only thing a user could do > is delete all relevant working copies and perform a new checkout. Could we teach chang

Re: Stuck between relocate and upgrade

2011-06-03 Thread Mark Phippard
On Fri, Jun 3, 2011 at 8:17 AM, Bert Huijben wrote: >> I do not get the impression that 1.4 is the relevant fact here.  It >> seems like the issue is just that svn upgrade needs to contact the >> repository?  So you cannot upgrade a WC that needs to be relocated? >> >> This does not sound like a

RE: Stuck between relocate and upgrade

2011-06-03 Thread Bert Huijben
> -Original Message- > From: Mark Phippard [mailto:markp...@gmail.com] > Sent: vrijdag 3 juni 2011 14:13 > To: Bert Huijben; dev@subversion.apache.org > Subject: Re: Stuck between relocate and upgrade > I do not get the impression that 1.4 is the relevant fact here. It > seems like the

RE: Stuck between relocate and upgrade

2011-06-03 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: vrijdag 3 juni 2011 14:05 > To: Bert Huijben > Cc: dev@subversion.apache.org > Subject: Re: Stuck between relocate and upgrade > > On Fri, Jun 03, 2011 at 01:53:45PM +0200, Bert Huijben wrote: > > Hi, > > > >

Re: Stuck between relocate and upgrade

2011-06-03 Thread Mark Phippard
On Fri, Jun 3, 2011 at 8:04 AM, Stefan Sperling wrote: > On Fri, Jun 03, 2011 at 01:53:45PM +0200, Bert Huijben wrote: >>       Hi, >> >> I'm trying to get SharpSvn working compiled against Subversion 1.7. After >> fixing a few minor compilation problems I found a problem that other users >> might

Re: Stuck between relocate and upgrade

2011-06-03 Thread Stefan Sperling
On Fri, Jun 03, 2011 at 01:53:45PM +0200, Bert Huijben wrote: > Hi, > > I'm trying to get SharpSvn working compiled against Subversion 1.7. After > fixing a few minor compilation problems I found a problem that other users > might find as well. > > In our test suite (which is based on the o

Stuck between relocate and upgrade

2011-06-03 Thread Bert Huijben
Hi, I'm trying to get SharpSvn working compiled against Subversion 1.7. After fixing a few minor compilation problems I found a problem that other users might find as well. In our test suite (which is based on the old AnkhSVN test suite) we have a few tarballs of working copies created wi

Re: rpath problem?

2011-06-03 Thread Philip Martin
Arwin Arni writes: > Why should the make process depend on what exists at the target? Your distribution may make modifications to libtool to reduce the inter-library dependencies; such modification can cause problems when the build produces libraries that link to other libraries in the build. Se

Re: rpath problem?

2011-06-03 Thread Stefan Sperling
On Fri, Jun 03, 2011 at 04:16:48PM +0530, Arwin Arni wrote: > Sometimes while compiling our sources, I get errors like this: > > cd subversion/svn && /usr/share/apr-1.0/build/libtool --tag=CC > --silent --mode=link gcc -Wno-system-headers -Wold-style-definition > -Werror=declaration-after-stateme

Re: [PATCH] Simplify and optimize RA-svn's string marshalling

2011-06-03 Thread Daniel Shahaf
Julian Foad wrote on Fri, Jun 03, 2011 at 09:52:21 +0100: > Hi Stefan2 and others. > > This patch simplifies code in RA-svn/marshal.c by using a single code > path to read both short and long strings efficiently. Using a single > code path is beneficial for test coverage. > > It is an alternativ

API review for 1.7

2011-06-03 Thread Julian Foad
I'm starting a review of the public API changes for 1.7. This is what I intend to do. If you have done or are doing any of these, or think of other things, please say. * Check that all changes from the 1.6 public API are marked as new or deprecated as appropriate. * Check that new functions

rpath problem?

2011-06-03 Thread Arwin Arni
Sometimes while compiling our sources, I get errors like this: cd subversion/svn && /usr/share/apr-1.0/build/libtool --tag=CC --silent --mode=link gcc -Wno-system-headers -Wold-style-definition -Werror=declaration-after-statement -Wpointer-arith -Wwrite-strings -Wshadow -ansi -Wall -Wformat=2

Re: svn commit: r1130528 - in /subversion/trunk/subversion: libsvn_client/patch.c libsvn_repos/hooks.c libsvn_subr/mergeinfo.c libsvn_subr/subst.c libsvn_subr/utf.c libsvn_wc/props.c svn/util.c

2011-06-03 Thread Johan Corveleyn
On Fri, Jun 3, 2011 at 10:56 AM, Julian Foad wrote: > On Thu, 2011-06-02 at 23:18 +0200, Johan Corveleyn wrote: >> On Thu, Jun 2, 2011 at 2:59 PM,   wrote: >> > Author: stefan2 >> > Date: Thu Jun  2 12:59:59 2011 >> > New Revision: 1130528 >> > >> > URL: http://svn.apache.org/viewvc?rev=1130528&vi

Re: svn commit: r1130528 - in /subversion/trunk/subversion: libsvn_client/patch.c libsvn_repos/hooks.c libsvn_subr/mergeinfo.c libsvn_subr/subst.c libsvn_subr/utf.c libsvn_wc/props.c svn/util.c

2011-06-03 Thread Julian Foad
On Thu, 2011-06-02 at 23:18 +0200, Johan Corveleyn wrote: > On Thu, Jun 2, 2011 at 2:59 PM, wrote: > > Author: stefan2 > > Date: Thu Jun 2 12:59:59 2011 > > New Revision: 1130528 > > > > URL: http://svn.apache.org/viewvc?rev=1130528&view=rev > > Log: > > Replace calls to svn_string_create_from_b

[PATCH] Simplify and optimize RA-svn's string marshalling

2011-06-03 Thread Julian Foad
Hi Stefan2 and others. This patch simplifies code in RA-svn/marshal.c by using a single code path to read both short and long strings efficiently. Using a single code path is beneficial for test coverage. It is an alternative to r1028352 which merged r985606 and r1028092 from the performance bra

Re: How to get the message out

2011-06-03 Thread Johan Corveleyn
On Tue, Nov 9, 2010 at 4:35 PM, Hyrum K. Wright wrote: > On Mon, Nov 8, 2010 at 9:39 AM, Bolstridge, Andrew > wrote: >> >>> -Original Message- >>> From: hy...@hyrumwright.org [mailto:hy...@hyrumwright.org] On Behalf >> Of Hyrum K. Wright >>> Sent: 07 November 2010 02:34 >>> To: Subversion

Re: First 1.7.0 prerelease: June 1

2011-06-03 Thread Stefan Fuhrmann
On 03.06.2011 04:16, Hyrum K Wright wrote: On Wed, May 18, 2011 at 5:17 AM, Hyrum K Wright wrote: Fire up your testing environments: they're going to get some use over the next couple of months. In an effort to release early and often, I'd like to cut the first 1.7.0 pre-release on June 1. Th