Re: svn commit: r1873943 - /subversion/trunk/subversion/tests/libsvn_fs_fs/fs-fs-pack-test.c

2020-02-13 Thread Daniel Shahaf
Joe Orton wrote on Wed, 12 Feb 2020 14:39 +00:00: > On Wed, Feb 12, 2020 at 02:28:54PM +0000, Daniel Shahaf wrote: > > jor...@apache.org wrote on Wed, 12 Feb 2020 13:41 -: > > > Author: jorton > > > Date: Wed Feb 12 13:41:25 2020 > > > New Revi

Re: svn commit: r1873943 - /subversion/trunk/subversion/tests/libsvn_fs_fs/fs-fs-pack-test.c

2020-02-12 Thread Daniel Shahaf
jor...@apache.org wrote on Wed, 12 Feb 2020 13:41 -: > Author: jorton > Date: Wed Feb 12 13:41:25 2020 > New Revision: 1873943 > > URL: http://svn.apache.org/viewvc?rev=1873943=rev > Log: > Fix test failures seen on 32-bit architectures (Fedora Raw Hide, both > i686 and armv7hl) when building

Re: ra_serf redirect URL canonicalization fix

2020-01-30 Thread Daniel Shahaf
Julian Foad wrote on Thu, 30 Jan 2020 20:05 +: > Stefan Sperling wrote: > > I don't think that will help much in this case. ra_serf is supposed to > > return a "corrected URL" the client can use, instead of the orignal URL > > which was already canonical. By definition, the output of this

Re: Testimonials page for SVN website

2020-01-24 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, 24 Jan 2020 16:53 -0500: > I'd like to showcase testimonials on the website (with the permission > of those who provide them, of course), in a new page called something > like Subversion Success Stories or maybe just Testimonials. The title > isn't important right now.

Re: Subversion fails to checkout new working set when $HOME is automounted

2020-01-24 Thread Daniel Shahaf
Joerg Wunsch wrote on Fri, 24 Jan 2020 08:23 +0100: > As Daniel Shahaf wrote: > > Could we look for a solution that doesn't involve explicit user input? > > For example, given «svn co $URL $dir», we could search only in > > ancestors that are writable by the curre

Re: Paid internships?

2020-01-24 Thread Daniel Shahaf
Stefan Sperling wrote on Fri, 24 Jan 2020 15:25 +0100: > What we need is not someone fresh out of college to get paid to work here. > We need a set of people to be paid who already have the experience this > project requires. Or we need to find ways to allow those people to keep > spending the

Re: future of our "experimental" features

2020-01-24 Thread Daniel Shahaf
Stefan Sperling wrote on Fri, 24 Jan 2020 15:48 +0100: > On Fri, Jan 24, 2020 at 01:39:58PM +, Paul Hammant wrote: > > I think y'all should promote something to mainstream, even if the > > performance isn't what you want it to be (for this feature). Better slow > > IMO, than "does the wrong

Re: DUMP Error

2020-01-22 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, 22 Jan 2020 11:00:20 -0500: > According to the OP's stack trace, the exception was an access > violation in svn_fs_print_modules(): > > Stacktrace: > #1 0x7fff2af55583 in svn_fs_print_modules() > #2 0x7fff2af5627d in svn_fs_create2() How is this stack state

Re: svn commit: r1872919 - /subversion/trunk/subversion/tests/libsvn_subr/mergeinfo-test.c

2020-01-17 Thread Daniel Shahaf
julianf...@apache.org wrote on Fri, Jan 17, 2020 at 14:54:46 -: > @@ -2089,18 +2130,22 @@ test_rangelist_merge_random_canonical_in > +if (failure_mode) >{ > -printf("testcase FAIL: %s / %s\n", > +printf("first example of a failure mode: %s / %s\n" >

Re: [#4840] Merge assertion failure in svn_sort__array_insert

2020-01-17 Thread Daniel Shahaf
Julian Foad wrote on Thu, 16 Jan 2020 09:18 +00:00: > I inspected the debug prints whizzing by, and noted that it included > each of the different kinds of input cases I expected (e.g. empty > ranges, reversed ranges, duplicate ranges, overlapping ranges, etc.) and > that the results included

Re: [#4840] Merge assertion failure in svn_sort__array_insert

2020-01-15 Thread Daniel Shahaf
Julian, would you like to answer the question in the second quoted paragraph? Daniel Shahaf wrote on Wed, Jan 08, 2020 at 14:24:39 +: > Julian Foad wrote on Wed, Jan 08, 2020 at 10:14:42 +: > > What? > > Using a PRNG makes the test code harder to read and to maintain,

Re: "svn list -v" column alignment issue

2020-01-13 Thread Daniel Shahaf
Vincent Lefevre wrote on Mon, 13 Jan 2020 10:26 +00:00: > On 2020-01-10 16:58:26 +0100, Johan Corveleyn wrote: > > Since both 'svn ls -v' and 'svn blame' can be called on a repository > > URL, I don't really see the point in caching the max(length(author)) > > of the working copy. > > > > The

Re: Svn server images / appliances / packages

2020-01-10 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, 10 Jan 2020 15:07 +00:00: > But: The reference system would be one particular configuration known > to work, with all the kinks ironed out. Isn't that just cd subversion/tests/cmdline && ./davautocheck.sh --no-tests ?

Re: 20th anniversary press?

2020-01-09 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, Jan 06, 2020 at 09:21:33 -0500: > Daniel Shahaf wrote: > > > > We're coming up on the 20th anniversary of the first commit to > > Subversion's CVS repository: > > > > [[[ > > % svn

Re: mailer.py can produce subject header violates RFC 5321/5322 if truncate_subject is not set

2020-01-09 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Thu, 09 Jan 2020 01:06 +00:00: > (I'm sorry I cannot spare much time in this month later, so > it is next month if I work for this issue...) No worries; the bug has been there since time immemorial. There's no urgency to fix it. Cheers, Daniel

Re: [#4840] Merge assertion failure in svn_sort__array_insert

2020-01-08 Thread Daniel Shahaf
Julian Foad wrote on Wed, Jan 08, 2020 at 10:14:42 +: > Daniel Shahaf wrote: > > Julian Foad wrote on Tue, Jan 07, 2020 at 09:47:48 +: > > > For now, I propose to make each test use a repeatable sequence, > > > independent > > > of the other

Re: Svn server images / appliances / packages

2020-01-08 Thread Daniel Shahaf
Julian Foad wrote on Wed, Jan 08, 2020 at 11:53:53 +: > Brane wrote: > > [...] "no binary packages" policy [...] > > There is not a "no binary packages" policy; I addressed this with a footnote > in my original email. Specifically, ASF policy says a project MAY > distribute binaries: > >

Re: "svn list -v" column alignment issue

2020-01-08 Thread Daniel Shahaf
Vincent Lefevre wrote on Wed, Jan 08, 2020 at 10:28:01 +0100: > On 2020-01-07 16:10:52 +0000, Daniel Shahaf wrote: > > Vincent Lefevre wrote on Tue, Jan 07, 2020 at 16:17:10 +0100: > > > On 2019-12-23 06:35:08 +0000, Daniel Shahaf wrote: > > > > Two things a

Re: "svn list -v" column alignment issue

2020-01-07 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, 07 Jan 2020 16:10 +00:00: > Vincent Lefevre wrote on Tue, Jan 07, 2020 at 16:17:10 +0100: > > On 2019-12-23 06:35:08 +0000, Daniel Shahaf wrote: > > > Vincent Lefevre wrote on Mon, 23 Dec 2019 02:21 +00:00: > > > > On 2019-12-21 08:09

Re: mailer.py cannot handle utf-8 path in Subject correctly (Re: mailer.py can produce subject header violates RFC 5321/5322 if truncate_subject is not set)

2020-01-07 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Wed, Jan 08, 2020 at 00:26:39 +0900: > On 2020/01/07 9:41, Yasuhito FUTATSUKI wrote: > > On 2020/01/07 6:52, Yasuhito FUTATSUKI wrote: > >> By the way, it seems another issue about truncate_subject that current > >> implementation of truncate_subject may break utf-8

Re: mailer.py can produce subject header violates RFC 5321/5322 if truncate_subject is not set

2020-01-07 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Tue, Jan 07, 2020 at 06:52:20 +0900: > I found tools/hook-scripts/mailer/mailer.py can produce very long > subject header line without folding. It can be easily over 1000 > characters [1] if some large source tree is imported in a repository > and truncate_subject

Re: "svn list -v" column alignment issue

2020-01-07 Thread Daniel Shahaf
Vincent Lefevre wrote on Tue, Jan 07, 2020 at 16:17:10 +0100: > On 2019-12-23 06:35:08 +0000, Daniel Shahaf wrote: > > Vincent Lefevre wrote on Mon, 23 Dec 2019 02:21 +00:00: > > > On 2019-12-21 08:09:46 +0000, Daniel Shahaf wrote: > > > > Vincent Lefevre wrote on

Re: [#4840] Merge assertion failure in svn_sort__array_insert

2020-01-07 Thread Daniel Shahaf
Julian Foad wrote on Tue, Jan 07, 2020 at 09:47:48 +: > For now, I propose to make each test use a repeatable sequence, independent > of the other tests. I think that will be enough; the options I mentioned > can be added if and when there is a demand for them. > > How does that sound? I

Re: svn commit: r1872398 - in /subversion/trunk/tools/hook-scripts/mailer: mailer.conf.example mailer.py

2020-01-06 Thread Daniel Shahaf
futat...@apache.org wrote on Mon, Jan 06, 2020 at 23:34:17 -: > +++ subversion/trunk/tools/hook-scripts/mailer/mailer.conf.example Mon Jan 6 > 23:34:17 2020 > @@ -23,6 +23,10 @@ > # This option specifies the hostname for delivery via SMTP. > #smtp_hostname = localhost > > +# This option

Re: buildbot failure in on svn-x64-macosx-bdb

2020-01-05 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, 05 Jan 2020 16:44 +00:00: > On Fri, Jan 3, 2020 at 5:02 PM Branko Čibej wrote: > > You both get signal 6, though. I assume that's SIGABRT in both cases. What > > > would cause this? Would this be an explicit abort() call, or an uncleared > > > svn_error_t (do both

Re: [PATCH] Avoid DeprecationWarning on make check with Python >= 3.5

2020-01-03 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Fri, Jan 03, 2020 at 05:34:48 +0900: > +++ build/run_tests.py(working copy) > @@ -64,6 +64,11 @@ > +if sys.version_info < (3, 5): > + import imp > +else: > + import importlib.util Add a comment here explaining the reason for this? E.g., — # The imp

Re: buildbot failure in on svn-x64-macosx-bdb

2020-01-03 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, Jan 03, 2020 at 09:22:45 -0500: > Copying the fail log from the buildbot (since it appears they don't > stay up forever): It seems to save the last 100 builds (click on "Show more" than increase the argument to the URL query argument) going back to 2019-01-26 (sic),

Re: Makefile.svn: a dumb question

2020-01-02 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, 02 Jan 2020 17:44 +00:00: > On Thu, Jan 2, 2020 at 11:35 AM Daniel Shahaf wrote: > > Nathan Hartman wrote on Thu, Jan 02, 2020 at 10:45:25 -0500: > > > Regarding the one test failure I had (autoprop_tests.py 7 with > > > [svn x bdb]), I'

Re: Makefile.svn: a dumb question

2020-01-02 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, Jan 02, 2020 at 10:45:25 -0500: > Regarding the one test failure I had (autoprop_tests.py 7 with > [svn x bdb]), I've had two more since, both with bdb. These are > intermittent database errors and occur in varying places. (All fsfs > tests have passed every time.)

Re: svn commit: r1872118 - in /subversion/trunk/subversion: include/private/svn_sorts_private.h libsvn_client/merge.c libsvn_subr/mergeinfo.c libsvn_subr/sorts.c tests/libsvn_subr/mergeinfo-test.c

2019-12-30 Thread Daniel Shahaf
julianf...@apache.org wrote on Mon, Dec 30, 2019 at 15:42:17 -: > * subversion/libsvn_subr/mergeinfo.c > (svn_rangelist_merge2): Extract the body of this function into a local > 'rangelist_merge2', leaving the original as an error-checking > wrapper. If an error occurs, report its

Re: svn commit: r1872030 - /subversion/trunk/subversion/libsvn_subr/mergeinfo.c

2019-12-28 Thread Daniel Shahaf
Good morning Julian, julianf...@apache.org wrote on Fri, Dec 27, 2019 at 15:08:31 -: > Author: julianfoad > Date: Fri Dec 27 15:08:31 2019 > New Revision: 1872030 > > URL: http://svn.apache.org/viewvc?rev=1872030=rev > Log: > Avoid converting invalid mergeinfo to bogus valid-looking

Re: Makefile.svn: a dumb question

2019-12-28 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, Dec 27, 2019 at 15:39:10 -0500: > On Fri, Dec 27, 2019 at 12:41 AM Daniel Shahaf > wrote: > > Nathan Hartman wrote on Thu, Dec 26, 2019 at 17:02:21 -0500: > > > (If you're wondering about /dev/sdb1, it appears to be a regular disk, > >

Re: Makefile.svn: a dumb question

2019-12-26 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, Dec 26, 2019 at 17:02:21 -0500: > On Thu, Dec 26, 2019 at 12:04 PM Daniel Shahaf > wrote: > > > Here are the contents of fails.log.svn-check-svn-bdb -- could be some > > > kind of fluke? I just started another full test run. Let's

Re: Makefile.svn: a dumb question

2019-12-26 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, 26 Dec 2019 16:48 +00:00: > One more question: Does anyone know which package(s) to install on > Debian to be able to run the JavaHL tests? Probably these: % apt-cache showsrc subversion | grep Build-Depends | vipe default-jdk-headless (>= 2:1.8) [!hurd-i386 !hppa

Re: Makefile.svn: a dumb question

2019-12-25 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, Dec 25, 2019 at 12:07:35 -0500: > On Wed, Dec 25, 2019 at 1:38 AM Yasuhito FUTATSUKI > wrote: > > > > On 2019/12/25 6:38, Nathan Hartman wrote: > > > When running the regression test suite via the 'svn-check' target of > > > tools/dev/unix-build/Makefile.svn, is

Re: Svn server images / appliances / packages

2019-12-22 Thread Daniel Shahaf
Branko Čibej wrote on Mon, 16 Dec 2019 15:33 +00:00: > We should look into how, or if, other ASF projects publish their > Dockerfiles. I'd much rather have an asf/ repository at docker.io than a > subversion/ repository. There's an official https://hub.docker.com/u/apache.

Re: svn commit: r1871916 - /subversion/trunk/subversion/svn/log-cmd.c

2019-12-22 Thread Daniel Shahaf
danie...@apache.org wrote on Mon, 23 Dec 2019 06:50 +00:00: > 'svn log': Make the --quiet and --diff options not mutually exclusive. > > +++ subversion/trunk/subversion/svn/log-cmd.c Mon Dec 23 06:50:26 2019 > @@ -733,10 +733,6 @@ svn_cl__log(apr_getopt_t *os, > - if (opt_state->quiet &&

Re: "svn list -v" column alignment issue

2019-12-22 Thread Daniel Shahaf
Vincent Lefevre wrote on Mon, 23 Dec 2019 02:21 +00:00: > On 2019-12-21 08:09:46 +0000, Daniel Shahaf wrote: > > Vincent Lefevre wrote on Sat, Dec 21, 2019 at 00:09:09 +0100: > > > There's something wrong with "svn list -v" column alignment when > > > th

Re: "svn list -v" column alignment issue

2019-12-21 Thread Daniel Shahaf
Vincent Lefevre wrote on Sat, Dec 21, 2019 at 00:09:09 +0100: > There's something wrong with "svn list -v" column alignment when > there are author names with more than 8 characters. For instance, > with the gcc repository: > > [...] > 279442 jozeflDec 16 12:02 libgcc/ > 278886

Re: svn commit: r1871827 - /subversion/trunk/subversion/bindings/swig/python/tests/client.py

2019-12-20 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Fri, 20 Dec 2019 13:31 +00:00: > I found that nb->shelved_func() in this line is > svn_swig_py_client_status_func() on swig Python bindings, and it is > incorrectly implemented that it isn't return value (i.e. void type). > This should be svn_client_status_func_t,

Re: "svn patch" and the TAB character

2019-12-16 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, 17 Dec 2019 01:55 +00:00: > I suppose that simply trying to repeatedly s/\s+\S+$// might work well > enough? That is: In English: remove all non-whitespaces at the end of the string, then remove all trailing whitespace. > data = line[len('--- '):].r

Re: "svn patch" and the TAB character

2019-12-16 Thread Daniel Shahaf
Doug Robinson wrote on Mon, Dec 16, 2019 at 11:13:25 -0500: > So the two file names, differing only by a TAB in the "right place" will > currently have completely different behaviors: > > My File NameSPACE(Revision 12) > My File NameTAB(Revision 12) > > I see no point in maintaining that the

Re: [jira] [Commented] (SVN-1532) Switch a file to a dir: can't switch it back to the file

2019-12-15 Thread Daniel Shahaf
Nathan Hartman (Jira) wrote on Sun, 15 Dec 2019 20:12 +00:00: > Two different fixes have been suggested above: > > (1) Several people: Open the editor on the parent rather than the node itself. > > or > > (2) Max Oliver Bowsher: "For exactly the same reason that you cannot > checkout a file,

Translatable diff headers (was: Re: "svn patch" and the TAB character)

2019-12-14 Thread Daniel Shahaf
Stefan Sperling wrote on Sat, 14 Dec 2019 11:13 +00:00: > The problem is that svn diff's revision number marker " (revision XY)" must > be separated by a TAB. In diff generation, the whole string is translated: _("%s\t(revision %ld)"). It seems to me that if a translator changed the start of the

Re: swig-py3 str/bytes difference in svn_config_*()

2019-12-14 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Sat, 14 Dec 2019 04:19 +00:00: > Though this issue was already resolved... > > On 2019/12/13 17:28, Yasuhito FUTATSUKI wrote: > > On 2019/12/13 16:24, Daniel Shahaf wrote: > >> Thanks for the quick fix.  However, it doesn't work on my machi

Re: "svn patch" and the TAB character

2019-12-14 Thread Daniel Shahaf
Doug Robinson wrote on Fri, 13 Dec 2019 21:59 +00:00: > If I [...] edit that patch file using an editor with settings that replace > the TAB > with a "proper" number of SPACE characters, Don't do that. If the context lines start with tabs (ignoring the first column), they would be corrupted

Re: swig-py3 str/bytes difference in svn_config_*()

2019-12-13 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Fri, Dec 13, 2019 at 17:28:18 +0900: > Thank you for testing. I also tested and same result on FreeBSD > with Python 3.6. It seems "z*" format in PyArg_ParseTuple() doesn't > work I expected. > > On the other hand, I can't find good reason to care typemap for > "const

Re: swig-py3 str/bytes difference in svn_config_*()

2019-12-12 Thread Daniel Shahaf
Thanks for the quick fix. However, it doesn't work on my machine (Debian stretch). With your latest patch, «svn_config_get_user_config_path(None, None)» calls the C function of the name with «path == NULL» and segfaults immediately, because the parameter is dereferenced on the first line of the

swig-py3 str/bytes difference in svn_config_*()

2019-12-12 Thread Daniel Shahaf
With swig-py3 in trunk: >>> from svn.core import * >>> svn_config_get_user_config_path(None, '') b'/home/daniel/.subversion' >>> d = _ >>> svn_config_ensure(d) Traceback (most recent call last): File "", line 1, in File "${prefix}/lib/svn-python/libsvn/core.py", line 6014, in

Re: Wiki editing

2019-12-12 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, 13 Dec 2019 01:04 +00:00: > I didn't think to look through site. Evidently there is at least one > script there. Speaking of which, did you intend for it to show up as > a hyperlink on the wiki? I intended to put the full URL there. I did not intend for it to be a

Re: Wiki editing

2019-12-12 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, 12 Dec 2019 15:31 +00:00: > On Wed, Dec 11, 2019 at 12:03 AM Daniel Shahaf > wrote: > > Nathan Hartman wrote on Wed, 11 Dec 2019 04:44 +00:00: > > > On Tue, Dec 10, 2019 at 9:22 PM Daniel Shahaf > > wrote: > > > > I wanted

Re: Wiki editing

2019-12-10 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, 11 Dec 2019 04:44 +00:00: > On Tue, Dec 10, 2019 at 9:22 PM Daniel Shahaf wrote: > > I wanted to update the Python 3 page on the wiki, but I'm given a choice > > between a in-browser WYSIWYG editor and editing raw HTML. Neither of > > these

Wiki editing

2019-12-10 Thread Daniel Shahaf
I wanted to update the Python 3 page on the wiki, but I'm given a choice between a in-browser WYSIWYG editor and editing raw HTML. Neither of these is very user-friendly to me (the default editor doesn't even render correctly; the raw HTML editor puts the whole list of bullets in one long source

Re: 1.9.x release notes, SVN-4722

2019-12-09 Thread Daniel Shahaf
Nathan Hartman wrote on Tue, Dec 10, 2019 at 01:22:41 -0500: > On Mon, Dec 9, 2019 at 10:22 PM Daniel Shahaf wrote: > > There were multiple security issues fixed in later 1.9 patch releases; see > > https://subversion.apache.org/security/ > > Yes. I see quite a few affec

Re: 1.9.x release notes, SVN-4722

2019-12-09 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, Dec 09, 2019 at 10:42:39 -0500: > + > +Commit can fail with an undeserved "Filesystem is corrupt" error > + +title="Link to this section"> > + > + > +See issue 4722, "checksum fail during commit when delta is 16K". > + > + > +When using a Subversion 1.9.7 server,

Re: [PATCH] svnversion --no-stat (and an idea about changelists)

2019-12-09 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, Dec 09, 2019 at 09:04:20 -0500: > On Sun, Dec 1, 2019 at 7:08 PM Daniel Shahaf wrote: > > > Julian Foad wrote on Sun, Dec 01, 2019 at 12:01:09 +: > > > Daniel Shahaf wrote: > > > > I'd like to get the "is this WC mixed r

Re: [PATCH] svnversion --no-stat (and an idea about changelists)

2019-12-09 Thread Daniel Shahaf
Julian Foad wrote on Mon, Dec 09, 2019 at 11:14:02 +: > It seems to me what you really need is a way to request some specific bits > of info about the "base shape" of the WC. The motivation for requesting > something more specific than the current output of 'svnversion' is clearly > the slow

Re: [PATCH] svnversion --no-stat (and an idea about changelists)

2019-12-09 Thread Daniel Shahaf
Johan Corveleyn wrote on Mon, 09 Dec 2019 09:31 +00:00: > On Mon, Dec 9, 2019 at 9:01 AM Daniel Shahaf wrote: > > > > Any further comments on either of the topics below? In particular, the > > patch acceptable? > > > > Daniel Shahaf wrote on Mon, 02 Dec 2019 00:0

Re: [PATCH] svnversion --no-stat (and an idea about changelists)

2019-12-09 Thread Daniel Shahaf
Any further comments on either of the topics below? In particular, the patch acceptable? Daniel Shahaf wrote on Mon, 02 Dec 2019 00:08 +00:00: > Julian Foad wrote on Sun, Dec 01, 2019 at 12:01:09 +: > > Daniel Shahaf wrote: > > > I'd like to get the "is

Re: 1.9.x release notes, SVN-4722

2019-12-08 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, 08 Dec 2019 06:04 +00:00: > Commit can fail with an undeserved "Filesystem is corrupt" error > > See issue 4722, "checksum fail during commit when delta is 16K". > > Under a very specific set of circumstances, a commit may fail with an > undeserved "Filesystem is

Re: find usage of gcov-clean target in Makefile.in

2019-12-04 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Thu, 05 Dec 2019 01:31 +00:00: > I'm sorry for the delay. No worries. > Thanks you, Daniel and Brane, now I can build out of the woking copy. > > This need to generate SWIG language bindings C source and support codes > before configure to build them, and then, I

Re: [PATCH] Fix wrapping of 'svn help' output at 80 chars

2019-12-04 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, 04 Dec 2019 23:04 +00:00: > On Wed, Dec 4, 2019 at 4:05 PM Nathan Hartman > wrote: > > On Wed, Dec 4, 2019 at 3:51 AM Daniel Shahaf > > wrote: > > I can confirm that with the patch applied, getopt_tests.py runs and > > all its tests

Re: [PATCH] Fix wrapping of 'svn help' output at 80 chars

2019-12-04 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, 04 Dec 2019 05:43 +00:00: > I haven't confirmed this yet but I think that fixes it because at some > point between initialization and this test running, sys.argv[0] is > being modified. Confirmed. > I found two instances of sys.argv[0] being assigned in >

Re: Eight 'info --show-item' issues

2019-12-03 Thread Daniel Shahaf
Julian Foad wrote on Tue, 03 Dec 2019 12:25 +00:00: > Daniel Shahaf wrote: > >> Let's start by naming the issues: > [...] > >> The semantics I'd like to have are: > [...] > > [I] didn't want this issue, while outstanding, to take up any > > brainwidth. >

Re: Eight 'info --show-item' issues

2019-12-03 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, 03 Dec 2019 12:02 +00:00: > > > Let's start by naming the issues: 9. MULTIPLE_TARGETS mode suppresses the "can't show in-repository size of working copy file '%s'" error. I can't imagine why. If it's fine to print nothing for a wc file w

Eight 'info --show-item' issues

2019-12-03 Thread Daniel Shahaf
I just discovered that 'svn info --show-item' has some twisty logic for _sometimes_ tacking on additional information at the end of a line: [subversion/svn/info-cmd.c] 1332receiver_baton.multiple_targets = (opt_state->depth > svn_depth_empty 1333

Re: [PATCH] Fix wrapping of 'svn help' output at 80 chars

2019-12-01 Thread Daniel Shahaf
Daniel Shahaf wrote on Mon, Dec 02, 2019 at 03:50:14 +: > Instead of running the entire test suite, you can do «cd …/cmdline && > ./getopt_tests.py». Run it with --help for details. By the way, the --help output doesn't document this, but in the syntax «./getopt_tests.py []»,

Re: [PATCH] Fix wrapping of 'svn help' output at 80 chars

2019-12-01 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, Dec 01, 2019 at 22:22:26 -0500: > On a related note, I cannot seem to run *just* getopt_tests.py. If I > run it like this, I get failure: > > [[[ > > $ make check TESTS=subversion/tests/cmdline/getopt_tests.py ⋮ > tests.log contains (only the first failure shown,

Re: Commits not being reported?

2019-12-01 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, 01 Dec 2019 15:02 +00:00: > hartmannathan Access granted (after authenticating Nathan offlist). Cheers, Daniel

Re: [PATCH] svnversion --no-stat (and an idea about changelists)

2019-12-01 Thread Daniel Shahaf
Julian Foad wrote on Sun, Dec 01, 2019 at 12:01:09 +: > Daniel Shahaf wrote: > > I'd like to get the "is this WC mixed revision?" and "is this WC switched?" > > bits without stat()-ing every single file in the worktree. > > What info do you actually w

Re: [PATCH] svnversion --no-stat

2019-12-01 Thread Daniel Shahaf
Branko Čibej wrote on Sun, Dec 01, 2019 at 13:13:04 +0100: > On 01.12.2019 04:12, Daniel Shahaf wrote: > > I'd like to get the "is this WC mixed revision?" and "is this WC switched?" > > bits without stat()-ing every single file in the worktree. > > Not g

Re: Merging branches/swig-py3 to trunk

2019-12-01 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, Dec 01, 2019 at 10:58:34 -0500: > On Thu, Nov 28, 2019 at 4:05 PM Daniel Shahaf wrote: > > I suggest to also grep for «sys.executable»; there are several > > instances of that in trunk. > > I did such a search and sys.executable is found in: >

[PATCH] svnversion --no-stat

2019-11-30 Thread Daniel Shahaf
I'd like to get the "is this WC mixed revision?" and "is this WC switched?" bits without stat()-ing every single file in the worktree. Patch enclosed. It still prints 'M' when there's a tree mod or a prop mod. In my use-case I actually throw that out: I use it as «svnversion --no-stat | sed

Re: find usage of gcov-clean target in Makefile.in

2019-11-29 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, 28 Nov 2019 21:50 +00:00: > Branko Čibej wrote on Thu, 28 Nov 2019 21:30 +00:00: > > I think this warrants a bug report to infra because the link really > > should work correctly. > > Created https://issues.apache.org/jira/browse/INFRA-19500. Fixed.

Re: find usage of gcov-clean target in Makefile.in

2019-11-28 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, 29 Nov 2019 01:41 +00:00: > On Thu, Nov 28, 2019 at 4:18 PM Daniel Shahaf wrote: > > Is -prune portable? I don't see it in the POSIX spec of find(1). > > Where did you look? This page mentions -prune and even provides an example: > https://

Re: find usage of gcov-clean target in Makefile.in

2019-11-28 Thread Daniel Shahaf
Branko Čibej wrote on Thu, 28 Nov 2019 21:30 +00:00: > I think this warrants a bug report to infra because the link really > should work correctly. Created https://issues.apache.org/jira/browse/INFRA-19500. Thanks, Daniel

Re: find usage of gcov-clean target in Makefile.in

2019-11-28 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Fri, Nov 29, 2019 at 00:15:48 +0900: > Hi, while I do 'make distclean', I find odd `find' usage. > > In Makefile.in: > > gcov-clean: > > rm -f gcov-lcov.dat gcov-lcov.log gcov-genhtml.log > > rm -rf gcov-report > > find . -name "*.gcda" -o -name "*.gcno"

Re: Merging branches/swig-py3 to trunk

2019-11-28 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Thu, Nov 28, 2019 at 20:36:25 +0900: > And there seems to be also some scripts calling Python > interpreter with -c option. > > I roughly searched: > [[[ > $ find . -name .svn -prune -or -type f -print0 | xargs -0 egrep -i > '(^|[^-])python.* -c' I suggest to also

Re: Last-Modified HTTP header in GET responses

2019-11-25 Thread Daniel Shahaf
Doug Robinson wrote on Mon, 25 Nov 2019 14:11 +00:00: > Can we get this fix back-ported into 1.10.x please? Breaking an LTS is > unfortunate as is waiting until the next LTS. r1866425 is already in https://svn.apache.org/repos/asf/subversion/branches/1.10.x/STATUS?p=r1870409. It will likely

Re: svn commit: r1870062 - /subversion/site/publish/docs/release-notes/1.14.html

2019-11-24 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, Nov 24, 2019 at 12:26:04 -0500: > On Thu, Nov 21, 2019 at 9:09 PM Daniel Shahaf wrote: > > hartmannat...@apache.org wrote on Thu, 21 Nov 2019 04:23 +00:00: > > > +The convenience script that downloads Subversion's minimal > > > +build-tim

Re: svn commit: r1870217 - /subversion/trunk/tools/server-side/svn-backup-dumps.py

2019-11-23 Thread Daniel Shahaf
futat...@apache.org wrote on Sat, Nov 23, 2019 at 10:08:30 -: > +++ subversion/trunk/tools/server-side/svn-backup-dumps.py Sat Nov 23 > 10:08:30 2019 > @@ -402,7 +402,8 @@ class SvnBackup: > -sys.stdout.write("%s " % buf.decode('utf-8')) > +

Re: Cannot get info for a file that was inside of file-replaced directory

2019-11-22 Thread Daniel Shahaf
Let's continue the discussion on dev@. [Moved from users@] Ivan, would you like to write a regression test for this? See subversion/tests/cmdline/info_tests.py. Cheers, Daniel P.S. Nathan, are you aware of this syntax? — «svn log --diff -x-wp -c r1823327» Nathan Hartman wrote on Fri, Nov

Re: svn commit: r1870062 - /subversion/site/publish/docs/release-notes/1.14.html

2019-11-22 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, 22 Nov 2019 06:08 +00:00: > Where should these point? > > Perhaps to: > https://svn.apache.org/viewvc/subversion/trunk/INSTALL?revision=HEAD > > with a TODO reminding us to change 'trunk' to 'branches/1.14.x'? The link need only be valid when the first 1.14.0-*

Re: svn commit: r1870062 - /subversion/site/publish/docs/release-notes/1.14.html

2019-11-21 Thread Daniel Shahaf
hartmannat...@apache.org wrote on Thu, 21 Nov 2019 04:23 +00:00: > +The convenience script that downloads Subversion's minimal > +build-time dependencies, get-deps.sh, has been updated to download > +py3c. This script is found in the source distribution's root > +directory. For the full list of

Re: Building subversion runs svnversion, which fails

2019-11-19 Thread Daniel Shahaf
Nathan Hartman wrote on Tue, 19 Nov 2019 18:25 +00:00: > On Tue, Nov 19, 2019 at 12:04 PM Daniel Shahaf > wrote: > > The concept of having the binary know the `svnversion` info of the > > working copy it was built from does make sense, however. We could make > >

Re: svn commit: r1869981 - /subversion/trunk/tools/dist/release.py

2019-11-19 Thread Daniel Shahaf
Julian Foad wrote on Tue, Nov 19, 2019 at 17:18:23 +: > Daniel Shahaf wrote: > > julianf...@apache.org wrote on Mon, 18 Nov 2019 16:31 +00:00: > > > Author: julianfoad > > > Date: Mon Nov 18 16:31:45 2019 > > > New Revision: 1869981 > > > > &

Re: svn commit: r1869982 - in /subversion/trunk/tools/dist: release-lines.yaml release.py

2019-11-19 Thread Daniel Shahaf
julianf...@apache.org wrote on Mon, 18 Nov 2019 17:00 +00:00: > +++ subversion/trunk/tools/dist/release.py Mon Nov 18 17:00:16 2019 > @@ -70,43 +71,22 @@ except ImportError: > +# Read the dist metadata (about release lines) > +with open(get_dist_metadata_file_path(), 'r') as stream: > +

Re: svn commit: r1869981 - /subversion/trunk/tools/dist/release.py

2019-11-19 Thread Daniel Shahaf
julianf...@apache.org wrote on Mon, 18 Nov 2019 16:31 +00:00: > Author: julianfoad > Date: Mon Nov 18 16:31:45 2019 > New Revision: 1869981 > > URL: http://svn.apache.org/viewvc?rev=1869981=rev > Log: > * tools/dist/release.py (recommended_release): Remove TODO: didn't make sense. The point of

Re: Building subversion runs svnversion, which fails

2019-11-19 Thread Daniel Shahaf
Nathan Hartman wrote on Tue, 19 Nov 2019 04:53 +00:00: > Moving this from users@ to dev@... [Aside: when doing this, it's a good to post a short response on users@ saying the conversation continues on dev@, for anyone who wants to follow along but isn't subscribed to both lists.] > On a somewhat

Re: svn commit: r1869870 - /subversion/trunk/INSTALL

2019-11-19 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, 18 Nov 2019 15:30 +00:00: > [[[ > > You need the Berkeley DB libraries only if you are building a > Subversion server that supports the older BDB repository storage back- > end, or a Subversion client that can access local BDB repositories via > the file:// URI

Re: svn commit: r1869945 - /subversion/site/staging/docs/release-notes/1.14.html

2019-11-19 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, 18 Nov 2019 15:46 +00:00: > The only problem with this idea is that the link won't take the reader > directly to the information about Python. INSTALL contains a lot of > other information to wade through.

Re: svn commit: r1869945 - /subversion/site/staging/docs/release-notes/1.14.html

2019-11-18 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, 17 Nov 2019 15:37 +00:00: > In that case, here's a thought: We can put a short message in a yellow > box: "Python is optional. Read more below." That would link to a > regular h3 section with the detailed text... +1 Furthermore, we have the option of making the box

Re: svn commit: r1869945 - /subversion/site/staging/docs/release-notes/1.14.html

2019-11-17 Thread Daniel Shahaf
danie...@apache.org wrote on Sun, 17 Nov 2019 13:53 +00:00: > +++ subversion/site/staging/docs/release-notes/1.14.html Sun Nov 17 13:53:41 > 2019 > @@ -269,8 +269,8 @@ Welcome below. > - > -Python is Optional. > + > +Python is Optional. href="#python-is-optional"> So, the link works, but when

Re: 1.14 Release Notes: New py3c Dependency

2019-11-17 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, Nov 17, 2019 at 01:42:52 -0500: > The 1.14 release notes, under "Support for Python 3.x," should > document the new dependency. I think it should be in a yellow note > box: YMMV, but I'd make it a regular , not a yellow note box. We don't want to water down the

Re: Fwd: buildbot failure in on svn-x64-macosx-apr2.0-dev

2019-11-17 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, Nov 17, 2019 at 00:16:56 -0500: > From > https://ci.apache.org/builders/svn-x64-macosx-apr2.0-dev/builds/2871/steps/svn/logs/stdio > (but all the recent failures are for the same reason): > > > Updating '.': > > svn: E170013: Unable to connect to a repository at URL '

Re: svn commit: r1869856 - /subversion/site/staging/docs/release-notes/1.14.html

2019-11-17 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, Nov 17, 2019 at 00:15:51 -0500: > Regarding your suggestion, I'm not sure I understand correctly. Are you > suggesting to re-order the paragraphs, like so: Yes.

Re: svn commit: r1869870 - /subversion/trunk/INSTALL

2019-11-17 Thread Daniel Shahaf
Disclaimer: Most of the below is just my own opinion. There's plenty of latitude in this. Nathan Hartman wrote on Sun, Nov 17, 2019 at 00:02:34 -0500: > You need Berkeley DB only if you are building support for > Subversion's older BDB repository storage back-end. The BDB > back-end is

Re: svn commit: r1869849 - /subversion/site/staging/docs/release-notes/1.14.html

2019-11-15 Thread Daniel Shahaf
Daniel Shahaf wrote on Fri, Nov 15, 2019 at 23:33:18 +: > julianf...@apache.org wrote on Fri, Nov 15, 2019 at 11:46:31 -: > > +++ subversion/site/staging/docs/release-notes/1.14.html Fri Nov 15 > > 11:46:31 2019 > > @@ -219,7 +219,7 @@ users. We'll cover

Re: svn commit: r1869870 - /subversion/trunk/INSTALL

2019-11-15 Thread Daniel Shahaf
hartmannat...@apache.org wrote on Fri, Nov 15, 2019 at 16:40:22 -: > +++ subversion/trunk/INSTALL Fri Nov 15 16:40:22 2019 > @@ -344,17 +344,21 @@ I.INTRODUCTION > + 7. Berkeley DB 4.X (DEPRECATED and OPTIONAL) ⋮ > + The BDB back end has been deprecated in favor of FSFS, which

Re: svn commit: r1869868 - /subversion/trunk/INSTALL

2019-11-15 Thread Daniel Shahaf
hartmannat...@apache.org wrote on Fri, Nov 15, 2019 at 16:21:00 -: > +++ subversion/trunk/INSTALL Fri Nov 15 16:20:59 2019 > @@ -120,17 +120,17 @@ I.INTRODUCTION > assembler modules of OpenSSL. As of OpenSSL 1.1.0 NASM is the > only supported assembler. > > + *

<    1   2   3   4   5   6   7   8   9   10   >