Running the 1.7.0 pre-releases on svn.apache.org

2011-06-13 Thread Hyrum K Wright
Before we moved to the ASF, the Subversion project had a habit of running our pre-releases on our live repository, and I wonder if there would be benefits to putting the 1.7.0 alphas on svn.apache.org. The server-side of 1.7.0 has seen several enhancements, but unlike the client, where much of the

Re: svn commit: r1134489 - /subversion/trunk/tools/dist/release.py

2011-06-11 Thread Hyrum K Wright
On Fri, Jun 10, 2011 at 7:49 PM, Daniel Shahaf wrote: > hwri...@apache.org wrote on Sat, Jun 11, 2011 at 00:14:03 -: >> +# About this script: >> +#   This script is intended to simplify creating Subversion releases, by >> +#   automating as much as is possible.  It works well with our Apache >

Re: s.a.o/download/ vs. s.a.o/source-code.html

2011-06-10 Thread Hyrum K Wright
On Fri, Jun 10, 2011 at 11:28 AM, C. Michael Pilato wrote: > On 06/10/2011 12:13 PM, Hyrum K Wright wrote: >> I think there are really two audiences here: people downloading >> releases, and folks looking to get the source from the repo.  I'd like >> to make /download

Re: s.a.o/download/ vs. s.a.o/source-code.html

2011-06-10 Thread Hyrum K Wright
On Fri, Jun 10, 2011 at 11:55 AM, Daniel Shahaf wrote: > Hyrum K Wright wrote on Fri, Jun 10, 2011 at 11:13:16 -0500: >> On Fri, Jun 10, 2011 at 10:40 AM, C. Michael Pilato >> wrote: >> > On 06/10/2011 09:40 AM, Hyrum K Wright wrote: >> >> In getting ready fo

Re: s.a.o/download/ vs. s.a.o/source-code.html

2011-06-10 Thread Hyrum K Wright
On Fri, Jun 10, 2011 at 10:40 AM, C. Michael Pilato wrote: > On 06/10/2011 09:40 AM, Hyrum K Wright wrote: >> In getting ready for the 1.7.0 release cycle, we've put together a new >> download page on subversion.apache.org.  This page allows us to make >> u

Re: Deferring the removal of temp APIs

2011-06-10 Thread Hyrum K Wright
On Fri, Jun 10, 2011 at 10:33 AM, C. Michael Pilato wrote: > On 06/10/2011 07:39 AM, Daniel Shahaf wrote: >> Julian Foad wrote on Fri, Jun 10, 2011 at 11:17:11 +0100: >>> The consensus seemed to be [1] that we can add/remove/change private >>> APIs during the 1.7.x series, >> >> Indeed that's the

s.a.o/download/ vs. s.a.o/source-code.html

2011-06-10 Thread Hyrum K Wright
In getting ready for the 1.7.0 release cycle, we've put together a new download page on subversion.apache.org. This page allows us to make use of the Apache mirroring infrastructure when distributing new releases. My aim is to have the download page eventually become the canonical source for rele

Re: [PATCH] svnmerge-migrate-history-remotely.py: move from getopt to optparse

2011-06-08 Thread Hyrum K Wright
On Wed, Jun 8, 2011 at 5:59 AM, anatoly techtonik wrote: > On Wed, Jun 8, 2011 at 12:57 PM, Stefan Sperling wrote: >> On Wed, Jun 08, 2011 at 09:34:05AM +0300, anatoly techtonik wrote: >>> On Mon, Jun 6, 2011 at 6:32 PM, Stefan Sperling wrote: >>> > On Thu, Jun 02, 2011 at 07:06:05PM +0300, anat

Re: API review - svn_info2_t

2011-06-08 Thread Hyrum K Wright
c dependency and the reason why it should be > changed.  I haven't yet added a constructor. > > - Julian > > > On Tue, 2011-06-07, Hyrum K Wright wrote: >> Oh, and if it hasn't already grown one yet, svn_info2_t needs a >> constructor.  svn_wc_info_t doesn'

Re: API review - svn_info2_t

2011-06-07 Thread Hyrum K Wright
Oh, and if it hasn't already grown one yet, svn_info2_t needs a constructor. svn_wc_info_t doesn't, since it's always created by libsvn_wc. -Hyrum On Tue, Jun 7, 2011 at 2:12 PM, Hyrum K Wright wrote: > As the original author of svn_info2_t, I'll share some thoughts

Re: API review - svn_info2_t

2011-06-07 Thread Hyrum K Wright
As the original author of svn_info2_t, I'll share some thoughts which might be of use. The struct was originally defined as svn_info_t in svn_client.h, but with wc-ng, it needed a face lift. At the same time, I recognized the fact that info can be obtained via a URL, which returned a subset of th

Re: svn commit: r1132966 - in /subversion/trunk: subversion/include/ subversion/libsvn_ra_svn/ subversion/svn/ subversion/svnlook/ subversion/svnsync/ subversion/svnversion/ tools/dev/svnraisetreeconf

2011-06-07 Thread Hyrum K Wright
How does this impact backward compat? If somebody was including just 'svn_wc.h' and expecting to get the contents of svn_version.h, their code will now not compile, yes? This is demonstrated by our own build breakage after r1132965. (You mention a similar cleanup happened early in 1.7 developmen

Re: Slides from recent event

2011-06-06 Thread Hyrum K Wright
On Mon, Jun 6, 2011 at 7:52 PM, Blair Zajac wrote: > On 05/24/2011 01:12 AM, Stefan Sperling wrote: >> >> On Mon, May 23, 2011 at 05:13:56PM -0700, Blair Zajac wrote: >>> >>> I see from >>> >>> http://www.elegosoft.com/bestof-svnday2011/ >>> >>> that some people gave talks.  I haven't seen any ema

Re: [l10n] Translation status report for trunk r1132623

2011-06-06 Thread Hyrum K Wright
On Mon, Jun 6, 2011 at 9:32 AM, Julian Foad wrote: > On Mon, 2011-06-06 at 13:05 +, Subversion Translation Status wrote: >> Translation status report for trunk@r1132623 >> >>   lang   trans untrans   fuzzy     obs >> -- >>     de    2053     139     287    

Re: svn commit: r1131434 - /subversion/trunk/configure.ac

2011-06-04 Thread Hyrum K Wright
On Sat, Jun 4, 2011 at 2:40 PM, Arfrever Frehtes Taifersar Arahesis wrote: > 2011-06-04 18:50:09 s...@apache.org napisał(a): >> Author: stsp >> Date: Sat Jun  4 16:50:08 2011 >> New Revision: 1131434 >> >> URL: http://svn.apache.org/viewvc?rev=1131434&view=rev >> Log: >> * configure.ac: Look for r

1.7.0-alpha1 tarballs up for testing/signing

2011-06-03 Thread Hyrum K Wright
All, At long request, we now have tarballs for the first 1.7.0 pre-release: 1.7.0-alpha1 ("phoenix-hatchling"). These were cut from trunk, and the magic rev is r1130808. The buildbots were green at that rev, and all tests pass for me locally. You can find them here: http://people.apache.org/~hw

Re: Stuck between relocate and upgrade

2011-06-03 Thread Hyrum K Wright
On Fri, Jun 3, 2011 at 7:27 AM, Daniel Shahaf wrote: > Bert Huijben wrote on Fri, Jun 03, 2011 at 14:17:47 +0200: >> And if one of those users doesn't manage its own installed applications >> (Read: typical corporate environment), then the only thing a user could do >> is delete all relevant worki

Re: First 1.7.0 prerelease: June 1

2011-06-03 Thread Hyrum K Wright
On Fri, Jun 3, 2011 at 2:54 AM, Stefan Fuhrmann wrote: > On 03.06.2011 04:16, Hyrum K Wright wrote: >> >> On Wed, May 18, 2011 at 5:17 AM, Hyrum K Wright >>  wrote: >>> >>> Fire up your testing environments: they're going to get some use over >>&g

Re: First 1.7.0 prerelease: June 1

2011-06-02 Thread Hyrum K Wright
On Wed, May 18, 2011 at 5:17 AM, Hyrum K Wright wrote: > Fire up your testing environments: they're going to get some use over > the next couple of months. > > In an effort to release early and often, I'd like to cut the first > 1.7.0 pre-release on June 1.  This will

Re: svn commit: r1130556 - in /subversion/tags/1.6.17: ./ subversion/include/svn_version.h

2011-06-02 Thread Hyrum K Wright
On Thu, Jun 2, 2011 at 3:17 PM, C. Michael Pilato wrote: > On 06/02/2011 04:11 PM, Hyrum K Wright wrote: >> On Thu, Jun 2, 2011 at 11:48 AM, C. Michael Pilato >> wrote: >>> On 06/02/2011 11:52 AM, Hyrum K Wright wrote: >>>> Mike, >>>> Thanks for p

Re: svn commit: r1130556 - in /subversion/tags/1.6.17: ./ subversion/include/svn_version.h

2011-06-02 Thread Hyrum K Wright
On Thu, Jun 2, 2011 at 11:48 AM, C. Michael Pilato wrote: > On 06/02/2011 11:52 AM, Hyrum K Wright wrote: >> Mike, >> Thanks for picking up the pieces here.  A couple of thoughts: >>  * Since the magic rev for the release is r1128011, the tag should be >> based on that

Re: svn commit: r1130688 - in /subversion/trunk/subversion: libsvn_fs_base/tree.c libsvn_fs_fs/tree.c

2011-06-02 Thread Hyrum K Wright
On Thu, Jun 2, 2011 at 12:49 PM, wrote: > Author: pburba > Date: Thu Jun  2 17:49:36 2011 > New Revision: 1130688 > > URL: http://svn.apache.org/viewvc?rev=1130688&view=rev > Log: > A partial fix for issue #3896 'mergeinfo syntax errors should be treated > gracefully': Tolerate invalid mergeinfo

Re: svn commit: r1130556 - in /subversion/tags/1.6.17: ./ subversion/include/svn_version.h

2011-06-02 Thread Hyrum K Wright
Mike, Thanks for picking up the pieces here. A couple of thoughts: * Since the magic rev for the release is r1128011, the tag should be based on that revision, per HACKING (see [1]) * From that point, we should then merge to the tag the relavant revisions from 1.6.x to make the tag match the rel

Re: svn commit: r1130319 - in /subversion/site/publish: index.html news.html

2011-06-01 Thread Hyrum K Wright
Gah. Thanks. -Hyrum On Wed, Jun 1, 2011 at 10:19 PM, Greg Stein wrote: > Fixed in r1130323 > > On Wed, Jun 1, 2011 at 18:12, Greg Stein wrote: >> Hunh? Looks like you changed the 1.6.16 date. >> >> On Wed, Jun 1, 2011 at 18:08,   wrote: >>> Author: hwright >>> Date: Wed Jun  1 22:08:40 2011 >>

Re: svn commit: r1129802 - /subversion/trunk/subversion/libsvn_wc/wc-checks.sql

2011-05-31 Thread Hyrum K Wright
On Tue, May 31, 2011 at 7:03 AM, wrote: > Author: julianfoad > Date: Tue May 31 17:03:44 2011 > New Revision: 1129802 > > URL: http://svn.apache.org/viewvc?rev=1129802&view=rev > Log: > * subversion/libsvn_wc/wc-checks.sql >  (validation_03, validation_04): Use more efficient SQL expressions. I

Re: svn commit: r1104124 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/deprecated.c libsvn_subr/io.c

2011-05-27 Thread Hyrum K Wright
ting callers. >> > >> > It also turns out that I may not need the new (revv'd) API at all --- >> > went a different way in the patch I'm working on --- so I may, after >> > all, not add a user of the new API today (as I'd planned to). >> > >>

Re: bindings in default build? (was: svn commit: r1126985 ...)

2011-05-24 Thread Hyrum K Wright
On Tue, May 24, 2011 at 7:36 AM, Greg Stein wrote: > On Tue, May 24, 2011 at 09:39, Mark Phippard wrote: >>... >> Wasn't it JavaHL that failed to compile?  If we want developers to >> always compile the Java bindings then why don't we remove it as a >> separate build target and just make it part

Re: "... first release candidate is expected in August 2011." Really?

2011-05-23 Thread Hyrum K Wright
On Mon, May 23, 2011 at 9:10 PM, Ivan Zhakov wrote: > On Tue, May 24, 2011 at 08:02, Greg Stein wrote: >> >> On May 23, 2011 10:21 PM, "Ivan Zhakov" wrote: >>> >>> On Tue, May 24, 2011 at 01:44, Mark Phippard wrote: >>>... >>> > >>> > I think they should stay in 1.7.0 until such point that we m

Re: "... first release candidate is expected in August 2011." Really?

2011-05-23 Thread Hyrum K Wright
On Mon, May 23, 2011 at 11:48 AM, C. Michael Pilato wrote: > On 05/23/2011 02:25 PM, Hyrum K Wright wrote: > > The outcome of the hackathon was "we'll start alpha releases in June and > > branch when the blockers are gone" > > Hrm... that's not quite what

Re: Using the Wimp decorator in the Python tests

2011-05-23 Thread Hyrum K Wright
On Mon, May 23, 2011 at 10:55 AM, Stefan Sperling wrote: > On Mon, Mar 14, 2011 at 01:22:39PM +, Philip Martin wrote: > > I don't see any of the Python tests using @Wimp. How is it used? > > > > @Wimp > > @Wimp() > > > > TypeError: __init__() got an unexpected keyword argument 'issues' > > >

Re: "... first release candidate is expected in August 2011." Really?

2011-05-23 Thread Hyrum K Wright
On Mon, May 23, 2011 at 11:05 AM, C. Michael Pilato wrote: > I recently saw the elego post-SvnDay write-up at: > > http://www.elegosoft.com/bestof-svnday2011/ > > Cool stuff, and I'm glad to see that our gracious hosts felt that the day > was successful. I know I was encouraged by conversations

Re: svn commit: r1126525 - in /subversion/trunk/subversion: libsvn_client/delete.c tests/cmdline/basic_tests.py

2011-05-23 Thread Hyrum K Wright
On Monday, May 23, 2011, Greg Stein wrote: > > On May 23, 2011 11:43 AM, "Hyrum K Wright" wrote: >>... >> Thanks for the review.  The original patch had rotted a bit, so I'm glad for >> some extra eyes.  Concerns addressed in subsequent commits. > T

Re: svn commit: r1126525 - in /subversion/trunk/subversion: libsvn_client/delete.c tests/cmdline/basic_tests.py

2011-05-23 Thread Hyrum K Wright
On Mon, May 23, 2011 at 8:15 AM, Greg Stein wrote: > On Mon, May 23, 2011 at 11:00, wrote: > >... > > +++ subversion/trunk/subversion/libsvn_client/delete.c Mon May 23 > 15:00:50 2011 > > @@ -141,36 +141,22 @@ path_driver_cb_func(void **dir_baton, > > return editor->delete_entry(path, SVN_INV

Re: svn commit: r1126481 - /subversion/trunk/subversion/libsvn_subr/svn_base64.c

2011-05-23 Thread Hyrum K Wright
On Mon, May 23, 2011 at 6:16 AM, Greg Stein wrote: > On Mon, May 23, 2011 at 09:11, wrote: > > Author: hwright > > Date: Mon May 23 13:11:10 2011 > > New Revision: 1126481 > > > > URL: http://svn.apache.org/viewvc?rev=1126481&view=rev > > Log: > > Remove some integer size mismatch warnings by u

Re: svn commit: r1125708 - /subversion/trunk/tools/dist/backport.pl

2011-05-21 Thread Hyrum K Wright
On Sat, May 21, 2011 at 7:12 AM, wrote: > Author: danielsh > Date: Sat May 21 14:12:27 2011 > New Revision: 1125708 > > URL: http://svn.apache.org/viewvc?rev=1125708&view=rev > Log: > * tools/dist/backport.pl: New tool to automate merging STATUS entries. I've not reviewed the script, nor do I ha

Re: svn commit: r1125292 - in /subversion/trunk: configure.ac notes/knobs subversion/libsvn_ra/ra_loader.c subversion/svn_private_config.hw

2011-05-21 Thread Hyrum K Wright
On Fri, May 20, 2011 at 2:28 AM, wrote: > Author: ivan > Date: Fri May 20 09:28:57 2011 > New Revision: 1125292 > > URL: http://svn.apache.org/viewvc?rev=1125292&view=rev > Log: > Add DEFAULT_HTTP_LIBRARY define for configuring default HTTP library to use. If this is meant to be at least quasi-p

Re: svn commit: r1125459 - /subversion/branches/1.6.x/STATUS

2011-05-21 Thread Hyrum K Wright
On Fri, May 20, 2011 at 4:21 PM, Philip Martin wrote: > Hyrum K Wright writes: > >> This is already nominated elsewhere in the file. >> >> (Hint: look in the 'Vetoed' section. :) ) > > Hmm, > >     -1: hwright (I'm not sure we need this: the

Re: svn commit: r1125327 - /subversion/trunk/subversion/svndumpfilter/main.c

2011-05-20 Thread Hyrum K Wright
This may be picking nits, but is the format for size_t and apr_size_t guaranteed to be the same on all platforms? -Hyrum On Fri, May 20, 2011 at 4:17 AM, wrote: > Author: philip > Date: Fri May 20 11:17:58 2011 > New Revision: 1125327 > > URL: http://svn.apache.org/viewvc?rev=1125327&view=rev >

Re: svn commit: r1125459 - /subversion/branches/1.6.x/STATUS

2011-05-20 Thread Hyrum K Wright
This is already nominated elsewhere in the file. (Hint: look in the 'Vetoed' section. :) ) -Hyrum On Fri, May 20, 2011 at 9:46 AM, wrote: > Author: philip > Date: Fri May 20 16:46:29 2011 > New Revision: 1125459 > > URL: http://svn.apache.org/viewvc?rev=1125459&view=rev > Log: > * STATUS: prop

Re: [PATCH] -r { DATE } with words

2011-05-19 Thread Hyrum K Wright
2011/5/19 Branko Čibej : > On 19.05.2011 15:38, Greg Stein wrote: >> 2011/5/19 Branko Čibej : >>> On 19.05.2011 11:53, Stefan Sperling wrote: On Wed, May 18, 2011 at 09:38:55PM +0200, Branko Čibej wrote: > Why? That doesn't make sense. Second of all, all these wordy aliases are > just

Re: SVN_ERR_ASSERT calls abort() in non-maintainer-mode

2011-05-19 Thread Hyrum K Wright
On Thu, May 19, 2011 at 3:48 PM, Arwin Arni wrote: > In our implementation of SVN_ERR_ASSERT, we do: > > #define SVN_ERR_ASSERT(expr)                                            \ >  do {                                                                  \ >    if (!(expr))                          

Re: WC format bump imminent - renaming pristines to .pristine

2011-05-19 Thread Hyrum K Wright
On Thu, May 19, 2011 at 11:36 AM, Justin Erenkrantz wrote: > On Thu, May 19, 2011 at 11:34 AM, Julian Foad > wrote: >> Oh, it looks like the choice of name >> >>  '.pristine' >> >> was not discussed in that thread.  Two or three of us thought that >> seemed like a sensible choice of name.  The o

Re: svn commit: r1104160 - /subversion/trunk/subversion/libsvn_subr/utf.c

2011-05-18 Thread Hyrum K Wright
2011/5/18 Branko Čibej : > On 17.05.2011 14:16, Hyrum K Wright wrote: >> apr_atomic_xchgptr() and friends are not available on APR 0.9.  (This >> is causing a buildbot build failure.) > > Maybe we should just drop support for APR-0.9 finally? I know that we > sort of &quo

Re: Vetos in 1.6.x branch -- and how they impact trunk

2011-05-18 Thread Hyrum K Wright
On Wed, May 18, 2011 at 6:32 PM, Paul Burba wrote: > On Tue, May 17, 2011 at 9:48 AM, Mark Phippard wrote: > >> There are some vetos in the 1.6.x branch that seem like they are >> questioning the change, not just whether it was a candidate for >> backport.  What does that mean for trunk and 1.7?

Re: [random line of thought] Hiding svn:mergeinfo

2011-05-18 Thread Hyrum K Wright
On Wed, May 18, 2011 at 3:51 PM, Paul Burba wrote: ... >>> [I suspect it might, but want to hear others' thoughts before laying >>> out my own.] >> >> I don't think hiding it completely is the way to go, but there has >> been some half-implemented code to filter propchanges from various >> operati

Re: Add ".svn-base" suffix to the pristine files in 1.7

2011-05-18 Thread Hyrum K Wright
On Wed, May 18, 2011 at 3:43 PM, Julian Foad wrote: > C. Michael Pilato wrote: >> On 05/18/2011 02:02 PM, C. Michael Pilato wrote: >> > On 05/18/2011 01:34 PM, C. Michael Pilato wrote: >> >> You mentioned not being able to provide a patch, but would you be >> >> willing/able to at least file an is

Re: Now May 18 Re: 1.6.17 release rolling next week (May 11)

2011-05-18 Thread Hyrum K Wright
On Tue, May 10, 2011 at 11:38 PM, Hyrum K Wright wrote: > On Mon, May 9, 2011 at 1:01 PM, Hyrum K Wright wrote: >> On Thu, May 5, 2011 at 9:37 AM, Hyrum K Wright wrote: >>> On Mon, May 2, 2011 at 3:38 PM, Hyrum K Wright >>> wrote: >>>> Hi all, >&

Re: Add ".svn-base" suffix to the pristine files in 1.7

2011-05-18 Thread Hyrum K Wright
On Wed, May 18, 2011 at 12:35 PM, Konstantin Kolinko wrote: > Hi, all! > > Right now the files in the pristine storage of 1.7 wc are named just > by their checksums, e.g. > > .svn/pristine/00/00014966dd2c75cedf7fc9989accf25e54685e58 > > I think it would be better to add ".svn-base" suffix to those

Re: enhancements for error reporting

2011-05-18 Thread Hyrum K Wright
On Wed, May 18, 2011 at 11:17 AM, C. Michael Pilato wrote: > On 05/18/2011 09:53 AM, Bert Huijben wrote: >> One obvious case is that libsvn_client sometimes suggests that you >> should do a 'svn something', which is only possible if you use svn. > > libsvn_client should *never* give suggestions th

First 1.7.0 prerelease: June 1

2011-05-18 Thread Hyrum K Wright
Fire up your testing environments: they're going to get some use over the next couple of months. In an effort to release early and often, I'd like to cut the first 1.7.0 pre-release on June 1. This will likely be a beta release, since there are still blocking issues, but I hope to get this into t

Re: [random line of thought] Hiding svn:mergeinfo

2011-05-18 Thread Hyrum K Wright
On Wed, May 18, 2011 at 9:32 AM, Bert Huijben wrote: > It would completely break mergetracking for about a dozen reasons :( > > I'll answer more detailed later, but this would just remove the > property everywhere. > > And if you could hide it in a better way while still storing it in the > wc, yo

Re: svn commit: r1104610 - in /subversion/trunk/subversion/libsvn_wc: props.c wc_db.c wc_db.h

2011-05-18 Thread Hyrum K Wright
On Wed, May 18, 2011 at 11:20 AM, Bert Huijben wrote: > > >> -Original Message- >> From: Greg Stein [mailto:gst...@gmail.com] >> Sent: woensdag 18 mei 2011 11:16 >> To: Bert Huijben >> Cc: dev@subversion.apache.org; Hyrum K Wright >> Subject: Re

Re: svn commit: r1104610 - in /subversion/trunk/subversion/libsvn_wc: props.c wc_db.c wc_db.h

2011-05-18 Thread Hyrum K Wright
On Wed, May 18, 2011 at 11:13 AM, Bert Huijben wrote: > > >> -Original Message----- >> From: Hyrum K Wright [mailto:hy...@hyrumwright.org] >> Sent: woensdag 18 mei 2011 11:11 >> To: Bert Huijben >> Cc: dev@subversion.apache.org; comm...@subversion.a

Re: svn commit: r1104610 - in /subversion/trunk/subversion/libsvn_wc: props.c wc_db.c wc_db.h

2011-05-18 Thread Hyrum K Wright
On Wed, May 18, 2011 at 1:48 AM, Bert Huijben wrote: >> -Original Message- >> From: Hyrum K Wright [mailto:hy...@hyrumwright.org] >> Sent: woensdag 18 mei 2011 1:11 >> To: dev@subversion.apache.org >> Cc: comm...@subversion.apache.org >> Su

Re: svn commit: r1104610 - in /subversion/trunk/subversion/libsvn_wc: props.c wc_db.c wc_db.h

2011-05-17 Thread Hyrum K Wright
I understand the desire to get the buildbots green again, and I'm sorry these revisions which I committed broke the bots, but a little patience might have been useful here. We have a long tradition of allowing folks to attempt to fix problems, rather than reverting their commits without consultati

Re: svn commit: r1104408 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py

2011-05-17 Thread Hyrum K Wright
For the record, proplist has been broken for a while. :) This test verifies that we fetch the right thing for a given node. My recent changes only changed which nodes the information is fetched on. In other words, I'm not really looking at this right now. -Hyrum On Tue, May 17, 2011 at 5:02 PM

op-depth-test 23 failure

2011-05-17 Thread Hyrum K Wright
I'm seeing the following failure on my Mac OS box, with trunk@1104228 [[[ dhcp207:libsvn_wc Hyrum$ ./op-depth-test 23 subversion/tests/libsvn_wc/op-depth-test.c:3431: (apr_err=150002) subversion/libsvn_client/copy.c:2443: (apr_err=150002) subversion/libsvn_client/copy.c:2268: (apr_err=150002) subv

Re: svn commit: r1104160 - /subversion/trunk/subversion/libsvn_subr/utf.c

2011-05-17 Thread Hyrum K Wright
apr_atomic_xchgptr() and friends are not available on APR 0.9. (This is causing a buildbot build failure.) -Hyrum On Tue, May 17, 2011 at 11:27 AM, wrote: > Author: stefan2 > Date: Tue May 17 11:27:25 2011 > New Revision: 1104160 > > URL: http://svn.apache.org/viewvc?rev=1104160&view=rev > Log

Re: svn commit: r1104160 - /subversion/trunk/subversion/libsvn_subr/utf.c

2011-05-17 Thread Hyrum K Wright
On Tue, May 17, 2011 at 11:27 AM, wrote: > Author: stefan2 > Date: Tue May 17 11:27:25 2011 > New Revision: 1104160 > > URL: http://svn.apache.org/viewvc?rev=1104160&view=rev > Log: > Speed up UTF8 conversion, especially if APR_HAS_THREADS. > Provide global global ... ? > ... -Hyrum

Re: svn commit: r1104124 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/deprecated.c libsvn_subr/io.c

2011-05-17 Thread Hyrum K Wright
Are there still valid use cases for the normal cstring case? If so, we shouldn't be deprecating the old API, but rather adding a distinct API. -Hyrum On Tue, May 17, 2011 at 10:55 AM, wrote: > Author: danielsh > Date: Tue May 17 10:55:51 2011 > New Revision: 1104124 > > URL: http://svn.apache.

Re: svn commit: r1103838 - in /subversion/trunk/subversion/bindings/javahl/native: Prompter.cpp Prompter.h

2011-05-17 Thread Hyrum K Wright
On Mon, May 16, 2011 at 7:06 PM, Mark Phippard wrote: > On Mon, May 16, 2011 at 2:50 PM,   wrote: >> Author: markphip >> Date: Mon May 16 18:50:40 2011 >> New Revision: 1103838 >> >> URL: http://svn.apache.org/viewvc?rev=1103838&view=rev >> Log: >> JavaHL: Fixed JNI code to look for the new UserPa

Re: svn commit: r1104056 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2011-05-17 Thread Hyrum K Wright
On Tue, May 17, 2011 at 8:47 AM, wrote: > Author: rhuijben > Date: Tue May 17 08:47:00 2011 > New Revision: 1104056 >... > Modified: subversion/trunk/subversion/libsvn_wc/wc_db.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc_db.c?rev=1104056&r1=1104055&r2=1104056

Re: svn commit: r1103582 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2011-05-17 Thread Hyrum K Wright
On Tue, May 17, 2011 at 8:11 AM, Greg Stein wrote: > On May 16, 2011 2:15 AM, wrote: >> >> Author: hwright >> Date: Mon May 16 00:14:39 2011 >> New Revision: 1103582 >> >> URL: http://svn.apache.org/viewvc?rev=1103582&view=rev >> Log: >> When populating the targets list, don't bother calculating

Re: svn commit: r1103771 - in /subversion/trunk/subversion: libsvn_client/prop_commands.c svn/propedit-cmd.c svn/propget-cmd.c

2011-05-17 Thread Hyrum K Wright
On Tue, May 17, 2011 at 7:51 AM, Daniel Shahaf wrote: > hwri...@apache.org wrote on Mon, May 16, 2011 at 15:36:24 -: >> Author: hwright >> Date: Mon May 16 15:36:24 2011 >> New Revision: 1103771 >> >> URL: http://svn.apache.org/viewvc?rev=1103771&view=rev >> Log: >> Convert a bit of the recurs

Re: svn commit: r1103765 - in /subversion/trunk/subversion: libsvn_wc/update_editor.c libsvn_wc/wc_db.c libsvn_wc/wc_db.h tests/libsvn_wc/db-test.c tests/libsvn_wc/op-depth-test.c

2011-05-16 Thread Hyrum K Wright
On Mon, May 16, 2011 at 3:24 PM, wrote: > Author: stefan2 > Date: Mon May 16 15:24:59 2011 > New Revision: 1103765 > > URL: http://svn.apache.org/viewvc?rev=1103765&view=rev > Log: > Finding the w/c base folder using svn_wc__db_wcroot_parse_local_abspath > can be expensive if being called for man

Re: svn commit: r1103391 - /subversion/trunk/notes/meetings/berlin-11-agenda

2011-05-16 Thread Hyrum K Wright
On Mon, May 16, 2011 at 11:48 AM, Ivan Zhakov wrote: > On Mon, May 16, 2011 at 13:45, Daniel Shahaf wrote: >> i...@apache.org wrote on Sun, May 15, 2011 at 14:24:46 -: >>> Author: ivan >>> Date: Sun May 15 14:24:45 2011 >>> New Revision: 1103391 >>> >>> URL: http://svn.apache.org/viewvc?rev=1

Re: [PATCH] in-process packed-offset cache broken in 1.6.16 (on 64-bit architectures)

2011-05-16 Thread Hyrum K Wright
Committed to the 1.6.x branch in r1103680. This fix will be in the next release of Subversion. Thanks again, -Hyrum On Mon, May 16, 2011 at 10:05 AM, Hyrum K Wright wrote: > It turns out that on trunk, we are using apr_int64_t which Daniel > tells me is still incorrect, so r1103665 a

Re: [PATCH] in-process packed-offset cache broken in 1.6.16 (on 64-bit architectures)

2011-05-16 Thread Hyrum K Wright
It turns out that on trunk, we are using apr_int64_t which Daniel tells me is still incorrect, so r1103665 applies your patch there, and I've nominated it for 1.6.x (with Daniel's vote) in r1103668. Thanks! -Hyrum On Mon, May 16, 2011 at 10:39 AM, Daniel Shahaf wrote: > +1 from Hyrum and I; we'

Re: SQLite and the LIKE operator

2011-05-16 Thread Hyrum K Wright
On Mon, May 16, 2011 at 8:28 AM, Bert Huijben wrote: > > >> -Original Message----- >> From: Hyrum K Wright [mailto:hy...@hyrumwright.org] >> Sent: maandag 16 mei 2011 9:39 >> To: Branko Čibej >> Cc: dev@subversion.apache.org >> Subject: Re: SQLite an

Re: SQLite and the LIKE operator

2011-05-16 Thread Hyrum K Wright
2011/5/16 Branko Čibej : > On 16.05.2011 03:13, Hyrum K Wright wrote: >> Several places in wc_db we use the following pattern to select all >> nodes with a common tree ancestor: >>  WHERE wc_id = ?1 AND (local_relpath = ?2 OR local_relpath LIKE ?3 ESCAPE >> '#

SQLite and the LIKE operator

2011-05-15 Thread Hyrum K Wright
Several places in wc_db we use the following pattern to select all nodes with a common tree ancestor: WHERE wc_id = ?1 AND (local_relpath = ?2 OR local_relpath LIKE ?3 ESCAPE '#') While this works, there was some concern about whether or not SQLite was using the proper indicies when executing thi

Re: svn commit: r1103177 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2011-05-14 Thread Hyrum K Wright
On Sat, May 14, 2011 at 7:29 PM, Greg Stein wrote: > On Sat, May 14, 2011 at 14:19,   wrote: >>... >> +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Sat May 14 18:19:11 2011 >> @@ -2466,10 +2466,18 @@ run_final_query(void *baton, >>                 svn_wc__db_wcroot_t *wcroot, >>              

Vulnerability in APR: CVE-2011-0419

2011-05-14 Thread Hyrum K Wright
To interested persons: Apache Subversion uses the Apache Portable Runtime (APR) to provide platform-specific and other utility services. APR announced the availability of APR 1.4.4, which addresses CVE-2011-0419, a potential unconstrained recursion bug in the apr_fnmatch(). An attacker could pot

Re: [svnbench] Revision: 1101392 compiled May 10 2011, 10:07:15

2011-05-10 Thread Hyrum K Wright
On Tue, May 10, 2011 at 6:31 PM, Neels Hofmeyr wrote: > The most recent benchmark suggests that the 'svn delete' performance > problem I was complaining about earlier is not only gone but completely > reversed. 'svn delete' is now EXTREMELY fast when compared to 1.6. > > Amazing. > > Also, one has

Now May 18 Re: 1.6.17 release rolling next week (May 11)

2011-05-10 Thread Hyrum K Wright
On Mon, May 9, 2011 at 1:01 PM, Hyrum K Wright wrote: > On Thu, May 5, 2011 at 9:37 AM, Hyrum K Wright wrote: >> On Mon, May 2, 2011 at 3:38 PM, Hyrum K Wright wrote: >>> Hi all, >>> >>> There have a been a couple of user-requested fixes nominated or >

Re: Error in 'svn cp', but the operation succeeds

2011-05-10 Thread Hyrum K Wright
On Tue, May 10, 2011 at 9:42 AM, C. Michael Pilato wrote: > On 05/09/2011 05:53 PM, Hyrum K Wright wrote: >> On Mon, May 9, 2011 at 3:46 PM, Hyrum K Wright wrote: >>> On Mon, May 9, 2011 at 3:20 PM, Hyrum K Wright >>> wrote: >>>> A small bug I ran acro

Re: Error in 'svn cp', but the operation succeeds

2011-05-09 Thread Hyrum K Wright
On Mon, May 9, 2011 at 4:58 PM, Stefan Sperling wrote: > On Mon, May 09, 2011 at 04:53:15PM -0500, Hyrum K Wright wrote: >> On Mon, May 9, 2011 at 3:46 PM, Hyrum K Wright wrote: >> > On Mon, May 9, 2011 at 3:20 PM, Hyrum K Wright >> > wrote: >> >> A small

Re: Error in 'svn cp', but the operation succeeds

2011-05-09 Thread Hyrum K Wright
On Mon, May 9, 2011 at 3:46 PM, Hyrum K Wright wrote: > On Mon, May 9, 2011 at 3:20 PM, Hyrum K Wright wrote: >> A small bug I ran across.  I'll eventually dig deeper, but if anybody >> has the time, they are welcome to look.  This is with a r1101202 trunk >> client. &

Re: Error in 'svn cp', but the operation succeeds

2011-05-09 Thread Hyrum K Wright
On Mon, May 9, 2011 at 3:20 PM, Hyrum K Wright wrote: > A small bug I ran across.  I'll eventually dig deeper, but if anybody > has the time, they are welcome to look.  This is with a r1101202 trunk > client. > > [[[ > $ svn cp ^/apr/site/trunk/docs/download.cgi . > svn:

Error in 'svn cp', but the operation succeeds

2011-05-09 Thread Hyrum K Wright
A small bug I ran across. I'll eventually dig deeper, but if anybody has the time, they are welcome to look. This is with a r1101202 trunk client. [[[ $ svn cp ^/apr/site/trunk/docs/download.cgi . svn: E160013: '/repos/asf/!svn/bc/30/apr/site/trunk/docs/download.cgi' path not found $ svn st A +

Re: What's left before branching 1.7.x?

2011-05-09 Thread Hyrum K Wright
On Thu, May 5, 2011 at 6:07 PM, Mark Phippard wrote: > On Thu, May 5, 2011 at 6:02 PM, Hyrum K Wright wrote: > >> We've still got bugs (we'll always have bugs), but I think getting >> more testing via the pre-releases is important at this stage, and I >> see

Re: 1.6.17 release rolling next week (May 11)

2011-05-09 Thread Hyrum K Wright
On Thu, May 5, 2011 at 9:37 AM, Hyrum K Wright wrote: > On Mon, May 2, 2011 at 3:38 PM, Hyrum K Wright wrote: >> Hi all, >> >> There have a been a couple of user-requested fixes nominated or >> backported to 1.6.17, and there are several pending fixes.  So let'

Re: %lld in svn_string.c

2011-05-09 Thread Hyrum K Wright
On Sat, May 7, 2011 at 6:27 AM, Daniel Shahaf wrote: > Someone added %lld and %llu codes to svn_string.c: > >    return svn_error_return( >             svn_error_createf(SVN_ERR_INCORRECT_PARAMS, NULL, >                               _("Number '%s' is out of range '[%lld, %lld]'"), >              

Re: svn commit: r1100756 - in /subversion/trunk/subversion/libsvn_wc: update_editor.c wc.h

2011-05-09 Thread Hyrum K Wright
On Sun, May 8, 2011 at 10:22 AM, wrote: > Author: rhuijben > Date: Sun May  8 15:22:01 2011 > New Revision: 1100756 > > URL: http://svn.apache.org/viewvc?rev=1100756&view=rev > Log: > Extract some logic from the update_editor's merge_file code to its own > function > to allow reusing it from the

Re: svn commit: r1100704 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-05-09 Thread Hyrum K Wright
On Sun, May 8, 2011 at 3:34 AM, wrote: > Author: rhuijben > Date: Sun May  8 08:34:56 2011 > New Revision: 1100704 > > URL: http://svn.apache.org/viewvc?rev=1100704&view=rev > Log: > * subversion/libsvn_wc/wc_db.c >  (scan_addition_txn, >   wclock_obtain_cb, >   svn_wc__db_wclock_obtain, >   svn_

Re: svn commit: r1100460 - /subversion/trunk/subversion/libsvn_wc/tree_conflicts.c

2011-05-07 Thread Hyrum K Wright
On Sat, May 7, 2011 at 1:26 AM, wrote: > Author: gstein > Date: Sat May  7 06:26:54 2011 > New Revision: 1100460 > > URL: http://svn.apache.org/viewvc?rev=1100460&view=rev > Log: > Simplify some tree conflict code by removing an (unused) error return. ...and add a bunch of vertical whitespace. :

Re: svn commit: r1100553 - in /subversion/trunk/tools/dev/benchmarks/large_dirs: ./ create_bigdir.sh

2011-05-07 Thread Hyrum K Wright
On Sat, May 7, 2011 at 9:41 AM, wrote: > Author: stefan2 > Date: Sat May  7 14:41:28 2011 > New Revision: 1100553 > > URL: http://svn.apache.org/viewvc?rev=1100553&view=rev > Log: > Add a simple test shell script that will execute and gauge basic > operations on increasingly large directories in

Re: New)(?) Subversion client user-agent string ugliness.

2011-05-06 Thread Hyrum K Wright
On Fri, May 6, 2011 at 4:01 PM, C. Michael Pilato wrote: > Is there a convention in HTTP user-agent strings to use whitespace to > delimit various bits of information carried in that string?  I asked because > our client strings now look like so in trunk co: > > "SVN/1.7.0-dev (under development)

Re: svn commit: r1100234 - /subversion/trunk/subversion/bindings/javahl/src/org/tigris/subversion/javahl/Status.java

2011-05-06 Thread Hyrum K Wright
On Fri, May 6, 2011 at 9:44 AM, Greg Stein wrote: > On May 6, 2011 10:41 AM, wrote: >> >> Author: hwright >> Date: Fri May  6 14:41:03 2011 >> New Revision: 1100234 >> >> URL: http://svn.apache.org/viewvc?rev=1100234&view=rev >> Log: >> JavaHL: Don't contact the server in the backward compat Stat

Re: svn commit: r1099981 - in /subversion/trunk/subversion/bindings/javahl: native/CreateJ.cpp src/org/apache/subversion/javahl/types/Status.java src/org/tigris/subversion/javahl/SVNClient.java src/or

2011-05-06 Thread Hyrum K Wright
On Fri, May 6, 2011 at 9:23 AM, Mark Phippard wrote: > On Thu, May 5, 2011 at 5:57 PM,   wrote: >> Author: hwright >> Date: Thu May  5 21:57:16 2011 >> New Revision: 1099981 >> >> URL: http://svn.apache.org/viewvc?rev=1099981&view=rev >> Log: >> JavaHL: Move some backward compat code out of C++, a

Re: svn commit: r1099981 - in /subversion/trunk/subversion/bindings/javahl: native/CreateJ.cpp src/org/apache/subversion/javahl/types/Status.java src/org/tigris/subversion/javahl/SVNClient.java src/or

2011-05-05 Thread Hyrum K Wright
On Thursday, May 5, 2011, Greg Stein wrote: > On Thu, May 5, 2011 at 17:57,   wrote: >> Author: hwright >> Date: Thu May  5 21:57:16 2011 >> New Revision: 1099981 >> >> URL: http://svn.apache.org/viewvc?rev=1099981&view=rev >> Log: >> JavaHL: Move some backward compat code out of C++, and into Jav

What's left before branching 1.7.x?

2011-05-05 Thread Hyrum K Wright
In chatting with Philip and Julian today, we got to pondering which bits we have left to complete before we branch 1.7.x, and start cutting pre-releases. The major concerns folks had a couple of months ago have largely been addressed, and it feels like we're in the mop-up stage. We've still got b

Re: 1.6.17 release rolling next week (May 11)

2011-05-05 Thread Hyrum K Wright
On Mon, May 2, 2011 at 3:38 PM, Hyrum K Wright wrote: > Hi all, > > There have a been a couple of user-requested fixes nominated or > backported to 1.6.17, and there are several pending fixes.  So let's > fire up the release machine and target a roll of 1.6.17 for May 11, >

Re: svn commit: r1099657 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c wc_db.h

2011-05-05 Thread Hyrum K Wright
On Thu, May 5, 2011 at 4:07 AM, Markus Schaber wrote: > Hi, > >> Von: Hyrum K Wright [mailto:hy...@hyrumwright.org] > >> Historically, notifications were interleaved with the operations, and >> if a user cancelled during the notification, they cancelled the >> r

Re: svn commit: r1099657 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c wc_db.h

2011-05-04 Thread Hyrum K Wright
On Wed, May 4, 2011 at 8:46 PM, wrote: > Author: gstein > Date: Thu May  5 01:46:31 2011 > New Revision: 1099657 > > URL: http://svn.apache.org/viewvc?rev=1099657&view=rev > Log: > Combine the changelist modification notification into the operation > itself, so that (in the future) we can make gu

Re: svn commit: r1099657 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c wc_db.h

2011-05-04 Thread Hyrum K Wright
On Thu, May 5, 2011 at 12:35 AM, Greg Stein wrote: > On Wed, May 4, 2011 at 22:49, Hyrum K Wright wrote: >> On Wed, May 4, 2011 at 8:46 PM,   wrote: >>> Author: gstein >>> Date: Thu May  5 01:46:31 2011 >>> New Revision: 1099657 >>> >>>

Re: svn commit: r1099657 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c wc_db.h

2011-05-04 Thread Hyrum K Wright
On Wed, May 4, 2011 at 8:46 PM, wrote: > Author: gstein > Date: Thu May  5 01:46:31 2011 > New Revision: 1099657 > > URL: http://svn.apache.org/viewvc?rev=1099657&view=rev > Log: > Combine the changelist modification notification into the operation > itself, so that (in the future) we can make gu

Re: svn commit: r1099436 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c update_editor.c wc_db.c wc_db.h

2011-05-04 Thread Hyrum K Wright
On Wed, May 4, 2011 at 11:31 AM, Greg Stein wrote: > On Wed, May 4, 2011 at 08:55,   wrote: >>... >> +++ subversion/trunk/subversion/libsvn_wc/wc_db.h Wed May  4 12:55:03 2011 >> @@ -1215,7 +1215,10 @@ svn_wc__db_op_delete(svn_wc__db_t *db, >>  /* Make delete notifications for all paths in the del

Re: svn commit: r1098610 - /subversion/trunk/subversion/libsvn_delta/editor.c

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 4:35 PM, Greg Stein wrote: > > On May 2, 2011 4:00 PM, "Hyrum K Wright" wrote: >> >> On Mon, May 2, 2011 at 2:52 PM, Greg Stein wrote: >> > On Mon, May 2, 2011 at 10:55,   wrote: >> >> Author: hwright >> >&g

Re: svn commit: r1099218 - /subversion/trunk/subversion/libsvn_wc/info.c

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 3:25 PM, Greg Stein wrote: > On Tue, May 3, 2011 at 16:03,   wrote: >>... >> +++ subversion/trunk/subversion/libsvn_wc/info.c Tue May  3 20:03:13 2011 >> @@ -172,11 +172,12 @@ build_info_for_entry(svn_info2_t **info, >>   /* A default */ >>   tmpinfo->size = SVN_INVALID_FILE

<    2   3   4   5   6   7   8   9   10   11   >