Re: svn commit: r1069963 - in /subversion/trunk: notes/client-configuration subversion/libsvn_wc/wc_db.c subversion/libsvn_wc/wc_db_pdh.c subversion/libsvn_wc/wc_db_private.h

2011-02-23 Thread Hyrum K Wright
On Wed, Feb 23, 2011 at 1:58 PM, Greg Stein wrote: > On Fri, Feb 11, 2011 at 16:57,   wrote: >>... >> +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Fri Feb 11 21:57:29 2011 >>... >> @@ -7265,17 +7270,22 @@ svn_wc__db_temp_set_access(svn_wc__db_t >>                            svn_wc_adm_access_

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Hyrum K Wright
On Wed, Feb 23, 2011 at 12:26 PM, Stefan Sperling wrote: > On Wed, Feb 23, 2011 at 04:26:52PM +, Julian Foad wrote: >> Hyrum K Wright wrote: >> > On Wed, Feb 23, 2011 at 9:53 AM, Julian Foad >> > wrote: >> > > Stefan Sperling wrote: >&

Re: initial thoughts on issue #3818: fix handling of externals in wc-ng

2011-02-23 Thread Hyrum K Wright
On Wed, Feb 23, 2011 at 9:53 AM, Julian Foad wrote: > (I've appended the issue subject to the subject line.) > > Stefan Sperling wrote: >> I filed a new issue today (issue #3818, "fix handling of externals in >> wc-ng" http://subversion.tigris.org/issues/show_bug.cgi?id=3818). >> >> I had a brief

Re: [Issue 3818] fix handling of externals in wc-ng

2011-02-23 Thread Hyrum K Wright
On Wed, Feb 23, 2011 at 7:10 AM, wrote: > http://subversion.tigris.org/issues/show_bug.cgi?id=3818 > > > > User stsp changed the following: > >                What    |Old value                 |New value > >     Iss

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Hyrum K Wright
On Mon, Feb 21, 2011 at 4:19 AM, Stefan Sperling wrote: > On Mon, Feb 21, 2011 at 12:46:25PM +0530, Noorul Islam K M wrote: >> >> Modify expected error string to use only error codes and also restrict >> one of the lines to less than 80 characters. >> >> Log >> [[[ >> >> * subversion/tests/cmdline

Re: svn commit: r1072431 - /subversion/trunk/subversion/include/private/svn_debug.h

2011-02-21 Thread Hyrum K Wright
Perhaps combine with the comment on line 40 of svn_debug.h? (One or the other feels quite redundant.) It might also be worth noting that lines produced this way won't interfere with test suite expectations. -Hyrum On Sat, Feb 19, 2011 at 2:05 PM, wrote: > Author: danielsh > Date: Sat Feb 19 2

Re: Inconsistent indentation in python code across code base

2011-02-21 Thread Hyrum K Wright
On Mon, Feb 21, 2011 at 9:56 AM, Noorul Islam K M wrote: > > I think we have in consistent python indentation. I can see that we use > 2 space in test/ and 4 in bindings/ctypes-python. Is it not a good idea > to stick to common indentation?  I can fix it.  Fixing ctypes-python > will be easier bec

Re: svn commit: r1072084 - /subversion/trunk/subversion/svn/util.c

2011-02-21 Thread Hyrum K Wright
On Fri, Feb 18, 2011 at 5:53 PM, wrote: > Author: danielsh > Date: Fri Feb 18 17:53:36 2011 > New Revision: 1072084 > > URL: http://svn.apache.org/viewvc?rev=1072084&view=rev > Log: > * subversion/svn/util.c >  (svn_cl__edit_string_externally): >    Preserve the edit log message file if the edito

Re: Unable to compile since r1072302

2011-02-21 Thread Hyrum K Wright
2011/2/20 Branko Čibej : > On 20.02.2011 22:05, Daniel Becroft wrote: >> ... >> /subversion/libsvn_fs_fs/.libs/libsvn_fs_fs-1.so.0: undefined >> reference to `svn_temp_serializer__add_string' >> collect2: ld returned 1 exit status >> >> I've narrowed it down to r1072302, and if I update back to -1,

Re: [PATCH] Fix failing expected error in blame_tests.py

2011-02-17 Thread Hyrum K Wright
On Thu, Feb 17, 2011 at 2:09 PM, Noorul Islam K M wrote: > > Log > [[[ > > Fix failing expected error regex. > > * subversion/tests/cmdline/blame_tests.py >  (blame_non_existent_url_target): Relax regex to allow errors from >   http: and svn: protocols. > > Patch by: Noorul Islam K M > ]]] > > >

Re: request to make svn_wc__prop_list_recursive a public API

2011-02-17 Thread Hyrum K Wright
2011/2/17 Branko Čibej : > On 17.02.2011 12:47, Stefan Küng wrote: >> Hi, >> >> The new function svn_wc__prop_list_recursive() provides a big >> performance gain for listing all properties of a full working copy. >> Currently I have to use svn_client_proplist3() to make use of that. >> >> But I'd l

Re: Updating revision numbers in log messages

2011-02-16 Thread Hyrum K Wright
On Wed, Feb 16, 2011 at 11:25 PM, Peter Samuelson wrote: > > [Hyrum K Wright] >> Through I series of scripts, I've updated the various log messages >> which reference pre-ASF revisions.  I have not yet made the changes to >> the ASF repo, for a couple of reaso

Updating revision numbers in log messages

2011-02-16 Thread Hyrum K Wright
Through I series of scripts, I've updated the various log messages which reference pre-ASF revisions. I have not yet made the changes to the ASF repo, for a couple of reasons: I'm not sure that we have consensus on doing so, and there are a large number of changes to make (~10 000, likely causing

Re: Bindings use is *painful*

2011-02-16 Thread Hyrum K Wright
On Wed, Feb 16, 2011 at 4:01 PM, Ramkumar Ramachandra wrote: > Hi, > > Stefan Sperling writes: >> On Wed, Feb 16, 2011 at 03:08:39PM +, Hyrum K Wright wrote: >> This is because the bindings are generated with SWIG. >> We cannot really fix this without using a d

Bindings use is *painful*

2011-02-16 Thread Hyrum K Wright
I'm writing a script in which I simply want to retrieve a set of arbitrary log message and then do stuff with them. Using the Python bindings seemed like the logical choice (whether is was or not is now debatable, but that isn't the point of this mail). Turns out that using the Python bindings is

Re: Pristine store - spec

2011-02-16 Thread Hyrum K Wright
No comments on the content, but reading the ensuing email thread, it may be useful to put the document in notes/wc-ng/pristines, and add questions / comments / corrections there. It would allow folks down the road to see all the critiques in one location, rather than reading N mails. -Hyrum On

Re: SQLite and callbacks

2011-02-15 Thread Hyrum K Wright
On Tue, Feb 15, 2011 at 2:53 PM, Stefan Sperling wrote: > On Tue, Feb 15, 2011 at 01:30:45PM +0100, Stefan Sperling wrote: >> On Mon, Feb 14, 2011 at 09:48:35PM +0100, Branko Čibej wrote: >> > On 14.02.2011 13:37, Stefan Sperling wrote: >> > > On Tue, Feb 08, 2011 at 11:50:36PM +0100, Branko Čibej

Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-15 Thread Hyrum K Wright
On Tue, Feb 15, 2011 at 10:47 AM, Bert Huijben wrote: > > >> -Original Message----- >> From: Hyrum K Wright [mailto:hy...@hyrumwright.org] >> Sent: dinsdag 15 februari 2011 11:44 >> To: Greg Stein >> Cc: C. Michael Pilato; Ivan Zhakov; dev@subversion.

Re: [Proposal] Remove DAV properties cache in ra_serf

2011-02-15 Thread Hyrum K Wright
On Tue, Feb 15, 2011 at 6:42 AM, Greg Stein wrote: > On Mon, Feb 14, 2011 at 14:14, C. Michael Pilato wrote: >> On 02/14/2011 01:57 PM, Ivan Zhakov wrote: >>> Hi, >>> >>> Currently ra_serf caches *all* DAV properties retrieved using PROPFIND >>> in session pool. This was attempt to reduce number

Re: Patches pending review

2011-02-14 Thread Hyrum K Wright
On Mon, Feb 14, 2011 at 11:33 AM, Noorul Islam K M wrote: > > See below in line more information about the patches. > > Noorul Islam K M writes: ... >> 3. Issue 3690 >> >>    http://svn.haxx.se/dev/archive-2011-01/0414.shtml >> >>    This is actually an enhancement and there were two approaches.

Re: 1.6.16 next week (now 23 Feb)

2011-02-14 Thread Hyrum K Wright
On Wed, Feb 9, 2011 at 10:00 PM, Hyrum K Wright wrote: > Hello folks: I'd like to cut 1.6.16 next Wednesday.  Please nominate / > review / vote / etc in the mean time. Hopefully this isn't dashing too many hopes, but I'm running out of tuits this week, and it appears folks s

Re: [Issue 3808] New - 'svn upgrade' doesn't remove

2011-02-14 Thread Hyrum K Wright
On Mon, Feb 14, 2011 at 10:07 PM, wrote: > http://subversion.tigris.org/issues/show_bug.cgi?id=3808 >                 Issue #|3808 >                 Summary|'svn upgrade' doesn't remove Looks like the summary is lacking a direct object. "doesn't remove" what? -Hyrum

Re: svn commit: r1069588 - in /subversion/trunk: subversion/tests/cmdline/diff_tests.py subversion/tests/cmdline/svntest/err.py subversion/tests/cmdline/svntest/verify.py tools/dev/gen-py-errors.py

2011-02-13 Thread Hyrum K Wright
On Sun, Feb 13, 2011 at 3:49 AM, Daniel Shahaf wrote: > hwri...@apache.org wrote on Thu, Feb 10, 2011 at 22:04:43 -: >> Added: subversion/trunk/tools/dev/gen-py-errors.py >> URL: >> http://svn.apache.org/viewvc/subversion/trunk/tools/dev/gen-py-errors.py?rev=1069588&view=auto >> =

Re: What is a "baton" from subversion sources?

2011-02-11 Thread Hyrum K Wright
2011/2/11 Branko Čibej : > On 11.02.2011 21:37, Daniel Becroft wrote: >> On Sat, Feb 12, 2011 at 6:07 AM, Grigory Petrov wrote: >> >>> Hello. >>> >>> I'm learning subversion API right now and examining it's source code and >>> examples. It's a lot of things in subversion source code that is called

Re: svn commit: r1068411 - /subversion/trunk/subversion/tests/cmdline/authz_tests.py

2011-02-11 Thread Hyrum K Wright
On Fri, Feb 11, 2011 at 5:59 PM, Kamesh Jayachandran wrote: >>kame...@apache.org wrote on Tue, Feb 08, 2011 at 14:25:06 -: >>> +  expected_error_for_cat = "svn: E175013: Unable to connect to a >>> repository"+ \ >>> +    " at URL '" + mu_url + "'\n" + \ >>> +   

Re: svn commit: r1068477 - /subversion/trunk/tools/dev/svnraisetreeconflict/main.c

2011-02-11 Thread Hyrum K Wright
On Fri, Feb 11, 2011 at 3:27 PM, Daniel Shahaf wrote: > hwri...@apache.org wrote on Tue, Feb 08, 2011 at 16:59:54 -: >> Author: hwright >> Date: Tue Feb  8 16:59:54 2011 >> New Revision: 1068477 >> >> URL: http://svn.apache.org/viewvc?rev=1068477&view=rev >> Log: >> * tools/dev/svnraisetreecon

Re: svn commit: r1069602 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-02-11 Thread Hyrum K Wright
On Fri, Feb 11, 2011 at 8:18 AM, Bert Huijben wrote: > > >> -Original Message- >> From: hwri...@apache.org [mailto:hwri...@apache.org] >> Sent: donderdag 10 februari 2011 23:56 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1069602 - >> /subversion/trunk/subversion/libsvn_wc

Re: svn commit: r1068695 - in /subversion/branches/integrate-stream-api-extensions: ./ subversion/include/svn_io.h subversion/libsvn_subr/stream.c subversion/libsvn_subr/subst.c

2011-02-10 Thread Hyrum K Wright
On Thu, Feb 10, 2011 at 1:02 AM, Stefan Fuhrmann wrote: > On 09.02.2011 02:07, Blair Zajac wrote: ... >> We have systems with APR 1.2 and it doesn't provide >> apr_file_buffer_size_get(). > > Is there anything in the 1.3 headers that would indicate > in which version a specific function got introd

Re: Remove svn_wc__db_temp_reset_format()

2011-02-09 Thread Hyrum K Wright
On Wed, Feb 9, 2011 at 10:52 PM, Philip Martin wrote: > Hyrum K Wright writes: > >> The svn_wc__db_temp_reset_format() function is only used in the >> upgrade process, but I'm not really sure its intent.  Does anybody >> familiar with the process know?  (t

Remove svn_wc__db_temp_reset_format()

2011-02-09 Thread Hyrum K Wright
I'm looking at some of the temp functions introduced early in the development of wc-ng. I suspect some of them can be removed, but just want to check and see if I'm missing something. The svn_wc__db_temp_reset_format() function is only used in the upgrade process, but I'm not really sure its inte

1.6.16 next week (16 Feb)

2011-02-09 Thread Hyrum K Wright
Hello folks: I'd like to cut 1.6.16 next Wednesday. Please nominate / review / vote / etc in the mean time. -Hyrum

Re: diff4-optimization-bytes

2011-02-08 Thread Hyrum K Wright
On Tue, Feb 8, 2011 at 9:26 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Fri, Feb 04, 2011 at 13:20:29 +0100: >> On Fri, Feb 4, 2011 at 7:56 AM, Daniel Shahaf >> wrote: >> > Could you have a look? (attached) >> >> Nice. It looks good to me (haven't tested it, just looked at the code; >> I

Re: svn commit: r1068750 - /subversion/trunk/configure.ac

2011-02-08 Thread Hyrum K Wright
Did you mean to commit a deletion of the back (I'm guessing 50) lines of the file? -Hyrum On Tue, Feb 8, 2011 at 9:41 PM, wrote: > Author: danielsh > Date: Wed Feb  9 03:41:58 2011 > New Revision: 1068750 > > URL: http://svn.apache.org/viewvc?rev=1068750&view=rev > Log: > * configure.ac: >   Ma

Re: svn commit: r1068585 - in /subversion/trunk/subversion/libsvn_ra_serf: auth.c commit.c serf.c util.c

2011-02-08 Thread Hyrum K Wright
On Tue, Feb 8, 2011 at 9:33 PM, Mark Phippard wrote: > On Tue, Feb 8, 2011 at 4:25 PM,   wrote: >> Author: hwright >> Date: Tue Feb  8 21:25:12 2011 >> New Revision: 1068585 >> Modified: subversion/trunk/subversion/libsvn_ra_serf/commit.c >> URL: >> http://svn.apache.org/viewvc/subversion/trunk/s

Re: Minimal Serf version in 1.7.0

2011-02-08 Thread Hyrum K Wright
On Tue, Feb 8, 2011 at 8:40 PM, C. Michael Pilato wrote: > On 02/08/2011 03:24 PM, Paul Burba wrote: >> On Tue, Feb 8, 2011 at 2:46 PM, Hyrum K Wright wrote: >>> I noticed the current minimal required serf version on trunk is 0.3.1. >>>  I've only been paying tan

Re: SQLite and callbacks

2011-02-08 Thread Hyrum K Wright
On Tue, Feb 8, 2011 at 7:59 PM, Stefan Sperling wrote: > On Tue, Feb 08, 2011 at 07:40:03PM +0000, Hyrum K Wright wrote: >> One of my greater concerns is that we don't have a concrete answer to >> "we'll release when " for the performance question.  What i

Minimal Serf version in 1.7.0

2011-02-08 Thread Hyrum K Wright
I noticed the current minimal required serf version on trunk is 0.3.1. I've only been paying tangential attention, but I seem to recall that there have a been a number of improvements in recent versions of Serf which affect memory and other stability issues. Should we bump the required version (o

Re: SQLite and callbacks

2011-02-08 Thread Hyrum K Wright
On Tue, Feb 8, 2011 at 7:27 PM, Stefan Sperling wrote: > On Tue, Feb 08, 2011 at 05:13:50PM +0000, Hyrum K Wright wrote: >> On Tue, Feb 8, 2011 at 4:15 PM, Stefan Sperling wrote: >> > On Tue, Feb 08, 2011 at 04:34:52PM +0100, Bert Huijben wrote: >> >> There is nob

Re: SQLite and callbacks

2011-02-08 Thread Hyrum K Wright
On Tue, Feb 8, 2011 at 4:15 PM, Stefan Sperling wrote: > On Tue, Feb 08, 2011 at 04:34:52PM +0100, Bert Huijben wrote: >> There is nobody actively working on status and there are no open >> issues on status to block branching... > > There's the general wc-ng performance issue (but I don't think it

Re: svn commit: r1068169 - /subversion/trunk/tools/server-side/svn-populate-node-origins-index.c

2011-02-08 Thread Hyrum K Wright
On Tue, Feb 8, 2011 at 3:03 AM, Daniel Shahaf wrote: > hwri...@apache.org wrote on Mon, Feb 07, 2011 at 22:09:15 -: >> Author: hwright >> Date: Mon Feb  7 22:09:15 2011 >> New Revision: 1068169 >> >> URL: http://svn.apache.org/viewvc?rev=1068169&view=rev >> Log: >> * tools/server-side/svn-popu

Re: Proposal: Use decorators in test suite for XFail, Skip, etc

2011-02-07 Thread Hyrum K Wright
On Sat, Feb 5, 2011 at 3:22 AM, Benjamin Peterson wrote: > Hyrum K Wright hyrumwright.org> writes: >> >> [[[ >> >> Index: subversion/tests/cmdline/svntest/testcase.py >> === >> --- su

Re: [PATCH] Re: Regarding issue 3690 - Work in progress

2011-02-07 Thread Hyrum K Wright
On Tue, Feb 8, 2011 at 1:41 AM, Daniel Shahaf wrote: > Hyrum K Wright wrote on Mon, Feb 07, 2011 at 23:14:10 +: >> On Fri, Feb 4, 2011 at 4:36 PM, Noorul Islam K M wrote: >> > hwright noorul: ignored_props_mod takes a list of properties, yes (as >> >        oppos

Re: [PATCH] Re: Regarding issue 3690 - Work in progress

2011-02-07 Thread Hyrum K Wright
On Fri, Feb 4, 2011 at 4:36 PM, Noorul Islam K M wrote: > "noorul Islam. Kamal Malmiyoda" writes: > >> On Feb 3, 2011, at 5:39 AM, "Hyrum K Wright" wrote: >> >>> On Wed, Feb 2, 2011 at 6:29 AM, Noorul Islam K M wrote: >>>> >>

Re: svn commit: r1067380 [1/3] - in /subversion/trunk/subversion/tests/cmdline: ./ svntest/

2011-02-07 Thread Hyrum K Wright
On Mon, Feb 7, 2011 at 1:49 PM, Philip Martin wrote: > Philip Martin writes: > >> hwri...@apache.org writes: >> >>> Author: hwright >>> Date: Sat Feb  5 02:17:32 2011 >>> New Revision: 1067380 >>> >>> URL: http://svn.apache.org/viewvc?rev=1067380&view=rev >>> Log: >>> Use Python decorators to den

Re: Buildbots failing after reintegration of diff-optimizations-bytes

2011-02-07 Thread Hyrum K Wright
On Mon, Feb 7, 2011 at 3:07 PM, Hyrum K Wright wrote: > On Mon, Feb 7, 2011 at 12:10 PM, Philip Martin > wrote: >> Johan Corveleyn writes: >> >>> Apparently I broke the builds on the builtbots yesterday evening, >>> after integrating the diff-optimi

Re: Buildbots failing after reintegration of diff-optimizations-bytes

2011-02-07 Thread Hyrum K Wright
On Mon, Feb 7, 2011 at 12:10 PM, Philip Martin wrote: > Johan Corveleyn writes: > >> Apparently I broke the builds on the builtbots yesterday evening, >> after integrating the diff-optimizations-bytes branch. Sorry for that. >> >> There were two problems: >> - Failing diff-diff3-test.exe (actuall

Re: Proposal: Use decorators in test suite for XFail, Skip, etc

2011-02-07 Thread Hyrum K Wright
On Mon, Feb 7, 2011 at 6:48 AM, Arwin Arni wrote: > On Saturday 05 February 2011 01:46 AM, Hyrum K Wright wrote: >> >> On Fri, Feb 4, 2011 at 7:54 PM, C. Michael Pilato >>  wrote: >>> >>> On 02/04/2011 02:09 PM, Greg Stein wrote: >>>> >>&g

Re: Proposal: Use decorators in test suite for XFail, Skip, etc

2011-02-04 Thread Hyrum K Wright
On Fri, Feb 4, 2011 at 7:54 PM, C. Michael Pilato wrote: > On 02/04/2011 02:09 PM, Greg Stein wrote: >> On Fri, Feb 4, 2011 at 12:15, Hyrum K Wright wrote: >>> ... >>> We currently mark tests XFail (or Skip, or something else) by wrapping >>> them in the test_

Re: Proposal: Use decorators in test suite for XFail, Skip, etc

2011-02-04 Thread Hyrum K Wright
On Fri, Feb 4, 2011 at 7:20 PM, Paul Burba wrote: > On Fri, Feb 4, 2011 at 2:11 PM, Hyrum K Wright wrote: >> On Fri, Feb 4, 2011 at 7:03 PM, Blair Zajac wrote: >>> >>> On Feb 4, 2011, at 9:15 AM, Hyrum K Wright wrote: >>> >>>> We currently

Re: Proposal: Use decorators in test suite for XFail, Skip, etc

2011-02-04 Thread Hyrum K Wright
On Fri, Feb 4, 2011 at 7:03 PM, Blair Zajac wrote: > > On Feb 4, 2011, at 9:15 AM, Hyrum K Wright wrote: > >> We currently mark tests XFail (or Skip, or something else) by wrapping >> them in the test_list in the test suite.  Rather than doing it there, >> I think

Proposal: Use decorators in test suite for XFail, Skip, etc

2011-02-04 Thread Hyrum K Wright
We currently mark tests XFail (or Skip, or something else) by wrapping them in the test_list in the test suite. Rather than doing it there, I think it makes more sense to use Python's decorator syntax to mark tests as XFail right at their definition, rather than down in the test list. Keeping all

Re: svn commit: r1067195 - in /subversion/trunk/subversion: include/svn_checksum.h libsvn_client/export.c libsvn_subr/checksum.c

2011-02-04 Thread Hyrum K Wright
Reviewing my own commits... On Fri, Feb 4, 2011 at 9:20 AM, wrote: > Author: hwright > Date: Fri Feb  4 15:20:50 2011 > New Revision: 1067195 > > URL: http://svn.apache.org/viewvc?rev=1067195&view=rev > Log: > Allow callers of svn_checksum_mismatch_err() to specify the first bit of their > error

Re: svn commit: r1067014 - /subversion/trunk/CHANGES

2011-02-03 Thread Hyrum K Wright
FYI: I plan on going through the rest of the 1.7.0 issues tomorrow, and adding their content to CHANGES. A number of these are bugs that we fixed by wc-ng, but since they've been long-standing bugs, and not issues which were reported *because* of wc-ng, I decided to go ahead and include them, on t

Re: [PATCH] Re: Regarding issue 3690 - Work in progress

2011-02-02 Thread Hyrum K Wright
On Wed, Feb 2, 2011 at 6:29 AM, Noorul Islam K M wrote: > > Is ignored_prop_mods list functionality completely implemented? Not yet. I've got all the boiler-plate done, but have not yet added the extra filtering in libsvn_repos. Because 'log' is a small part of the overall feature set, and I'm

Re: Roadmap : 1.7 Release Status : Test Review : XFails

2011-02-02 Thread Hyrum K Wright
On Wed, Feb 2, 2011 at 5:54 PM, Daniel Shahaf wrote: > Mark Phippard wrote on Wed, Feb 02, 2011 at 07:47:14 -0500: >> The take-away for me is that if we adopted a convention (or did >> something in the test code) to make sure that all XFails were >> associated with an issue then it would collectiv

Issue tracker 1.7.0 milestone

2011-02-02 Thread Hyrum K Wright
Anybody following issues@ would have seen a lot of traffic from me today. I've been updating milestones to make it easier to document which issues were fixed in 1.7.0. The basic workflow was: * Get list of all issue closed since 1.6.x branch * Remove issue listed as fixed in various versions of

Re: svn commit: r1066203 - /subversion/trunk/subversion/libsvn_repos/commit.c

2011-02-01 Thread Hyrum K Wright
It looks like this triggers another abort: (gdb) r 8 --allow-segfaults Starting program: /Users/Hyrum/dev/svn-trunk3/subversion/tests/libsvn_repos/repos-test 8 --allow-segfaults Reading symbols for shared libraries ... done Assertion failed: (svn_relpath_is_canonica

Re: svn commit: r1064905 - in /subversion/branches/ignore-mergeinfo-log/subversion: libsvn_ra_svn/client.c svnserve/serve.c

2011-02-01 Thread Hyrum K Wright
Done in r1066137. -Hyrum On Fri, Jan 28, 2011 at 8:17 PM, Daniel Shahaf wrote: > What about libsvn_ra_svn/protocol ? > > hwri...@apache.org wrote on Fri, Jan 28, 2011 at 21:59:14 -: >> Author: hwright >> Date: Fri Jan 28 21:59:14 2011 >> New Revision: 1064905 >> >> URL: http://svn.apache.org

Re: Deltifying directories on the server

2011-02-01 Thread Hyrum K Wright
On Tue, Feb 1, 2011 at 10:54 AM, Greg Hudson wrote: > On Tue, 2011-02-01 at 10:29 -0500, C. Michael Pilato wrote: >> I can only really speak for the BDB side of things, but... "what he said". > > I'll elaborate a little bit.  API issues aside, we're used to putting > artifacts from different versi

Re: [PATCH] Re: Regarding issue 3690 - Work in progress

2011-01-31 Thread Hyrum K Wright
On Mon, Jan 31, 2011 at 10:52 PM, Noorul Islam K M wrote: > Hyrum K Wright writes: > >> On Mon, Jan 31, 2011 at 10:53 AM, Noorul Islam K M wrote: >> >>> Daniel Becroft writes: >>> >>>> On 27/01/2011, at 17:04, Noorul Islam K M wrote: >>&

Deltifying directories on the server

2011-01-31 Thread Hyrum K Wright
Philip and I had an interesting conversation with some users this evening, and I'm just archiving my brain dump here. These users have a large repository with a large number of branches in the /branches directory (~35k). We described the well-known phenomenon in which directories aren't deltified

Re: [PATCH] Re: Regarding issue 3690 - Work in progress

2011-01-31 Thread Hyrum K Wright
On Mon, Jan 31, 2011 at 10:53 AM, Noorul Islam K M wrote: > Daniel Becroft writes: > >> On 27/01/2011, at 17:04, Noorul Islam K M wrote: >> >>> Hi, >>> >>> I am planning to work on issue 3690. Before starting with this I have >>> few questions. >>> >>> 1. Hyrum updated the issue with his comment

Re: svn commit: r1064847 - /subversion/trunk/subversion/svnserve/serve.c

2011-01-31 Thread Hyrum K Wright
On Sat, Jan 29, 2011 at 3:02 PM, Branko Čibej wrote: > On 29.01.2011 21:36, Daniel Shahaf wrote: >> Hyrum K Wright wrote on Sat, Jan 29, 2011 at 12:03:18 -0600: >>> The protocol document is in error: 'revprops' must always be followed >>> by a list, even i

Re: svn commit: r1064847 - /subversion/trunk/subversion/svnserve/serve.c

2011-01-29 Thread Hyrum K Wright
On Fri, Jan 28, 2011 at 9:23 PM, Daniel Shahaf wrote: > hwri...@apache.org wrote on Fri, Jan 28, 2011 at 20:01:35 -: >> Author: hwright >> Date: Fri Jan 28 20:01:35 2011 >> New Revision: 1064847 >> >> URL: http://svn.apache.org/viewvc?rev=1064847&view=rev >> Log: >> * subversion/svnserve/serve

Re: svn commit: r1064847 - /subversion/trunk/subversion/svnserve/serve.c

2011-01-29 Thread Hyrum K Wright
On Sat, Jan 29, 2011 at 8:20 AM, Bert Huijben wrote: > > >> -Original Message- >> From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] >> Sent: zaterdag 29 januari 2011 4:24 >> To: dev@subversion.apache.org >> Cc: comm...@subversion.apache.org >> Subject: Re: svn commit: r1064847 - >> /sub

Re: svn commit: r1064847 - /subversion/trunk/subversion/svnserve/serve.c

2011-01-29 Thread Hyrum K Wright
On Fri, Jan 28, 2011 at 9:23 PM, Daniel Shahaf wrote: > hwri...@apache.org wrote on Fri, Jan 28, 2011 at 20:01:35 -: >> Author: hwright >> Date: Fri Jan 28 20:01:35 2011 >> New Revision: 1064847 >> >> URL: http://svn.apache.org/viewvc?rev=1064847&view=rev >> Log: >> * subversion/svnserve/serve

Re: svn commit: r1064261 - /subversion/trunk/COMMITTERS

2011-01-28 Thread Hyrum K Wright
On Fri, Jan 28, 2011 at 5:04 AM, Julian Foad wrote: > Daniel Shahaf wrote: >> I'd rather not remove their entries entirely from COMMITTERS. > > +1.  Being unable to contact them (currently) is a completely different > thing from deciding to remove them from the list of committers.  And > failure t

Re: Status of the branch diff-optimizations-bytes branch

2011-01-28 Thread Hyrum K Wright
On Fri, Jan 28, 2011 at 6:49 AM, Johan Corveleyn wrote: > On Fri, Jan 28, 2011 at 5:51 AM, Hyrum K Wright wrote: >> On Tue, Jan 25, 2011 at 8:31 PM, Johan Corveleyn wrote: >>> On Tue, Jan 25, 2011 at 4:58 PM, Hyrum K Wright >>> wrote: >>>> Johan (and ot

Re: Status of the branch diff-optimizations-bytes branch

2011-01-27 Thread Hyrum K Wright
On Tue, Jan 25, 2011 at 8:31 PM, Johan Corveleyn wrote: > On Tue, Jan 25, 2011 at 4:58 PM, Hyrum K Wright wrote: >> Johan (and other interested parties), >> I've been following some of the commits to the >> diff-optimizations-branch with interest.  While I've not

Re: Status of the branch diff-optimizations-bytes branch

2011-01-27 Thread Hyrum K Wright
On Thu, Jan 27, 2011 at 3:13 PM, Hyrum K Wright wrote: > On Thu, Jan 27, 2011 at 3:08 PM, Johan Corveleyn wrote: >> On Thu, Jan 27, 2011 at 4:52 PM, Hyrum K Wright >> wrote: >>> Johan, >>> I'd appreciate review on the attached patch.  It is an attempt to

Re: Merging /branches/integrate-cache-membuffer to /trunk

2011-01-27 Thread Hyrum K Wright
On Wed, Jan 26, 2011 at 4:42 PM, Stefan Sperling wrote: > On Wed, Jan 26, 2011 at 11:25:59PM +0100, Stefan Fuhrmann wrote: >> Hi @all, >> >> I'm planning to merge said branch Monday 7th. >> Speak now or forever hold your peace. >> >> Rationale: >> >> I've been testing / using that code for a while

Re: svn commit: r1064261 - /subversion/trunk/COMMITTERS

2011-01-27 Thread Hyrum K Wright
Question: if emails are bouncing, that almost certainly means these folks have not filed CLAs, and in which case, they don't have commit access anymore. Should we just remove them from COMMITTERS? -Hyrum On Thu, Jan 27, 2011 at 1:27 PM, wrote: > Author: stsp > Date: Thu Jan 27 19:27:55 2011 >

Re: Status of the branch diff-optimizations-bytes branch

2011-01-27 Thread Hyrum K Wright
On Thu, Jan 27, 2011 at 3:08 PM, Johan Corveleyn wrote: > On Thu, Jan 27, 2011 at 4:52 PM, Hyrum K Wright wrote: >> Johan, >> I'd appreciate review on the attached patch.  It is an attempt to rev >> the svn_diff_fns_t struct and related functions.  You'll notice

Re: Status of the branch diff-optimizations-bytes branch

2011-01-27 Thread Hyrum K Wright
On Wed, Jan 26, 2011 at 7:15 PM, Johan Corveleyn wrote: > On Wed, Jan 26, 2011 at 10:50 PM, Hyrum K Wright > wrote: >> On Tue, Jan 25, 2011 at 8:31 PM, Johan Corveleyn wrote: >> ... >>>>  * revv svn_diff.h#svn_diff_fns_t             [] >>>>

Re: Status of the branch diff-optimizations-bytes branch

2011-01-26 Thread Hyrum K Wright
On Tue, Jan 25, 2011 at 8:31 PM, Johan Corveleyn wrote: ... >>  * revv svn_diff.h#svn_diff_fns_t             [] >> >> It looks like, for the most part, any destabilizing functionality is >> completed, and what remains are simply optimizations.  This >> optimization work can probably be performed o

Re: Status of the branch diff-optimizations-bytes branch

2011-01-26 Thread Hyrum K Wright
On Tue, Jan 25, 2011 at 11:41 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Wed, Jan 26, 2011 at 03:31:11 +0100: >> Revving svn_diff_fns_t: what do you mean with parallelizing it? I must >> admit that I don't really know (yet) how to go about that. Very early >> during the branch work, danie

Re: log -g regression in r1028108

2011-01-25 Thread Hyrum K Wright
On Tue, Jan 25, 2011 at 1:14 PM, Stefan Sperling wrote: > On Tue, Jan 25, 2011 at 10:34:43AM -0600, Kevin Radke wrote: >> (I'm moving this conversation from users to dev, since I have >> convinced myself a regression was introduced in r1028108) >> See: http://svn.haxx.se/users/archive-2010-12/0265

Status of the branch diff-optimizations-bytes branch

2011-01-25 Thread Hyrum K Wright
Johan (and other interested parties), I've been following some of the commits to the diff-optimizations-branch with interest.  While I've not reviewed them for technical merit, it appears that others have, and that there is good work going on in the branch.  I'm wondering what the potential for mer

Re: Document return codes of 'svn ls'

2011-01-20 Thread Hyrum K Wright
On Thu, Jan 20, 2011 at 3:41 AM, Arwin Arni wrote: > On Saturday 15 January 2011 12:24 AM, anatoly techtonik wrote: > >> Hello, >> >> How can I know if a file is not present in specific revision? >> >> From one side I can run 'svn ls' and if it returns 0 when file exists, >> but if 'svn ls' retu

Some performance data

2011-01-17 Thread Hyrum K Wright
I've been looking at which bugs can be closed by the pending completion of wc-ng. In particular, I've been looking at issue #1284: http://subversion.tigris.org/issues/show_bug.cgi?id=1284 The issue is essentially a complaint about the performance of 'svn mv somedir targetdir' when the number of f

Re: headers in the body Re: [l10n] Translation status report for trunk r1057984

2011-01-12 Thread Hyrum K Wright
On Wed, Jan 12, 2011 at 12:01 PM, Branko Čibej wrote: > On 12.01.2011 18:43, Branko Čibej wrote: >> On 12.01.2011 16:47, Hyrum K Wright wrote: >>> On Wed, Jan 12, 2011 at 8:14 AM, Branko Čibej wrote: >>>> On 12.01.2011 15:01, Daniel Shahaf wrote: >>>>>

Re: headers in the body Re: [l10n] Translation status report for trunk r1057984

2011-01-12 Thread Hyrum K Wright
On Wed, Jan 12, 2011 at 8:14 AM, Branko Čibej wrote: > On 12.01.2011 15:01, Daniel Shahaf wrote: >> SVN DEV wrote on Wed, Jan 12, 2011 at 04:21:52 +: >>> X-Mailer: l10n-report.py r1055713 >>> Reply-To: dev@subversion.apache.org >>> Mail-Followup-To: dev@subversion.apache.org >>> Auto-Submitted

Re: [l10n] Translation status report for trunk r1055292

2011-01-12 Thread Hyrum K Wright
On Wed, Jan 12, 2011 at 7:50 AM, Ramkumar Ramachandra wrote: > Hi, > > Hyrum K Wright writes: >> I'm working on getting a web-based translation system installed on ASF >> hardware for use by Subversion, and possibly other projects, and will >> report progress

Re: svn commit: r1057908 - /subversion/trunk/subversion/libsvn_client/patch.c

2011-01-11 Thread Hyrum K Wright
On Tue, Jan 11, 2011 at 4:56 PM, wrote: > Author: stsp > Date: Tue Jan 11 22:56:34 2011 > New Revision: 1057908 > > URL: http://svn.apache.org/viewvc?rev=1057908&view=rev > Log: > Significantly reduce the time spent by "svn patch" to figure out whether > there are empty directories to be deleted

Re: [l10n] Translation status report for trunk r1055292

2011-01-11 Thread Hyrum K Wright
On Wed, Jan 5, 2011 at 7:53 AM, Daniel Shahaf wrote: > By the way, as I said on wayita: +1 to Hyrum for heading the translation > efforts; I am annoyed at having to receive mails which *for me* are > information-free (because I follow the commits@ list), not at the larger > picture of someone fina

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Hyrum K Wright
On Tue, Jan 11, 2011 at 8:07 AM, C. Michael Pilato wrote: > On 01/11/2011 09:01 AM, Mark Phippard wrote: >> On Tue, Jan 11, 2011 at 8:43 AM, C. Michael Pilato >> wrote: >>> On 01/11/2011 08:20 AM, Julian Foad wrote: I'm not 100% sure whether close_wcroot() is the best place to delete u

Re: [RFC] Require SQLite >= 3.6.18

2011-01-11 Thread Hyrum K Wright
On Tue, Jan 11, 2011 at 6:01 AM, Julian Foad wrote: > Any objection to requiring SQLite >= 3.6.18 as in the attached patch? Patch looks good. > WHY? > > In order to use SQLite triggers to automatically update the pristine > text reference counts (see the thread "Ref-counting for pristine texts":

Re: [oss-security] CVE request for subversion

2011-01-08 Thread Hyrum K Wright
On Wed, Jan 5, 2011 at 10:09 AM, Josh Bressers wrote: > > OK, let's split the CVE id then. > > So for > A, "* prevent crash in mod_dav_svn when using SVNParentPath (r1033166)" >  Upstream changeset: >  http://svn.apache.org/viewvc?view=revision&revision=1033166 > > Let's use CVE-2010-4539. > > For

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-08 Thread Hyrum K Wright
On Fri, Jan 7, 2011 at 10:06 AM, Julian Foad wrote: > On Fri, 2011-01-07 at 15:19 +, Philip Martin wrote: >> Julian Foad writes: >> >> > The only case that SQLite doesn't handle automatically is the >> > replacement part of "INSERT OR REPLACE INTO ...": it doesn't fire the >> > "delete" trigg

Re: Force Subversion to grab information from Mac OS X keychain

2011-01-08 Thread Hyrum K Wright
Your question is about the usage of Subversion, not it's development. Hence, us...@subversion.apache.org is the appropriate forum for your post. Best, -Hyrum On Fri, Jan 7, 2011 at 2:43 PM, Kevin Lindeman wrote: > Hi, > > I am running Subversion on Mac OS X. I noticed that once I login correctly

Re: svn commit: r1054250 - /subversion/trunk/subversion/libsvn_subr/eol.c

2011-01-01 Thread Hyrum K Wright
On Sat, Jan 1, 2011 at 11:18 AM, wrote: > Author: stefan2 > Date: Sat Jan  1 16:18:55 2011 > New Revision: 1054250 > > URL: http://svn.apache.org/viewvc?rev=1054250&view=rev > Log: > About 3x speed up of svn_eol__find_eol_start() on 64 bit machines > (20 .. 40% on 32 bits). This function is a sig

Re: svn commit: r1054229 - /subversion/trunk/subversion/libsvn_subr/opt.c

2011-01-01 Thread Hyrum K Wright
On Sat, Jan 1, 2011 at 10:51 AM, Kamesh Jayachandran wrote: >>-  SVN_ERR(svn_cmdline_fputs(_("Copyright (C) 2010 The Apache Software >>Foundation.\n" >>+  SVN_ERR(svn_cmdline_fputs(_("Copyright (C) 2011 The Apache Software >>Foundation.\n" > > Won't this be 2010-2011? Nope. -Hyrum

Re: [Issue 3770] New - JavaHL method to set binary property is broken

2010-12-30 Thread Hyrum K Wright
On Thu, Dec 30, 2010 at 2:57 PM, Mark Phippard wrote: > On Thu, Dec 30, 2010 at 2:17 PM, Hyrum K Wright wrote: > >> Mark, >> Daniel pointed out on IRC that all the revpropTable arguments in the >> JavaHL API are Map.  Should they be adjusted to >> Map ? >

Re: [Issue 3770] New - JavaHL method to set binary property is broken

2010-12-30 Thread Hyrum K Wright
On Wed, Dec 29, 2010 at 4:43 PM, wrote: > http://subversion.tigris.org/issues/show_bug.cgi?id=3770 >                 Issue #|3770 >                 Summary|JavaHL method to set binary property is broken >               Component|subversion >                 Version|1.6.x >                Platform

Re: [l10n] Translation status report for trunk r1053795

2010-12-30 Thread Hyrum K Wright
For the interested, this is the output of tools/po/l10n-report.py. I've set it up as a weekly cron job, emailing the results to d...@. -Hyrum On Wed, Dec 29, 2010 at 11:20 PM, SVN DEV wrote: > Translation status report for tr...@r1053795 > >  lang   trans untrans   fuzzy     obs > --

Re: svn commit: r1053645 - /subversion/trunk/tools/po/l10n-report.py

2010-12-29 Thread Hyrum K Wright
On Wed, Dec 29, 2010 at 3:02 PM, Peter Samuelson wrote: > > [hwri...@apache.org] >> * tools/po/l10n-report.py >>   (main): Use the smtp library for sending mail, rather than shelling out >>     to 'sendmail'. > > I know this is a specialty script only run by certain people, but on > the whole, I t

Re: svn commit: r1053461 - /subversion/site/publish/doap.rdf

2010-12-28 Thread Hyrum K Wright
On Tue, Dec 28, 2010 at 5:36 PM, Mark Phippard wrote: > On Tue, Dec 28, 2010 at 5:00 PM,   wrote: >> Author: hwright >> Date: Tue Dec 28 22:00:37 2010 >> New Revision: 1053461 >> >> URL: http://svn.apache.org/viewvc?rev=1053461&view=rev >> Log: >> First hack at a DOAP file for Subversion, as reque

Re: Safe to add a field to svn_error_t?

2010-12-24 Thread Hyrum K Wright
On Fri, Dec 24, 2010 at 12:10 AM, Blair Zajac wrote: > The addition of "tracing" to svn_error_t in 1.7 currently uses a special > message string "traced call".  Instead of doing this, can we safely add an > svn_boolean_t to svn_error_t the indicates if it is a traced error? > > While svn_error_t i

Re: [PATCH] Fix a bug in dirent_uri.c:svn_uri_condense_targets()

2010-12-24 Thread Hyrum K Wright
On Fri, Dec 24, 2010 at 4:33 AM, vijay wrote: > Hi, > > This patch fixes the bug reported in > http://svn.haxx.se/dev/archive-2010-12/0592.shtml   . We need to copy the > value of PCOMMON from SCRATCH_POOL to RESULT_POOL since we are exiting early > when there is only one target uri to work on. >

Re: How to delete particular revision of file from SVN Repos

2010-12-23 Thread Hyrum K Wright
On Thu, Dec 23, 2010 at 2:33 AM, stsivaraj wrote: > > Hi All, >         I am using Subversion version1.2 and need one favour. I have > written code to delete particular revision from SVN Repository. > Unfortunately, i couldn't delete particular version from repository. Any one > can response me..

<    4   5   6   7   8   9   10   11   12   13   >