This is a bug. This allows editing of log message as long as user has some
write access somewhere in the repository not necessarily on the change paths.
With regards
Kamesh Jayachandran
-Original Message-
From: C. Michael Pilato [mailto:cmpil...@collab.net]
Sent: Thu 7/19/2012 6:21 PM
Only if your pre-revprop-change hook allows it.
pre-revprop-change is not the place to do path based authz and default hook
script allows editing log message.
With regards
Kamesh Jayachandran
small typo.
-he or see
+he or she
With regards
Kamesh jayachandrancmpil...@apache.org wrote:Author: cmpilato
Date: Thu Jul 19 13:54:38 2012
New Revision: 1363336
URL: http://svn.apache.org/viewvc?rev=1363336view=rev
Log:
* notes/authz_policy.txt
(REVISION PROPERTIES): It's been years, but
in such a way that it appears in some
logical order.
For example I started my review from 'main()' which is in the middle of the
file and I move above and below that function to review further.
With regards
Kamesh Jayachandran
-Original Message-
From: Prabhu Gnana Sundar [mailto:prabh
Thanks Prabhu. Committed this patch in r1165631.
With regards
Kamesh Jayachandran
-Original Message-
From: Prabhu Gnana Sundar Ponnarasu
Sent: Tue 9/6/2011 12:33 PM
To: Kamesh Jayachandran
Cc: Vijayaguru Guruchave; dev@subversion.apache.org
Subject: Re: [PATCH] get-location-segments.py
When I press 'p' it should preserve and prompt again. It actually preserves
this acceptance inside ~/.subversion but somehow it keeps throwing this warning
screen.
With regards
Kamesh Jayachandran
-Original Message-
From: Prabhu Gnana Sundar [mailto:prabh...@collab.net]
Sent: Fri 9/2
as per the outcome of location segments report.
With regards
Kamesh Jayachandran
-Original Message-
From: Paul Burba [mailto:ptbu...@gmail.com]
Sent: Thu 7/14/2011 9:18 PM
To: Prabhu Gnana Sundar Ponnarasu
Cc: dev@subversion.apache.org
Subject: Re: (Possible) bug in the way we track
-option));
This PATCH ignores --config-option.
Bert via r1080198 you seemed to have introduced --config-option to svnadmin.
I am not aware of a case where --config-option would be needed for svnadmin.
Can you clarify?
With regards
Kamesh Jayachandran
SVN_ERR(svn_repos_create(repos, opt_state
Thanks Prabhu,
I committed your two patches together as they are related at r1126459.
With regards
Kamesh Jayachandran
.
With regards
Kamesh Jayachandran
it and
let you know what is wrong?
With regards
Kamesh Jayachandran
Any insight is appreciated.
Paul
On the server(proxy) it is an assertion error on the following code
block from subversion/mod_dav_svn/mirror.c:proxy_request_fixup
assert((uri_segment[0] == '\0')
|| (uri_segment[0
meant?
Sorry, I was wrong, I meant your patch against 1.6.x branch as one of my
colleague has win32 svn build setup for 1.6.x I can build the binaries
to see if it is peculiar to win32.
With regards
Kamesh Jayachandran
Paul
-test-work/slave
svn: OPTIONS of 'http://127.0.0.1/svn-test-work/slave': 200 OK
(http://127.0.0.1)
/snip
With regards
Kamesh Jayachandran
.
Prabhu posted similar patch 4 months back
http://svn.haxx.se/dev/archive-2011-01/0157.shtml
My +1 for this change.
With regards
Kamesh Jayachandran
Committed it in 1102690.
-Original Message-
From: Kamesh Jayachandran [mailto:kam...@collab.net]
Sent: Thu 5/12/2011 10:38 PM
To: dev@subversion.apache.org
Subject: [PATCH] Fix for issue3870 - File descriptor leaks during svnsync
Hi All,
Attached patch fixes the File descriptor leaks
editor drive, so no issue.
With regards
Kamesh Jayachandran
destroyed. You need instead for file baton's to have lifetimes that's
about as long as the whole editor drive.
Thanks Mike for explaining this. Then such a long living pool would cause
similar leak!!!
With regards
Kamesh Jayachandran
Thanks, Committed this patch in r1095662.
With regards
Kamesh Jayachandran
On 04/18/2011 04:05 PM, Arwin Arni wrote:
Hi All,
This patch adds a test case to
subversion/tests/cmdline/dav-mirror-autocheck.sh to showcase the
following bug.
In a master/slave repositories setup where writes
With regards
Kamesh Jayachandran
Thanks Vijay for the detailed summary and the fix.
I committed it at r1088602.
With regards
Kamesh Jayachandran
On 04/04/2011 12:00 PM, vijay wrote:
On Thursday 24 March 2011 07:41 PM, Kamesh Jayachandran wrote:
On 03/24/2011 05:54 PM, vijay wrote:
Just now I came to know that it fails
that exhibits the same failure for both neon
and serf.
Meanwhile analysing why it succeeds in serf would teach something
interesting.
With regards
Kamesh Jayachandran
Thanks Regards,
vijayaguru
On Thursday 24 March 2011 05:12 PM, Kamesh Jayachandran wrote:
Thanks for the Patch Vijay.
In my FC14
dry_run_merge_conflicting_binary(sbox):
+ dry run shouldn't make conflict resoln files
^
typo?
Thanks Stefan. Fixed in r1081703.
With regards
Kamesh Jayachandran
. Committed your patch in r1081390.
With regards
Kamesh Jayachandran
Kamesh Jayachandran wrote on Fri, Mar 11, 2011 at 18:12:21 +0530:
Unless there are no objection I will commit this patch post I
receive a r1075802 regression fix(and testcase) from either Daniel
Becroft or Arwin.
Hold on, are you suggesting to commit the two thousand, six hundred and
sixty
a
r1075802 regression fix(and testcase) from either Daniel Becroft or Arwin.
With regards
Kamesh Jayachandran
On 03/02/2011 09:00 PM, Arwin Arni wrote:
Hi All,
Thanks for all the feedback.
As Stefan said, yes, this patch was an immense learning experience for
me and I wouldn't trade
--config-option.
Not sure why we need --config-option for svnadmin?
With regards
Kamesh Jayachandran
for a
newcomer.
As a newcomer I would post a working patch than start a discussion(of
course only if the idea is straightforward) which is often open-ended
and confuses/discourages the new-comer if he is *not* that serious about
the feature he proposes.
With regards
Kamesh Jayachandran
Thanks Vijay.
Committed your in r1076234.
With regards
Kamesh Jayachandran
On 03/02/2011 03:18 PM, vijay wrote:
Attached the patch that uses macro based solution. APLOG_USE_MODULE is
used only in case of HTTPD 2.3.
Thanks Regards,
Vijayaguru
On Wednesday 02 March 2011 12:20 AM, Stefan
that the callers don't have to change.
On the whole I preferred the macro solution.
Me to prefer the orignal macro based solution.
With regards
Kamesh Jayachandran
some targets don't exist\n
Do we need full error message in the expected error?
With regards
Kamesh Jayachandran
expected_err_re = re.compile(expected_err)
Stefen,
Please find attached modified patch.
Log
[[[
Fix failing expected error regex. Also capture ra_neon error
.
This is the last correction. I promise.
Thanks Arwin. Committed at r1069791.
With regards
Kamesh Jayachandran
Regards,
Arwin Arni
On 02/11/2011 07:49 PM, Arwin Arni wrote:
On Friday 11 February 2011 07:06 PM, Kamesh Jayachandran wrote:
Thanks Arwin. Committed at r1069791.
With regards
Kamesh Jayachandran
Here is the follow-up patch that fixes the deprecated calls of
svn_config_read.
Regards,
Arwin Arni
Thanks
)
+ if sbox.repo_url.startswith(http):
+expected_error_for_cat = .*[Ff]orbidden.*
+ else:
+expected_error_for_cat = .*svn: E170001: Authorization failed.*
+
Do you mean to reinstate errorcodes(E175013, E175013, E175009) check ?
With regards
Kamesh Jayachandran
Thanks Prabhu committed your patch in r1068802.
With regards
Kamesh Jayachandran
-Original Message-
From: Prabhu Gnana Sundar Ponnarasu
Sent: Wed 2/9/2011 2:30 PM
To: Bert Huijben
Cc: Kamesh Jayachandran; dev@subversion.apache.org
Subject: Re: [PATCH] New XFail test for issue 3781
Hi
Prabhu,
Please send the patch against the current HEAD.
With regards
Kamesh Jayachandran
-Original Message-
From: Prabhu Gnana Sundar Ponnarasu
Sent: Tue 2/8/2011 1:11 PM
To: Kamesh Jayachandran
Cc: dev@subversion.apache.org
Subject: [PATCH] New XFail test for issue 3781
Hi Kamesh
reduce this to simpler one as most of the time same 'cat' and 'commit'
is tested with one 'for' loop
which iterates over [(rule1, section1), (rule2, section2)...]
With regards
Kamesh Jayachandran
-Original Message-
From: Prabhu Gnana Sundar Ponnarasu
Sent: Tue 2/8/2011 6:23 PM
To: Kamesh
fixed..
Thanks Arwin. Committed the patch in r1064093.
With regards
Kamesh Jayachandran
Regards,
Arwin Arni
.
Then we can change the behaviour to always case-sensitive approach as against
today's case-insensitive approach.
With regards
Kamesh Jayachandran
-Original Message-
From: Daniel Shahaf [mailto:d...@daniel.shahaf.name]
Sent: Fri 1/28/2011 12:16 AM
To: Kamesh Jayachandran; Arwin Arni Nandagopal
Cc: dev@subversion.apache.org
Subject: Re: svn commit:
r1064093-/subversion/trunk/subversion/libsvn_repos/authz.c
Kamesh Jayachandran
-terminated string, or NULL if no eol marker is found.
NUL is not a typo I guess, NUL means '\0', While NULL is (void *) 0x.
With regards
Kamesh Jayachandran
With regards
Kamesh Jayachandran
[PS] Unless I am mistaken svn_fspath__* can be used in libsvn_repos
too instead of svn_path_* wherever applicable and hence a chance to
become public.
I don't quite understand what you mean here.
I meant subversion/libsvn_repos/commit.c:delete_entry() uses
Hi Prabhu,
I committed this patch in r1054583.
Thanks
With regards
Kamesh Jayachandran
On 01/01/2011 03:07 AM, Gavin Beau Baumanis wrote:
Ping.
This patch submission has received no comments.
On 17/12/2010, at 5:46 PM, Prabhu Gnana Sundar wrote:
Hi,
In my previous patch, I just tweaked
- SVN_ERR(svn_cmdline_fputs(_(Copyright (C) 2010 The Apache Software
Foundation.\n
+ SVN_ERR(svn_cmdline_fputs(_(Copyright (C) 2011 The Apache Software
Foundation.\n
Won't this be 2010-2011?
With regards
Kamesh Jayachandran
/test
svn-1.7 upgrade
With regards
Kamesh Jayachandran
On 12/31/2010 02:58 PM, Arwin Arni wrote:
On Thursday 30 December 2010 09:35 PM, Kamesh Jayachandran wrote:
Hi All,
I did the following.
cd /tmp
cd svn-1.6 co file:///repo/abc
touch abc/test
svn-1.6 add abc/test
#Make sure below commit
Thanks Arwin. Committed your patch at r1054090.
With regards
Kamesh Jayachandran
On 12/31/2010 04:31 PM, Arwin Arni wrote:
Hi Kamesh,
Here is the new patch and log message and the .tar.bz2 file.
Regards,
Arwin Arni
Arwin,
Sorry, I guess my description can be reduced to even simple form.
I
Vijay,
I removed the server side(related portions from libsvn_subr) of this
change from this patch and committed the rest in r1054115.
With regards
Kamesh Jayachandran
On 12/29/2010 12:28 PM, vijay wrote:
Hi,
Attaching the patch that prefixes an underscore with the error
messages to make
Committed the fix in r1054133.
With regards
Kamesh Jayachandran
On 12/30/2010 09:35 PM, Kamesh Jayachandran wrote:
Hi All,
I did the following.
cd /tmp
cd svn-1.6 co file:///repo/abc
touch abc/test
svn-1.6 add abc/test
#Make sure below commit fails either by a pre-commit hook or File
system
URL: http://svn.apache.org/viewvc?rev=1054168view=rev
Log:
* subversion/libsvn_ra_serf/win32_auth_sspi.c
(sspi_maxtokensize): Add a paren missing from r1054115.
Thanks for fixing. Sorry for *not* taking note of it.
With regards
Kamesh Jayachandran
corresponds to 1053813:1053833
With regards
Kamesh Jayachandran
by changing it to NOOP. Which I think is enough to keep ABI.
With regards
Kamesh Jayachandran
even have such one in headers?)) should promptly
say so in the headers.
* start with __svn like we see in some of the libc headers. The vague __
starting would signal about the scope/ABI nature of the API.
/my understanding
With regards
Kamesh Jayachandran
[PS] Unless I am mistaken svn_fspath__
svn_fspath__get_longest_ancestor
svn_error__locate
svn_error__malfunction
IIUC __ convention is used for semi-public functions where we may not
keep BC promise.
Do I miss something?
With regards
Kamesh Jayachandran
. */
const char *base_path;
/snip
With regards
Kamesh Jayachandran
Thanks Vijay.
Committed in r1052547.
With regards
Kamesh Jayachandran
-Original Message-
From: Vijayaguru Guruchave
Sent: Fri 12/24/2010 9:42 PM
To: dev@subversion.apache.org
Cc: Daniel Shahaf; Kamesh Jayachandran
Subject: Re: [PATCH] Fix some deprecation warnings
On Friday 24
down?
+ SVN_ERR(svn_uri_condense_targets(url_or_path,condensed_targets,
+ target_urls, TRUE, pool, pool));
With regards
Kamesh Jayachandran
but no error was returned);
Same as above.
Thanks
With regards
Kamesh Jayachandran
Hi Zhang,
This feature is already available via --diff :
produce diff output option log command in upcoming svn 1.7.
With regards
Kamesh Jayachandran
On 12/20/2010 08:47 AM, Zhang, Wei-Jovi (NSN - CN/Hangzhou) wrote:
Hi,
I have a question about svn log command
On 12/08/2010 09:21 PM, Julian Foad wrote:
On Sat, 2010-12-04, Kamesh Jayachandran wrote:
I understand your patch fixes the following two cases.
1. svn di -cN explicitly_reinstated_file_with_mod_at_rN
Hi Kamesh and Prabhu.
What you're describing here sounds good - it sounds like a simpler
support in 1.5.x
for supporting both:
http://subversion.apache.org/docs/release-notes/1.5.html#dav-modules
Thanks Mark, Yes I got confused with 1.4.x(To add to my confusion, my
1.5.9 build install was showing only serf it did not take the neon from
subversion-deps-1.5.9-bundle).
With regards
Kamesh
'.
Without this switch it would show all the lines as 'added' with this switch it
would show only 'the modified lines'.
While debugging some issue I could see 'svnlook diff --diff-copy-from' doing
exactly the same and asked Prabhu to do the same.
With regards
Kamesh Jayachandran
There is a new
(cat_url_special_characters, test_list): New test
Patch by: Noorul Islam K Mnoorul{_AT_}collab.net
]]]
Thanks and Regards
Noorul
Thanks for the patch, Committed in r1033028.
With regards
Kamesh Jayachandran
(ls_url_special_characters, test_list): New test
Patch by: Noorul Islam K Mnoorul{_AT_}collab.net
]]]
Thanks Noorul. I tweaked for a cosmetic consistency and committed in
r1033045.
With regards
Kamesh Jayachandran
refactoring at r1032568.
With regards
Kamesh Jayachandran
|relpath}_split do not seem like its deprecating
function. So removed that portion from your patch.
Committed the patch at r1032610.
With regards
Kamesh Jayachandran
svn_path_url_add_component)
)
Pass NULL pointer to svn_relpath_basename wherever the returned
basename need not be persistent.
Patch by: Vijayaguru Gvijay_at_collab.net
Suggested by: Kameshj
]]]
Thanks committed in r1004306.
With regards
Kamesh Jayachandran
Thanks Regards,
Vijayaguru
@@
/*
- * svn_file_handle_cache.c: open file handle caching for Subversion
+ * svn__file_handle_cache.c: open file handle caching for Subversion
*
I guess it is a find and replace error. I mean file name still remains same.
Thanks
With regards
Kamesh Jayachandran
Hi Ann,
Patch has not reached the list.
Did you forget attach it?
With regards
Kamesh Jayachandran
On 07/26/2010 08:34 AM, svnusert...@href.com wrote:
[[[
Contributed Feature: enable lazy sync via new export flag,
--skipfilesmatchingsize
* subversion/libsvn_client/export.c
= svntest.main.run_svnrdump(sbox.repo_url)
+ r, out, err = svntest.main.run_svnrdump(dump, sbox.repo_url)
if (r != 0):
raise svntest.Failure('Result code not 0')
With regards
Kamesh Jayachandran
On 07/26/2010 12:51 AM, artag...@apache.org wrote:
Author: artagnon
Date: Sun Jul 25 19:21:02 2010
New Revision
On 07/26/2010 05:25 PM, Ramkumar Ramachandra wrote:
Hi Kamesh,
Kamesh Jayachandran writes:
This breaks the 2 tests in svnrdump_tests.
Though the following inline patch may fix it you may have different plans
Thanks! Yes, I'm aware that it breaks tests. Unfortunately, I have too
'.
With regards
Kamesh Jayachandran
.
Commit happens in the slave? That's certainly and obviously wrong. But
I don't understand what you mean by the configured slave url has the
*encodable* characters.
Hope I made it clear now in the STATUS file in my recent commit.
With regards
Kamesh Jayachandran
SVNListParentPath) consults mod_authz_svn(or some authorizer)
for every item listed which is not the case today.
With regards
Kamesh Jayachandran
of Location /svn/ which was leaking the same info.
With regards
Kamesh Jayachandran
(req_check_access): When canonicalized 'uri' and 'root_path' are same
allow the request.
]]]
If there are no objections will commit this in next couple of days.
Thanks
With regards
Kamesh Jayachandran
Index: subversion/mod_authz_svn/mod_authz_svn.c
path from authz control.
* subversion/mod_authz_svn/mod_authz_svn.c
(req_check_access): When canonicalized 'uri' and 'root_path' are same
allow the request.
]]]
If there are no objections will commit this in next couple of days.
Thanks
With regards
Kamesh Jayachandran
Index: subversion
control is neccessary in
this case.
Will update the comment.
With regards
Kamesh Jayachandran
Modified as suggested.
Thanks
With regards
Kamesh Jayachandran
-Original Message-
From: Blair Zajac [mailto:bl...@orcaware.com]
Sent: Mon 3/1/2010 10:47 PM
To: kame...@apache.org
Cc: dev@subversion.apache.org
Subject: Re: svn commit: r917512 - in /subversion/trunk/subversion/mod_dav_svn
On 02/15/2010 07:44 PM, Julian Foad wrote:
Kamesh Jayachandran wrote:
With the below apache configuration(See the trailing slash at the end of
'/svn/').
Location /svn/
DAV svn
SVNParentPath /repositories
SVNMasterURI http://master/svn/
SVNAdvertiseV2Protocol Off
/Location
svn mergeinfo --show-revs eligible
https://svn.apache.org/repos/asf/subversion/trunk
https://svn.apache.org/repos/asf/subversion/branches/1.6.x
Above command lists 'r876233' while that has already been merged!
With regards
Kamesh Jayachandran
for double slash and not anything functional to
that issue, I may be wrong.
Thoughts?
Thanks
With regards
Kamesh Jayachandran
Index: subversion/mod_dav_svn/mirror.c
===
--- subversion/mod_dav_svn/mirror.c (revision 910164
, seems silly to require a server upgrade instead.
Kamesh, can you look into this?
Attached patch fixes it, though I need to get better context to the
relevant code base to give a 100% confident fix, which I will do it sooner.
With regards
Kamesh Jayachandran
Index: subversion/libsvn_ra_serf
test 8 failure.)
In next few hours I will commit this as it looks fairly obvious unless
there are some objections.
Thanks Mike,
With regards
Kamesh Jayachandran
PS
[1]
http://mail-archives.apache.org/mod_mbox/subversion-dev/201001.mbox/%3c4b4cc1aa.6000...@collab.net%3e
Make CHECKOUT request
On 01/18/2010 11:47 PM, Kamesh Jayachandran wrote:
whether it addresses any of the points Mike raised and in what ways,
that sort of thing.
Hey forgot to answer this bit. Mike was suggesting to make use of
'DAV:apply-to-version' in CHECKOUT rather than the problematic PROPFIND. I did
and how it changes the commit process
and the interactions with a proxy.
It just does not do the problematic PROPFIND leaving way to CHECKOUT to
figure it out.
With regards
Kamesh Jayachandran
to be modified or somesuch.
Thanks. I knew this was a DAV checkout, but I thought it was also
used in some read operations. Anyway, that probably explains why it
works.
Nice suggestion.
Committed in r900797.
With regards
Kamesh Jayachandran
On 01/13/2010 05:07 PM, Kamesh Jayachandran wrote:
On 01/13/2010 12:08 AM, C. Michael Pilato wrote:
Kamesh Jayachandran wrote:
Hi All,
Last week I posted the patch to implement 'svn client' to identify the
svn operation they are about to do with a given ra_session.
Following thread has
PROPFIND and the POST it does already gets proxied.
With regards
Kamesh Jayachandran
boolean parameter
'for_commit' which is set to TRUE only by commit.c:apply_revprops() while
others set it to FALSE and hence no SVN-COMMIT header.
As it was a in concept patch I just did not write a log message, sorry for that.
With regards
Kamesh Jayachandran
On 01/13/2010 12:08 AM, C. Michael Pilato wrote:
Kamesh Jayachandran wrote:
Hi All,
Last week I posted the patch to implement 'svn client' to identify the
svn operation they are about to do with a given ra_session.
Following thread has the detailed discussion.
http://mail
of 'administrative control of activity based on operation names'.
With regards
Kamesh Jayachandran
this patch relies on '-r' to tell about base revision for this
commit.
Just thought of recording it here.
With regards
Kamesh Jayachandran
Index: subversion/svn/propset-cmd.c
===
--- subversion/svn/propset-cmd.c(revision 896770
* neon still uses the old protocol i.e do not make POST requests
so suffers from original PROPFIND problem and hence need our fix.
*serf* uses 'POST' request to get the baseline revision, 'POST' request
is proxied to MASTER so it does not suffer from this problem.
With regards
Kamesh Jayachandran
On 01/07/2010 07:53 PM, C. Michael Pilato wrote:
Kamesh Jayachandran wrote:
With all due respect, the proposed solution looks enormous compared to
the
size of the problem. Does the original problem exist in HTTPv2? At a
minimum, could the ra_dav providers not annotate the PROPFIND
On 01/06/2010 06:41 PM, Senthil Kumaran S wrote:
C. Michael Pilato wrote:
Kamesh Jayachandran wrote:
With Without this patch mergeinfo_test-8 fails both over ra_neon and
ra_serf.
Ooh! I was *just* about to start debugging my mergeinfo_test-8 failures on
the issue-3242-dev
.
The patch attached to the Philips response earlier applies 'SVN-ACTION'
based detection and if it fails defaults to connection based detection.
Once detected a PROPFIND as for commit we just proxy it.
Hope this explains.
With regards
Kamesh Jayachandran
On 01/06/2010 07:35 PM, Julian Foad wrote
On 01/06/2010 06:58 PM, Bert Huijben wrote:
-Original Message-
From: Kamesh Jayachandran [mailto:kam...@collab.net]
Sent: woensdag 6 januari 2010 14:00
To: dev@subversion.apache.org
Subject: [PATCH] Make svn clients indicate their operation name to
backend(right now only to DAV
connection.
Or some forced closure of the connection due to intermittent network issues on
client or server end.
With regards
Kamesh Jayachandran
Kamesh Jayachandran
need to handle something else like this on the backend
especially on all 'ra' layers. Will we again do some other trick on a case by
case basis?
With regards
Kamesh Jayachandran
With regards
Kamesh Jayachandran
100 matches
Mail list logo
