> -Original Message-
> From: Stefan Sperling [mailto:s...@elego.de]
> Sent: dinsdag 18 december 2012 10:46
> To: Peter Samuelson; dev@subversion.apache.org
> Subject: Re: svn commit: r1422706 - in /subversion/trunk/subversion:
> libsvn_subr/opt.c tests/cmdline/svntest/m
Stefan Sperling wrote on Tue, Dec 18, 2012 at 11:27:25 +0100:
> On Tue, Dec 18, 2012 at 12:19:02PM +0200, Daniel Shahaf wrote:
> > Stefan Sperling wrote on Tue, Dec 18, 2012 at 11:03:56 +0100:
> > > Why would you *not* want to do this? Don't say "because the bug isn't
> > > in svn" since that is cl
On Tue, Dec 18, 2012 at 12:19:02PM +0200, Daniel Shahaf wrote:
> Stefan Sperling wrote on Tue, Dec 18, 2012 at 11:03:56 +0100:
> > Why would you *not* want to do this? Don't say "because the bug isn't
> > in svn" since that is clear. We're not fixing a bug in 'svn'. We're
> > making it work properl
Stefan Sperling wrote on Tue, Dec 18, 2012 at 11:03:56 +0100:
> Why would you *not* want to do this? Don't say "because the bug isn't
> in svn" since that is clear. We're not fixing a bug in 'svn'. We're
> making it work properly by default in more environments.
I didn't say you should not apply t
On Tue, Dec 18, 2012 at 11:48:02AM +0200, Daniel Shahaf wrote:
> Stefan Sperling wrote on Tue, Dec 18, 2012 at 09:54:08 +0100:
> > On Tue, Dec 18, 2012 at 01:55:55AM +0200, Daniel Shahaf wrote:
> > > Not sure. For unattended scripts, the only difference between passing
> > > --non-interactive or n
Stefan Sperling wrote on Tue, Dec 18, 2012 at 09:54:08 +0100:
> On Tue, Dec 18, 2012 at 01:55:55AM +0200, Daniel Shahaf wrote:
> > Not sure. For unattended scripts, the only difference between passing
> > --non-interactive or not passing it is the error message they get, right?
> >
> > I mean, if
On Mon, Dec 17, 2012 at 09:39:49PM +0100, Stefan Sperling wrote:
> The simple patch below implements it with the isatty() on *nix and
> _isatty() on Windows (untested -- thanks for the hint Bert!).
Updated version that adds --force-interactive for users who require
the previous behaviour for whate
On Tue, Dec 18, 2012 at 09:54:08AM +0100, Stefan Sperling wrote:
> I've seen this happen in Jenkins builds that run 'svn export' and
> adding --non-interactive fixed it.
Correction: I misrembered. This wasn't happening in Jenkins, but in an
automated test environment ("SQS Test") which executes ba
On Tue, Dec 18, 2012 at 01:55:55AM +0200, Daniel Shahaf wrote:
> Not sure. For unattended scripts, the only difference between passing
> --non-interactive or not passing it is the error message they get, right?
>
> I mean, if they pass it they will get "Cannot prompt because we aren't
> interacti
Stefan Sperling wrote on Mon, Dec 17, 2012 at 21:39:49 +0100:
> On Mon, Dec 17, 2012 at 01:44:43PM -0600, Peter Samuelson wrote:
> > [Stefan Sperling]
> > > We could use iatty() to enable --non-interactive if output is not
> > > going to a terminal, for instance.
> >
> > I floated this idea some t
Stefan Sperling wrote on Mon, Dec 17, 2012 at 21:32:24 +0100:
> On Mon, Dec 17, 2012 at 09:14:42PM +0100, Branko Čibej wrote:
> > That "blatant abuse" happens at least in two places that I'm aware of:
> > our tests, and Emacs vc-mode.
>
> There is a difference between scraping the cli output and h
> On Mon, Dec 17, 2012 at 01:44:43PM -0600, Peter Samuelson wrote:
> > [Stefan Sperling]
> > > We could use iatty() to enable --non-interactive if output is not
> > > going to a terminal, for instance.
> >
> > I floated this idea some time ago and I'm still in favor of it. But I
> > think a simp
On Mon, Dec 17, 2012 at 01:44:43PM -0600, Peter Samuelson wrote:
> [Stefan Sperling]
> > We could use iatty() to enable --non-interactive if output is not
> > going to a terminal, for instance.
>
> I floated this idea some time ago and I'm still in favor of it. But I
> think a simple isatty(STDER
On Mon, Dec 17, 2012 at 09:14:42PM +0100, Branko Čibej wrote:
> That "blatant abuse" happens at least in two places that I'm aware of:
> our tests, and Emacs vc-mode.
There is a difference between scraping the cli output and having
a program type answers into prompts. Do our tests really do the la
On 12/17/2012 03:11 PM, Branko Čibej wrote:
> On 17.12.2012 20:01, C. Michael Pilato wrote:
>> On 12/17/2012 01:05 PM, Branko Čibej wrote:
>>> On 17.12.2012 15:03, C. Michael Pilato wrote:
On 12/17/2012 05:19 AM, Branko Čibej wrote:
> On 17.12.2012 09:47, Bert Huijben wrote:
>> I think
On 17.12.2012 20:44, Peter Samuelson wrote:
> [Stefan Sperling]
>> We could use iatty() to enable --non-interactive if output is not
>> going to a terminal, for instance.
> I floated this idea some time ago and I'm still in favor of it. But I
> think a simple isatty(STDERR_FILENO) would be wrong.
On 17.12.2012 20:01, C. Michael Pilato wrote:
> On 12/17/2012 01:05 PM, Branko Čibej wrote:
>> On 17.12.2012 15:03, C. Michael Pilato wrote:
>>> On 12/17/2012 05:19 AM, Branko Čibej wrote:
On 17.12.2012 09:47, Bert Huijben wrote:
> I think we should suppress this warning on Windows when th
[Stefan Sperling]
> We could use iatty() to enable --non-interactive if output is not
> going to a terminal, for instance.
I floated this idea some time ago and I'm still in favor of it. But I
think a simple isatty(STDERR_FILENO) would be wrong. What you want is
to detect that there is a contro
On 12/17/2012 01:05 PM, Branko Čibej wrote:
> On 17.12.2012 15:03, C. Michael Pilato wrote:
>> On 12/17/2012 05:19 AM, Branko Čibej wrote:
>>> On 17.12.2012 09:47, Bert Huijben wrote:
I think we should suppress this warning on Windows when the CryptoAPI
encryption is enabled (read: +- alw
On 17.12.2012 15:03, C. Michael Pilato wrote:
> On 12/17/2012 05:19 AM, Branko Čibej wrote:
>> On 17.12.2012 09:47, Bert Huijben wrote:
>>> I think we should suppress this warning on Windows when the CryptoAPI
>>> encryption is enabled (read: +- always) to avoid unneeded user questions.
>> I rather
On 12/17/2012 05:19 AM, Branko Čibej wrote:
> On 17.12.2012 09:47, Bert Huijben wrote:
>> I think we should suppress this warning on Windows when the CryptoAPI
>> encryption is enabled (read: +- always) to avoid unneeded user questions.
>
> I rather think we should disable plaintext password stora
On 17.12.2012 11:23, Bert Huijben wrote:
>
>> -Original Message-
>> From: Branko Čibej [mailto:br...@wandisco.com]
>> Sent: maandag 17 december 2012 11:19
>> To: dev@subversion.apache.org
>> Subject: Re: svn commit: r1422706 - in /subversion/trunk/subve
> -Original Message-
> From: Branko Čibej [mailto:br...@wandisco.com]
> Sent: maandag 17 december 2012 11:19
> To: dev@subversion.apache.org
> Subject: Re: svn commit: r1422706 - in /subversion/trunk/subversion:
> libsvn_subr/opt.c tests/cmdline/svntest/main.py
>
On 17.12.2012 10:28, Stefan Sperling wrote:
> On Mon, Dec 17, 2012 at 08:47:43AM +, Bert Huijben wrote:
>> And I’m not sure what to think of the color escape strings...
>> Do these work on any not Windows os with any terminal settings?
>> (We currently only use these in the test suite and the r
On 17.12.2012 09:47, Bert Huijben wrote:
> I think we should suppress this warning on Windows when the CryptoAPI
> encryption is enabled (read: +- always) to avoid unneeded user questions.
I rather think we should disable plaintext password storage by default,
I don't care about Windows, and let p
"Bert Huijben" writes:
>> -Original Message-
>> From: br...@apache.org [mailto:br...@apache.org]
>> Sent: zondag 16 december 2012 23:43
>> To: comm...@subversion.apache.org
>> Subject: svn commit: r1422706 - in /subversion/trunk/subversion:
&g
On Sun, Dec 16, 2012 at 10:43:26PM -, br...@apache.org wrote:
> Author: brane
> Date: Sun Dec 16 22:43:25 2012
> New Revision: 1422706
>
> URL: http://svn.apache.org/viewvc?rev=1422706&view=rev
> Log:
> Print a warning in "svn --version" if plaintext password storage is enabled.
One more rema
> -Original Message-
> From: br...@apache.org [mailto:br...@apache.org]
> Sent: zondag 16 december 2012 23:43
> To: comm...@subversion.apache.org
> Subject: svn commit: r1422706 - in /subversion/trunk/subversion:
> libsvn_subr/opt.c tests/cmdline/svntest/main.py
>
&
On Mon, Dec 17, 2012 at 08:47:43AM +, Bert Huijben wrote:
> I think we should suppress this warning on Windows when the CryptoAPI
> encryption is enabled (read: +- always) to avoid unneeded user questions.
Also, the warning is printed even if plaintext password storage is
disabled at runtime v
these in the test suite and the result is plainly
visisble on the buildbot log)
Bert
*From:* br...@apache.org
*Sent:* December 16, 2012 11:43 PM
*To:* comm...@subversion.apache.org
*Subject:* svn commit: r1422706 - in /subversion/trunk/subversion:
libsvn_subr/opt.c tests/cmdline/svntest/main.py
30 matches
Mail list logo
