Re: [VOTE] Release Apache Superset 1.1.0 based on Superset 1.1.0rc1

2021-04-02 Thread Erik Ritter
I agree on having an rc2. Let's cherry-pick this commit (and any other safe bug fixes that have come in since) and cut a new rc. -1 Erik On Fri, Apr 2, 2021 at 4:39 PM Beto Dealmeida wrote: > I think we should cherry-pick the fix and do an RC2, it's a 1-character > fix and personally I use

Re: [VOTE] Release Apache Superset 1.1.0 based on Superset 1.1.0rc1

2021-04-02 Thread Beto Dealmeida
I think we should cherry-pick the fix and do an RC2, it's a 1-character fix and personally I use that feature all the time. On 4/2/21 4:13 PM, Evan Rusackas wrote: This issue was addressed after the RC was cut, by this PR: https://github.com/apache/superset/pull/13657 There is a workaround

Re: [VOTE] Release Apache Superset 1.1.0 based on Superset 1.1.0rc1

2021-04-02 Thread Evan Rusackas
This issue was addressed after the RC was cut, by this PR: https://github.com/apache/superset/pull/13657 There is a workaround available of copying the query and pasting it into SQL Lab manually. Since I’m not sure how many people rely on that feature, I’m not sure if this constitutes a bug

Re: [VOTE] Release Apache Superset 1.1.0 based on Superset 1.1.0rc1

2021-04-02 Thread Junlin Chen
Identified an issue during testing of 1.1/1.1.0 branches. When clicking on 'Run in SQL Lab' from Explore in any chart, flask.debughelpers.FormDataRoutingRedirect is returned and the whole page crashed. although there's a workaround, this button is quite commonly used... *I'm inclined to have rc2.