RE: [DISCUSS] User Service

2013-02-08 Thread Jan Bernhardt
) WorkflowFormTO getFormForUser(@PathParam(userId) Long userId); Best regards. Jan -Original Message- From: Francesco Chicchiriccò [mailto:ilgro...@apache.org] Sent: Dienstag, 5. Februar 2013 11:03 To: dev@syncope.apache.org Subject: Re: [DISCUSS] User Service On 05/02/2013 10:01, Christian

Re: [DISCUSS] User Service

2013-02-08 Thread Francesco Chicchiriccò
On 08/02/2013 09:05, Jan Bernhardt wrote: Hi syncoper, I do not even see methods in RoleService that should be moved into a different ServiceInterface! Workflow controller is used in RoleController but just for CRUD operations, no direct access, so this is mostly transparent to user. But I

Re: [DISCUSS] User Service

2013-02-05 Thread Christian Schneider
On 04.02.2013 18:10, Francesco Chicchiriccò wrote: I agree with you that WorkflowController and the workflow methods in UserController do not belong together. On the other hand I think it may be a good idea to separate them from the UserService. So would it make sense to have a

RE: [DISCUSS] User Service

2013-02-04 Thread Jan Bernhardt
-Original Message- From: Francesco Chicchiriccò [mailto:ilgro...@apache.org] Sent: Freitag, 1. Februar 2013 17:45 To: dev@syncope.apache.org Subject: Re: [DISCUSS] User Service On 01/02/2013 17:32, Jan Bernhardt wrote: Hi Syncoper, I'm almost done with new REST API Service

Re: [DISCUSS] User Service

2013-02-04 Thread Francesco Chicchiriccò
On 04/02/2013 12:12, Jan Bernhardt wrote: -Original Message- From: Francesco Chicchiriccò [mailto:ilgro...@apache.org] Sent: Freitag, 1. Februar 2013 17:45 To: dev@syncope.apache.org Subject: Re: [DISCUSS] User Service On 01/02/2013 17:32, Jan Bernhardt wrote: Hi Syncoper, I'm almost

Re: [DISCUSS] User Service

2013-02-04 Thread Christian Schneider
On 04.02.2013 12:41, Francesco Chicchiriccò wrote: On 04/02/2013 12:12, Jan Bernhardt wrote: The workflow-related methods in UserController (and RoleController BTW) are there because they are involved in user (and role) lifecycle management. Given these things, I wouldn't make any

Re: [DISCUSS] User Service

2013-02-04 Thread Christian Schneider
One other idea for the username / userId based methods. Why not simply use: /users/{userIdorName} So basically you could do get /users/100 or get /users/chris@mydomain We could handle both using @GET @Path({userId}) UserTO read(@PathParam(userId) String userId); This is convenient for any

Re: [DISCUSS] User Service

2013-02-04 Thread Francesco Chicchiriccò
On 04/02/2013 14:00, Christian Schneider wrote: On 04.02.2013 12:41, Francesco Chicchiriccò wrote: On 04/02/2013 12:12, Jan Bernhardt wrote: The workflow-related methods in UserController (and RoleController BTW) are there because they are involved in user (and role) lifecycle management.

[DISCUSS] User Service

2013-02-01 Thread Jan Bernhardt
Hi Syncoper, I'm almost done with new REST API Service Interface documentation [1]. Last peace missing is only User Service. Please take time to review changes to new Service Interfaces and let's have a discussion on this mailing-list. I think we already discussed all general changes, but if

Re: [DISCUSS] User Service

2013-02-01 Thread Francesco Chicchiriccò
On 01/02/2013 17:32, Jan Bernhardt wrote: Hi Syncoper, I'm almost done with new REST API Service Interface documentation [1]. Last peace missing is only User Service. Please take time to review changes to new Service Interfaces and let's have a discussion on this mailing-list. I think we