> -Original Message-
> From: Fabio Martelli [mailto:fabio.marte...@gmail.com]
> Sent: Freitag, 18. Januar 2013 10:25
> To: dev@syncope.apache.org
> Subject: Re: [Discussion] New REST Service Interfaces - Entitlements
>
>
> Il giorno 18/gen/2013, alle ore 09.47,
Il giorno 18/gen/2013, alle ore 09.47, Jan Bernhardt ha scritto:
>>>
>>> May be a rule or a validity date or something like this.
>>> I'll keep the possibility to extend EntitlementTO.
>>
>> A validity date would not be necessary. It is only important to tell the
>> unmarshaller to be LAX with
Il giorno 18/gen/2013, alle ore 09.21, Jan Bernhardt ha scritto:
> Hi Fabio,
>
>>>
>>> === Renaming Service ===
>>> Rename AuthenticationController to EntitlementService(Impl), since
>> containing methods have little to nothing to do with authentication. It is
>> only
>> about Entitlements...
> Names will be Consistent. New CXF REST Services will all End with *Service.
> Old Spring Services currently ending with *Controller will eventually all
> vanish, once new Services are actually used (migration is complete).
Than is absolutely OK for me. + 1.
Andrei.
>
> Best regards.
> Jan
I would rather do it in the annotations. Internally we often have a
internal class without TO and a transfer object that ends in TO.
So I think it makes sense to differentiate them on the class level.
Christian
On 18.01.2013 09:51, Jan Bernhardt wrote:
>> Btw. I would rather name the xml element
>
> Btw. I would rather name the xml element Entitlement than EntitlementTO
> as the fact that it is a transfer object is not important on the xml level.
>
I agree. Not using *TO ending would look nicer on transport layer.
The question here is, should we also remove "TO" in Classnames, or just
> >
> > May be a rule or a validity date or something like this.
> > I'll keep the possibility to extend EntitlementTO.
>
> A validity date would not be necessary. It is only important to tell the
> unmarshaller to be LAX with the received document. By this the
> ummarshaller will only unmarshall
> >>>
> >>> Option 1 matches more or less current marshaling. I personally would
> prefer Option 2 because this would give us the opportunity to easily extend
> EntitlementTO at a later point (if needed) without becoming incompatible
> with previous version.
> >> Agree with you for the reason given
Hi Christian,
> >> === Renaming Service ===
> >> Rename AuthenticationController to EntitlementService(Impl), since
> containing methods have little to nothing to do with authentication. It is
> only
> about Entitlements...
> > Why not AuthorizationController or AccessController? I'd prefer the
Hi Andrei,
>
> > === Renaming Service ===
> > Rename AuthenticationController to EntitlementService(Impl), since
> > containing methods have little to nothing to do with authentication.
> > It is only about Entitlements...
>
> +1 for Entitlement, -1 for Service. I would keep names consistently,
Hi Fabio,
> >
> > === Renaming Service ===
> > Rename AuthenticationController to EntitlementService(Impl), since
> containing methods have little to nothing to do with authentication. It is
> only
> about Entitlements...
>
> Why not AuthorizationController or AccessController? I'd prefer the fi
Il giorno 17/gen/2013, alle ore 17.09, Christian Schneider ha scritto:
> On 17.01.2013 14:43, Fabio Martelli wrote:
>> Il giorno 17/gen/2013, alle ore 14.03, Jan Bernhardt ha scritto:
>>
>>> Hi Syncoper,
>>>
>>> The following changes are proposed regarding AuthenticationController:
>>>
>>> ==
On 17.01.2013 14:43, Fabio Martelli wrote:
> Il giorno 17/gen/2013, alle ore 14.03, Jan Bernhardt ha scritto:
>
>> Hi Syncoper,
>>
>> The following changes are proposed regarding AuthenticationController:
>>
>> === Renaming Service ===
>> Rename AuthenticationController to EntitlementService(Impl)
Hi Jan,
> === Renaming Service ===
> Rename AuthenticationController to EntitlementService(Impl), since
> containing methods have little to nothing to do with authentication. It is
> only
> about Entitlements...
+1 for Entitlement, -1 for Service. I would keep names consistently, if use
Entitle
Il giorno 17/gen/2013, alle ore 14.03, Jan Bernhardt ha scritto:
> Hi Syncoper,
>
> The following changes are proposed regarding AuthenticationController:
>
> === Renaming Service ===
> Rename AuthenticationController to EntitlementService(Impl), since containing
> methods have little to noth
nuar 2013 14:04
> To: dev@syncope.apache.org
> Subject: RE: [Discussion] New REST Service Interfaces - Entitlements
>
> Hi Syncoper,
>
> The following changes are proposed regarding AuthenticationController:
>
> === Renaming Service ===
> Rename AuthenticationControlle
Hi Syncoper,
The following changes are proposed regarding AuthenticationController:
=== Renaming Service ===
Rename AuthenticationController to EntitlementService(Impl), since containing
methods have little to nothing to do with authentication. It is only about
Entitlements...
=== Changing re
17 matches
Mail list logo
