[GitHub] [systemml] asfgit closed pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-25 Thread GitBox
asfgit closed pull request #971: URL: https://github.com/apache/systemml/pull/971 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemml] muehlburger commented on pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-25 Thread GitBox
muehlburger commented on pull request #971: URL: https://github.com/apache/systemml/pull/971#issuecomment-649504796 Thank you! It was a pleasure! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [systemml] Baunsgaard commented on pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-25 Thread GitBox
Baunsgaard commented on pull request #971: URL: https://github.com/apache/systemml/pull/971#issuecomment-649463903 Hi @muehlburger ! Thanks for your contribution! :superhero: :star: I have squashed all your commits into one, and intend to push this to master after the testsuite is

[GitHub] [systemml] Baunsgaard opened a new pull request #980: Systemml 135

2020-06-25 Thread GitBox
Baunsgaard opened a new pull request #980: URL: https://github.com/apache/systemml/pull/980 @corepointer I think you made some changes to the execution? https://issues.apache.org/jira/browse/SYSTEMML-135 I would like to go further and simply remove the template file

[GitHub] [systemml] kev-inn commented on a change in pull request #946: Privacy Runtime Extended

2020-06-25 Thread GitBox
kev-inn commented on a change in pull request #946: URL: https://github.com/apache/systemml/pull/946#discussion_r445399020 ## File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedRequest.java ## @@ -74,4 +80,16 @@ public int getNumParams() {

[GitHub] [systemml] sebwrede commented on a change in pull request #946: Privacy Runtime Extended

2020-06-25 Thread GitBox
sebwrede commented on a change in pull request #946: URL: https://github.com/apache/systemml/pull/946#discussion_r445388137 ## File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedRequest.java ## @@ -74,4 +80,16 @@ public int getNumParams() {

[GitHub] [systemml] sebwrede commented on a change in pull request #946: Privacy Runtime Extended

2020-06-25 Thread GitBox
sebwrede commented on a change in pull request #946: URL: https://github.com/apache/systemml/pull/946#discussion_r445387201 ## File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedRequest.java ## @@ -33,20 +35,24 @@ private

[GitHub] [systemml] muehlburger commented on a change in pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-25 Thread GitBox
muehlburger commented on a change in pull request #971: URL: https://github.com/apache/systemml/pull/971#discussion_r445350487 ## File path: src/main/java/org/apache/sysds/runtime/io/FrameWriterProto.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [systemml] kev-inn commented on a change in pull request #946: Privacy Runtime Extended

2020-06-24 Thread GitBox
kev-inn commented on a change in pull request #946: URL: https://github.com/apache/systemml/pull/946#discussion_r445086179 ## File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedRequest.java ## @@ -74,4 +80,16 @@ public int getNumParams() {

[GitHub] [systemml] Baunsgaard commented on pull request #947: [DOC][2/2] Documentation for builtin KMeans function

2020-06-24 Thread GitBox
Baunsgaard commented on pull request #947: URL: https://github.com/apache/systemml/pull/947#issuecomment-648652232 Hi @j143, i missed this PR and comment. I think it is fine with the dev notebook, but i don't like that so much of it is setup. Could this not be simplified? Also where do

[GitHub] [systemml] Baunsgaard commented on pull request #975: Extend the Python API

2020-06-23 Thread GitBox
Baunsgaard commented on pull request #975: URL: https://github.com/apache/systemml/pull/975#issuecomment-648032616 Hi @juliale-15, Thank you for your PR :+1: , while merging I only updated the documentation. I hope you feel motivated to commit more to Open Source and SystemDS in the

[GitHub] [systemml] asfgit closed pull request #975: Extend the Python API

2020-06-23 Thread GitBox
asfgit closed pull request #975: URL: https://github.com/apache/systemml/pull/975 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemml-website] j143 commented on pull request #69: Add new committer to the community page.

2020-06-22 Thread GitBox
j143 commented on pull request #69: URL: https://github.com/apache/systemml-website/pull/69#issuecomment-647918190 Sebastian, in case if you want to practice committing to the `svn` repository for updating our main website, a small resource available at (for windows, but works for

[GitHub] [systemml-website] j143 commented on pull request #69: Add new committer to the community page.

2020-06-22 Thread GitBox
j143 commented on pull request #69: URL: https://github.com/apache/systemml-website/pull/69#issuecomment-647917417 Can the details be reviewed? cc @baunsgaard This is an automated message from the Apache Git Service.

[GitHub] [systemml] kev-inn commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-22 Thread GitBox
kev-inn commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443464831 ## File path: src/test/java/org/apache/sysds/test/functions/federated/FederatedConstructionTest.java ## @@ -142,7 +142,7 @@ public void

[GitHub] [systemml] phaniarnab merged pull request #979: [SYSTEMDS-414] New rewrite for PCA -> lmDS pipeline

2020-06-21 Thread GitBox
phaniarnab merged pull request #979: URL: https://github.com/apache/systemml/pull/979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [systemml] phaniarnab commented on pull request #979: [SYSTEMDS-414] New rewrite for PCA -> lmDS pipeline

2020-06-21 Thread GitBox
phaniarnab commented on pull request #979: URL: https://github.com/apache/systemml/pull/979#issuecomment-647189994 Will merge in once tests are executed. This is an automated message from the Apache Git Service. To respond

[GitHub] [systemml] phaniarnab opened a new pull request #979: [SYSTEMDS-414] New rewrite for PCA -> lmDS pipeline

2020-06-21 Thread GitBox
phaniarnab opened a new pull request #979: URL: https://github.com/apache/systemml/pull/979 This patch contains a rewrite to reuse tsmm result in lmDS if called after PCA incrementally for increasing number of columns.

[GitHub] [systemml] phaniarnab closed pull request #978: print max memory, spilled items.

2020-06-21 Thread GitBox
phaniarnab closed pull request #978: URL: https://github.com/apache/systemml/pull/978 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [systemml] phaniarnab commented on pull request #978: print max memory, spilled items.

2020-06-21 Thread GitBox
phaniarnab commented on pull request #978: URL: https://github.com/apache/systemml/pull/978#issuecomment-647165836 Didn't reproduce. Trying again. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [systemml] phaniarnab opened a new pull request #978: print max memory, spilled items.

2020-06-21 Thread GitBox
phaniarnab opened a new pull request #978: URL: https://github.com/apache/systemml/pull/978 This PR is to investigate the test failure. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [systemml] Baunsgaard commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
Baunsgaard commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443136339 ## File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedWorkerHandler.java ## @@ -115,6 +131,77 @@ private

[GitHub] [systemml] Baunsgaard commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
Baunsgaard commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443135981 ## File path: src/test/java/org/apache/sysds/test/functions/federated/FederatedConstructionTest.java ## @@ -142,7 +142,7 @@ public void

[GitHub] [systemml] Baunsgaard commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
Baunsgaard commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443135741 ## File path: src/main/java/org/apache/sysds/runtime/instructions/fed/MultiReturnParameterizedBuiltinFEDInstruction.java ## @@ -0,0 +1,215 @@ +/* + *

[GitHub] [systemml] Baunsgaard commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
Baunsgaard commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443135535 ## File path: src/main/java/org/apache/sysds/runtime/instructions/fed/MultiReturnParameterizedBuiltinFEDInstruction.java ## @@ -0,0 +1,215 @@ +/* + *

[GitHub] [systemml] Baunsgaard commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
Baunsgaard commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443135535 ## File path: src/main/java/org/apache/sysds/runtime/instructions/fed/MultiReturnParameterizedBuiltinFEDInstruction.java ## @@ -0,0 +1,215 @@ +/* + *

[GitHub] [systemml] Baunsgaard commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
Baunsgaard commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443134308 ## File path: src/main/java/org/apache/sysds/runtime/instructions/fed/MultiReturnParameterizedBuiltinFEDInstruction.java ## @@ -0,0 +1,215 @@ +/* + *

[GitHub] [systemml] Baunsgaard commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
Baunsgaard commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r437422120 ## File path: src/main/java/org/apache/sysds/runtime/instructions/fed/MultiReturnParameterizedBuiltinFEDInstruction.java ## @@ -0,0 +1,215 @@ +/* + *

[GitHub] [systemml] kev-inn commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
kev-inn commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443132571 ## File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedWorkerHandler.java ## @@ -115,6 +131,77 @@ private

[GitHub] [systemml] kev-inn commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
kev-inn commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443132351 ## File path: src/test/java/org/apache/sysds/test/functions/federated/FederatedConstructionTest.java ## @@ -142,7 +142,7 @@ public void

[GitHub] [systemml] kev-inn commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
kev-inn commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443132290 ## File path: src/main/java/org/apache/sysds/runtime/instructions/fed/MultiReturnParameterizedBuiltinFEDInstruction.java ## @@ -0,0 +1,215 @@ +/* + *

[GitHub] [systemml] kev-inn commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
kev-inn commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443132118 ## File path: src/main/java/org/apache/sysds/runtime/instructions/fed/MultiReturnParameterizedBuiltinFEDInstruction.java ## @@ -0,0 +1,215 @@ +/* + *

[GitHub] [systemml] kev-inn commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
kev-inn commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443131821 ## File path: src/main/java/org/apache/sysds/runtime/instructions/fed/MultiReturnParameterizedBuiltinFEDInstruction.java ## @@ -0,0 +1,215 @@ +/* + *

[GitHub] [systemml] kev-inn commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
kev-inn commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443131598 ## File path: src/main/java/org/apache/sysds/runtime/instructions/fed/MultiReturnParameterizedBuiltinFEDInstruction.java ## @@ -0,0 +1,215 @@ +/* + *

[GitHub] [systemml] kev-inn commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
kev-inn commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443131492 ## File path: src/main/java/org/apache/sysds/runtime/instructions/fed/MultiReturnParameterizedBuiltinFEDInstruction.java ## @@ -0,0 +1,215 @@ +/* + *

[GitHub] [systemml] kev-inn commented on a change in pull request #966: [WIP][SYSTEMML-229] Fed frame recode transform (encode) support

2020-06-20 Thread GitBox
kev-inn commented on a change in pull request #966: URL: https://github.com/apache/systemml/pull/966#discussion_r443131449 ## File path: src/main/java/org/apache/sysds/runtime/instructions/fed/MultiReturnParameterizedBuiltinFEDInstruction.java ## @@ -0,0 +1,215 @@ +/* + *

[GitHub] [systemml] Shafaq-Siddiqi commented on a change in pull request #976: [SYSTEMDS-200] Gaussian Mixture Model builtin

2020-06-18 Thread GitBox
Shafaq-Siddiqi commented on a change in pull request #976: URL: https://github.com/apache/systemml/pull/976#discussion_r442314756 ## File path: src/test/java/org/apache/sysds/test/functions/builtin/BuiltinGMMTest.java ## @@ -44,69 +45,66 @@

[GitHub] [systemml] asfgit merged pull request #977: [SYSTEMDS-501] Documentation webpage framework

2020-06-18 Thread GitBox
asfgit merged pull request #977: URL: https://github.com/apache/systemml/pull/977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemml] Baunsgaard commented on pull request #977: [SYSTEMDS-501] Documentation webpage framework

2020-06-18 Thread GitBox
Baunsgaard commented on pull request #977: URL: https://github.com/apache/systemml/pull/977#issuecomment-646018686 If you want to see how it looks go to: https://baunsgaard.github.io/systemds/ This is an automated

[GitHub] [systemml] Baunsgaard commented on a change in pull request #975: Extend the Python API

2020-06-18 Thread GitBox
Baunsgaard commented on a change in pull request #975: URL: https://github.com/apache/systemml/pull/975#discussion_r442164461 ## File path: src/main/python/systemds/matrix/data_gen.py ## @@ -102,3 +105,70 @@ def rand(sds_context: SystemDSContext, rows: int, cols: int,

[GitHub] [systemml] juliale-15 commented on a change in pull request #975: Extend the Python API

2020-06-18 Thread GitBox
juliale-15 commented on a change in pull request #975: URL: https://github.com/apache/systemml/pull/975#discussion_r442124998 ## File path: src/main/python/systemds/matrix/data_gen.py ## @@ -102,3 +105,70 @@ def rand(sds_context: SystemDSContext, rows: int, cols: int,

[GitHub] [systemml] juliale-15 commented on pull request #975: Extend the Python API

2020-06-18 Thread GitBox
juliale-15 commented on pull request #975: URL: https://github.com/apache/systemml/pull/975#issuecomment-645926669 > Hi Juliale! > > Great job, ⭐ i like the addition, and nice to see that you also consider the invalid input cases! > I have a few comments to be addressed but

[GitHub] [systemml] Baunsgaard opened a new pull request #977: [SYSTEMDS-501] Documentation webpage framework

2020-06-18 Thread GitBox
Baunsgaard opened a new pull request #977: URL: https://github.com/apache/systemml/pull/977 The Basic documentation framework from gh-pages back on master branch removing all previous except basic design. If possible i would like that the API docs are generated and not pushed like

[GitHub] [systemml] Shafaq-Siddiqi opened a new pull request #976: [WIP]: [SYSTEMDS-200] Gaussian Mixture Model builtin

2020-06-17 Thread GitBox
Shafaq-Siddiqi opened a new pull request #976: URL: https://github.com/apache/systemml/pull/976 New Builtin for Gaussian Mixture Model with four covariance types namely VVV, EEE, diag and spherical (please see the script header for more details). Spark tests for using kmeans as

[GitHub] [systemml] Shafaq-Siddiqi closed pull request #914: [SYSTEMDS-200] Gaussian Mixture Model

2020-06-17 Thread GitBox
Shafaq-Siddiqi closed pull request #914: URL: https://github.com/apache/systemml/pull/914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [systemml] Baunsgaard commented on pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-17 Thread GitBox
Baunsgaard commented on pull request #971: URL: https://github.com/apache/systemml/pull/971#issuecomment-645418101 Also A nice SystemDS name of the PR and add it to a task inside `/docs/dev/task.txt` This is an automated

[GitHub] [systemml] Baunsgaard commented on a change in pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-17 Thread GitBox
Baunsgaard commented on a change in pull request #971: URL: https://github.com/apache/systemml/pull/971#discussion_r441597515 ## File path: src/main/java/org/apache/sysds/runtime/io/FrameWriterFactory.java ## @@ -55,6 +55,10 @@ public static FrameWriter createFrameWriter(

[GitHub] [systemml] j143 closed pull request #499: [SYSTEMML-1606] Update notebook samples with latest code

2020-06-17 Thread GitBox
j143 closed pull request #499: URL: https://github.com/apache/systemml/pull/499 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [systemml] j143 commented on pull request #499: [SYSTEMML-1606] Update notebook samples with latest code

2020-06-17 Thread GitBox
j143 commented on pull request #499: URL: https://github.com/apache/systemml/pull/499#issuecomment-645403954 Let us close this one for now. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [systemml] j143 closed pull request #949: Propose: Bring docs to master branch.

2020-06-17 Thread GitBox
j143 closed pull request #949: URL: https://github.com/apache/systemml/pull/949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [systemml] muehlburger commented on pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-17 Thread GitBox
muehlburger commented on pull request #971: URL: https://github.com/apache/systemml/pull/971#issuecomment-645366329 @Baunsgaard could you have another look at the changes? Would be happy to get your feedback! :-) This is an

[GitHub] [systemml] sebwrede commented on a change in pull request #946: Privacy Runtime Extended

2020-06-17 Thread GitBox
sebwrede commented on a change in pull request #946: URL: https://github.com/apache/systemml/pull/946#discussion_r441459421 ## File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedResponse.java ## @@ -94,10 +94,11 @@ public void

[GitHub] [systemml] Baunsgaard commented on pull request #949: Propose: Bring docs to master branch.

2020-06-17 Thread GitBox
Baunsgaard commented on pull request #949: URL: https://github.com/apache/systemml/pull/949#issuecomment-645296766 @j143, How about we then close this PR? and make an concrete design in a another PR? This is an

[GitHub] [systemml] Baunsgaard commented on a change in pull request #946: Privacy Runtime Extended

2020-06-17 Thread GitBox
Baunsgaard commented on a change in pull request #946: URL: https://github.com/apache/systemml/pull/946#discussion_r441449635 ## File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedResponse.java ## @@ -94,10 +94,11 @@ public void

[GitHub] [systemml] sebwrede commented on a change in pull request #946: Privacy Runtime Extended

2020-06-17 Thread GitBox
sebwrede commented on a change in pull request #946: URL: https://github.com/apache/systemml/pull/946#discussion_r441446884 ## File path: src/main/java/org/apache/sysds/runtime/privacy/PrivacyMonitor.java ## @@ -30,23 +30,33 @@ import

[GitHub] [systemml] sebwrede commented on a change in pull request #946: Privacy Runtime Extended

2020-06-17 Thread GitBox
sebwrede commented on a change in pull request #946: URL: https://github.com/apache/systemml/pull/946#discussion_r441442854 ## File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedResponse.java ## @@ -94,10 +94,11 @@ public void

[GitHub] [systemml] j143 commented on pull request #922: [WIP][SYSTEMML-2524] Dedicated documentation for source installation on windows

2020-06-17 Thread GitBox
j143 commented on pull request #922: URL: https://github.com/apache/systemml/pull/922#issuecomment-645288133 Yes, now we could work on a target document scheme https://github.com/apache/systemml/pull/949#issuecomment-639109432

[GitHub] [systemml] Baunsgaard commented on a change in pull request #946: Privacy Runtime Extended

2020-06-17 Thread GitBox
Baunsgaard commented on a change in pull request #946: URL: https://github.com/apache/systemml/pull/946#discussion_r441439819 ## File path: src/main/java/org/apache/sysds/runtime/privacy/PrivacyMonitor.java ## @@ -30,23 +30,33 @@ import

[GitHub] [systemml] sebwrede commented on a change in pull request #946: Privacy Runtime Extended

2020-06-17 Thread GitBox
sebwrede commented on a change in pull request #946: URL: https://github.com/apache/systemml/pull/946#discussion_r441438074 ## File path: src/main/java/org/apache/sysds/runtime/privacy/PrivacyMonitor.java ## @@ -30,23 +30,33 @@ import

[GitHub] [systemml] Baunsgaard commented on a change in pull request #922: [WIP][SYSTEMML-2524] Dedicated documentation for source installation on windows

2020-06-17 Thread GitBox
Baunsgaard commented on a change in pull request #922: URL: https://github.com/apache/systemml/pull/922#discussion_r441437582 ## File path: dev/docs/windows-source-installation.md ## @@ -0,0 +1,81 @@ +# Developing Apache SystemDS on Windows Platform + +These instructions will

[GitHub] [systemml] Baunsgaard commented on pull request #922: [WIP][SYSTEMML-2524] Dedicated documentation for source installation on windows

2020-06-17 Thread GitBox
Baunsgaard commented on pull request #922: URL: https://github.com/apache/systemml/pull/922#issuecomment-645284275 > Hi @Baunsgaard, > > 1. I just moved the `docs` folder to make room for the `gh-pages` content. > > 2. Once, it is merged we could think about how to

[GitHub] [systemml] Baunsgaard commented on a change in pull request #975: Extend the Python API

2020-06-17 Thread GitBox
Baunsgaard commented on a change in pull request #975: URL: https://github.com/apache/systemml/pull/975#discussion_r441434083 ## File path: src/main/python/systemds/matrix/data_gen.py ## @@ -102,3 +105,70 @@ def rand(sds_context: SystemDSContext, rows: int, cols: int,

[GitHub] [systemml] juliale-15 commented on a change in pull request #975: Extend the Python API

2020-06-17 Thread GitBox
juliale-15 commented on a change in pull request #975: URL: https://github.com/apache/systemml/pull/975#discussion_r441426528 ## File path: src/main/python/systemds/matrix/data_gen.py ## @@ -102,3 +105,70 @@ def rand(sds_context: SystemDSContext, rows: int, cols: int,

[GitHub] [systemml] Baunsgaard commented on a change in pull request #923: [SYSTEMDS-352] New builtin for identifying cells violating length constrain

2020-06-17 Thread GitBox
Baunsgaard commented on a change in pull request #923: URL: https://github.com/apache/systemml/pull/923#discussion_r441385213 ## File path: src/main/java/org/apache/sysds/runtime/instructions/spark/BinarySPInstruction.java ## @@ -106,7 +108,9 @@ else if (dt1 ==

[GitHub] [systemml] Baunsgaard commented on a change in pull request #946: Privacy Runtime Extended

2020-06-17 Thread GitBox
Baunsgaard commented on a change in pull request #946: URL: https://github.com/apache/systemml/pull/946#discussion_r441375740 ## File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedResponse.java ## @@ -94,10 +94,11 @@ public void

[GitHub] [systemml] Baunsgaard commented on a change in pull request #975: Extend the Python API

2020-06-16 Thread GitBox
Baunsgaard commented on a change in pull request #975: URL: https://github.com/apache/systemml/pull/975#discussion_r440771496 ## File path: src/main/python/systemds/matrix/data_gen.py ## @@ -29,6 +29,8 @@ from systemds.operator import OperationNode from systemds.context

[GitHub] [systemml] asfgit closed pull request #970: [MINOR] Add federated Prefix for statistics

2020-06-16 Thread GitBox
asfgit closed pull request #970: URL: https://github.com/apache/systemml/pull/970 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemml] Baunsgaard commented on pull request #970: [MINOR] Add federated Prefix for statistics

2020-06-16 Thread GitBox
Baunsgaard commented on pull request #970: URL: https://github.com/apache/systemml/pull/970#issuecomment-644616788 @sebwrede, Thanks i forgot about this PR, I will merge it soon. This is an automated message from the Apache

[GitHub] [systemml] Baunsgaard commented on pull request #970: [MINOR] Add federated Prefix for statistics

2020-06-16 Thread GitBox
Baunsgaard commented on pull request #970: URL: https://github.com/apache/systemml/pull/970#issuecomment-644616064 Because previously it required the whole line for the logging file. but now it has been changed to construct the `-Dlog4j.configuration=file:` part inside a variable. If you

[GitHub] [systemml] sebwrede commented on pull request #970: [MINOR] Add federated Prefix for statistics

2020-06-16 Thread GitBox
sebwrede commented on pull request #970: URL: https://github.com/apache/systemml/pull/970#issuecomment-644606246 LGTM. Why is `-Dlog4j.configuration=file:` removed? This is an automated message from the Apache Git

[GitHub] [systemml] juliale-15 opened a new pull request #975: Extend the Python API

2020-06-15 Thread GitBox
juliale-15 opened a new pull request #975: URL: https://github.com/apache/systemml/pull/975 Extend the Python API by - Trigonometric Built-In Functions such as sin, cos, tan etc - Other Build-In Functions: reverse, transpose, order - Linear Algebra Built-In Functions: Cholesky

[GitHub] [systemml] asfgit closed pull request #956: [MINOR] Fix code coverage tool

2020-06-15 Thread GitBox
asfgit closed pull request #956: URL: https://github.com/apache/systemml/pull/956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemml] Baunsgaard commented on pull request #973: [SYSTEMML-2536][WIP] Found CVEs in dependencies

2020-06-14 Thread GitBox
Baunsgaard commented on pull request #973: URL: https://github.com/apache/systemml/pull/973#issuecomment-643744787 well there are multiple issues with that. Switching to Hadoop 3.0 requires yes spark 3.0 but that is currently not in a stable release. (since December 2019). Also

[GitHub] [systemml] j143 commented on pull request #954: [DOC] Documentation for builtin intersect function

2020-06-13 Thread GitBox
j143 commented on pull request #954: URL: https://github.com/apache/systemml/pull/954#issuecomment-643718441 Thank you, @t201 - LGTM.    This is an automated message from the Apache Git Service. To respond to the

[GitHub] [systemml] j143 edited a comment on pull request #961: Documentation for Multinomial Logistic Regression using Trust Region method

2020-06-13 Thread GitBox
j143 edited a comment on pull request #961: URL: https://github.com/apache/systemml/pull/961#issuecomment-643718317 Thank you, @t201 - LGTM.    This is an automated message from the Apache Git Service. To respond to

[GitHub] [systemml] j143 commented on pull request #954: [DOC] Documentation for builtin intersect function

2020-06-13 Thread GitBox
j143 commented on pull request #954: URL: https://github.com/apache/systemml/pull/954#issuecomment-643718381 The example is not valid and hence not included. This is an automated message from the Apache Git Service. To

[GitHub] [systemml] j143 commented on pull request #969: Added documentation for imputeByFD Function

2020-06-13 Thread GitBox
j143 commented on pull request #969: URL: https://github.com/apache/systemml/pull/969#issuecomment-643718289 Thank you, @t201 - LGTM.    This is an automated message from the Apache Git Service. To respond to the

[GitHub] [systemml] j143 commented on pull request #961: Documentation for Multinomial Logistic Regression using Trust Region method

2020-06-13 Thread GitBox
j143 commented on pull request #961: URL: https://github.com/apache/systemml/pull/961#issuecomment-643718317 Thank you, @h0901 - LGTM.    This is an automated message from the Apache Git Service. To respond to the

[GitHub] [systemml] j143 commented on pull request #969: Added documentation for imputeByFD Function

2020-06-13 Thread GitBox
j143 commented on pull request #969: URL: https://github.com/apache/systemml/pull/969#issuecomment-643718272 The example provided in this PR is not valid! This is an automated message from the Apache Git Service. To respond

[GitHub] [systemml] j143 commented on pull request #947: [DOC][2/2] Documentation for builtin KMeans function

2020-06-13 Thread GitBox
j143 commented on pull request #947: URL: https://github.com/apache/systemml/pull/947#issuecomment-643718205 Hi @Baunsgaard, can you have a look at this? **Review aid:** (Just in case!)  1. [Dev notebook, `opens in google

[GitHub] [systemml] asfgit closed pull request #954: [DOC] Documentation for builtin intersect function

2020-06-13 Thread GitBox
asfgit closed pull request #954: URL: https://github.com/apache/systemml/pull/954 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemml] asfgit closed pull request #961: Documentation for Multinomial Logistic Regression using Trust Region method

2020-06-13 Thread GitBox
asfgit closed pull request #961: URL: https://github.com/apache/systemml/pull/961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemml] asfgit closed pull request #969: Added documentation for imputeByFD Function

2020-06-13 Thread GitBox
asfgit closed pull request #969: URL: https://github.com/apache/systemml/pull/969 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemml] j143 commented on pull request #973: [SYSTEMML-2536][WIP] Found CVEs in dependencies

2020-06-13 Thread GitBox
j143 commented on pull request #973: URL: https://github.com/apache/systemml/pull/973#issuecomment-643708833 - [ ] For `Spark 2.*`, only `Hadoop 2.*` seems to compatible as seen at https://spark.apache.org/downloads.html? - [ ] For `Spark 3.*` there seems to be no problem though!

[GitHub] [systemml] j143 commented on pull request #962: [DOC] Documentation for builtin cvlm function.

2020-06-13 Thread GitBox
j143 commented on pull request #962: URL: https://github.com/apache/systemml/pull/962#issuecomment-643600772 Thank you, @wizard-420 - LGTM.    This is an automated message from the Apache Git Service. To respond to

[GitHub] [systemml] asfgit closed pull request #962: [DOC] Documentation for builtin cvlm function.

2020-06-13 Thread GitBox
asfgit closed pull request #962: URL: https://github.com/apache/systemml/pull/962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemml] j143 commented on pull request #959: [DOC] Documentation for builtin image data augmentation functions

2020-06-13 Thread GitBox
j143 commented on pull request #959: URL: https://github.com/apache/systemml/pull/959#issuecomment-643599145 Thank you, @h0901 - LGTM.    This is an automated message from the Apache Git Service. To respond to the

[GitHub] [systemml] asfgit closed pull request #959: [DOC] Documentation for builtin image data augmentation functions

2020-06-13 Thread GitBox
asfgit closed pull request #959: URL: https://github.com/apache/systemml/pull/959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemml] j143 removed a comment on pull request #968: [DOC] Documentation for builtin glm function.

2020-06-13 Thread GitBox
j143 removed a comment on pull request #968: URL: https://github.com/apache/systemml/pull/968#issuecomment-64181 Thank you, Supratick! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [systemml] j143 commented on pull request #968: [DOC] Documentation for builtin glm function.

2020-06-13 Thread GitBox
j143 commented on pull request #968: URL: https://github.com/apache/systemml/pull/968#issuecomment-643596620 Thank you, @wizard-420 - LGTM.    This is an automated message from the Apache Git Service. To respond to

[GitHub] [systemml] asfgit closed pull request #968: [DOC] Documentation for builtin glm function.

2020-06-13 Thread GitBox
asfgit closed pull request #968: URL: https://github.com/apache/systemml/pull/968 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [systemml] j143 commented on pull request #942: builtins-reference.md

2020-06-13 Thread GitBox
j143 commented on pull request #942: URL: https://github.com/apache/systemml/pull/942#issuecomment-643589945 Already resolved by #936 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [systemml] j143 closed pull request #942: builtins-reference.md

2020-06-13 Thread GitBox
j143 closed pull request #942: URL: https://github.com/apache/systemml/pull/942 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [systemml] phaniarnab commented on a change in pull request #972: [MINOR] MICE now accepts a recoded matrix as input

2020-06-12 Thread GitBox
phaniarnab commented on a change in pull request #972: URL: https://github.com/apache/systemml/pull/972#discussion_r439627882 ## File path: scripts/builtin/mice.dml ## @@ -19,266 +19,176 @@ # #- -# Builtin

[GitHub] [systemml] phaniarnab commented on a change in pull request #972: [MINOR] MICE now accepts a recoded matrix as input

2020-06-12 Thread GitBox
phaniarnab commented on a change in pull request #972: URL: https://github.com/apache/systemml/pull/972#discussion_r439621028 ## File path: src/test/java/org/apache/sysds/test/functions/builtin/BuiltinMiceTest.java ## @@ -36,7 +36,7 @@ private static final String

[GitHub] [systemml] phaniarnab merged pull request #974: [SYSTEMDS-413] Cache MultiReturnBuiltin instructions

2020-06-11 Thread GitBox
phaniarnab merged pull request #974: URL: https://github.com/apache/systemml/pull/974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [systemml] phaniarnab commented on pull request #974: [SYSTEMDS-413] Cache MultiReturnBuiltin instructions

2020-06-11 Thread GitBox
phaniarnab commented on pull request #974: URL: https://github.com/apache/systemml/pull/974#issuecomment-642976880 Opened this PR to verify if tests are passing. Will merge the changes once verified. This is an automated

[GitHub] [systemml] phaniarnab opened a new pull request #974: [SYSTEMDS-413] Cache MultiReturnBuiltin instructions

2020-06-11 Thread GitBox
phaniarnab opened a new pull request #974: URL: https://github.com/apache/systemml/pull/974 This patch enables caching of multi-return instructions like eigen. Furthermore, this includes a new partial rewrite and adds PCA as a test case.

[GitHub] [systemml] muehlburger commented on a change in pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-10 Thread GitBox
muehlburger commented on a change in pull request #971: URL: https://github.com/apache/systemml/pull/971#discussion_r438322892 ## File path: pom.xml ## @@ -1021,6 +1021,25 @@ maven-gpg-plugin 1.6 + +

[GitHub] [systemml] Shafaq-Siddiqi commented on a change in pull request #972: [MINOR] MICE now accepts a recoded matrix as input

2020-06-10 Thread GitBox
Shafaq-Siddiqi commented on a change in pull request #972: URL: https://github.com/apache/systemml/pull/972#discussion_r438096170 ## File path: src/test/java/org/apache/sysds/test/functions/builtin/BuiltinMiceTest.java ## @@ -50,33 +50,47 @@ public void testMiceMixCP() {

  1   2   3   4   5   6   7   8   9   >