Re: Radio and RadioGroup as AbstractField subclasses

2011-08-25 Thread Andreas Andreou
I personnaly consider the way zone works right now in Select a hack. And btw, RadioGroup really works with that code! On Wed, Aug 24, 2011 at 14:26, Denis Stepanov wrote: > I don't really like hacks like extracting the value or calling process > submission also RadioGroup will not work because

Re: Radio and RadioGroup as AbstractField subclasses

2011-08-24 Thread Denis Stepanov
I don't really like hacks like extracting the value or calling process submission also RadioGroup will not work because it doesn't have a client id. Right now I would rather see small changes to add support for a zone param on Checkbox and RadioGroup and refactoring after 5.3. Denis Aug 24, 20

Re: Radio and RadioGroup as AbstractField subclasses

2011-08-24 Thread Andreas Andreou
I'm away on vacations so i didn't commit any code to apache svn. But you can take a look of what's involved at https://github.com/andyhot/tapestry5/commits/trunk On Tue, Aug 23, 2011 at 13:44, Denis Stepanov wrote: > I would like to have a zone param support for Chechbox and RadioGroup in 5.3. >

Re: Radio and RadioGroup as AbstractField subclasses

2011-08-23 Thread Denis Stepanov
I would like to have a zone param support for Chechbox and RadioGroup in 5.3. Will you manage to finish the refactoring into this version? Denis Aug 16, 2011 v 11:41 PM, Andreas Andreou: > :) Your patch is ok - it's basically a copy of the Select code that > did the same thing - but > what i'd

Re: Radio and RadioGroup as AbstractField subclasses

2011-08-16 Thread Thiago H. de Paula Figueiredo
On Tue, 16 Aug 2011 17:38:11 -0300, Andreas Andreou wrote: Hi, Hi! But (there's always a but!), I then noticed that Radio and RadioGroup do not extend from AbstractField, So, I'm wondering, are there any particular reason for this? Because i see a lot of the AbstractField code being d

Re: Radio and RadioGroup as AbstractField subclasses

2011-08-16 Thread Andreas Andreou
Inline - but keep in mind what i would really like to discuss here is if the radio components should extend from AbstractField. The details for supporting zone parameter in AbstractFields should be discussed in separate thread. On Wed, Aug 17, 2011 at 00:17, Denis Stepanov wrote: > Not all form f

Re: Radio and RadioGroup as AbstractField subclasses

2011-08-16 Thread Denis Stepanov
> So, anyway, i'd like to provide the zone parameter to all > AbstractField subclasses > since i don't see the need to special-case it to a particular component > and in fact i've gotten it to work quite nicely. I don't think it's a good idea. Not all form fields support zone update, TextField do

Radio and RadioGroup as AbstractField subclasses

2011-08-16 Thread Andreas Andreou
Hi, I've started work on TAP5-1602 (Add Zone parameter to Checkbox component) and it's been an interesting learning experience (it's really the first time i'm going over such big part of the T5 codebase) - so, keep that in mind, it should explain my ignorance in a few cases! So, anyway, i'd like t