Hey,
Are C++ coding standards for thrift defined anywhere? I see that lib/cpp
looks like this 'ClassName::methodName' but compiler code look more like
't_class_name::method_name'. I definitely prefer first style, but
currently I'm playing around compiler. Can I use 'lib' style, assuming
Hey Konrad
We do not have a definitive style guide, but overall we try and keep
everything formatted in a similar style for the given lib that is being
worked on. As the compiler starts to move towards more stdlib standards use
I would agree that using the 'ClassName::methodName' style would be
I haven't seen any explicit coding standards. I have a minor preference
for using whatever the local style already is, but it isn't a large
concern of mine.
Konrad Grochowski hc...@minions.org.pl wrote on 09/26/2014 08:03:45 AM:
From: Konrad Grochowski hc...@minions.org.pl
To:
Konrad Grochowski created THRIFT-2724:
-
Summary: Coding standards page
Key: THRIFT-2724
URL: https://issues.apache.org/jira/browse/THRIFT-2724
Project: Thrift
Issue Type: Improvement
That's what I also tried, but compiler is much different from lib, so I
just wanted to be sure that lib is 'future'.
Issue created :)
-kg
W dniu 2014-09-26 15:28, Ben Craig pisze:
I haven't seen any explicit coding standards. I have a minor preference
for using whatever the local style
[
https://issues.apache.org/jira/browse/THRIFT-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149156#comment-14149156
]
Jake Farrell commented on THRIFT-2724:
--
Great idea, so far we try and stay to the
Konrad Grochowski created THRIFT-2728:
-
Summary: C# coding standards
Key: THRIFT-2728
URL: https://issues.apache.org/jira/browse/THRIFT-2728
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2726:
-
Summary: AS3 coding standards
Key: THRIFT-2726
URL: https://issues.apache.org/jira/browse/THRIFT-2726
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2729:
-
Summary: C++ coding standards
Key: THRIFT-2729
URL: https://issues.apache.org/jira/browse/THRIFT-2729
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2731:
-
Summary: D coding standards
Key: THRIFT-2731
URL: https://issues.apache.org/jira/browse/THRIFT-2731
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2733:
-
Summary: Erlang coding standards
Key: THRIFT-2733
URL: https://issues.apache.org/jira/browse/THRIFT-2733
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2730:
-
Summary: Cocoa coding standards
Key: THRIFT-2730
URL: https://issues.apache.org/jira/browse/THRIFT-2730
Project: Thrift
Issue Type: Sub-task
I think this is already reported.
https://issues.apache.org/jira/browse/THRIFT-2626
On Fri, Sep 26, 2014 at 7:16 PM, Konrad Grochowski (JIRA) j...@apache.org
wrote:
Konrad Grochowski created THRIFT-2724:
-
Summary: Coding standards page
Konrad Grochowski created THRIFT-2732:
-
Summary: Delphi coding standards
Key: THRIFT-2732
URL: https://issues.apache.org/jira/browse/THRIFT-2732
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2736:
-
Summary: haxe coding standards
Key: THRIFT-2736
URL: https://issues.apache.org/jira/browse/THRIFT-2736
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2738:
-
Summary: JS coding standards
Key: THRIFT-2738
URL: https://issues.apache.org/jira/browse/THRIFT-2738
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2735:
-
Summary: Haskell coding standards
Key: THRIFT-2735
URL: https://issues.apache.org/jira/browse/THRIFT-2735
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2737:
-
Summary: Java coding standards
Key: THRIFT-2737
URL: https://issues.apache.org/jira/browse/THRIFT-2737
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2739:
-
Summary: OCaml coding standards
Key: THRIFT-2739
URL: https://issues.apache.org/jira/browse/THRIFT-2739
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2734:
-
Summary: Go coding standards
Key: THRIFT-2734
URL: https://issues.apache.org/jira/browse/THRIFT-2734
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2743:
-
Summary: Smalltalk coding standards
Key: THRIFT-2743
URL: https://issues.apache.org/jira/browse/THRIFT-2743
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2740:
-
Summary: Perl coding standards
Key: THRIFT-2740
URL: https://issues.apache.org/jira/browse/THRIFT-2740
Project: Thrift
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/THRIFT-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2736:
--
Summary: Haxe coding standards (was: haxe coding standards)
Haxe coding standards
Konrad Grochowski created THRIFT-2742:
-
Summary: Ruby coding standards
Key: THRIFT-2742
URL: https://issues.apache.org/jira/browse/THRIFT-2742
Project: Thrift
Issue Type: Sub-task
Konrad Grochowski created THRIFT-2741:
-
Summary: Python coding standards
Key: THRIFT-2741
URL: https://issues.apache.org/jira/browse/THRIFT-2741
Project: Thrift
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/THRIFT-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149172#comment-14149172
]
Konrad Grochowski commented on THRIFT-2626:
---
linked with THRIFT-2724 - I've
[
https://issues.apache.org/jira/browse/THRIFT-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149173#comment-14149173
]
Konrad Grochowski commented on THRIFT-2724:
---
comments from THRIFT-2626 suggests
[
https://issues.apache.org/jira/browse/THRIFT-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2726:
--
Component/s: AS3 - Library
AS3 coding standards
[
https://issues.apache.org/jira/browse/THRIFT-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2727:
--
Component/s: C glib - Library
C glib coding standards
---
[
https://issues.apache.org/jira/browse/THRIFT-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2728:
--
Component/s: C# - Library
C# coding standards
---
[
https://issues.apache.org/jira/browse/THRIFT-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2730:
--
Component/s: Cocoa - Library
Cocoa coding standards
--
[
https://issues.apache.org/jira/browse/THRIFT-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2733:
--
Component/s: Erlang - Library
Erlang coding standards
---
[
https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2729:
--
Component/s: C++ - Library
C++ coding standards
[
https://issues.apache.org/jira/browse/THRIFT-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2731:
--
Component/s: D - Library
D coding standards
--
[
https://issues.apache.org/jira/browse/THRIFT-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2732:
--
Component/s: Delphi - Library
Delphi coding standards
---
[
https://issues.apache.org/jira/browse/THRIFT-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2736:
--
Component/s: Haxe - Library
Haxe coding standards
-
[
https://issues.apache.org/jira/browse/THRIFT-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2740:
--
Component/s: Perl - Library
Perl coding standards
-
[
https://issues.apache.org/jira/browse/THRIFT-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2737:
--
Component/s: JavaME - Library
Java coding standards
-
[
https://issues.apache.org/jira/browse/THRIFT-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2737:
--
Component/s: Java - Library
Java coding standards
-
[
https://issues.apache.org/jira/browse/THRIFT-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2734:
--
Component/s: Go - Library
Go coding standards
---
[
https://issues.apache.org/jira/browse/THRIFT-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2735:
--
Component/s: Haskell - Library
Haskell coding standards
[
https://issues.apache.org/jira/browse/THRIFT-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2738:
--
Component/s: Node.js - Library
JavaScript - Library
JS coding
[
https://issues.apache.org/jira/browse/THRIFT-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2742:
--
Component/s: Ruby - Library
Ruby coding standards
-
[
https://issues.apache.org/jira/browse/THRIFT-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2741:
--
Component/s: Python - Library
Python coding standards
---
[
https://issues.apache.org/jira/browse/THRIFT-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Grochowski updated THRIFT-2743:
--
Component/s: Smalltalk - Library
Smalltalk coding standards
I think this veers off into territory that should be avoided for this project.
I am not against having coding standards. Not at all. But Thrift is a fairly
mature product. Disregarding new language support, I suspect that the bulk of
the future coding required will be bug fixes. If that is
That was exactly what I felt.
Von: Rush Manbert
Gesendet: 26.09.2014 17:44
An: dev@thrift.apache.org
Betreff: Re: C++ coding standards
I think this veers off into territory that should be avoided for this project.
I am not against having coding standards. Not at
That doesn't mean that we shouldn't have coding standards. It does
suggest that the coding standards should encode existing practice, and
shouldn't try to change the status quo too much.
Jens Geyer jensge...@hotmail.com wrote on 09/26/2014 11:33:06 AM:
From: Jens Geyer jensge...@hotmail.com
I am in particular agreement with the don't edit working code to
conform with style in the compiler and perhaps in compiled languages
in general. However in languages that are interpreted, often the
interpreter will accept really bad or even erroneous code which will
fail to execute (but only if
Hi Konrad,
for C#, Go and Haxe the IDEs and/or toolchains (gofmt) already a certain style
that is commonly accepted. Especially for Go it is a deliberate part of the
design. Would that suffice or do we need just another doc?
Where I agree is Delphi, because the Emba style guide and defaults
Oh, I really hope, that for most langs, standards will be like Please
follow default settings/guidelines for XYZ lang, found at:
http://go.to.xyz.manual.com;. I've just added all those tasks for
consistency. Especially if we're going with Roger's suggestion about
lib/$lang/ReadMe.md - then it
I agree that editing code only to match changed coding standards is
unnecessary (mostly because it disrupts 'git blame' ;) ), but that
doesn't mean that new parts should keep to old ugly, inconsistent style.
I really believe in importance of constant refactoring and maintenance,
and that
[
https://issues.apache.org/jira/browse/THRIFT-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
alisdair sullivan updated THRIFT-2721:
--
Fix Version/s: (was: 0.9.2)
1.0
generate more idiomatic erlang
[
https://issues.apache.org/jira/browse/THRIFT-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150363#comment-14150363
]
alisdair sullivan commented on THRIFT-2721:
---
this should probably wait until
54 matches
Mail list logo
