Shaun Lindsay created THRIFT-2948:
-
Summary: Python TJSONProtocol doesn't handle structs with binary
fields containing invalid unicode.
Key: THRIFT-2948
URL: https://issues.apache.org/jira/browse/THRIFT-2948
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r2773
--- Diff: lib/cpp/src/thrift/protocol/TProtocolTypes.h ---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
[
https://issues.apache.org/jira/browse/THRIFT-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285937#comment-14285937
]
Luca Sacchi commented on THRIFT-2942:
-
Thankyou Jens, nice clean fix.
Luca
> CSharp
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23308416
--- Diff: lib/cpp/src/thrift/protocol/TProtocol.h ---
@@ -659,6 +659,11 @@ class TProtocolFactory {
virtual ~TProtocolFactory() {}
virtua
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23307653
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.h ---
@@ -0,0 +1,308 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user djwatson commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23307400
--- Diff: lib/cpp/src/thrift/protocol/TProtocol.h ---
@@ -659,6 +659,11 @@ class TProtocolFactory {
virtual ~TProtocolFactory() {}
virtual
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23305256
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.h ---
@@ -0,0 +1,308 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23305046
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.h ---
@@ -0,0 +1,308 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23305015
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.h ---
@@ -0,0 +1,308 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23304519
--- Diff: lib/cpp/src/thrift/protocol/TProtocol.h ---
@@ -659,6 +659,11 @@ class TProtocolFactory {
virtual ~TProtocolFactory() {}
virtua
10 matches
Mail list logo