[jira] [Commented] (THRIFT-3295) C# library does not build on Mono 4.0.2.5 or later

2015-09-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729619#comment-14729619 ] ASF GitHub Bot commented on THRIFT-3295: Github user asfgit closed the pull request at:

[GitHub] thrift pull request: THRIFT-3310 - lib/erl/README.md has incorrect...

2015-09-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3310) lib/erl/README.md has incorrect formatting

2015-09-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729577#comment-14729577 ] ASF GitHub Bot commented on THRIFT-3310: Github user asfgit closed the pull request at:

[jira] [Closed] (THRIFT-3310) lib/erl/README.md has incorrect formatting

2015-09-03 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-3310. -- > lib/erl/README.md has incorrect formatting > -- > >

[jira] [Resolved] (THRIFT-3310) lib/erl/README.md has incorrect formatting

2015-09-03 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3310. Resolution: Fixed Fix Version/s: 0.9.3 Comitted, thanks! > lib/erl/README.md has incorrect

[jira] [Updated] (THRIFT-3295) C# library does not build on Mono 4.0.2.5 or later

2015-09-03 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3295: --- Assignee: Nobuaki Sukegawa (was: Jens Geyer) > C# library does not build on Mono 4.0.2.5 or later >

[jira] [Resolved] (THRIFT-3295) C# library does not build on Mono 4.0.2.5 or later

2015-09-03 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3295. Resolution: Fixed Fix Version/s: 0.9.3 Committed, many thanks. > C# library does not build

[jira] [Comment Edited] (THRIFT-3302) Go JSON protocol should encode Thrift byte type as signed integer string

2015-09-03 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729656#comment-14729656 ] Jens Geyer edited comment on THRIFT-3302 at 9/3/15 7:44 PM: Why don't we

[jira] [Commented] (THRIFT-3302) Go JSON protocol should encode Thrift byte type as signed integer string

2015-09-03 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729656#comment-14729656 ] Jens Geyer commented on THRIFT-3302: Why don't we change the {{WriteByte(byte)}} methods into

[jira] [Updated] (THRIFT-3310) lib/erl/README.md has incorrect formatting

2015-09-03 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3310: --- Assignee: chris snow (was: Jens Geyer) > lib/erl/README.md has incorrect formatting >

[GitHub] thrift pull request: THRIFT-3295 C# library does not build on Mono...

2015-09-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/586 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3310) lib/erl/README.md has incorrect formatting

2015-09-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729690#comment-14729690 ] Hudson commented on THRIFT-3310: SUCCESS: Integrated in Thrift #1650 (See

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-03 Thread snikulov
Github user snikulov commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38620073 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test)

Re: Thrift // CMake build system state

2015-09-03 Thread Sergei Nikulov
Hello Jake, I see some decision to support both versions - static and dynamic in one build. Then we struggle with strange macroses like LINK_AGAINST... and make build scripts more and more complicated. Perhaps, the better way use BUILD_SHARED_LIBS option instead. Who have clean vision about

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-03 Thread snikulov
Github user snikulov commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38619873 --- Diff: build/cmake/DefineOptions.cmake --- @@ -62,8 +62,10 @@ endif() find_package(OpenSSL QUIET) CMAKE_DEPENDENT_OPTION(WITH_OPENSSL "Build

[jira] [Created] (THRIFT-3314) Dots in file names of includes causes dots in javascript variable names

2015-09-03 Thread Matt Fysh (JIRA)
Matt Fysh created THRIFT-3314: - Summary: Dots in file names of includes causes dots in javascript variable names Key: THRIFT-3314 URL: https://issues.apache.org/jira/browse/THRIFT-3314 Project: Thrift