[GitHub] thrift pull request: Fixed MinGW-w64 build && boost/functional con...

2015-09-27 Thread becrux
GitHub user becrux opened a pull request: https://github.com/apache/thrift/pull/628 Fixed MinGW-w64 build && boost/functional conflict Fixed MinGW-w64 build Fixed Boost - TR1 conflict You can merge this pull request into a Git repository by running: $ git pull https://githu

[jira] [Commented] (THRIFT-3357) Additional java compiler option to generate EnumSet/EnumMap where elements/keys are enums

2015-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909863#comment-14909863 ] ASF GitHub Bot commented on THRIFT-3357: Github user afds commented on the pull r

[GitHub] thrift pull request: THRIFT-3357: enum_containers option to genera...

2015-09-27 Thread afds
Github user afds commented on the pull request: https://github.com/apache/thrift/pull/627#issuecomment-143589859 I'm perfectly fine to make it default. Theoretically possible issues is that someone heavily relies on HashMap/HashSet or uses _null_ keys/elements (EnumMap/EnumSet

[jira] [Commented] (THRIFT-3357) Additional java compiler option to generate EnumSet/EnumMap where elements/keys are enums

2015-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909786#comment-14909786 ] ASF GitHub Bot commented on THRIFT-3357: Github user Jens-G commented on a diff i

[GitHub] thrift pull request: THRIFT-3357: enum_containers option to genera...

2015-09-27 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/627#discussion_r40506016 --- Diff: compiler/cpp/src/generate/t_java_generator.cc --- @@ -5139,8 +5215,11 @@ THRIFT_REGISTER_GENERATOR( "reuse-objects: Data objects will n

[jira] [Commented] (THRIFT-3359) Binary field incompatibilities

2015-09-27 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909780#comment-14909780 ] Jens Geyer commented on THRIFT-3359: Hard to believe C++ should be incompatible. Can

[jira] [Created] (THRIFT-3360) Improve cross test servers and clients further

2015-09-27 Thread Nobuaki Sukegawa (JIRA)
Nobuaki Sukegawa created THRIFT-3360: Summary: Improve cross test servers and clients further Key: THRIFT-3360 URL: https://issues.apache.org/jira/browse/THRIFT-3360 Project: Thrift Issue

[jira] [Created] (THRIFT-3359) Binary field incompatibilities

2015-09-27 Thread Nobuaki Sukegawa (JIRA)
Nobuaki Sukegawa created THRIFT-3359: Summary: Binary field incompatibilities Key: THRIFT-3359 URL: https://issues.apache.org/jira/browse/THRIFT-3359 Project: Thrift Issue Type: Bug