[GitHub] thrift pull request: THRIFT-3386 misc. warnings with make check

GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/751 THRIFT-3386 misc. warnings with make check At long last, here's a patch that adds explicit casts to the C (GLib) test code to prevent compiler warnings during `make check`. You can merge this pu

[jira] [Commented] (THRIFT-3386) misc. warnings with make check

[ https://issues.apache.org/jira/browse/THRIFT-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065914#comment-15065914 ] ASF GitHub Bot commented on THRIFT-3386: GitHub user simonsouth opened a pull req

Re: proposed changes to haskell cabal configure flags

Thank you Nobuaki, I'll create a PR including the changes you suggested. It may take a few weeks to find the time to test your suggestions, but apart from that, hopefully there won't be any problems. Thanks, Sam On Sun, Dec 20, 2015 at 5:08 PM, Nobuaki Sukegawa wrote: > Hi Sam, > > It looks qu

[jira] [Commented] (THRIFT-2994) Node.js TJSONProtocol cannot be used for object serialization.

[ https://issues.apache.org/jira/browse/THRIFT-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065767#comment-15065767 ] ASF GitHub Bot commented on THRIFT-2994: Github user timse commented on a diff in

[GitHub] thrift pull request: THRIFT-2994: Fix TJsonProtocol for nodejs

Github user timse commented on a diff in the pull request: https://github.com/apache/thrift/pull/379#discussion_r48103666 --- Diff: lib/nodejs/lib/thrift/json_protocol.js --- @@ -89,9 +89,16 @@ TJSONProtocol.RType.set = Type.SET; TJSONProtocol.Version = 1; TJSONProto

[jira] [Commented] (THRIFT-2994) Node.js TJSONProtocol cannot be used for object serialization.

[ https://issues.apache.org/jira/browse/THRIFT-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065763#comment-15065763 ] ASF GitHub Bot commented on THRIFT-2994: Github user timse commented on a diff in

[GitHub] thrift pull request: THRIFT-2994: Fix TJsonProtocol for nodejs

Github user timse commented on a diff in the pull request: https://github.com/apache/thrift/pull/379#discussion_r48103629 --- Diff: lib/nodejs/lib/thrift/json_protocol.js --- @@ -89,9 +89,16 @@ TJSONProtocol.RType.set = Type.SET; TJSONProtocol.Version = 1; TJSONProto

[jira] [Commented] (THRIFT-2994) Node.js TJSONProtocol cannot be used for object serialization.

[ https://issues.apache.org/jira/browse/THRIFT-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065737#comment-15065737 ] ASF GitHub Bot commented on THRIFT-2994: Github user nsuke commented on a diff in

[GitHub] thrift pull request: THRIFT-2994: Fix TJsonProtocol for nodejs

Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/379#discussion_r48103125 --- Diff: lib/nodejs/lib/thrift/json_protocol.js --- @@ -89,9 +89,16 @@ TJSONProtocol.RType.set = Type.SET; TJSONProtocol.Version = 1; TJSONProto

[GitHub] thrift pull request: THRIFT-3495 Minor enhancements and fixes for ...

GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/750 THRIFT-3495 Minor enhancements and fixes for cross test You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3495 Alternatively yo

[jira] [Commented] (THRIFT-3495) Minor enhancements and fixes for cross test

[ https://issues.apache.org/jira/browse/THRIFT-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065734#comment-15065734 ] ASF GitHub Bot commented on THRIFT-3495: GitHub user nsuke opened a pull request:

[jira] [Created] (THRIFT-3495) Minor enhancements and fixes for cross test

Aki Sukegawa created THRIFT-3495: Summary: Minor enhancements and fixes for cross test Key: THRIFT-3495 URL: https://issues.apache.org/jira/browse/THRIFT-3495 Project: Thrift Issue Type: Impr

[jira] [Commented] (THRIFT-2869) JSON: run schema validation from tests

[ https://issues.apache.org/jira/browse/THRIFT-2869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065717#comment-15065717 ] ASF GitHub Bot commented on THRIFT-2869: Github user nsuke commented on a diff in

[GitHub] thrift pull request: THRIFT-2869: Run JSON schema validator from t...

Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/299#discussion_r48102430 --- Diff: lib/json/schema.json --- @@ -20,66 +21,78 @@ "map", "union", "struct", -"exception", "b

[GitHub] thrift pull request: Thrift 2869 redux

GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/749 Thrift 2869 redux You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-2869 Alternatively you can review and apply these changes a