Build failed in Jenkins: thrift #598

2016-02-02 Thread gmcdonald
See Changes: [nsuke] Update OpenSSL version for Appveyor build [nsuke] Adjust Python SSL test delay in an attempt to avoid flakiness on CI [nsuke] THRIFT-3592 Add basic test client --

[jira] [Commented] (THRIFT-3593) Add new IDL keyword 'signal' to be able that a server can actively send messages to all its connected clients to prevent polling

2016-02-02 Thread Sebastian Zenker (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128908#comment-15128908 ] Sebastian Zenker commented on THRIFT-3593: -- THRIFT-2287 - Is similar but different to my feature

[jira] [Commented] (THRIFT-3595) Perl Bindings: Set serialization/deserialization differs

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127901#comment-15127901 ] ASF GitHub Bot commented on THRIFT-3595: GitHub user amillerchip opened a pull request:

[GitHub] thrift pull request: THRIFT-3595 Perl: Unify implementation of set...

2016-02-02 Thread amillerchip
GitHub user amillerchip opened a pull request: https://github.com/apache/thrift/pull/831 THRIFT-3595 Perl: Unify implementation of set as a hashref https://issues.apache.org/jira/browse/THRIFT-3595 You can merge this pull request into a Git repository by running: $ git pull

[jira] [Updated] (THRIFT-3595) Perl Bindings: Set serialization/deserialization differs

2016-02-02 Thread Adam Millerchip (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Millerchip updated THRIFT-3595: Summary: Perl Bindings: Set serialization/deserialization differs (was: Perl Bindings:

[jira] [Updated] (THRIFT-3595) Perl Bindings: Set serialization/deserialization differs

2016-02-02 Thread Adam Millerchip (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Millerchip updated THRIFT-3595: Patch Info: Patch Available Description: In the Perl bindings, a Thrift Set is

[jira] [Commented] (THRIFT-3592) Add basic test client

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128455#comment-15128455 ] ASF GitHub Bot commented on THRIFT-3592: Github user asfgit closed the pull request at:

[GitHub] thrift pull request: THRIFT-3592 Add basic test client

2016-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/830 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3585) compact protocol implement of lua for thrift.

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128535#comment-15128535 ] ASF GitHub Bot commented on THRIFT-3585: Github user nsuke commented on the pull request:

[GitHub] thrift pull request: THRIFT-3585 Lua: compact protocol implement o...

2016-02-02 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/828#issuecomment-178683522 Tested with `test/lua/test_basic_client.lua` and found several problems. Examples of problematic valus were negative i8 values (-128 ~ -1), some i32 values

[jira] [Created] (THRIFT-3596) Better conformance to PEP8

2016-02-02 Thread Aki Sukegawa (JIRA)
Aki Sukegawa created THRIFT-3596: Summary: Better conformance to PEP8 Key: THRIFT-3596 URL: https://issues.apache.org/jira/browse/THRIFT-3596 Project: Thrift Issue Type: Improvement

[GitHub] thrift pull request: THRIFT-3596 Better conformance to PEP8

2016-02-02 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/832 THRIFT-3596 Better conformance to PEP8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3596 Alternatively you can review and

[jira] [Commented] (THRIFT-3596) Better conformance to PEP8

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128557#comment-15128557 ] ASF GitHub Bot commented on THRIFT-3596: GitHub user nsuke opened a pull request:

[jira] [Updated] (THRIFT-3592) Add basic test client

2016-02-02 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa updated THRIFT-3592: - Fix Version/s: 0.9.4 > Add basic test client > - > > Key:

[jira] [Resolved] (THRIFT-3592) Add basic test client

2016-02-02 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3592. -- Resolution: Fixed > Add basic test client > - > > Key:

[GitHub] thrift pull request: THRIFT-3584 Lua: To check element of self whe...

2016-02-02 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/826#issuecomment-178662632 While it might fix a problem in sending `false` from Lua, combined send + receive test does not seem to work even with this fix. Do you want to fix reading side too

[GitHub] thrift pull request: THRIFT-3585 Lua: compact protocol implement o...

2016-02-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/828#discussion_r51591170 --- Diff: lib/lua/src/luabpack.c --- @@ -103,7 +104,7 @@ static int l_bunpack(lua_State *L) { const char *code = luaL_checkstring(L, 1);

[jira] [Updated] (THRIFT-3596) Better conformance to PEP8

2016-02-02 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa updated THRIFT-3596: - Description: py coding_standards.md states it follows PEP8 but currently it does not do so at

[jira] [Commented] (THRIFT-3584) the value(false) for parameter self.argBool will be lost when condition is 'if self.argBool then' .

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128470#comment-15128470 ] ASF GitHub Bot commented on THRIFT-3584: Github user nsuke commented on the pull request:

[jira] [Commented] (THRIFT-3585) compact protocol implement of lua for thrift.

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128485#comment-15128485 ] ASF GitHub Bot commented on THRIFT-3585: Github user nsuke commented on a diff in the pull

Re: [PROPOSAL] Immutable java codegen

2016-02-02 Thread John Sirois
On Thu, Jan 28, 2016 at 11:15 AM, John Sirois wrote: > > > On Thu, Jan 28, 2016 at 11:04 AM, BCG wrote: > >> On 01/28/2016 12:06 PM, John Sirois wrote: >> >>> I've filed an issue that proposes either adding an option to the `java` >>> gen >>> lang or

[jira] [Commented] (THRIFT-3485) thrift NPM package includes whole thrift repository, is 30 megabytes

2016-02-02 Thread Charles Pritchard (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129955#comment-15129955 ] Charles Pritchard commented on THRIFT-3485: --- Looking for an estimate as to when this update

[jira] [Commented] (THRIFT-3584) the value(false) for parameter self.argBool will be lost when condition is 'if self.argBool then' .

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129651#comment-15129651 ] ASF GitHub Bot commented on THRIFT-3584: Github user mygityf commented on the pull request:

[GitHub] thrift pull request: THRIFT-3584 Lua: To check element of self whe...

2016-02-02 Thread mygityf
Github user mygityf commented on the pull request: https://github.com/apache/thrift/pull/826#issuecomment-178964162 To read a field by field id instead of argument of 'self ' in reading side. The problem can not be reproduced in reading side. --- If your project is set up for it,