Re: Dart Tutorial build fails with Error 65

2016-06-14 Thread Mark Erickson
hmm, is it failing in a different subdirectory now (not client) ? On Tue, Jun 14, 2016 at 5:24 PM, Jens Geyer wrote: > > But "make all" still fails with error 65? > > > -Ursprüngliche Nachricht- From: Mark Erickson > Sent: Tuesday, June 14, 2016 11:33 PM > > To:

Re: Dart Tutorial build fails with Error 65

2016-06-14 Thread Jens Geyer
But "make all" still fails with error 65? -Ursprüngliche Nachricht- From: Mark Erickson Sent: Tuesday, June 14, 2016 11:33 PM To: Thrift-Dev Subject: Re: Dart Tutorial build fails with Error 65 It looks like it worked now. I'd say that we probably need to remove stale generated

[jira] [Commented] (THRIFT-3753) TServerFramework::stop may fail to interrupt connected clients

2016-06-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330697#comment-15330697 ] ASF GitHub Bot commented on THRIFT-3753: Github user tpcwang commented on the issue:

[GitHub] thrift issue #959: THRIFT-3753 Fixed a race condition in TServerFramework::s...

2016-06-14 Thread tpcwang
Github user tpcwang commented on the issue: https://github.com/apache/thrift/pull/959 @jeking3 Thanks for catching it. It is rebased correctly now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: Dart Tutorial build fails with Error 65

2016-06-14 Thread Mark Erickson
On second thought, `git clean` probably isn't the best mechanism, since it could lead to unintended deletion of files during development. But we can remove pubspec.lock, .packages, packages/ and web/packages/ (any packages directory or subdirectory) in Makefile.am clean-local. Mark On Tue, Jun

Re: Dart Tutorial build fails with Error 65

2016-06-14 Thread Mark Erickson
It looks like it worked now. I'd say that we probably need to remove stale generated code as part of the clean step in the Makefile, e.g. via `git clean -xdf`. Mark On Tue, Jun 14, 2016 at 4:28 PM, Jens Geyer wrote: > Hi Mark, > > see below. What does that tell us? > >

Re: Dart Tutorial build fails with Error 65

2016-06-14 Thread Jens Geyer
Hi Mark, see below. What does that tell us? $ cd tutorial/dart/client/ $ pub get Resolving dependencies... The pubspec for thrift 0.1.0 from path has version 1.0.0-dev. $ git clean -xdf Lösche .packages Lösche packages/ Lösche pubspec.lock Lösche web/packages $ pub get Resolving

Re: Dart Tutorial build fails with Error 65

2016-06-14 Thread Mark Erickson
Hi Jens, It looks like it's failing on running `pub get` within tutorial/dart/client. It's working for me, but I'm curious what you see differently from what I see here: (thrift)thrift$ cd tutorial/dart/client/ (thrift)client$ pub get Resolving dependencies... Got dependencies! (thrift)client$

[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata

2016-06-14 Thread Steve Cohen (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330635#comment-15330635 ] Steve Cohen commented on THRIFT-3834: - [~jensg] My next submission will definitely be a PR, it's nice

[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata

2016-06-14 Thread Steve Cohen (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330633#comment-15330633 ] Steve Cohen commented on THRIFT-3834: - Thanks for your patience. > Erlang namespacing and exception

[jira] [Updated] (THRIFT-1676) As a user of TNonBlockingServer, I want the option to bind to a specific interface to service requests

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-1676: --- Summary: As a user of TNonBlockingServer, I want the option to bind to a specific

[GitHub] thrift issue #959: THRIFT-3753 Fixed a race condition in TServerFramework::s...

2016-06-14 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/959 I recommend you rebase this against origin/master because the list of commits above leads me to believe it wasn't on origin/master to begin with, and the fix should be small. Plus this will re-run

[jira] [Commented] (THRIFT-3753) TServerFramework::stop may fail to interrupt connected clients

2016-06-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330632#comment-15330632 ] ASF GitHub Bot commented on THRIFT-3753: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-1676) As a user of TNonBlockingServer, I want the option to bind to a specific interface to service requests

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330611#comment-15330611 ] James E. King, III commented on THRIFT-1676: My guess is the changes applied for THRIFT-1025

[jira] [Updated] (THRIFT-1676) As a user of TNonBlockingServer, I want to allow it to bind to a specific interface to service requests

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-1676: --- Summary: As a user of TNonBlockingServer, I want to allow it to bind to a specific

[jira] [Updated] (THRIFT-1676) Allow specifying IP/hostname in TServer::serve; implement in TNonBlockingServer

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-1676: --- Summary: Allow specifying IP/hostname in TServer::serve; implement in

[jira] [Closed] (THRIFT-2977) C++ Non-blocking server core dump - signal 6

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-2977. -- Resolution: Unresolved Assignee: James E. King, III I am closing this because we

[jira] [Updated] (THRIFT-2977) C++ Non-blocking server core dump - signal 6

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2977: --- Issue Type: Question (was: Bug) > C++ Non-blocking server core dump - signal 6 >

[jira] [Commented] (THRIFT-3228) Fix TAutoOverlapThread may reference released memory

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330593#comment-15330593 ] James E. King, III commented on THRIFT-3228: Does the priority of critical still make sense

[jira] [Commented] (THRIFT-3238) Fix TNamedPipeServer can be interrupted by faulty client

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330590#comment-15330590 ] James E. King, III commented on THRIFT-3238: Does the priority of critical still make sense

[jira] [Commented] (THRIFT-3821) TMemoryBuffer buffer may overflow when resizing

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330589#comment-15330589 ] James E. King, III commented on THRIFT-3821: How likely is this to occur in the field? It

[jira] [Updated] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3768: --- Priority: Critical (was: Major) > TThreadedServer may crash if it is destroyed

[jira] [Updated] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3768: --- Priority: Major (was: Minor) > TThreadedServer may crash if it is destroyed

[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata

2016-06-14 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330483#comment-15330483 ] Jens Geyer commented on THRIFT-3834: We consider moving to PR only. the benefit is that we get the

[jira] [Resolved] (THRIFT-3233) Fix C++ ThreadManager::Impl::removeWorker worker join

2016-06-14 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3233. Resolution: Fixed Fix Version/s: 0.10.0 Committed. > Fix C++

Dart Tutorial build fails with Error 65

2016-06-14 Thread Jens Geyer
Hi Darties, any idea what I’m doing wrong? This is the result of “make all” with current stable dart version. + thrift 1.0.0-dev from path ../../../../lib/dart Downloading source_span 1.2.3... Downloading stack_trace 1.6.5... Changed 13 dependencies! cd gen-dart/shared;

[GitHub] thrift pull request #1027: THRIFT-3834 Erlang namespacing and exception meta...

2016-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1027 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3233) Fix C++ ThreadManager::Impl::removeWorker worker join

2016-06-14 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330269#comment-15330269 ] Jens Geyer commented on THRIFT-3233: Looking at it. > Fix C++ ThreadManager::Impl::removeWorker

[jira] [Commented] (THRIFT-3233) Fix C++ ThreadManager::Impl::removeWorker worker join

2016-06-14 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330267#comment-15330267 ] Jens Geyer commented on THRIFT-3233: Looking at it. > Fix C++ ThreadManager::Impl::removeWorker

[jira] [Commented] (THRIFT-3853) Transport to a child process established ad hoc (using stdin/stdout).

2016-06-14 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330199#comment-15330199 ] Jens Geyer commented on THRIFT-3853: Hi [~mjo], thanks for the patch. (1) IIRC this can be done

Android-specific codegen and runtime proposal

2016-06-14 Thread Ben Bader
Hi Thrift devs, I maintain a Thrift implementation that is specialized for Android (https://github.com/Microsoft/thrifty), and am curious if there is any interest in accepting something like this in Apache Thrift. I’ll try to be brief and summarize. Briefly, on Android we have a system

[jira] [Updated] (THRIFT-3853) Transport to a child process established ad hoc (using stdin/stdout).

2016-06-14 Thread Mariusz Ornowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mariusz Ornowski updated THRIFT-3853: - Attachment: thrift-3853-lib-cpp-child-process-transport.patch Patch proposal. >

[jira] [Created] (THRIFT-3853) Transport to a child process established ad hoc (using stdin/stdout).

2016-06-14 Thread Mariusz Ornowski (JIRA)
Mariusz Ornowski created THRIFT-3853: Summary: Transport to a child process established ad hoc (using stdin/stdout). Key: THRIFT-3853 URL: https://issues.apache.org/jira/browse/THRIFT-3853

[GitHub] thrift issue #1014: Thrift 3839

2016-06-14 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1014 Please rebase your pull request against origin/master. The build may not be 100% stabilized but we removed the offending Jenkins build that was constantly failing. 2 out of my 3 open pull

Pull request backlog

2016-06-14 Thread Jim King
We have 106 total open pull requests, some from 2014. Every one of them that I looked at (that passed a build at the time) have merge conflicts. We really need to get a handle on this. I found some that have been marked as closed, fixed but the pull request is still open, like:

[jira] [Reopened] (THRIFT-3826) Appveyor builds cannot download winflexbison properly

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reopened THRIFT-3826: This busted https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/364

[jira] [Commented] (THRIFT-3233) Fix C++ ThreadManager::Impl::removeWorker worker join

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329391#comment-15329391 ] James E. King, III commented on THRIFT-3233: The latest build passed fully. Please merge

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

2016-06-14 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329390#comment-15329390 ] James E. King, III commented on THRIFT-3768: The latest build passed fully. Please merge

[GitHub] thrift issue #1014: Thrift 3839

2016-06-14 Thread kufd
Github user kufd commented on the issue: https://github.com/apache/thrift/pull/1014 We use this fix in our prod and it works as mentioned. But as i can see the build is failed not because of my changes So i am just waiting for review from commiters. --- If your project

[GitHub] thrift issue #1014: Thrift 3839

2016-06-14 Thread sstach
Github user sstach commented on the issue: https://github.com/apache/thrift/pull/1014 Is there a chance that the build failures get fixed soon? We are facing the same problem and this fix would be awesome if it works as mentioned! --- If your project is set up for it, you can reply