[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

2016-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368871#comment-15368871 ] ASF GitHub Bot commented on THRIFT-3873: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1044: THRIFT-3873: fix compiler warnings on windows with VS201...

2016-07-08 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1044 Found that the automake environment wasn't building properly - will push a fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

2016-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368847#comment-15368847 ] ASF GitHub Bot commented on THRIFT-3873: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1044: THRIFT-3873: fix compiler warnings on windows wit...

2016-07-08 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1044 THRIFT-3873: fix compiler warnings on windows with VS2010 Also fixed: concurrency tests were using assert() in a bad way limiting them to debug builds only Also fixed: changed config.h VERSION

[GitHub] thrift pull request #1043: THRIFT-3873: fix compiler warnings on windows wit...

2016-07-08 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/1043 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

2016-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368843#comment-15368843 ] ASF GitHub Bot commented on THRIFT-3873: Github user jeking3 closed the pull request at:

[jira] [Created] (THRIFT-3875) Create a new text format protocol that supports read/write

2016-07-08 Thread Tian Wang (JIRA)
Tian Wang created THRIFT-3875: - Summary: Create a new text format protocol that supports read/write Key: THRIFT-3875 URL: https://issues.apache.org/jira/browse/THRIFT-3875 Project: Thrift Issue

[jira] [Commented] (THRIFT-3810) unresolved external symbol "public: virtual void __cdecl apache::thrift::server::TServerFramework::serve(void)" (?serve@TServerFramework@server@thrift@apache@@UEAAXXZ)

2016-07-08 Thread zengraoli (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368800#comment-15368800 ] zengraoli commented on THRIFT-3810: --- thanks! > unresolved external symbol "public: virtual void

Rebase your pull requests for thrift

2016-07-08 Thread Jim King
If you have submitted a pull request in the last couple of months, it may have failed due to various reasons. It looks like we're past those issues now, so please rebase your pull requests for thrift and push them up to github so they can rebuild. We have over 110 pull requests in the queue

[jira] [Commented] (THRIFT-3848) As an implementer of a perl socket server, I do not want to have to remember to ignore SIGCHLD for it to work properly

2016-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368755#comment-15368755 ] ASF GitHub Bot commented on THRIFT-3848: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1040: THRIFT-3848: Perl ForkingServer must ignore SIGCHLD to a...

2016-07-08 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1040 Rebased on master to fix the TServerIntegrationTest hang. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (THRIFT-3810) unresolved external symbol "public: virtual void __cdecl apache::thrift::server::TServerFramework::serve(void)" (?serve@TServerFramework@server@thrift@apache@@UEAAXXZ)

2016-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368745#comment-15368745 ] ASF GitHub Bot commented on THRIFT-3810: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1043: THRIFT-3810: fix compiler warnings on windows wit...

2016-07-08 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1043 THRIFT-3810: fix compiler warnings on windows with VS2010 Also fixed: concurrency tests were using assert() in a bad way limiting them to debug builds only Also fixed: changed config.h VERSION

[jira] [Resolved] (THRIFT-3861) Travis CI builds are timing out - C++TServerIntegrationTest appears to be hanging

2016-07-08 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3861. Resolution: Fixed Fix Version/s: 0.10.0 > Travis CI builds are timing out -

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

2016-07-08 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368710#comment-15368710 ] James E. King, III commented on THRIFT-3873: I also found the define of VERSION in config.h

[jira] [Commented] (THRIFT-3874) _TSPEC is not populated on de-serialization of type classes

2016-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368668#comment-15368668 ] ASF GitHub Bot commented on THRIFT-3874: GitHub user sashakavun opened a pull request:

[GitHub] thrift pull request #1042: THRIFT-3874 PHP Compiler: struct definition is no...

2016-07-08 Thread sashakavun
GitHub user sashakavun opened a pull request: https://github.com/apache/thrift/pull/1042 THRIFT-3874 PHP Compiler: struct definition is not populated on type classes de-serialization When type class which was serialized and deserialized by internal PHP functions (for example, if

[GitHub] thrift pull request #1041: THRIFT-3874 PHP Compiler: struct definition is no...

2016-07-08 Thread sashakavun
Github user sashakavun closed the pull request at: https://github.com/apache/thrift/pull/1041 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (THRIFT-3874) _TSPEC is not populated on de-serialization of type classes

2016-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368653#comment-15368653 ] ASF GitHub Bot commented on THRIFT-3874: Github user sashakavun closed the pull request at:

[jira] [Commented] (THRIFT-3874) _TSPEC is not populated on de-serialization of type classes

2016-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368618#comment-15368618 ] ASF GitHub Bot commented on THRIFT-3874: GitHub user sashakavun opened a pull request:

[GitHub] thrift pull request #1041: THRIFT-3874 PHP Compiler: struct definition is no...

2016-07-08 Thread sashakavun
GitHub user sashakavun opened a pull request: https://github.com/apache/thrift/pull/1041 THRIFT-3874 PHP Compiler: struct definition is not populated on type classes de-serialization You can merge this pull request into a Git repository by running: $ git pull

[jira] [Updated] (THRIFT-3874) _TSPEC is not populated on de-serialization of type classes

2016-07-08 Thread Aleksandr Kavun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Kavun updated THRIFT-3874: Attachment: php-gen-wakeup-fix.patch Fix for populating $_TSPEC on type class

[jira] [Created] (THRIFT-3874) _TSPEC is not populated on de-serialization of type classes

2016-07-08 Thread Aleksandr Kavun (JIRA)
Aleksandr Kavun created THRIFT-3874: --- Summary: _TSPEC is not populated on de-serialization of type classes Key: THRIFT-3874 URL: https://issues.apache.org/jira/browse/THRIFT-3874 Project: Thrift

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

2016-07-08 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368483#comment-15368483 ] James E. King, III commented on THRIFT-3873: I found the concurrency tests are using assert()

[jira] [Commented] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368466#comment-15368466 ] ASF GitHub Bot commented on THRIFT-2156: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1033: THRIFT-2156: fix errno handling in server socket

2016-07-08 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1033 Rebased now that the correct fix for THRIFT-3768 is in which was causing build failures... using this to prove that is resolved so I can re-mark THRIFT-3768 closed and THRIFT-3861 fixed. --- If

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

2016-07-08 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368455#comment-15368455 ] James E. King, III commented on THRIFT-3768: Glad there weren't any issues rebasing /

[jira] [Resolved] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

2016-07-08 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3768. Resolution: Fixed LGTM, rebased & committed. > TThreadedServer may crash if it is destroyed

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

2016-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368344#comment-15368344 ] ASF GitHub Bot commented on THRIFT-3768: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #980: THRIFT-3768: ensure TThreadedServer guarantees the...

2016-07-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/980 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

2016-07-08 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368332#comment-15368332 ] Jens Geyer commented on THRIFT-3768: Sure. May I rebase it for you? > TThreadedServer may crash if

[jira] [Created] (THRIFT-3873) Fix various compiler warnings when using VS2010

2016-07-08 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-3873: -- Summary: Fix various compiler warnings when using VS2010 Key: THRIFT-3873 URL: https://issues.apache.org/jira/browse/THRIFT-3873 Project: Thrift

[jira] [Commented] (THRIFT-2089) Compiler ignores duplicate typenames

2016-07-08 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367879#comment-15367879 ] James E. King, III commented on THRIFT-2089: This was resolved a few years ago however there

[jira] [Resolved] (THRIFT-3810) unresolved external symbol "public: virtual void __cdecl apache::thrift::server::TServerFramework::serve(void)" (?serve@TServerFramework@server@thrift@apache@@UEAAXXZ)

2016-07-08 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3810. Resolution: Cannot Reproduce Fix Version/s: 0.10.0 Resolving as Cannot

[jira] [Commented] (THRIFT-3810) unresolved external symbol "public: virtual void __cdecl apache::thrift::server::TServerFramework::serve(void)" (?serve@TServerFramework@server@thrift@apache@@UEAAXXZ)

2016-07-08 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367869#comment-15367869 ] James E. King, III commented on THRIFT-3810: Using cmake I was able to build libthrift

[jira] [Updated] (THRIFT-3848) As an implementer of a perl socket server, I do not want to have to remember to ignore SIGCHLD for it to work properly

2016-07-08 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3848: --- Description: In a project I work on, we use a perl thrift server as a mock to

[jira] [Commented] (THRIFT-3848) As an implementer of a perl socket server, I do not want to have to remember to ignore SIGCHLD for it to work properly

2016-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367792#comment-15367792 ] ASF GitHub Bot commented on THRIFT-3848: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1040: THRIFT-3848: Perl ForkingServer must ignore SIGCH...

2016-07-08 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1040 THRIFT-3848: Perl ForkingServer must ignore SIGCHLD to avoid infinite loop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift

[jira] [Commented] (THRIFT-3550) Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is present

2016-07-08 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367735#comment-15367735 ] James E. King, III commented on THRIFT-3550: I think we want our standard distribution build

[jira] [Commented] (THRIFT-3593) Enable server-side to issue requests to clients on the same connection (push notifications)

2016-07-08 Thread Sebastian Zenker (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367650#comment-15367650 ] Sebastian Zenker commented on THRIFT-3593: -- One thing I forgot: you may wonder about the

[jira] [Commented] (THRIFT-3593) Enable server-side to issue requests to clients on the same connection (push notifications)

2016-07-08 Thread Sebastian Zenker (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367643#comment-15367643 ] Sebastian Zenker commented on THRIFT-3593: -- In our company, we currently building up our next

[jira] [Commented] (THRIFT-3593) Enable server-side to issue requests to clients on the same connection (push notifications)

2016-07-08 Thread Sebastian Zenker (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367605#comment-15367605 ] Sebastian Zenker commented on THRIFT-3593: -- In my opinion, "push notifications" should become