[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368483#comment-15368483
]
James E. King, III commented on THRIFT-3873:
--------------------------------------------
I found the concurrency tests are using assert() in a bad way which causes
these tests only to run on debug builds. Once I enabled /W3 for MSVC builds it
pointed out a couple things were unused in a release build leading me to this.
I'm fixing this up as part of this change set. I have it building with /W3 and
no warnings. Could even turn on /WX but thinking perhaps not the best thing to
do given the combinations of compilers and libraries out there.
> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
> Key: THRIFT-3873
> URL: https://issues.apache.org/jira/browse/THRIFT-3873
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: VS2010, Windows
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Trivial
>
> While verifying a defect I had to build the windows thrift C++ library and
> found a number of compiler warnings that needed to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
