[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368847#comment-15368847 ]
ASF GitHub Bot commented on THRIFT-3873: ---------------------------------------- GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1044 THRIFT-3873: fix compiler warnings on windows with VS2010 Also fixed: concurrency tests were using assert() in a bad way limiting them to debug builds only Also fixed: changed config.h VERSION to THRIFT_VERSION to avoid conflicts with windows or third party headers With this pull request in a CMake build on Windows VS2010 or on Linux (Ubuntu 14.04) the C++ code compiles clean with /W3 level warnings enabled. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift defect/THRIFT-3873 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1044.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1044 ---- commit 171d202ad1bf643c485ec7cdbaccf59cba67b489 Author: James E. King, III <jim.k...@simplivity.com> Date: 2016-07-08T22:04:21Z THRIFT-3873: fix compiler warnings on windows with VS2010 and fix concurrency tests only running in debug mode; change VERSION to THRIFT_VERSION to avoid conflicts with third party or OS headers ---- > Fix various compiler warnings when using VS2010 > ----------------------------------------------- > > Key: THRIFT-3873 > URL: https://issues.apache.org/jira/browse/THRIFT-3873 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.10.0 > Environment: VS2010, Windows > Reporter: James E. King, III > Assignee: James E. King, III > Priority: Trivial > > While verifying a defect I had to build the windows thrift C++ library and > found a number of compiler warnings that needed to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)