[
https://issues.apache.org/jira/browse/THRIFT-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627539#comment-15627539
]
Benjamin Gould commented on THRIFT-3956:
Possible solution could be to:
1) Identify all Java
[
https://issues.apache.org/jira/browse/THRIFT-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Gould updated THRIFT-3956:
---
Description:
Consider the following IDL, which is legal and leads to successful source code
Benjamin Gould created THRIFT-3956:
--
Summary: Java keywords that are legal in IDL can lead to generated
code that will not compile
Key: THRIFT-3956
URL: https://issues.apache.org/jira/browse/THRIFT-3956
[
https://issues.apache.org/jira/browse/THRIFT-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Gould updated THRIFT-2695:
---
Assignee: (was: Benjamin Gould)
> Generated Java Client interface should implement
[
https://issues.apache.org/jira/browse/THRIFT-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Gould reassigned THRIFT-2695:
--
Assignee: Benjamin Gould
> Generated Java Client interface should implement
[
https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Gould reassigned THRIFT-3301:
--
Assignee: Benjamin Gould
> Java generated code uses imports that can lead to class
[
https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627306#comment-15627306
]
Benjamin Gould commented on THRIFT-3301:
Upon further thought I think that the Java keyword
[
https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626686#comment-15626686
]
Jens Geyer edited comment on THRIFT-3301 at 11/1/16 9:13 PM:
-
{quote}
Also
[
https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626686#comment-15626686
]
Jens Geyer commented on THRIFT-3301:
{quote}
Also one thing to note is that the Java code generated
GitHub user ndjensen opened a pull request:
https://github.com/apache/thrift/pull/1121
TTransport.py micro-optimization: don't call len(chunk) twice
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ndjensen/thrift master
[
https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626365#comment-15626365
]
ASF GitHub Bot commented on THRIFT-3301:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1120
I think a number of those things are in the "reserved" keyword list for the
thrift compiler, so that's okay. Nice, I'll mark this one approved.
---
If your project is set up for it, you can reply
[
https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626349#comment-15626349
]
ASF GitHub Bot commented on THRIFT-3301:
Github user bgould commented on the issue:
Github user bgould commented on the issue:
https://github.com/apache/thrift/pull/1120
Also one thing to note is that the Java code generated from following valid
IDL will still fail to compile because the names match Java primitive types...
I know of no way to avoid this problem:
[
https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626227#comment-15626227
]
ASF GitHub Bot commented on THRIFT-3301:
Github user bgould commented on the issue:
Github user bgould commented on the issue:
https://github.com/apache/thrift/pull/1120
@jeking3
Yes exactly. I added it to the build process that compiles the java unit
tests... so if some change to compiler introduces a regression, the IDL in that
file should fail to
Github user maximelamure commented on the issue:
https://github.com/apache/thrift/pull/1053
Just for information, adding custom tags generate an exception with
`thriftpy` :
```
thriftpy.parser.exc.ThriftGrammerError: Grammer error '('
```
---
If your project is set up
[
https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626030#comment-15626030
]
ASF GitHub Bot commented on THRIFT-3301:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1120
I'm not seeing why JavaTypes was introduced - was it simply used to
manually check the build for output of every native type? Is the result from
JavaTypes compilation used in some unit test that
[
https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625943#comment-15625943
]
ASF GitHub Bot commented on THRIFT-3301:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1120
Does the cmake install job need to be updated as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bgould commented on the issue:
https://github.com/apache/thrift/pull/1120
Thanks @nsuke I'm pretty sure that was the problem. I created a new IDL
file for validating this change, and I've now added it to tests/Makefile.am
---
If your project is set up for it, you can
[
https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625651#comment-15625651
]
ASF GitHub Bot commented on THRIFT-3301:
Github user bgould commented on the issue:
23 matches
Mail list logo
