Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1156
> Good intentions, absolutely, but the implementation ..
FWIW, I agree. However, we still need a solution and as I explained above,
we don't have a way of returning an error here. That leav
[
https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823547#comment-15823547
]
ASF GitHub Bot commented on THRIFT-4011:
Github user dcelasun commented on the is
[
https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823384#comment-15823384
]
ASF GitHub Bot commented on THRIFT-4011:
Github user Jens-G commented on the issu
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1156
Oopsie. After I read the word "map" above I must have been mentally
switched to maps somehow. My mistake.
Nevertheless what I said about panic and errors in general above still
holds true.
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1088
Hi @Jens-G
Done - you can check master in https://github.com/vgotra/thrift.
Added framed transport and added sample of usage of MultiplexedProtocol.
Also updated docs for library.
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1088
Yes - I can. Not sure about multiplex. I will check it and ping you later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
[
https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823166#comment-15823166
]
Chandler May commented on THRIFT-4029:
--
The new zip distribution works for me.
> Ac
[
https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823163#comment-15823163
]
ASF GitHub Bot commented on THRIFT-4011:
Github user dcelasun commented on the is
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1156
Hey @Jens-G, I'm not sure I follow you, what does this have anything to do
with maps? Assuming you meant sets, the docs say:
> An unordered set of unique elements. Translates to an STL set,
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1088
Could you extract the other stuff (e.g. framed transport, multiplex, ...)
into a separate PR that works with the current Thrift code base? Smaller PRs
are easier to review, and we get at least these
[
https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823148#comment-15823148
]
ASF GitHub Bot commented on THRIFT-4011:
Github user Jens-G commented on the issu
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1156
http://thrift.apache.org/docs/types states that (as one would expect) a
Thrift map is defined as "A map of **strictly unique keys** to values.
Translates to an STL map, Java HashMap, PHP associative
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1153#discussion_r96138653
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() {
ownEventBase_ = f
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823138#comment-15823138
]
ASF GitHub Bot commented on THRIFT-2945:
Github user Jens-G commented on the issu
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1147
@all: Everyone happy with it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
[
https://issues.apache.org/jira/browse/THRIFT-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823094#comment-15823094
]
ASF GitHub Bot commented on THRIFT-4011:
GitHub user dcelasun opened a pull reque
GitHub user dcelasun opened a pull request:
https://github.com/apache/thrift/pull/1156
THRIFT-4011 Use slices for Thrift sets
As discussed in
[THRIFT-4011](https://issues.apache.org/jira/browse/THRIFT-4011), this commit
changes the Go generator to use slices, instead of maps for Th
17 matches
Mail list logo