[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

2017-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863020#comment-15863020 ] ASF GitHub Bot commented on THRIFT-4060: Github user jeking3 commented on a diff in the pull

[jira] [Updated] (THRIFT-4084) Improve SSL security in thrift by adding a make cross client that checks to make sure SSLv3 protocol cannot be negotiated

2017-02-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4084: --- Description: Following code review discussions in THRIFT-3369, and seeing

[GitHub] thrift pull request #1172: THRIFT-4060 add better support in the cpp generat...

2017-02-12 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1172#discussion_r100707345 --- Diff: lib/cpp/test/AnnotationTest.cpp --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] thrift pull request #1187: Review for pull up extended namespace support, ad...

2017-02-12 Thread przygienda
GitHub user przygienda opened a pull request: https://github.com/apache/thrift/pull/1187 Review for pull up extended namespace support, addition of macros to allow application to macroize over defintions ... Please review initial request here ... You can merge this pull request

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

2017-02-12 Thread Tony Przygienda (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863010#comment-15863010 ] Tony Przygienda commented on THRIFT-2945: - understood, I'm commenting purely in Rust context here

[jira] [Comment Edited] (THRIFT-2945) Implement support for Rust language

2017-02-12 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863002#comment-15863002 ] Jens Geyer edited comment on THRIFT-2945 at 2/12/17 10:20 PM: --

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

2017-02-12 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863002#comment-15863002 ] Jens Geyer commented on THRIFT-2945: http://thrift.apache.org/docs/idl {{[6] NamespaceScope ::=

[jira] [Assigned] (THRIFT-4085) Add .NET Core to the make cross standard test suite and docker build images for CI

2017-02-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4085: -- Assignee: (was: James E. King, III) > Add .NET Core to the make cross

[jira] [Commented] (THRIFT-4085) Add .NET Core to the make cross standard test suite and docker build images for CI

2017-02-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862938#comment-15862938 ] James E. King, III commented on THRIFT-4085: I tried updating the Ubuntu docker image like

[jira] [Assigned] (THRIFT-4085) Add .NET Core to the make cross standard test suite and docker build images for CI

2017-02-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4085: -- Assignee: James E. King, III > Add .NET Core to the make cross standard test

[jira] [Assigned] (THRIFT-4085) Add .NET Core to the make cross standard test suite and docker build images for CI

2017-02-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4085: -- Assignee: (was: James E. King, III) > Add .NET Core to the make cross

[jira] [Updated] (THRIFT-4084) Improve SSL security in thrift by adding a make cross client that checks to make sure SSLv3 protocol cannot be negotiated

2017-02-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4084: --- Summary: Improve SSL security in thrift by adding a make cross client that checks to

[jira] [Updated] (THRIFT-4084) Improve SSL security in thrift by adding a make cross client that checks to make sure SSLv2 and SSLv3 protocols cannot be negotiated

2017-02-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4084: --- Description: Following code review discussions in THRIFT-3369, and seeing

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

2017-02-12 Thread Tony Przygienda (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862911#comment-15862911 ] Tony Przygienda commented on THRIFT-2945: - fantastic work albeit it compltely ruined all my

[jira] [Created] (THRIFT-4085) Add .NET Core to the make cross standard test suite and docker build images for CI

2017-02-12 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4085: -- Summary: Add .NET Core to the make cross standard test suite and docker build images for CI Key: THRIFT-4085 URL: https://issues.apache.org/jira/browse/THRIFT-4085

[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

2017-02-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862886#comment-15862886 ] James E. King, III commented on THRIFT-4060: In my PR I have already added a compiler

[jira] [Updated] (THRIFT-4084) Improve SSL security in thrift by adding a make cross client that checks to make sure SSLv2 and SSLv3 protocols cannot be negotiated

2017-02-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4084: --- Description: Following code review discussions in THRIFT-3369, and seeing

[GitHub] thrift issue #1185: Thrift 3369 - Third try to merge SSL c_glib

2017-02-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1185 @nsuke something like this seems to work in the ubuntu docker image: ``` has_secure_ssl_handshake = 0 try: from OpenSSL.SSL import OP_NO_SSLv3

[jira] [Commented] (THRIFT-4084) Improve SSL security in thrift by adding a make cross client that checks to make sure SSLv2 and SSLv3 protocols cannot be negotiated

2017-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862771#comment-15862771 ] ASF GitHub Bot commented on THRIFT-4084: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-3165) Improve SSL Security in thrift by requiring TLS v1.2 by default

2017-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862770#comment-15862770 ] ASF GitHub Bot commented on THRIFT-3165: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1185: Thrift 3369 - Third try to merge SSL c_glib

2017-02-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1185 I opened THRIFT-4084 as a mechanism to verify all the SSL server implementations are secure "enough" at their default settings. --- If your project is set up for it, you can reply to this email

[GitHub] thrift issue #1185: Thrift 3369 - Third try to merge SSL c_glib

2017-02-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1185 @gadLinux The current standard for thrift is to use the SSLv23 handshake, but to negotiate at TLSv1.0 or later. See Apache Jira https://issues.apache.org/jira/browse/THRIFT-3165 for that. Code to

[jira] [Commented] (THRIFT-4026) TSSLSocket doesn't work with Python < 2.7.9

2017-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862764#comment-15862764 ] ASF GitHub Bot commented on THRIFT-4026: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1166: THRIFT-4026 TSSLSocket doesn't work with Python <...

2017-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3938) Python TNonblockingServer does not work with SSL

2017-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862763#comment-15862763 ] ASF GitHub Bot commented on THRIFT-3938: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1100: THRIFT-3938 Python TNonblockingServer does not wo...

2017-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (THRIFT-4084) Improve SSL security in thrift by adding a make cross client that checks to make sure SSLv2 and SSLv3 protocols cannot be negotiated

2017-02-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4084: --- Labels: cross-validation security ssl tls (was: ) > Improve SSL security in thrift

[jira] [Created] (THRIFT-4084) Improve SSL security in thrift by adding a make cross client that checks to make sure SSLv2 and SSLv3 protocols cannot be negotiated

2017-02-12 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4084: -- Summary: Improve SSL security in thrift by adding a make cross client that checks to make sure SSLv2 and SSLv3 protocols cannot be negotiated Key: THRIFT-4084 URL:

[GitHub] thrift issue #1185: Thrift 3369 - Third try to merge SSL c_glib

2017-02-12 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1185 Seems it's still failing. Do you think I can modify the back the protocol and use SSL2-3 for the tests? --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (THRIFT-4037) [CMake] Use a single build system for thrift to make development easier

2017-02-12 Thread Gonzalo Aguilar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862707#comment-15862707 ] Gonzalo Aguilar commented on THRIFT-4037: - I don't like the m4 interface of autotools but I can

[GitHub] thrift issue #1185: Thrift 3369 - Third try to merge SSL c_glib

2017-02-12 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1185 Hi, I must say that TLS1.2 is the recommended version for SSL because SSL3 is so buggy and insecure that everyone is filtering it. For testing can be ok. I would not change the default

[GitHub] thrift issue #1185: Thrift 3369 - Third try to merge SSL c_glib

2017-02-12 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1185 @jeking3 in that case, Ubuntu might be using a patched version of Python. According to the [doc](https://docs.python.org/2/library/ssl.html#ssl.OP_NO_SSLv2), it's added in 2.7.9. >