[jira] [Resolved] (THRIFT-4255) Go generator has type errors when in read/write functions for set

2017-07-20 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davin Chia resolved THRIFT-4255. Resolution: Fixed > Go generator has type errors when in read/write functions for set >

[jira] [Commented] (THRIFT-4255) Go generator has type errors when in read/write functions for set

2017-07-20 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095485#comment-16095485 ] Davin Chia commented on THRIFT-4255: Seems this has been fixed in

[GitHub] thrift issue #1311: Fix for constant assignments to optional fields in Go.

2017-07-20 Thread davinchia
Github user davinchia commented on the issue: https://github.com/apache/thrift/pull/1311 https://stackoverflow.com/questions/30716354/how-do-i-do-a-literal-int64-in-go is a good summary of the different ways to assign constant values in Go. I decided to use an anonymous

[GitHub] thrift pull request #1311: Fix for constant assignments to optional fields i...

2017-07-20 Thread davinchia
GitHub user davinchia opened a pull request: https://github.com/apache/thrift/pull/1311 Fix for constant assignments to optional fields in Go. As per ticket https://issues.apache.org/jira/browse/THRIFT-4253. As I dug through the code I realised the problem was not only

[jira] [Commented] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095309#comment-16095309 ] ASF GitHub Bot commented on THRIFT-4253: GitHub user davinchia opened a pull request:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094403#comment-16094403 ] ASF GitHub Bot commented on THRIFT-4236: GitHub user taozle reopened a pull request:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094402#comment-16094402 ] ASF GitHub Bot commented on THRIFT-4236: Github user taozle closed the pull request at:

[GitHub] thrift pull request #1309: Use build tags to support context.

2017-07-20 Thread taozle
GitHub user taozle reopened a pull request: https://github.com/apache/thrift/pull/1309 Use build tags to support context. As the comment in https://issues.apache.org/jira/browse/THRIFT-4236, this PR use build tags to support context in go1.7 above. You can merge this pull request

[GitHub] thrift pull request #1309: Use build tags to support context.

2017-07-20 Thread taozle
Github user taozle closed the pull request at: https://github.com/apache/thrift/pull/1309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is