Question about t_const_value in plugin.thrift (and its relation to t_const_value in compiler/..../parse)

2017-11-29 Thread Chet Murthy
TL;DR I think that the definition of t_const_value in plugin.thrift needs to change, in an incompatible way, so that it can properly carry all the information from the compiler to plugins. Thoughts? Adivce? I was trying to understand the meaning of all the fields in plugin.thrift's messages,

[jira] [Commented] (THRIFT-3686) Java processor should report internal error on uncaught exception

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272101#comment-16272101 ] ASF GitHub Bot commented on THRIFT-3686: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1428: THRIFT-3686 Java processor should report internal...

2017-11-29 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1428 THRIFT-3686 Java processor should report internal error on uncaught e… …xception (resubmit for nsuke) Client: java This closes #904 This closes #1428 You can

[jira] [Commented] (THRIFT-3657) D TFileWriterTransport close should use non-priority send

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272096#comment-16272096 ] ASF GitHub Bot commented on THRIFT-3657: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1427: THRIFT-3657 D TFileWriterTransport close should u...

2017-11-29 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1427 THRIFT-3657 D TFileWriterTransport close should use non-priority send Client: D (resubmit for nsuke) This closes #884 This closes #1427 You can merge this pull request into a

[jira] [Commented] (THRIFT-3610) Streamline exception handling in Python server handler

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272094#comment-16272094 ] ASF GitHub Bot commented on THRIFT-3610: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1426: THRIFT-3610 Streamline exception handling in Pyth...

2017-11-29 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1426 THRIFT-3610 Streamline exception handling in Python server handler Client: py (resubmitting for nsuke) This closes #842 This closes #1426 You can merge this pull request into

[jira] [Commented] (THRIFT-3602) Make Tornado server send exception on unexpected handler error

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272092#comment-16272092 ] ASF GitHub Bot commented on THRIFT-3602: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1425: THRIFT-3602 Make Tornado server send exception on...

2017-11-29 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1425 THRIFT-3602 Make Tornado server send exception on unexpected handler … …error (resubmitting for nsuke) Client: py This closes #839 This closes #1425 You can

[jira] [Commented] (THRIFT-3600) Make TTwisted server send exception on unexpected handler error

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272086#comment-16272086 ] ASF GitHub Bot commented on THRIFT-3600: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1424: THRIFT-3600 Make TTwisted server send exception o...

2017-11-29 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1424 THRIFT-3600 Make TTwisted server send exception on unexpected handler… … error (resubmitting for nsuke) Client: py This closes #838 This closes #1424 You can

[jira] [Commented] (THRIFT-3580) THeader for Haskell

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272074#comment-16272074 ] ASF GitHub Bot commented on THRIFT-3580: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1423: THRIFT-3580 THeader for Haskell (Resubmitting for...

2017-11-29 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1423 THRIFT-3580 THeader for Haskell (Resubmitting for nsuke) This closes #820 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift

[jira] [Commented] (THRIFT-82) Common Lisp support

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272059#comment-16272059 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jeking3 commented on the issue:

[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support

2017-11-29 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1412 I have sent an email to the two participants for which permission is needed to move copyright statements in order to comply with the Apache licensing requirements. I asked them to each post either

[jira] [Commented] (THRIFT-4392) compiler/..../plugin.thrift structs mis-ordered blows up ocaml generator

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272054#comment-16272054 ] ASF GitHub Bot commented on THRIFT-4392: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1413: 0.8.x

2017-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1413 ---

[GitHub] thrift pull request #1417: THRIFT-4392 reorder structs in plugin.thrift

2017-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1417 ---

[jira] [Assigned] (THRIFT-4392) compiler/..../plugin.thrift structs mis-ordered blows up ocaml generator

2017-11-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4392: -- Assignee: James E. King, III > compiler//plugin.thrift structs

[jira] [Updated] (THRIFT-4395) Unable to build in the ubuntu-xenial docker image: clap 2.28 requires Rust 1.20

2017-11-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4395: --- Affects Version/s: (was: 0.10.0) 0.11.0 > Unable to build

[jira] [Resolved] (THRIFT-4395) Unable to build in the ubuntu-xenial docker image: clap 2.28 requires Rust 1.20

2017-11-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4395. Resolution: Fixed > Unable to build in the ubuntu-xenial docker image: clap 2.28

[jira] [Commented] (THRIFT-4395) Unable to build in the ubuntu-xenial docker image: clap 2.28 requires Rust 1.20

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272047#comment-16272047 ] ASF GitHub Bot commented on THRIFT-4395: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1421: THRIFT-4395: fix rust build on xenial

2017-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1421 ---

[jira] [Commented] (THRIFT-4397) ubuntu install instructions broken on 16.04

2017-11-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271891#comment-16271891 ] Jens Geyer commented on THRIFT-4397: That whole list needs an overhaul ... PHP5? Mongrel? > ubuntu

[jira] [Updated] (THRIFT-4397) ubuntu install instructions broken on 16.04

2017-11-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4397: --- Description: http://thrift.apache.org/docs/install/debian {quote} sudo apt-get install automake

[jira] [Updated] (THRIFT-4397) ubuntu install instructions broken on 16.04

2017-11-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4397: --- Environment: (was: http://thrift.apache.org/docs/install/debian {quote} sudo apt-get install

[jira] [Created] (THRIFT-4397) ubuntu install instructions broken on 16.04

2017-11-29 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-4397: -- Summary: ubuntu install instructions broken on 16.04 Key: THRIFT-4397 URL: https://issues.apache.org/jira/browse/THRIFT-4397 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-4396) inconsistent (or plain wrong) version numbers in master/trunk

2017-11-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271781#comment-16271781 ] Jens Geyer commented on THRIFT-4396: @all: please double-check the modifications and don't hesitate

[jira] [Commented] (THRIFT-4396) inconsistent (or plain wrong) version numbers in master/trunk

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271770#comment-16271770 ] ASF GitHub Bot commented on THRIFT-4396: GitHub user Jens-G opened a pull request:

[GitHub] thrift pull request #1422: THRIFT-4396 inconsistent (or plain wrong) version...

2017-11-29 Thread Jens-G
GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1422 THRIFT-4396 inconsistent (or plain wrong) version numbers in master/t… …runk Client: (multiple) Patch: Jens Geyer You can merge this pull request into a Git repository by running:

[jira] [Updated] (THRIFT-4396) inconsistent (or plain wrong) version numbers in master/trunk

2017-11-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4396: --- Description: There are a bunch of files who have either a plain wrong number or at least something

[jira] [Updated] (THRIFT-4396) inconsistent (or plain wrong) version numbers in master/trunk

2017-11-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4396: --- Component/s: Build Process > inconsistent (or plain wrong) version numbers in master/trunk >

[jira] [Created] (THRIFT-4396) inconsistent (or plain wrong) version numbers in master/trunk

2017-11-29 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-4396: -- Summary: inconsistent (or plain wrong) version numbers in master/trunk Key: THRIFT-4396 URL: https://issues.apache.org/jira/browse/THRIFT-4396 Project: Thrift

[jira] [Commented] (THRIFT-4395) Unable to build in the ubuntu-xenial docker image: clap 2.28 requires Rust 1.20

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271558#comment-16271558 ] ASF GitHub Bot commented on THRIFT-4395: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1421: THRIFT-4395: fix rust build on xenial

2017-11-29 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1421 Well thank goodness for CI builds, I forgot to update the tutorial package file! ---

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP (csharp server, cpp client; need cross test enhancement)

2017-11-29 Thread Chet Murthy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271480#comment-16271480 ] Chet Murthy commented on THRIFT-3877: - I can't help with C# (unless we can find somebody who knows C#

[jira] [Updated] (THRIFT-3877) C++: library don't work with HTTP (csharp server, cpp client; need cross test enhancement)

2017-11-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3877: --- Summary: C++: library don't work with HTTP (csharp server, cpp client; need cross

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP.

2017-11-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271328#comment-16271328 ] James E. King, III commented on THRIFT-3877: There are still a lot of cpp-other failures in

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP.

2017-11-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271292#comment-16271292 ] James E. King, III commented on THRIFT-3877: {noformat}

[GitHub] thrift issue #1418: Thrift 3877 http server buffering bug oneway

2017-11-29 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1418 I think it's fine as-is, except for adding to ThriftTest in this case since that is a global test thrift file, and you need one local to lib/cpp/test. The fact you took the time to add a unit test

[GitHub] thrift issue #1418: Thrift 3877 http server buffering bug oneway

2017-11-29 Thread chetmurthy
Github user chetmurthy commented on the issue: https://github.com/apache/thrift/pull/1418 Will do. Please do suggest any style changes that you think appropriate -- I am *fully* bought-into the idea that a project should have a uniform style, and even if I were not to agree with

[GitHub] thrift pull request #1418: Thrift 3877 http server buffering bug oneway

2017-11-29 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1418#discussion_r153869127 --- Diff: test/ThriftTest.thrift --- @@ -409,3 +409,8 @@ struct StructB { 1: optional StructA aa; 2: required StructA ab; } +

[jira] [Commented] (THRIFT-4395) Unable to build in the ubuntu-xenial docker image: clap 2.28 requires Rust 1.20

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271251#comment-16271251 ] ASF GitHub Bot commented on THRIFT-4395: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1421: THRIFT-4395: fix rust build on xenial

2017-11-29 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1421 THRIFT-4395: fix rust build on xenial You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4395 Alternatively you can review

[jira] [Commented] (THRIFT-4395) Unable to build in the ubuntu-xenial docker image: clap 2.28 requires Rust 1.20

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271246#comment-16271246 ] ASF GitHub Bot commented on THRIFT-4395: GitHub user jeking3 opened a pull request:

[jira] [Commented] (THRIFT-4395) Unable to build in the ubuntu-xenial docker image: clap 2.28 requires Rust 1.20

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271248#comment-16271248 ] ASF GitHub Bot commented on THRIFT-4395: Github user jeking3 closed the pull request at:

[jira] [Commented] (THRIFT-4395) Unable to build in the ubuntu-xenial docker image: clap 2.28 requires Rust 1.20

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271247#comment-16271247 ] ASF GitHub Bot commented on THRIFT-4395: Github user jeking3 commented on the issue:

[GitHub] thrift pull request #1420: THRIFT-4395: fix rust build on xenial

2017-11-29 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/1420 ---

[GitHub] thrift pull request #1420: THRIFT-4395: fix rust build on xenial

2017-11-29 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1420 THRIFT-4395: fix rust build on xenial I found this while doing due diligence on another issue (C++ HTTP) - I could no longer run cross test because builds fail in lib/rs. You can merge this pull

[GitHub] thrift issue #1420: THRIFT-4395: fix rust build on xenial

2017-11-29 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1420 shoot... will resubmit without THRIFT-3877 ---

[jira] [Assigned] (THRIFT-4395) Unable to build in the ubuntu-xenial docker image: clap 2.28 requires Rust 1.20

2017-11-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4395: -- Assignee: James E. King, III > Unable to build in the ubuntu-xenial docker

[jira] [Created] (THRIFT-4395) Unable to build in the ubuntu-xenial docker image: clap 2.28 requires Rust 1.20

2017-11-29 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4395: -- Summary: Unable to build in the ubuntu-xenial docker image: clap 2.28 requires Rust 1.20 Key: THRIFT-4395 URL: https://issues.apache.org/jira/browse/THRIFT-4395

[jira] [Assigned] (THRIFT-3877) C++: library don't work with HTTP.

2017-11-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3877: -- Assignee: James E. King, III > C++: library don't work with HTTP. >

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP.

2017-11-29 Thread Chet Murthy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271147#comment-16271147 ] Chet Murthy commented on THRIFT-3877: - I'm new to contributing to OSS, but very, very old in the

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP.

2017-11-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271134#comment-16271134 ] James E. King, III commented on THRIFT-3877: It'll be interesting to see how many disabled

[jira] [Updated] (THRIFT-4287) Add c++ compiler "no_skeleton" flag option

2017-11-29 Thread Or Yahud (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Or Yahud updated THRIFT-4287: - Description: Add c++ compiler "no_skeleton" flag option in case you don't want thrift to generate a

[jira] [Updated] (THRIFT-4287) Add c++ compiler "no_skeleton" flag option

2017-11-29 Thread Or Yahud (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Or Yahud updated THRIFT-4287: - Description: Add c++ compiler "no_skeleton" flag option in case you don't want thrift to generate a