[GitHub] thrift issue #1440: Enhancement binary_protocol with frametransport

2017-12-09 Thread zhiyu-he
Github user zhiyu-he commented on the issue: https://github.com/apache/thrift/pull/1440 @jeking3 but the difference between buffer-transport and frame_transport, is only the data-length. i think thrift transport only use for raw-socket read within golang, it's

[jira] [Commented] (THRIFT-4410) Extra ending underscore with field ending with `result` for Golang

2017-12-09 Thread Bob Cao (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285086#comment-16285086 ] Bob Cao commented on THRIFT-4410: - Hi [~jensg], thanks for the explanation! I tried very hard to

[jira] [Resolved] (THRIFT-4417) fb303 build broken after conversion to stdcxx namespace - missing header

2017-12-09 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4417. Resolution: Fixed > fb303 build broken after conversion to stdcxx namespace -

[jira] [Resolved] (THRIFT-4416) Perl CPAN Packaging Improvements

2017-12-09 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4416. Resolution: Fixed Fix Version/s: 0.12.0 > Perl CPAN Packaging Improvements

[jira] [Commented] (THRIFT-4416) Perl CPAN Packaging Improvements

2017-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285019#comment-16285019 ] ASF GitHub Bot commented on THRIFT-4416: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-4418) evhttp_connection_new is deprecated; use evhttp_connection_base_new

2017-12-09 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4418. Resolution: Fixed > evhttp_connection_new is deprecated; use

[GitHub] thrift pull request #1441: THRIFT-4416: Automate and fix CPAN packaging

2017-12-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1441 ---

[GitHub] thrift pull request #1438: THRIFT-5555

2017-12-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1438 ---

[jira] [Created] (THRIFT-4418) evhttp_connection_new is deprecated; use evhttp_connection_base_new

2017-12-09 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4418: -- Summary: evhttp_connection_new is deprecated; use evhttp_connection_base_new Key: THRIFT-4418 URL: https://issues.apache.org/jira/browse/THRIFT-4418

[GitHub] thrift pull request #1439: Fix fb303 build: add lost shared_ptr.hpp

2017-12-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1439 ---

[jira] [Created] (THRIFT-4417) fb303 build broken after conversion to stdcxx namespace - missing header

2017-12-09 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4417: -- Summary: fb303 build broken after conversion to stdcxx namespace - missing header Key: THRIFT-4417 URL: https://issues.apache.org/jira/browse/THRIFT-4417

[GitHub] thrift issue #1440: Enhancement binary_protocol with frametransport

2017-12-09 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1440 @jfarrell could you please look into why Travis CI didn't execute on this pull request? It wouldn't have mattered, since this PR has no unit test or cross test that engages it at the moment, but

[GitHub] thrift issue #1440: Enhancement binary_protocol with frametransport

2017-12-09 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1440 Transport and Protocols are supposed to be distinct layers in the Thrift architecture; why did you combine the Binary Transport with the Framed Protocol? ---

[jira] [Commented] (THRIFT-4416) Perl CPAN Packaging Improvements

2017-12-09 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284835#comment-16284835 ] James E. King, III commented on THRIFT-4416: Pull request is out - I have repackaged 0.10.0

[jira] [Commented] (THRIFT-4416) Perl CPAN Packaging Improvements

2017-12-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284833#comment-16284833 ] ASF GitHub Bot commented on THRIFT-4416: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1441: THRIFT-4416: Automate and fix CPAN packaging

2017-12-09 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1441 THRIFT-4416: Automate and fix CPAN packaging * Ensures only necessary files are in the manifest. * Ensures that META.json has the syntactic sugar to properly index Thrift as a single package.

[jira] [Updated] (THRIFT-4416) Perl CPAN Packaging Improvements

2017-12-09 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4416: --- Description: The perl library has a few files and a shell script designed to

[jira] [Created] (THRIFT-4416) Perl CPAN Packaging Improvements

2017-12-09 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4416: -- Summary: Perl CPAN Packaging Improvements Key: THRIFT-4416 URL: https://issues.apache.org/jira/browse/THRIFT-4416 Project: Thrift Issue Type:

[GitHub] thrift pull request #1440: Enhancement binary_protocol with frametransport

2017-12-09 Thread zhiyu-he
GitHub user zhiyu-he opened a pull request: https://github.com/apache/thrift/pull/1440 Enhancement binary_protocol with frametransport for frametransport write method write data-length to server read method read data-length from server and there are lots of