[jira] [Commented] (THRIFT-4497) Erlang records should use map() for map type

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363499#comment-16363499 ] ASF GitHub Bot commented on THRIFT-4497: GitHub user dhull opened a pull request:

[GitHub] thrift pull request #1495: THRIFT-4497: Use map() field type for Erlang type...

2018-02-13 Thread dhull
GitHub user dhull opened a pull request: https://github.com/apache/thrift/pull/1495 THRIFT-4497: Use map() field type for Erlang type for map struct fields The Thrift Erlang code generator previously generated fields with the `#{}` Erlang type for maps fields. In the Erlang type

[jira] [Created] (THRIFT-4497) Erlang records should use map() for map type

2018-02-13 Thread David Hull (JIRA)
David Hull created THRIFT-4497: -- Summary: Erlang records should use map() for map type Key: THRIFT-4497 URL: https://issues.apache.org/jira/browse/THRIFT-4497 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-4460) php library use PSR-2

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363387#comment-16363387 ] ASF GitHub Bot commented on THRIFT-4460: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1472: THRIFT-4460: PHP Library use PSR-2

2018-02-13 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1472#discussion_r168062703 --- Diff: build/docker/scripts/sca.sh --- @@ -49,6 +49,10 @@ flake8 --ignore=E501 test/test.py flake8 --ignore=E501,E722 test/crossrunner flake8

[jira] [Commented] (THRIFT-4496) Screen keywords in service method names

2018-02-13 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363264#comment-16363264 ] Jens Geyer commented on THRIFT-4496: If the idea is, however, to *get completely rid of the global

[jira] [Commented] (THRIFT-4496) Screen keywords in service method names

2018-02-13 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363255#comment-16363255 ] Jens Geyer commented on THRIFT-4496: In addition to the (by intention) not exhaustive global keyword

[jira] [Commented] (THRIFT-4448) Golang: do something with context.Context

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363189#comment-16363189 ] ASF GitHub Bot commented on THRIFT-4448: Github user johnboiles commented on the issue:

[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context

2018-02-13 Thread johnboiles
Github user johnboiles commented on the issue: https://github.com/apache/thrift/pull/1459 @jeking3 done ---

[jira] [Commented] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362909#comment-16362909 ] ASF GitHub Bot commented on THRIFT-4352: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1465: THRIFT-4352: update artful to use haxe 3.4.4 which fixes...

2018-02-13 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1465 I found a check-in to hxcpp around October 2017 which enabled C++11 by default; I had to disable it by setting this environment variable: `export HXCPP_CPP11=0` in the ubsan build script. ---

[jira] [Created] (THRIFT-4496) Screen keywords in service method names

2018-02-13 Thread Vera Filippova (JIRA)
Vera Filippova created THRIFT-4496: -- Summary: Screen keywords in service method names Key: THRIFT-4496 URL: https://issues.apache.org/jira/browse/THRIFT-4496 Project: Thrift Issue Type: New

[jira] [Commented] (THRIFT-4495) Erlang records should allow 'undefined' for non-required fields

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362836#comment-16362836 ] ASF GitHub Bot commented on THRIFT-4495: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1494: THRIFT-4495: Allow `undefined` for non-required Erlang r...

2018-02-13 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1494 We use these versions in CI today, FYI: trusty: R16B03 xenial: 18.3 (this is the one we run "make cross" under) artful: 20.0.4 ---

[jira] [Commented] (THRIFT-4495) Erlang records should allow 'undefined' for non-required fields

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362761#comment-16362761 ] ASF GitHub Bot commented on THRIFT-4495: GitHub user dhull opened a pull request:

[GitHub] thrift pull request #1494: THRIFT-4495: Allow `undefined` for non-required E...

2018-02-13 Thread dhull
GitHub user dhull opened a pull request: https://github.com/apache/thrift/pull/1494 THRIFT-4495: Allow `undefined` for non-required Erlang records fields. As of Erlang 19, the dialyzer static type-analysis tool no longer implicitly adds `undefined` to the allowed types for a field.

[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context

2018-02-13 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1459 Would you mind squashing this into a single commit? ---

[jira] [Created] (THRIFT-4495) Erlang records should allow 'undefined' for non-required fields

2018-02-13 Thread David Hull (JIRA)
David Hull created THRIFT-4495: -- Summary: Erlang records should allow 'undefined' for non-required fields Key: THRIFT-4495 URL: https://issues.apache.org/jira/browse/THRIFT-4495 Project: Thrift

[jira] [Commented] (THRIFT-4494) Increase Java Socket Buffer Size

2018-02-13 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362559#comment-16362559 ] BELUGA BEHR commented on THRIFT-4494: - Here, the buffer is hard-coded to 8192 (which matches the

[jira] [Created] (THRIFT-4494) Increase Java Socket Buffer Size

2018-02-13 Thread BELUGA BEHR (JIRA)
BELUGA BEHR created THRIFT-4494: --- Summary: Increase Java Socket Buffer Size Key: THRIFT-4494 URL: https://issues.apache.org/jira/browse/THRIFT-4494 Project: Thrift Issue Type: Improvement