stale[bot] commented on pull request #2029:
URL: https://github.com/apache/thrift/pull/2029#issuecomment-619322505
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed in 7 days if no further activity occurs.
Thank you for your
stale[bot] commented on pull request #1997:
URL: https://github.com/apache/thrift/pull/1997#issuecomment-619322506
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed in 7 days if no further activity occurs.
Thank you for your
dcelasun commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619266798
Tests are [failing](https://api.travis-ci.org/v3/job/679128191/log.txt).
```
gopath/src/tests/multiplexed_protocol_test.go:72:35: cannot use processor
(type
dcelasun commented on a change in pull request #2121:
URL: https://github.com/apache/thrift/pull/2121#discussion_r414897662
##
File path: lib/cpp/Makefile.am
##
@@ -87,6 +87,7 @@ libthrift_la_SOURCES = src/thrift/TApplicationException.cpp \
penenin opened a new pull request #2121:
URL: https://github.com/apache/thrift/pull/2121
Add support for using WebSockets as a server transport to the C++ library.
- [X] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
penenin opened a new pull request #2120:
URL: https://github.com/apache/thrift/pull/2120
When establishing a WebSocket connection, Firefox sends Connection:
keep-alive, Upgrade instead of just Connection: Upgrade. Check to see if
Upgrade is in the header instead of checking to see if
James Lacey created THRIFT-5185:
---
Summary: C++: Add WebSocket Server Transport
Key: THRIFT-5185
URL: https://issues.apache.org/jira/browse/THRIFT-5185
Project: Thrift
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duru Can Celasun reassigned THRIFT-5164:
Assignee: Duru Can Celasun
> Go middleware support
> -
>
>
dcelasun commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619146495
@fishy @pacejackson thanks for the PR, I've been looking forward to this!
I'll play around with this locally tomorrow and we'll take it from there.
[
https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuxuan Wang updated THRIFT-5164:
Labels: Breaking-Change (was: )
> Go middleware support
> -
>
>
fishy commented on pull request #2119:
URL: https://github.com/apache/thrift/pull/2119#issuecomment-619143377
@dcelasun :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pacejackson opened a new pull request #2119:
URL: https://github.com/apache/thrift/pull/2119
Client: go
This PR adds a simple middleware framework for Go servers.
It provides:
1. A `ProcessorMiddleware` function interface used to define the actual
middleware
2.
emmenlau opened a new pull request #2118:
URL: https://github.com/apache/thrift/pull/2118
This PR adds cmake support for the C# netstd implementation. The major
changes are only in cmake and in the Visual Studio project files. The actual
build is executed via `dotnet` (which has to be
dcelasun commented on pull request #2115:
URL: https://github.com/apache/thrift/pull/2115#issuecomment-619019610
LGTM and all tests are green.
This is an automated message from the Apache Git Service.
To respond to the
dcelasun commented on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-619018047
Actually, the build is all green now, so I'm gonna go ahead and merge it.
Thanks everyone!
This is an
dcelasun commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618984445
That's a great idea actually, please go ahead and change it.
This is an automated message from the Apache Git
emmenlau commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618958494
Dammit, you are right! Thanks.
Slightly off-topic, I think the comments in the Dockerfile should really be
changed. I've had good experience with adding comments in
dcelasun edited a comment on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-618949715
> It is waiting for someone with commit rights to either merge this or
complain :)
I'm not familiar with Swift but others in this PR seem to be, so I'd be
happy
dcelasun commented on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-618949715
> It is waiting for someone with commit rights to either merge this or
complain :)
I'm not familiar with thrift but others in this PR seem to be, so I'd be
happy to
alexanderedge commented on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-618948182
> @alexanderedge could you please rebase from master? The CI failures are
unrelated but there have been some fixes on master and I'd like to see if we
can get a green
janosvitok commented on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-618947781
@kirviz: It is waiting for someone with commit rights to either merge this
or complain :) In the mean time, if you can try this at home :) and report the
results here (e.g.
dcelasun commented on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-618946513
@alexanderedge could you please rebase from master? The CI failures are
unrelated but there have been some fixes on master and I'd like to see if we
can get a green build
kirviz commented on pull request #2073:
URL: https://github.com/apache/thrift/pull/2073#issuecomment-61897
Hi guys, I'm trying to find my way around here and eager for this PR.
I see the changes have been approved. Could anyone tell me what happens next?
dcelasun edited a comment on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618937017
I've restarted it and it failed again, because there really is a bug
:slightly_smiling_face: This:
```
echo "deb https://deb.nodesource.com/node_10.x xenial
dcelasun commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618937017
I've restarted it and it failed again, because there really is a bug
:slightly_smiling_face: This:
```
echo "deb https://deb.nodesource.com/node_10.x xenial main" |
emmenlau commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618924107
> Unfortunately this seems to have broken Travis:
>
> > Error response from daemon: Dockerfile parse error line 60: unknown
instruction: APT-ADD-REPOSITORY
> > The
dcelasun commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618919413
Unfortunately this seems to have broken Travis:
> Rebuilding docker image ubuntu-xenial
> Sending build context to Docker daemon 11.26kB
> Error response from
zeshuai007 opened a new pull request #2117:
URL: https://github.com/apache/thrift/pull/2117
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does
CC'ing James King who did our Travis setup IIRC.
On Fri, 24 Apr 2020, at 10:42, Mario Emmenlauer wrote:
>
> In the past weeks I've had a significant number of failing Travis CI
> builds, the majority of which was failing in something that looked like
> a docker build.
>
> Is it correct and
In the past weeks I've had a significant number of failing Travis CI
builds, the majority of which was failing in something that looked like
a docker build.
Is it correct and intended that Travis builds, or at least updates, a
docker image for every test? Maybe this step could be split out of
zeshuai007 opened a new pull request #2089:
URL: https://github.com/apache/thrift/pull/2089
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does
emmenlau opened a new pull request #2116:
URL: https://github.com/apache/thrift/pull/2116
This PR adds wrapping to the TZlibTransportFactory. This is very helpful so
that servers can create their "normal" transport factory like before, then wrap
it into a TZlibTransportFactory.
zeshuai007 commented on pull request #2089:
URL: https://github.com/apache/thrift/pull/2089#issuecomment-618908962
hi, @dcelasun
I have modified it locally and can resubmit this PR. can you reopen this PR?
This is an
emmenlau opened a new pull request #2115:
URL: https://github.com/apache/thrift/pull/2115
The Thrift implementations for NodeJS and Javascript seem to have come from
the same origins, and the code shares a strong resemblance. However it seems
the implementations have deviated over time.
[
https://issues.apache.org/jira/browse/THRIFT-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Emmenlauer closed THRIFT-4759.
Assignee: James E. King III
Resolution: Fixed
This has been merged and fixed.
>
[
https://issues.apache.org/jira/browse/THRIFT-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Emmenlauer closed THRIFT-4819.
Resolution: Cannot Reproduce
I think this may be related to dynamic linking of Thrift,
[
https://issues.apache.org/jira/browse/THRIFT-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Emmenlauer closed THRIFT-5112.
Resolution: Duplicate
This issue is indeed a duplicate of "Moving website content to new
emmenlau opened a new pull request #2114:
URL: https://github.com/apache/thrift/pull/2114
This is a minor PR that removes the (now deprecated) boost dependency from
the tests of Thrift compiler, and removes the (unused) script `bincat.sh`. I'm
curious if the CI finds any problems...
emmenlau commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618865274
Thanks @dcelasun, fixed now. Please review.
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/THRIFT-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duru Can Celasun resolved THRIFT-4282.
--
Fix Version/s: 0.14.0
Resolution: Resolved
> StressTestNonBlocking is disabled
dcelasun commented on pull request #2106:
URL: https://github.com/apache/thrift/pull/2106#issuecomment-618835805
CI is all green, merged.
This is an automated message from the Apache Git Service.
To respond to the message,
dcelasun commented on pull request #2113:
URL: https://github.com/apache/thrift/pull/2113#issuecomment-618832363
Tests are failing:
```
File "test/thrift_json.py", line 79
if __name__ == '__main__':
^
SyntaxError: invalid syntax
dcelasun commented on pull request #2110:
URL: https://github.com/apache/thrift/pull/2110#issuecomment-618831826
Thanks! CI failures are unrelated so I'm merging this.
This is an automated message from the Apache Git
43 matches
Mail list logo
