[GitHub] [thrift] compdzwio opened a new pull request #2433: Update compact_protocol.js

2021-08-06 Thread GitBox
compdzwio opened a new pull request #2433: URL: https://github.com/apache/thrift/pull/2433 fix bug - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [ ] If a ticket

[jira] [Comment Edited] (THRIFT-5451) Thrift compiler binary distributions

2021-08-06 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394930#comment-17394930 ] Yuxuan Wang edited comment on THRIFT-5451 at 8/6/21, 6:12 PM: -- Another

[jira] [Commented] (THRIFT-5451) Thrift compiler binary distributions

2021-08-06 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394934#comment-17394934 ] Jens Geyer commented on THRIFT-5451:

[jira] [Updated] (THRIFT-5451) Thrift compiler binary distributions

2021-08-06 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5451: --- Issue Type: Wish (was: Dependency upgrade) > Thrift compiler binary distributions >

[jira] [Updated] (THRIFT-5451) Thrift compiler binary distributions

2021-08-06 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5451: --- Component/s: (was: Website) (was: Compiler (General)) > Thrift compiler

[jira] [Commented] (THRIFT-5451) Thrift compiler binary distributions

2021-08-06 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394930#comment-17394930 ] Yuxuan Wang commented on THRIFT-5451: - Another option is to build a docker image to run the

[jira] [Commented] (THRIFT-5451) Thrift compiler binary distributions

2021-08-06 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394913#comment-17394913 ] Benjamin Marwell commented on THRIFT-5451: -- Hi Mario,   This can easily be solved by static

[jira] [Commented] (THRIFT-5451) Thrift compiler binary distributions

2021-08-06 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394833#comment-17394833 ] Mario Emmenlauer commented on THRIFT-5451: -- I agree that this would be nice to have. But

[jira] [Updated] (THRIFT-5451) Thrift compiler binary distributions

2021-08-06 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Emmenlauer updated THRIFT-5451: - Priority: Minor (was: Major) > Thrift compiler binary distributions >

Re: AppVeyor build instructions update imminent - is it ok?

2021-08-06 Thread Mario Emmenlauer
Dear Thrift developers, I've completed a large update of the AppVeyor build instructions. It would be great to get some feedback. Most importantly, MSVC builds did not execute any tests in the past, possibly for a long time. This has been fixed - the ctest exclude regexp was set to empty which

Re: question about pull request

2021-08-06 Thread Mario Emmenlauer
Dear Kumar, On 06.08.21 08:55, Duru Can Celasun wrote: > On Fri, 6 Aug 2021, at 04:03, Bhalchandra Pandit wrote: >> I created this pull request >> which only has javadoc fixes. Apparently, some checks failed (appveyor and >> travis ci). I looked at the

[jira] [Created] (THRIFT-5451) Thrift compiler binary distributions

2021-08-06 Thread Benjamin Marwell (Jira)
Benjamin Marwell created THRIFT-5451: Summary: Thrift compiler binary distributions Key: THRIFT-5451 URL: https://issues.apache.org/jira/browse/THRIFT-5451 Project: Thrift Issue Type:

Re: question about pull request

2021-08-06 Thread Duru Can Celasun
On Fri, 6 Aug 2021, at 04:03, Bhalchandra Pandit wrote: > I created this pull request > which only has javadoc fixes. Apparently, some checks failed (appveyor and > travis ci). I looked at the links but I am not able to figure out why they > failed for