[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155962#comment-16155962
]
Chris Bannister edited comment on THRIFT-4285 at 9/6/17 8:16 PM:
--
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-4285:
Attachment: 0001-go-pull-generated-send-recv-into-lib-v7.patch
Updated all tests (hopefully
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-4285:
Attachment: (was: 0001-go-pull-generated-send-recv-into-lib-v5.patch)
> Pull generated
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-4285:
Attachment: 0001-go-pull-generated-send-recv-into-lib-v6.patch
Fixed and updated the tests
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-4285:
Attachment: (was: 0001-go-pull-generated-send-recv-into-lib-v3.patch)
> Pull generated
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-4285:
Attachment: (was: 0001-go-pull-generated-send-recv-into-lib.patch)
> Pull generated sen
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-4285:
Attachment: (was: 0001-go-pull-generated-send-recv-into-lib-v4.patch)
> Pull generated
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-4285:
Attachment: 0001-go-pull-generated-send-recv-into-lib-v5.patch
Fix nil error with a set typ
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-4285:
Attachment: (was: 0001-go-pull-generated-send-recv-into-lib-2.patch)
> Pull generated s
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132000#comment-16132000
]
Chris Bannister edited comment on THRIFT-4285 at 8/18/17 10:05 AM:
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-4285:
Attachment: 0001-go-pull-generated-send-recv-into-lib-v4.patch
Fix typo, use tmp names for
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-4285:
Attachment: 0001-go-pull-generated-send-recv-into-lib-v3.patch
Export TStandardClient as it
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-4285:
Attachment: 0001-go-pull-generated-send-recv-into-lib-2.patch
removed unnecessary interface
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124980#comment-16124980
]
Chris Bannister commented on THRIFT-4285:
-
Something I just noticed, no need to d
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124955#comment-16124955
]
Chris Bannister commented on THRIFT-4285:
-
This is a breaking change for the gene
[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-4285:
Attachment: 0001-go-pull-generated-send-recv-into-lib.patch
> Pull generated send/recv into
Chris Bannister created THRIFT-4285:
---
Summary: Pull generated send/recv into library to allow behaviour
to be customised
Key: THRIFT-4285
URL: https://issues.apache.org/jira/browse/THRIFT-4285
Proje
[
https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344427#comment-15344427
]
Chris Bannister commented on THRIFT-3799:
-
I would say this is not a good idea, a
[
https://issues.apache.org/jira/browse/THRIFT-3805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275738#comment-15275738
]
Chris Bannister commented on THRIFT-3805:
-
The check for the buffer size should b
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-3533:
Attachment: 0001-THRIFT-3533-go-check-that-the-struct-is-nil-before-w.patch
> Can not send
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266835#comment-15266835
]
Chris Bannister commented on THRIFT-3533:
-
[~jensg] sorry for the delay, can you
Chris Bannister created THRIFT-3575:
---
Summary: Go compiler tries to use unexported library methods when
using read_write_private
Key: THRIFT-3575
URL: https://issues.apache.org/jira/browse/THRIFT-3575
[
https://issues.apache.org/jira/browse/THRIFT-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-3575:
Attachment: 0001-go-dont-use-reader-writer-names-for-lib-functions.patch
> Go compiler trie
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109649#comment-15109649
]
Chris Bannister edited comment on THRIFT-3533 at 1/20/16 10:56 PM:
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109649#comment-15109649
]
Chris Bannister edited comment on THRIFT-3533 at 1/20/16 10:50 PM:
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109649#comment-15109649
]
Chris Bannister commented on THRIFT-3533:
-
Yeah that is a bit of a pain, I think
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108954#comment-15108954
]
Chris Bannister commented on THRIFT-3533:
-
[~jensg] can you take a look at this p
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-3533:
Patch Info: Patch Available
> Can not send nil pointer as service method argument
> ---
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-3533:
Attachment: 0001-go-compiler-handle-nil-fields-correctly.patch
> Can not send nil pointer a
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090984#comment-15090984
]
Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:12 AM:
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090984#comment-15090984
]
Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:11 AM:
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090984#comment-15090984
]
Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:11 AM:
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090984#comment-15090984
]
Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:10 AM:
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090984#comment-15090984
]
Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:10 AM:
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090984#comment-15090984
]
Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:08 AM:
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090984#comment-15090984
]
Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:09 AM:
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090984#comment-15090984
]
Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:09 AM:
[
https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090984#comment-15090984
]
Chris Bannister commented on THRIFT-3533:
-
In python you can write this,
service
Chris Bannister created THRIFT-3533:
---
Summary: Can not send nil pointer as service method argument
Key: THRIFT-3533
URL: https://issues.apache.org/jira/browse/THRIFT-3533
Project: Thrift
Is
[
https://issues.apache.org/jira/browse/THRIFT-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183063#comment-14183063
]
Chris Bannister commented on THRIFT-2791:
-
Is this necessary as you can wrap the
[
https://issues.apache.org/jira/browse/THRIFT-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051870#comment-14051870
]
Chris Bannister edited comment on THRIFT-2598 at 7/3/14 8:19 PM:
--
[
https://issues.apache.org/jira/browse/THRIFT-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051870#comment-14051870
]
Chris Bannister commented on THRIFT-2598:
-
It should be possible to work around t
[
https://issues.apache.org/jira/browse/THRIFT-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983157#comment-13983157
]
Chris Bannister commented on THRIFT-2502:
-
This is awesome
> Optimize go impleme
[
https://issues.apache.org/jira/browse/THRIFT-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975520#comment-13975520
]
Chris Bannister commented on THRIFT-2488:
-
You should get output along the lines
[
https://issues.apache.org/jira/browse/THRIFT-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-2488:
Attachment: timeout.thrift
testcase.go
> Timeouts can leave client in unre
Chris Bannister created THRIFT-2488:
---
Summary: Timeouts can leave client in unrecoverable state
Key: THRIFT-2488
URL: https://issues.apache.org/jira/browse/THRIFT-2488
Project: Thrift
Issue
[
https://issues.apache.org/jira/browse/THRIFT-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-2488:
Affects Version/s: 0.9.1
> Timeouts can leave client in unrecoverable state
>
[
https://issues.apache.org/jira/browse/THRIFT-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974878#comment-13974878
]
Chris Bannister commented on THRIFT-2009:
-
Not yet, I think we should change publ
[
https://issues.apache.org/jira/browse/THRIFT-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974138#comment-13974138
]
Chris Bannister commented on THRIFT-2009:
-
This change causes service methods whi
[
https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959245#comment-13959245
]
Chris Bannister commented on THRIFT-2445:
-
Shouldnt this be part of test/go ?
>
[
https://issues.apache.org/jira/browse/THRIFT-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943032#comment-13943032
]
Chris Bannister commented on THRIFT-2419:
-
Yeah after your comment I figured I wo
[
https://issues.apache.org/jira/browse/THRIFT-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943029#comment-13943029
]
Chris Bannister commented on THRIFT-2420:
-
Again good spot :) Makes sense to me.
Chris Bannister created THRIFT-2419:
---
Summary: golang - Fix fmt.Errorf in generated code
Key: THRIFT-2419
URL: https://issues.apache.org/jira/browse/THRIFT-2419
Project: Thrift
Issue Type:
[
https://issues.apache.org/jira/browse/THRIFT-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-2419:
Attachment: 0001-Fix-fmt.Errorf-not-formatting-the-error.patch
> golang - Fix fmt.Errorf i
[
https://issues.apache.org/jira/browse/THRIFT-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942205#comment-13942205
]
Chris Bannister commented on THRIFT-2418:
-
Good spot, looks good to me.
> Go han
[
https://issues.apache.org/jira/browse/THRIFT-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-2388:
Description:
The documentation for Interrupt() on server_transport states that
implementa
Chris Bannister created THRIFT-2388:
---
Summary: GoLang - Fix data races in simple_server and server_socket
Key: THRIFT-2388
URL: https://issues.apache.org/jira/browse/THRIFT-2388
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-2388:
Attachment: 0001-Fix-data-races-in-simple_server-and-server_socket.patch
> GoLang - Fix da
Chris Bannister created THRIFT-2349:
---
Summary: Golang - improve tutorial
Key: THRIFT-2349
URL: https://issues.apache.org/jira/browse/THRIFT-2349
Project: Thrift
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/THRIFT-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-2349:
Attachment: THRIFT-2349.patch
> Golang - improve tutorial
> -
>
>
[
https://issues.apache.org/jira/browse/THRIFT-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-2343:
Attachment: 0002-Update-tutorial-to-reflect-changes-to-exceptions.patch
000
[
https://issues.apache.org/jira/browse/THRIFT-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891344#comment-13891344
]
Chris Bannister commented on THRIFT-2343:
-
I've fixed that, do you want me to su
[
https://issues.apache.org/jira/browse/THRIFT-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-2343:
Description:
Currently the Thrift compiler for Go generates some very ugly (by Go's
stand
[
https://issues.apache.org/jira/browse/THRIFT-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-2343:
Attachment: 0002-go-processor-exceptions-are-treated-as-one-error.patch
000
Chris Bannister created THRIFT-2343:
---
Summary: Golang - Return a single error for all exceptions instead
of multiple return values
Key: THRIFT-2343
URL: https://issues.apache.org/jira/browse/THRIFT-2343
[
https://issues.apache.org/jira/browse/THRIFT-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Bannister updated THRIFT-2337:
Attachment: THRIFT-2337-golang-timeouts.patch
> Golang does not report TIMED_OUT exception
Chris Bannister created THRIFT-2337:
---
Summary: Golang does not report TIMED_OUT exceptions
Key: THRIFT-2337
URL: https://issues.apache.org/jira/browse/THRIFT-2337
Project: Thrift
Issue Type
67 matches
Mail list logo