Re: [VOTE] Apache Thrift 0.20.0-rc1 release candidate

2024-03-14 Thread Duru Can Celasun
+1 On Thu, 14 Mar 2024, at 20:21, Yuxuan Wang wrote: > +1 > > On Tue, Mar 12, 2024 at 3:13 PM Jens Geyer wrote: > >> All, >> >> I propose that we accept the following release candidate as the official >> Apache Thrift 0.20.0 release: >> >> >>

[jira] [Commented] (THRIFT-3037) Can not build Go code when using typedef in IDL

2023-11-27 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790269#comment-17790269 ] Duru Can Celasun commented on THRIFT-3037: -- You should be able to do it yourself. From

[jira] [Assigned] (THRIFT-3037) Can not build Go code when using typedef in IDL

2023-11-27 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun reassigned THRIFT-3037: Assignee: (was: Duru Can Celasun) > Can not build Go code when using type

[jira] [Commented] (THRIFT-5745) go: Implement slog.LogValuer for exceptions and/or structs

2023-11-17 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787407#comment-17787407 ] Duru Can Celasun commented on THRIFT-5745: -- The Stringer implementation has been a long time

[jira] [Commented] (THRIFT-5744) Proposal: Switch all go logging in the library to slog

2023-11-17 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787349#comment-17787349 ] Duru Can Celasun commented on THRIFT-5744: -- I haven't had a chance to use slog at scale (we use

Re: [VOTE] Apache Thrift 0.19.0-rc1 release candidate

2023-08-30 Thread Duru Can Celasun
+1 On Wed, 30 Aug 2023, at 17:39, Yuxuan Wang wrote: > +1 > > On Sun, Aug 27, 2023 at 7:22 AM Jens Geyer wrote: > >> All, >> >> I propose that we accept the following release candidate as the official >> Apache Thrift 0.19.0 release: >> >> >>

Re: [VOTE] Apache Thrift 0.19.0-rc0 release candidate

2023-08-08 Thread Duru Can Celasun
+1 We've been using this RC in production for about a week with no issues. On Mon, 7 Aug 2023, at 18:19, Yuxuan Wang wrote: > +1. > > We tested the go compiler/lib but didn't finish the python test in time but > don't want to hold this forever. > > Also there's a new RC for go1.21 so I don't

Re: [VOTE] Apache Thrift 0.18.1-rc0 release candidate

2023-02-24 Thread Duru Can Celasun
+1 On Thu, 23 Feb 2023, at 21:31, Jens Geyer wrote: > @all, > > I propose that we accept the following release candidate as the official > Apache Thrift 0.18.1 release: > > https://dist.apache.org/repos/dist/dev/thrift/0.18.1-rc0/thrift-0.18.1.tar.gz > > The release candidate was created from

Re: [VOTE] Apache Thrift 0.18.0-rc0 release candidate

2023-02-07 Thread Duru Can Celasun
+1 On Tue, 7 Feb 2023, at 20:50, Yuxuan Wang wrote: > +1 > > On Mon, Feb 6, 2023 at 4:12 PM Jens Geyer wrote: > >> All, >> >> I propose that we accept the following release candidate as the official >> Apache Thrift 0.18.0 release: >> >> >>

Re: The UUID change seems to be a big breaking change

2022-09-09 Thread Duru Can Celasun
Agreed. It seems a new reserved word is unavoidable, so let's at least prefix it. On Fri, 9 Sep 2022, at 18:30, Yuxuan Wang wrote: > If making it not a reserved word is infeasible, my next suggestion would be > to rename it to something like "tuuid" (similar to how we prefix t to a lot > of the

Re: [VOTE] Apache Thrift 0.17.0-rc0 release candidate

2022-09-08 Thread Duru Can Celasun
+1 On Thu, 8 Sep 2022, at 18:34, Yuxuan Wang wrote: > +1 > > On Wed, Sep 7, 2022 at 1:50 PM Jens Geyer wrote: > >> All, >> >> I propose that we accept the following release candidate as the official >> Apache Thrift 0.17.0 release: >> >> >>

[jira] [Commented] (THRIFT-5609) TJSONProtocol and TSimpleJSONProtocol are unsafe to be used with TDeserializerPool and TSerializerPool

2022-08-05 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576063#comment-17576063 ] Duru Can Celasun commented on THRIFT-5609: -- 4 is clean and safe, but 2 is cleaner. Can you

Re: [VOTE] Apache Thrift 0.16.0-rc2 release candidate

2022-02-10 Thread Duru Can Celasun
+1 On Thu, 10 Feb 2022, at 18:48, Yuxuan Wang wrote: > +1 > > Thanks for all the work, Jens! > > On Wed, Feb 9, 2022 at 12:19 PM Jens Geyer wrote: > >> >> All, >> >> I propose that we accept the following release candidate as the official >> Apache Thrift 0.16.0 release: >> >> >>

Re: [VOTE] Apache Thrift 0.16.0-rc1 release candidate

2022-02-05 Thread Duru Can Celasun
+1 On Sat, 5 Feb 2022, at 21:56, Mario Emmenlauer wrote: > Thanks a lot Jens! +1 from my side, and keep up the good work! > > Happy evening, > > Mario > > > On 04.02.22 23:10, Jens Geyer wrote: >> All, >> >> I propose that we accept the following release candidate as the official >> Apache

[jira] [Commented] (THRIFT-5509) Potential connection leaks caused by the connectivity check

2022-02-03 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486650#comment-17486650 ] Duru Can Celasun commented on THRIFT-5509: -- Option 2, definitely. > Potential connection le

Re: Drop support of Python 2?

2022-01-07 Thread Duru Can Celasun
On Fri, 7 Jan 2022, at 21:27, Yuxuan Wang wrote: > According to https://www.python.org/doc/sunset-python-2/, support for > Python 2 was stopped from 2020-01-01, which is already more than two years > ago from now. Is there any reason that thrift should continue to support > Python 2 in the newer

Re: [VOTE] Apache Thrift 0.15.0-rc0 release candidate

2021-09-07 Thread Duru Can Celasun
+1 On Wed, 8 Sep 2021, at 01:31, Yuxuan Wang wrote: > +1 > > On Sat, Sep 4, 2021 at 1:01 PM Jens Geyer wrote: > > > All, > > > > I propose that we accept the following release candidate as the official > > Apache Thrift 0.15.0 release: > > > > > >

Re: question about pull request

2021-08-06 Thread Duru Can Celasun
On Fri, 6 Aug 2021, at 04:03, Bhalchandra Pandit wrote: > I created this pull request > which only has javadoc fixes. Apparently, some checks failed (appveyor and > travis ci). I looked at the links but I am not able to figure out why they > failed for

Re: partial deserialization of Thrift

2021-07-13 Thread Duru Can Celasun
artial <=> full). The >solution enables selectively deserializing any arbitrary nested subset. > > Kumar > > On Mon, Jul 12, 2021 at 4:10 PM Duru Can Celasun > wrote: > > > This is definitely an interesting problem at scale and it'd be great to > > have

Re: partial deserialization of Thrift

2021-07-12 Thread Duru Can Celasun
This is definitely an interesting problem at scale and it'd be great to have a solution upstream. I second Yuxuan's questions. From the blog post it seems you have an implementation for Java, but it would be great to have at least one more. On Tue, 13 Jul 2021, at 00:00, Yuxuan Wang wrote: >

Re: [VOTE] Apache Thrift 0.14.2-rc1 release candidate

2021-06-12 Thread Duru Can Celasun
+1 On Sat, 12 Jun 2021, at 18:27, Yuxuan Wang wrote: > +1 > > On Sat, Jun 12, 2021 at 10:13 AM Jens Geyer wrote: > > > All, > > > > I propose that we accept the following release candidate as the official > > Apache Thrift 0.14.2 release: > > > > > >

Re: [VOTE] Apache Thrift 0.14.1-rc0 release candidate

2021-03-02 Thread Duru Can Celasun
+1 On Tue, 2 Mar 2021, at 23:13, Yuxuan Wang wrote: > +1 > > On Tue, Mar 2, 2021 at 1:35 PM Jens Geyer wrote: > > > All, > > > > I propose that we accept the following release candidate as the official > > Apache Thrift 0.14.1 release: > > > > > >

Re: Travis open-source builds sharply reduced

2021-03-02 Thread Duru Can Celasun
Keep in mind that the ASF has a paid subscription [1] to Travis, so we are not limited to the open source plan. [1] https://blogs.apache.org/infra/entry/apache_gains_additional_travis_ci On Tue, 2 Mar 2021, at 08:28, Mario Emmenlauer wrote: > > Hi, > > On 02.03.21 05:28, Allen George wrote: >

[jira] [Comment Edited] (THRIFT-5358) Add go.mod file(s)

2021-02-19 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287393#comment-17287393 ] Duru Can Celasun edited comment on THRIFT-5358 at 2/19/21, 10:18 PM

[jira] [Commented] (THRIFT-5358) Add go.mod file(s)

2021-02-19 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287398#comment-17287398 ] Duru Can Celasun commented on THRIFT-5358: -- Ah ok, we haven't upgraded to 1.16 yet so I assumed

[jira] [Comment Edited] (THRIFT-5358) Add go.mod file(s)

2021-02-19 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287393#comment-17287393 ] Duru Can Celasun edited comment on THRIFT-5358 at 2/19/21, 10:03 PM

[jira] [Commented] (THRIFT-5358) Add go.mod file(s)

2021-02-19 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287393#comment-17287393 ] Duru Can Celasun commented on THRIFT-5358: -- Sounds like a plan. I suggest we do a quick 0.14.1

Re: [VOTE][RESULT] Apache Thrift 0.14.0-rc0 release candidate

2021-02-10 Thread Duru Can Celasun
s vote (we should) we can go ahead with the release. Thoughts? On Wed, 10 Feb 2021, at 20:04, Jens Geyer wrote: > All, > > Including my own vote of +1 we have 2 binding +1. > Additionally, we received one non-binding +1. > No -1 votes have been cast. > > Binding Votes > +

Re: [VOTE] Apache Thrift 0.14.0-rc0 release candidate

2021-02-04 Thread Duru Can Celasun
+1 On Fri, 5 Feb 2021, at 00:13, Yuxuan Wang wrote: > +1 (is this how voting works?) > > Also I think you have a typo on the branch name. I don't see > "release/0.14.0" branch, but I do see "0.14.0" branch > > On Thu, Feb 4, 2021 at 3:52 PM Jens Geyer wrote: > > > All, > > > > I propose that

[jira] [Commented] (THRIFT-4914) Go: Link between THeader and context object

2021-01-22 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270055#comment-17270055 ] Duru Can Celasun commented on THRIFT-4914: -- Sounds reasonable. I agree that there are likely

[jira] [Comment Edited] (THRIFT-5338) Proposal: Raise minimal supported Go version with upcoming 0.14.0 release

2021-01-19 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268065#comment-17268065 ] Duru Can Celasun edited comment on THRIFT-5338 at 1/19/21, 5:35 PM

[jira] [Commented] (THRIFT-5338) Proposal: Raise minimal supported Go version with upcoming 0.14.0 release

2021-01-19 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268065#comment-17268065 ] Duru Can Celasun commented on THRIFT-5338: -- I'm happy to go for 1.14x. It has been quite

Re: Plans/process for 0.14.0 release?

2021-01-06 Thread Duru Can Celasun
I'd say get as many commits in as you can. Our release schedule is at best erratic, who knows when 0.15 might happen :) On Wed, 6 Jan 2021, at 21:35, Mario Emmenlauer wrote: > > On 04.01.21 21:41, Yuxuan Wang wrote: > > Judging from history the end of the years are usually when we do releases,

Re: Plans/process for 0.14.0 release?

2021-01-05 Thread Duru Can Celasun
xt release > (v0.14.0). @Can might take a look at them? :) > > On Tue, Jan 5, 2021 at 2:38 PM Duru Can Celasun wrote: > > > I'm in favour of cutting a new release, though I never did one for thrift > > and I won't have the time to get involved any time soon. > > >

Re: Plans/process for 0.14.0 release?

2021-01-05 Thread Duru Can Celasun
I'm in favour of cutting a new release, though I never did one for thrift and I won't have the time to get involved any time soon. On Tue, 5 Jan 2021, at 21:47, Jens Geyer wrote: > @all > > > Good question. I'm in favour of it. Who does it? > > That was actually a real question. I support the

[jira] [Commented] (THRIFT-5326) Expand TException interface in go library

2020-12-21 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253300#comment-17253300 ] Duru Can Celasun commented on THRIFT-5326: -- I like the enum approach better. This will break

[jira] [Commented] (THRIFT-5322) Go compact_protocol allocating unreasonable buffer size

2020-12-10 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247254#comment-17247254 ] Duru Can Celasun commented on THRIFT-5322: -- Buffer size limits have been implemented [1

[jira] [Commented] (THRIFT-4685) Support the new golang modules (1.11 or later)

2020-12-08 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246095#comment-17246095 ] Duru Can Celasun commented on THRIFT-4685: -- Indeed, even the Go module spec [1] mentions

[jira] [Commented] (THRIFT-4685) Support the new golang modules (1.11 or later)

2020-12-08 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245965#comment-17245965 ] Duru Can Celasun commented on THRIFT-4685: -- I'm not sure if it's ok to change the versioning

Re: Your project's website

2020-10-30 Thread Duru Can Celasun
'm still pretty new to the project > and might have missed if you sent it already, sorry for that :-( > > All the best, Mario > > > On 30.10.20 11:19, Duru Can Celasun wrote: > > I've created the repo using self-service > > https://github.com/apache/thrift-website &

Re: Your project's website

2020-10-30 Thread Duru Can Celasun
branch > to the publish branch (see README for explanation), and then you'll be > completely off of CMS and can do whatever you want after that. :) > > On Thu, Oct 29, 2020 at 4:08 PM Duru Can Celasun wrote: > > > > This looks excellent Christopher, thank you for working on this

Re: Your project's website

2020-10-29 Thread Duru Can Celasun
till finishing up) is at > https://github.com/ctubbsii/thrift-website > Of course, the Thrift PMC is not obligated to use what I've done, but > it will get them off of CMS immediately if they want to use it. > > On Thu, Oct 29, 2020 at 5:08 AM Mario Emmenlauer wrote: > > > &

Re: Your project's website

2020-10-28 Thread Duru Can Celasun
Apologies, I thought I was replying to Andrew and I only just now realize it was Christopher. My point stands though, if there is an easier/preferred way to do this just let me know and we'll do that. On Wed, 28 Oct 2020, at 17:46, Duru Can Celasun wrote: > Andrew, > > I think there

Re: Your project's website

2020-10-28 Thread Duru Can Celasun
-4710?focusedCommentId=16972218=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16972218 > > On Wed, Oct 28, 2020 at 8:43 AM Duru Can Celasun wrote: > > > > Hi Andrew, > > > > The site on ReadTheDocs [1] isn't just documentation, it'

Re: Your project's website

2020-10-28 Thread Duru Can Celasun
project's migration so we can keep track of what we need to do to provide a > smooth transition for the project. > > Andrew > > On Sat, Oct 3, 2020 at 1:10 PM Duru Can Celasun wrote: > > > Hi Andrew, > > > > Any news on this? How should we proceed? >

Re: Your project's website

2020-10-03 Thread Duru Can Celasun
Hi Andrew, Any news on this? How should we proceed? Cheers, Can On Wed, 26 Aug 2020, at 16:38, Duru Can Celasun wrote: > Hi Andrew, > > Sorry for the late response. Last year I started working on a migration > from Apache CMS to "read the docs" [1] but I never got

Re: Your project's website

2020-08-26 Thread Duru Can Celasun
Hi Andrew, Sorry for the late response. Last year I started working on a migration from Apache CMS to "read the docs" [1] but I never got a chance to finish it. It's mostly complete, but we could definitely use some INFRA help to get it over the finish line. Would it be possible to have a

[jira] [Commented] (THRIFT-5269) Contexts are missing from GO generated code

2020-08-24 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183399#comment-17183399 ] Duru Can Celasun commented on THRIFT-5269: -- Sorry, we don't have a fixed schedule. It should

[jira] [Resolved] (THRIFT-5269) Contexts are missing from GO generated code

2020-08-24 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5269. -- Resolution: Not A Problem > Contexts are missing from GO generated c

[jira] [Updated] (THRIFT-5269) Contexts are missing from GO generated code

2020-08-24 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun updated THRIFT-5269: - Priority: Trivial (was: Blocker) > Contexts are missing from GO generated c

[jira] [Commented] (THRIFT-5269) Contexts are missing from GO generated code

2020-08-24 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183373#comment-17183373 ] Duru Can Celasun commented on THRIFT-5269: -- OK, I see the problem. You are trying to use the Go

[jira] [Commented] (THRIFT-5269) Contexts are missing from GO generated code

2020-08-24 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183362#comment-17183362 ] Duru Can Celasun commented on THRIFT-5269: -- Missing where? There are many places where contexts

[jira] [Resolved] (THRIFT-5233) I/O timeout handling in go library

2020-06-18 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5233. -- Fix Version/s: 0.14.0 Resolution: Fixed > I/O timeout handling in go libr

[jira] [Commented] (THRIFT-5233) I/O timeout handling in go library

2020-06-12 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134564#comment-17134564 ] Duru Can Celasun commented on THRIFT-5233: -- > I started to look into the rabbit hole of

[jira] [Comment Edited] (THRIFT-5164) Go middleware support

2020-06-12 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134473#comment-17134473 ] Duru Can Celasun edited comment on THRIFT-5164 at 6/12/20, 7:35 PM

[jira] [Commented] (THRIFT-5164) Go middleware support

2020-06-12 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134473#comment-17134473 ] Duru Can Celasun commented on THRIFT-5164: -- I think both approaches have their merits

Re: Docker build not working as expected?

2020-06-03 Thread Duru Can Celasun
On Wed, 3 Jun 2020, at 08:49, Mario Emmenlauer wrote: > > Hi Can and all, > > On 03.06.20 00:14, Duru Can Celasun wrote: > > Hi, > > > > On Tue, 2 Jun 2020, at 21:56, Mario Emmenlauer wrote: > >> > >> Hi all, > >> > >>

Re: Docker build not working as expected?

2020-06-02 Thread Duru Can Celasun
Hi, On Tue, 2 Jun 2020, at 21:56, Mario Emmenlauer wrote: > > Hi all, > > whenever I check the Travis builds, I see that many of them take > a significant portion of their time to build new docker images. I've > checked the Travis build instructions but is not completely obvious > what the

[jira] [Commented] (THRIFT-5214) go: Implement connection check in TSocket

2020-05-28 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118910#comment-17118910 ] Duru Can Celasun commented on THRIFT-5214: -- [~fishywang] 0.14 isn't a concern right now so we

[jira] [Resolved] (THRIFT-5214) go: Implement connection check in TSocket

2020-05-27 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5214. -- Fix Version/s: 0.14.0 Resolution: Fixed > go: Implement connection ch

[jira] [Commented] (THRIFT-5214) go: Implement connection check in TSocket

2020-05-22 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113828#comment-17113828 ] Duru Can Celasun commented on THRIFT-5214: -- 1. Github's fix for that issue was also non-windows

[jira] [Commented] (THRIFT-5209) WIP: Support TinyGo

2020-05-14 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106975#comment-17106975 ] Duru Can Celasun commented on THRIFT-5209: -- I'm generally open to this sort of addition

[jira] [Commented] (THRIFT-5205) Tag prior releases with "v" prefix for compatibility with go.mod

2020-05-12 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105554#comment-17105554 ] Duru Can Celasun commented on THRIFT-5205: -- I think doing "go get library@revision&

[jira] [Updated] (THRIFT-5205) Tag prior releases with "v" prefix for compatibility with go.mod

2020-05-12 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun updated THRIFT-5205: - Issue Type: Wish (was: Task) > Tag prior releases with "v" prefix for

[jira] [Comment Edited] (THRIFT-5205) Tag prior releases with "v" prefix for compatibility with go.mod

2020-05-12 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105132#comment-17105132 ] Duru Can Celasun edited comment on THRIFT-5205 at 5/12/20, 6:34 AM

[jira] [Updated] (THRIFT-5205) Tag prior releases with "v" prefix for compatibility with go.mod

2020-05-12 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun updated THRIFT-5205: - Affects Version/s: (was: 0.12.0) > Tag prior releases with "v

[jira] [Commented] (THRIFT-5205) Tag prior releases with "v" prefix for compatibility with go.mod

2020-05-12 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105132#comment-17105132 ] Duru Can Celasun commented on THRIFT-5205: -- v0.12.0 is already [tagged|https://github.com

[jira] [Updated] (THRIFT-5205) Tag prior releases with "v" prefix for compatibility with go.mod

2020-05-12 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun updated THRIFT-5205: - Priority: Minor (was: Blocker) > Tag prior releases with "v" prefix for

[jira] [Commented] (THRIFT-5164) Go middleware support

2020-04-28 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094199#comment-17094199 ] Duru Can Celasun commented on THRIFT-5164: -- I use something very similar with opencensus

[jira] [Resolved] (THRIFT-5179) Thrift compiler will generate wrong code if IDL struct's name is 'a' or 'b'

2020-04-28 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5179. -- Fix Version/s: 0.14.0 Resolution: Fixed > Thrift compiler will generate wr

[jira] [Resolved] (THRIFT-5164) Go middleware support

2020-04-27 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5164. -- Fix Version/s: 0.14.0 Resolution: Fixed > Go middleware supp

[jira] [Resolved] (THRIFT-5184) D: WebSocket Server Transport Fix for Firefox

2020-04-27 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5184. -- Resolution: Fixed > D: WebSocket Server Transport Fix for Fire

[jira] [Assigned] (THRIFT-5164) Go middleware support

2020-04-24 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun reassigned THRIFT-5164: Assignee: Duru Can Celasun > Go middleware supp

Re: Is Travis CI building docker images?

2020-04-24 Thread Duru Can Celasun
CC'ing James King who did our Travis setup IIRC. On Fri, 24 Apr 2020, at 10:42, Mario Emmenlauer wrote: > > In the past weeks I've had a significant number of failing Travis CI > builds, the majority of which was failing in something that looked like > a docker build. > > Is it correct and

[jira] [Resolved] (THRIFT-4282) StressTestNonBlocking is disabled in Appveyor as it is unstable on Windows in general

2020-04-24 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-4282. -- Fix Version/s: 0.14.0 Resolution: Resolved > StressTestNonBlocking is disab

[jira] [Resolved] (THRIFT-5171) Fix maven-ant-tasks to use HTTPS instead of HTTP

2020-04-23 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5171. -- Fix Version/s: 0.14.0 Resolution: Fixed > Fix maven-ant-tasks to use HT

[jira] [Commented] (THRIFT-5164) Go middleware support

2020-04-14 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083083#comment-17083083 ] Duru Can Celasun commented on THRIFT-5164: -- I agree that middleware isn't exactly transferable

[jira] [Commented] (THRIFT-5164) Go middleware support

2020-04-03 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17074391#comment-17074391 ] Duru Can Celasun commented on THRIFT-5164: -- I'm much more open to the idea today than I

[jira] [Commented] (THRIFT-4710) Move all ASF CMS website content to GitHub

2020-02-26 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046188#comment-17046188 ] Duru Can Celasun commented on THRIFT-4710: -- That's good to know, thanks. We should stick

[jira] [Commented] (THRIFT-4710) Move all ASF CMS website content to GitHub

2020-02-26 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045922#comment-17045922 ] Duru Can Celasun commented on THRIFT-4710: -- That can all be figured out later, once the new

[jira] [Commented] (THRIFT-4710) Move all ASF CMS website content to GitHub

2020-02-26 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045902#comment-17045902 ] Duru Can Celasun commented on THRIFT-4710: -- I don't personally have any plans for it but I'm

[jira] [Commented] (THRIFT-5113) Web-based developer and user chat?

2020-02-26 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045882#comment-17045882 ] Duru Can Celasun commented on THRIFT-5113: -- I've been slowly working on a new version

[jira] [Commented] (THRIFT-5107) Travis build fails with missing Python 3.3 or newer?

2020-02-21 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042212#comment-17042212 ] Duru Can Celasun commented on THRIFT-5107: -- Nice find! Mind sending in a PR? > Travis bu

[jira] [Commented] (THRIFT-5075) Backport fixes for CVE-2019-0205 to (Java) 0.9.3-1 version

2020-01-25 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023641#comment-17023641 ] Duru Can Celasun commented on THRIFT-5075: -- I don't think it's a good idea either. Which

[jira] [Resolved] (THRIFT-5069) Go: TDserializer is not resource pool friendly

2020-01-18 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5069. -- Fix Version/s: 0.14.0 Resolution: Fixed > Go: TDserializer is not resou

[jira] [Commented] (THRIFT-5069) Go: TDserializer is not resource pool friendly

2020-01-17 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018526#comment-17018526 ] Duru Can Celasun commented on THRIFT-5069: -- OK, sounds good. Let's include that in this PR

[jira] [Commented] (THRIFT-5069) Go: TDserializer is not resource pool friendly

2020-01-17 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018163#comment-17018163 ] Duru Can Celasun commented on THRIFT-5069: -- [~fishywang] it could be useful, depends on what

[jira] [Commented] (THRIFT-5068) CI is broken due to http://repo1.maven.org

2020-01-17 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017960#comment-17017960 ] Duru Can Celasun commented on THRIFT-5068: -- Thanks for the PR! Travis is all green now. >

[jira] [Resolved] (THRIFT-5068) CI is broken due to http://repo1.maven.org

2020-01-17 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5068. -- Resolution: Fixed > CI is broken due to http://repo1.maven.

[jira] [Commented] (THRIFT-5068) CI is broken due to http://repo1.maven.org

2020-01-17 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017881#comment-17017881 ] Duru Can Celasun commented on THRIFT-5068: -- Thanks, that does seem to be the cause. I won't

[jira] [Commented] (THRIFT-5068) CI is broken due to http://repo1.maven.org

2020-01-15 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016374#comment-17016374 ] Duru Can Celasun commented on THRIFT-5068: -- This has effected other Apache projects as well

[jira] [Updated] (THRIFT-5068) CI is broken due to http://repo1.maven.org

2020-01-15 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun updated THRIFT-5068: - Description: Upstream has [removed|https://support.sonatype.com/hc/en-us/articles

[jira] [Created] (THRIFT-5068) CI is broken due to http://repo1.maven.org

2020-01-15 Thread Duru Can Celasun (Jira)
Duru Can Celasun created THRIFT-5068: Summary: CI is broken due to http://repo1.maven.org Key: THRIFT-5068 URL: https://issues.apache.org/jira/browse/THRIFT-5068 Project: Thrift Issue

[jira] [Resolved] (THRIFT-5003) Websocket Connection in Browsers with nodejs code

2020-01-07 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5003. -- Resolution: Fixed > Websocket Connection in Browsers with nodejs c

[jira] [Updated] (THRIFT-5049) Process panic in generated processor

2020-01-06 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun updated THRIFT-5049: - Issue Type: Wish (was: Improvement) > Process panic in generated proces

[jira] [Commented] (THRIFT-5049) Process panic in generated processor

2020-01-06 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008676#comment-17008676 ] Duru Can Celasun commented on THRIFT-5049: -- The library - correctly - doesn't handle panics

[jira] [Updated] (THRIFT-5049) Process panic in generated processor

2020-01-06 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun updated THRIFT-5049: - Priority: Minor (was: Major) > Process panic in generated proces

[jira] [Commented] (THRIFT-5039) thrift npm package should be published from root folder

2019-12-18 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998999#comment-16998999 ] Duru Can Celasun commented on THRIFT-5039: -- cc [~jking] > thrift npm package sho

[jira] [Resolved] (THRIFT-4995) [Rust] Use `ToSocketAddrs` for expressing network addresses

2019-12-14 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-4995. -- Fix Version/s: 0.14.0 Resolution: Fixed > [Rust] Use `ToSocketAd

[jira] [Resolved] (THRIFT-5046) Custom tags remove db and json tags

2019-12-13 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5046. -- Fix Version/s: 0.14.0 Resolution: Fixed > Custom tags remove db and json t

  1   2   >