[
https://issues.apache.org/jira/browse/THRIFT-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Bakken closed THRIFT-4445.
---
Resolution: Invalid
My analysis was wrong, will open a new ticket.
> PHP TSocket broken by THR
Stig Bakken created THRIFT-4445:
---
Summary: PHP TSocket broken by THRIFT-4295
Key: THRIFT-4445
URL: https://issues.apache.org/jira/browse/THRIFT-4445
Project: Thrift
Issue Type: Bug
Stig Bakken created THRIFT-4238:
---
Summary: JSON generator: make annotation-aware
Key: THRIFT-4238
URL: https://issues.apache.org/jira/browse/THRIFT-4238
Project: Thrift
Issue Type: Improvement
Stig Bakken created THRIFT-3807:
---
Summary: Swift compiler does not escape reserved words
Key: THRIFT-3807
URL: https://issues.apache.org/jira/browse/THRIFT-3807
Project: Thrift
Issue Type: Bug
Stig Bakken created THRIFT-3806:
---
Summary: Swift generator does not handle self-referring structs
Key: THRIFT-3806
URL: https://issues.apache.org/jira/browse/THRIFT-3806
Project: Thrift
Issue
Stig Bakken created THRIFT-3617:
---
Summary: CMake does not build gv/xml generators
Key: THRIFT-3617
URL: https://issues.apache.org/jira/browse/THRIFT-3617
Project: Thrift
Issue Type: Bug
Stig Bakken created THRIFT-3574:
---
Summary: Cocoa generator makes uncompilable imports
Key: THRIFT-3574
URL: https://issues.apache.org/jira/browse/THRIFT-3574
Project: Thrift
Issue Type: Bug
[
https://issues.apache.org/jira/browse/THRIFT-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980043#comment-14980043
]
Stig Bakken commented on THRIFT-3263:
-
Anyone have time to review this patch?
> PHP jsonSerial
Stig Bakken created THRIFT-3263:
---
Summary: PHP jsonSerialize() should cast scalar types
Key: THRIFT-3263
URL: https://issues.apache.org/jira/browse/THRIFT-3263
Project: Thrift
Issue Type
Stig Bakken created THRIFT-3132:
---
Summary: Properly format date in Java @Generated annotations
Key: THRIFT-3132
URL: https://issues.apache.org/jira/browse/THRIFT-3132
Project: Thrift
Issue
Stig Bakken created THRIFT-3126:
---
Summary: PHP JSON serializer converts empty or int-indexed maps to
lists
Key: THRIFT-3126
URL: https://issues.apache.org/jira/browse/THRIFT-3126
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304906#comment-14304906
]
Stig Bakken commented on THRIFT-2940:
-
[~roger.meier] I tested out a similar approach
[
https://issues.apache.org/jira/browse/THRIFT-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Bakken reopened THRIFT-2894:
-
Hi Jens,
I updated (and squashed) the original pull request, the commit you merged did
not handle
Stig Bakken created THRIFT-2894:
---
Summary: PHP json serializer skips maps with int/bool keys
Key: THRIFT-2894
URL: https://issues.apache.org/jira/browse/THRIFT-2894
Project: Thrift
Issue Type
[
https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235421#comment-14235421
]
Stig Bakken commented on THRIFT-2859:
-
Thanks, [~hcorg]. Opened a new PR at https
[
https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235216#comment-14235216
]
Stig Bakken commented on THRIFT-2859:
-
What about this patch (based on Konrad's
Stig Bakken created THRIFT-2869:
---
Summary: JSON: run schema validation from tests
Key: THRIFT-2869
URL: https://issues.apache.org/jira/browse/THRIFT-2869
Project: Thrift
Issue Type
in generated code for
langs which have typedef constructs. Like C or C++, where such IDL leads to
something like typedef int32_t int which tries to redefine C keyword...
-KG
On 01.12.2014 15:26, Stig Bakken wrote:
FWIW, I agree with Randy. There is value to being able to directly
compare two type
s/is a service/is a better service/ ;-)
On Tue, Dec 2, 2014 at 3:01 PM, Stig Bakken s...@zedge.net wrote:
@Konrad: My point about errors came to mind because I had just been
working on the JSON generator, where type names are strings. I guess
it won't apply if the aliases are only present
is 32-bit. 'long' on Max and Linux
64-bit is 64-bits, but 'long' on Win64 is 32-bits.
True. Another point against it.
--
Stig Bakken
CTO, Zedge.net - free your phone!
Out of curiosity, what kinds of errors did you see from this?
- Stig
On Mon, Dec 1, 2014 at 1:18 AM, Jens Geyer jensge...@hotmail.com wrote:
Hi *,
I have found people multiple times doing things like this, ending up with
strange errors.
typedef i32 int
What about making it legal
What about making it legal and allowing int as an built-in alias for i32?
Or should we add some kind of warning instead?
Or would either one of these just open pandora’s box?
Have fun,
JensG
--
Stig Bakken
CTO, Zedge.net - free your phone!
[
https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229188#comment-14229188
]
Stig Bakken commented on THRIFT-2859:
-
Jens:
TBH, the schema isn't really done yet
[
https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229263#comment-14229263
]
Stig Bakken commented on THRIFT-2859:
-
Updated the PR with proper formatting code
[
https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229263#comment-14229263
]
Stig Bakken edited comment on THRIFT-2859 at 11/30/14 10:23 PM
[
https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229288#comment-14229288
]
Stig Bakken commented on THRIFT-2859:
-
This looks to be a good JSON validator tool
Stig Bakken created THRIFT-2857:
---
Summary: C# generator creates uncompilable code for struct
constants
Key: THRIFT-2857
URL: https://issues.apache.org/jira/browse/THRIFT-2857
Project: Thrift
Stig Bakken created THRIFT-2859:
---
Summary: JSON generator: output complete descriptors
Key: THRIFT-2859
URL: https://issues.apache.org/jira/browse/THRIFT-2859
Project: Thrift
Issue Type
[
https://issues.apache.org/jira/browse/THRIFT-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226825#comment-14226825
]
Stig Bakken commented on THRIFT-2857:
-
I can make one. Any suggestions on where
[
https://issues.apache.org/jira/browse/THRIFT-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227291#comment-14227291
]
Stig Bakken commented on THRIFT-2857:
-
Gotcha ;)
struct Foo { 1: i32 bar; }
const
[
https://issues.apache.org/jira/browse/THRIFT-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227291#comment-14227291
]
Stig Bakken edited comment on THRIFT-2857 at 11/27/14 6:04 AM
[
https://issues.apache.org/jira/browse/THRIFT-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227291#comment-14227291
]
Stig Bakken edited comment on THRIFT-2857 at 11/27/14 6:06 AM
[
https://issues.apache.org/jira/browse/THRIFT-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156444#comment-14156444
]
Stig Bakken commented on THRIFT-2674:
-
Thanks, [~jensg]! This is not clear from
Stig Bakken created THRIFT-2722:
---
Summary: Fix javascript service inheritance namespacing
Key: THRIFT-2722
URL: https://issues.apache.org/jira/browse/THRIFT-2722
Project: Thrift
Issue Type
Hi guys,
There's a lot of functionality missing from lib/js that is present in
lib/nodejs, such as binary or compact protocols. I would love to
contribute code for this, but before I do, has there been any discussion
around common JavaScript code that can be used by both the nodejs and js
Stig Bakken created THRIFT-2712:
---
Summary: PHP: add json option to create JsonSerializable code
Key: THRIFT-2712
URL: https://issues.apache.org/jira/browse/THRIFT-2712
Project: Thrift
Issue
[
https://issues.apache.org/jira/browse/THRIFT-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Bakken updated THRIFT-2712:
Description:
This patch adds a json option to PHP code generation that will make generated
[
https://issues.apache.org/jira/browse/THRIFT-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Bakken updated THRIFT-2674:
Attachment: js-type.diff
Attaching patch since pull request doesn't seem to get connected
[
https://issues.apache.org/jira/browse/THRIFT-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Bakken updated THRIFT-2673:
Attachment: php-arg-validator-fix.diff
PHP: generated Service_method_result code should not have
[
https://issues.apache.org/jira/browse/THRIFT-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113963#comment-14113963
]
Stig Bakken commented on THRIFT-2674:
-
I assume you meant vnd.apache.thrift.compact
[
https://issues.apache.org/jira/browse/THRIFT-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109062#comment-14109062
]
Stig Bakken commented on THRIFT-2674:
-
Your most recent suggestion looks very nice
Stig Bakken created THRIFT-2673:
---
Summary: PHP: generated Service_method_result code should not have
validators
Key: THRIFT-2673
URL: https://issues.apache.org/jira/browse/THRIFT-2673
Project: Thrift
Stig Bakken created THRIFT-2674:
---
Summary: JavaScript: declare Accept: and Content-Type: in request
Key: THRIFT-2674
URL: https://issues.apache.org/jira/browse/THRIFT-2674
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Bakken updated THRIFT-2673:
Component/s: PHP - Compiler
PHP: generated Service_method_result code should not have validators
[
https://issues.apache.org/jira/browse/THRIFT-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105841#comment-14105841
]
Stig Bakken commented on THRIFT-2674:
-
I think that's a good approach, the most
Stig Bakken created THRIFT-2671:
---
Summary: PHP validator should not be applied to exceptions
Key: THRIFT-2671
URL: https://issues.apache.org/jira/browse/THRIFT-2671
Project: Thrift
Issue Type
[
https://issues.apache.org/jira/browse/THRIFT-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Bakken updated THRIFT-2671:
Comment: was deleted
(was: diff --git a/compiler/cpp/src/generate/t_php_generator.cc
b/compiler
[
https://issues.apache.org/jira/browse/THRIFT-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103550#comment-14103550
]
Stig Bakken commented on THRIFT-2671:
-
diff --git a/compiler/cpp/src/generate
[
https://issues.apache.org/jira/browse/THRIFT-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Bakken updated THRIFT-2671:
diff --git a/compiler/cpp/src/generate/t_php_generator.cc
b/compiler/cpp/src/generate
[
https://issues.apache.org/jira/browse/THRIFT-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Bakken updated THRIFT-2671:
Comment: was deleted
(was: diff --git a/compiler/cpp/src/generate/t_php_generator.cc
b/compiler
[
https://issues.apache.org/jira/browse/THRIFT-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Bakken closed THRIFT-2671.
---
Resolution: Incomplete
PHP validator should not be applied to exceptions
[
https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071518#comment-14071518
]
Stig Bakken commented on THRIFT-2632:
-
Gotcha! Fixed, and added a test script
Stig Bakken created THRIFT-2632:
---
Summary: PHP: add validate option to generate read/write
validation code
Key: THRIFT-2632
URL: https://issues.apache.org/jira/browse/THRIFT-2632
Project: Thrift
53 matches
Mail list logo
