Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1156
http://thrift.apache.org/docs/types states that (as one would expect) a
Thrift map is defined as "A map of **strictly unique keys** to values.
Translates to an STL map, Java HashMap, PHP associative
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1156
Hey @Jens-G, I'm not sure I follow you, what does this have anything to do
with maps? Assuming you meant sets, the docs say:
> An unordered set of unique elements. Translates to an STL set,
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1156
Oopsie. After I read the word "map" above I must have been mentally
switched to maps somehow. My mistake.
Nevertheless what I said about panic and errors in general above still
holds true.
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1156
> Good intentions, absolutely, but the implementation ..
FWIW, I agree. However, we still need a solution and as I explained above,
we don't have a way of returning an error here. That leav
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1156
+1
Sent from mobile device, please ignore spelling mistakes.
Von: Duru Can Celasun
Gesendet: 16.01.2017 08:00
An: apache/thrift
Cc: Jens Ge
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1156
Hi @dcelasun,any news? In caseyou're donw with it, could you rebase the PR
to trigger a new Travis build?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1156
Hey @Jens-G sorry, I didn't have time to finish this up just yet. The lib
part of the PR is still missing, but I'll be doing that in a few days. I'll
rebase, push and let you know.
---
If your pr
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1156
Ok, all fine. Don't panic ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1156
I finally hade some time to take a look at this. Duplicate detection is now
implemented with `reflect.DeepEqual`. It isn't really ideal, but Go lacks a way
of defining equality for arbitrary types,
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1156
@Jens-G Squashed commits and rebased from master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1156
```
src/common/clientserver_test.go:61: cannot use handler (type
*MockThriftTest) as type thrifttest.ThriftTest in argument to GetServerParams:
*MockThriftTest does not implement thrifttes
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1156
Whoops, I must have missed that one. Should be fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1156
@Jens-G All tests green and rebased from master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1156
Ok, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
14 matches
Mail list logo
