Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1156
+1
Sent from mobile device, please ignore spelling mistakes.
________________________________
Von: Duru Can Celasun
Gesendet: 16.01.2017 08:00
An: apache/thrift
Cc: Jens Geyer; Mention
Betreff: Re: [apache/thrift] THRIFT-4011 Use slices for Thrift sets (#1156)
Good intentions, absolutely, but the implementation ..
FWIW, I agree. However, we still need a solution and as I explained above,
we don't have a way of returning an error here. That leaves us with silent
deduplication (during serialization) in lib/go/thrift. Are you OK with that?
-
You are receiving this because you were mentioned.
Reply to this email directly, view it on
GitHub<https://github.com/apache/thrift/pull/1156#issuecomment-272787325>, or
mute the
thread<https://github.com/notifications/unsubscribe-auth/AFkH7U-4jT-CNWuziuVaqCK6G_FWI8Koks5rSxWOgaJpZM4Lj4Hw>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
