Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100917042
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR(
"android_legacy: Do not
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r10097
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR(
"android_legacy: Do
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100901172
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR(
"android_legacy: Do not
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100875982
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR(
"android_legacy: Do
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100873930
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR(
"android_legacy: Do not
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100861533
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR(
"android_legacy: Do
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100623293
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -91,6 +92,8 @@ class t_java_generator : public t_oop_generator {
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100586606
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -91,6 +92,8 @@ class t_java_generator : public t_oop_generator {
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100586356
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -3527,6 +3531,11 @@ void
t_java_generator::generate_process_function(t_service*
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100565597
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -91,6 +92,8 @@ class t_java_generator : public t_oop_generator {
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100562753
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -91,6 +92,8 @@ class t_java_generator : public t_oop_generator {
GitHub user ctubbsii opened a pull request:
https://github.com/apache/thrift/pull/1186
THRIFT-1805 Provide option for handling RTEs
Adds a Java option to the generator to generate code which lets Thrift
handle RuntimeExceptions from a service, and present them as
13 matches
Mail list logo
