Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1197
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101915787
--- Diff: test/secure/test_secure.bash ---
@@ -0,0 +1,69 @@
+#!/bin/bash
+
+#
+# Checks various desired attributes in SSL/TLS implementations
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101914898
--- Diff: lib/nodejs/lib/thrift/connection.js ---
@@ -247,6 +247,11 @@ exports.createConnection = function(host, port,
options) {
};
exports
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101914903
--- Diff: test/tests.json ---
@@ -606,5 +606,23 @@
"compact"
],
"workdir": "rs/bin"
+ },
+ {
+"name": "secure"
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101914893
--- Diff: lib/py/src/transport/sslcompat.py ---
@@ -66,6 +66,14 @@ def legacy_validate_callback(cert, hostname):
--- End diff --
I backed
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101914676
--- Diff: test/tests.json ---
@@ -606,5 +606,23 @@
"compact"
],
"workdir": "rs/bin"
+ },
+ {
+"name": "secure"
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101909371
--- Diff: test/tests.json ---
@@ -606,5 +606,23 @@
"compact"
],
"workdir": "rs/bin"
+ },
+ {
+"name": "secure",
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101909373
--- Diff: test/secure/test_secure.bash ---
@@ -0,0 +1,69 @@
+#!/bin/bash
+
+#
+# Checks various desired attributes in SSL/TLS implementations.
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101909372
--- Diff: lib/py/src/transport/sslcompat.py ---
@@ -66,6 +66,14 @@ def legacy_validate_callback(cert, hostname):
--- End diff --
As far as I
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101909066
--- Diff: test/secure/test_secure.bash ---
@@ -0,0 +1,69 @@
+#!/bin/bash
+
+#
+# Checks various desired attributes in SSL/TLS implementations
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101909034
--- Diff: lib/py/src/transport/sslcompat.py ---
@@ -66,6 +66,14 @@ def legacy_validate_callback(cert, hostname):
--- End diff --
In the Ub
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101908742
--- Diff: test/tests.json ---
@@ -606,5 +606,23 @@
"compact"
],
"workdir": "rs/bin"
+ },
+ {
+"name": "secure"
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101908692
--- Diff: lib/go/thrift/ssl_socket.go ---
@@ -20,152 +20,155 @@
package thrift
--- End diff --
Sorry, I'm using the geany editor and I have
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101908015
--- Diff: lib/go/thrift/ssl_socket.go ---
@@ -20,152 +20,155 @@
package thrift
--- End diff --
See
https://github.com/golang/go/commit/014f3
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101907094
--- Diff: lib/go/thrift/ssl_socket.go ---
@@ -20,152 +20,155 @@
package thrift
--- End diff --
We cannot replace indentation with spaces beca
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101907745
--- Diff: test/secure/test_secure.bash ---
@@ -0,0 +1,69 @@
+#!/bin/bash
+
+#
+# Checks various desired attributes in SSL/TLS implementations.
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101907113
--- Diff: test/tests.json ---
@@ -606,5 +606,23 @@
"compact"
],
"workdir": "rs/bin"
+ },
+ {
+"name": "secure",
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101907319
--- Diff: lib/py/src/transport/sslcompat.py ---
@@ -66,6 +66,14 @@ def legacy_validate_callback(cert, hostname):
--- End diff --
Is it to in
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101907637
--- Diff: lib/nodejs/lib/thrift/connection.js ---
@@ -247,6 +247,11 @@ exports.createConnection = function(host, port,
options) {
};
exports.c
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1197
THRIFT-4084: Add a SSL/TLS negotiation check to crosstest to verify SSLv3
is not active and that TLSv1.0 through 1.2 are accepted
Fixed the following server implementations to properly disable SSLv
20 matches
Mail list logo
