[GitHub] thrift pull request #1200: THRIFT-3706: glib client/java server/crosstest mu...

2017-02-21 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1200#discussion_r102356256 --- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_multiplexed_protocol.c --- @@ -42,146 +41,119 @@ static GParamSpec *thrift_multiplexed_protocol_obj_

[GitHub] thrift pull request #1200: THRIFT-3706: glib client/java server/crosstest mu...

2017-02-21 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1200#discussion_r102356814 --- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_protocol.c --- @@ -61,15 +61,15 @@ thrift_protocol_set_property (GObject *object, guint property_id,

[GitHub] thrift pull request #1200: THRIFT-3706: glib client/java server/crosstest mu...

2017-02-21 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1200#discussion_r102356989 --- Diff: lib/c_glib/src/thrift/c_glib/transport/thrift_socket.h --- @@ -50,11 +50,8 @@ struct _ThriftSocket /* private */ gchar *hostnam

[GitHub] thrift pull request #1200: THRIFT-3706: glib client/java server/crosstest mu...

2017-02-21 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1200#discussion_r102357395 --- Diff: lib/java/test/org/apache/thrift/test/TestServer.java --- @@ -190,7 +193,9 @@ public static void main(String [] args) { if (protocol_ty

[GitHub] thrift pull request #1200: THRIFT-3706: glib client/java server/crosstest mu...

2017-02-22 Thread gadLinux
Github user gadLinux commented on a diff in the pull request: https://github.com/apache/thrift/pull/1200#discussion_r102411428 --- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_multiplexed_protocol.c --- @@ -42,146 +41,119 @@ static GParamSpec *thrift_multiplexed_protocol_obj

[GitHub] thrift pull request #1200: THRIFT-3706: glib client/java server/crosstest mu...

2017-02-22 Thread gadLinux
Github user gadLinux commented on a diff in the pull request: https://github.com/apache/thrift/pull/1200#discussion_r102412439 --- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_protocol.c --- @@ -61,15 +61,15 @@ thrift_protocol_set_property (GObject *object, guint property_id,

[GitHub] thrift pull request #1200: THRIFT-3706: glib client/java server/crosstest mu...

2017-02-22 Thread gadLinux
Github user gadLinux commented on a diff in the pull request: https://github.com/apache/thrift/pull/1200#discussion_r102412630 --- Diff: lib/java/test/org/apache/thrift/test/TestServer.java --- @@ -190,7 +193,9 @@ public static void main(String [] args) { if (protocol_t

[GitHub] thrift pull request #1200: THRIFT-3706: glib client/java server/crosstest mu...

2017-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena