Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108063510
--- Diff: build/docker/scripts/ubsan.sh ---
@@ -15,7 +15,7 @@ export CXX=clang++-3.8
# undefined casting, aka "vptr".
#
# TODO: fix
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108063013
--- Diff: build/docker/scripts/ubsan.sh ---
@@ -15,7 +15,7 @@ export CXX=clang++-3.8
# undefined casting, aka "vptr".
#
# TODO: fix undefined
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108062987
--- Diff: compiler/cpp/src/thrift/generate/t_xml_generator.cc ---
@@ -391,11 +391,16 @@ void t_xml_generator::write_type(t_type* ttype) {
if (type ==
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108061946
--- Diff: compiler/cpp/src/thrift/generate/t_json_generator.cc ---
@@ -273,10 +273,14 @@ void t_json_generator::write_type_spec(t_type* ttype)
{
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108061961
--- Diff: compiler/cpp/src/thrift/generate/t_xml_generator.cc ---
@@ -391,11 +391,16 @@ void t_xml_generator::write_type(t_type* ttype) {
if
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108061917
--- Diff: build/docker/scripts/ubsan.sh ---
@@ -15,7 +15,7 @@ export CXX=clang++-3.8
# undefined casting, aka "vptr".
#
# TODO: fix
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1222
THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-4134
