[
https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812284#comment-13812284
]
Hudson commented on THRIFT-1815:
FAILURE: Integrated in Thrift #932 (See
[
https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812523#comment-13812523
]
Hudson commented on THRIFT-1815:
SUCCESS: Integrated in Thrift #933 (See
[
https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544095#comment-13544095
]
Jens Geyer commented on THRIFT-1815:
+1 for the patch (y)
There's just one minor
[
https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544099#comment-13544099
]
Andrew Gaul commented on THRIFT-1815:
-
Thanks; attached.
Code
[
https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544381#comment-13544381
]
Hudson commented on THRIFT-1815:
Integrated in Thrift #599 (See
[
https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543453#comment-13543453
]
Jens Geyer commented on THRIFT-1815:
Looks good to me, except for a small conflict
[
https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543473#comment-13543473
]
Andrew Gaul commented on THRIFT-1815:
-
Sorry I did not realize that Thrift moved to
[
https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541609#comment-13541609
]
Jens Geyer commented on THRIFT-1815:
I see and understand your point, but I'm not so
[
https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541961#comment-13541961
]
Andrew Gaul commented on THRIFT-1815:
-
1) I compile 3,500 lines across 11 .thrift
