[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959949#comment-15959949 ] ASF GitHub Bot commented on THRIFT-3627: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959948#comment-15959948 ] ASF GitHub Bot commented on THRIFT-3627: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959636#comment-15959636 ] ASF GitHub Bot commented on THRIFT-3627: GitHub user jeking3 opened a pull request:

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959637#comment-15959637 ] ASF GitHub Bot commented on THRIFT-3627: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952508#comment-15952508 ] James E. King, III commented on THRIFT-3627: This pull request probably needs to be rebased

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190127#comment-15190127 ] Roger Meier commented on THRIFT-3627: - I think we should add something like

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148604#comment-15148604 ] Aki Sukegawa commented on THRIFT-3627: -- Consistency is a good point. In that case, the right way

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145924#comment-15145924 ] ASF GitHub Bot commented on THRIFT-3627: GitHub user kazuki-ma opened a pull request:

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145948#comment-15145948 ] Hudson commented on THRIFT-3627: SUCCESS: Integrated in Thrift-precommit #118 (See

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145953#comment-15145953 ] Aki Sukegawa commented on THRIFT-3627: -- +1 for white space changes, as git history pollution can be

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145960#comment-15145960 ] ASF GitHub Bot commented on THRIFT-3627: Github user kazuki-ma closed the pull request at:

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145961#comment-15145961 ] ASF GitHub Bot commented on THRIFT-3627: GitHub user kazuki-ma reopened a pull request:

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145977#comment-15145977 ] Hudson commented on THRIFT-3627: SUCCESS: Integrated in Thrift-precommit #120 (See