Re: introduce --signoff ?

2013-06-20 Thread Jake Farrell
--signoff would be appropriate use in this case as the committer is directly involved with the delivery if the patch from the --author and the --author has granted use of that work to the ASF by attaching the patch to an issue within Jira at issues.apache.org.   Since contributors do not neces

Re: Re: introduce --signoff ?

2013-06-20 Thread Evan Nemerson
On Thu, 2013-06-20 at 21:53 +, Roger Meier wrote: > yes, you are right. > > git commit --signoff --author="Cross Everything " > -a -m "THRIFT- lang: description" > > does the trick! > > I've just tested it here including also signoff: > https://git-wip-us.apache.org/repos/asf?p=thrift.

Re: Re: introduce --signoff ?

2013-06-20 Thread Roger Meier
yes, you are right. git commit --signoff --author="Cross Everything " -a -m "THRIFT- lang: description" does the trick! I've just tested it here including also signoff: https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=commit;h=cc25c52de4fc1d9d856a759b283ff96a6c251c29 https://issue

Re: introduce --signoff ?

2013-06-19 Thread Carl Yeksigian
I think it might be better attribution to use --author="(author)", if this is for attribution. That way the authorship can go to the person who authored the patch; committer will remain the committer's name. Just for a preview, I just made a test commit to a review branch on my github, so if inter

introduce --signoff ?

2013-06-19 Thread Roger Meier
what about using the signoff feature for contributions? git commit --signoff -a -m "THRIFT- lang: description" roger ;-r