[jira] [Commented] (THRIFT-2343) Golang - Return a single error for all exceptions instead of multiple return values

[ https://issues.apache.org/jira/browse/THRIFT-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891344#comment-13891344 ] Chris Bannister commented on THRIFT-2343: - I've fixed that, do you want me to

[jira] [Updated] (THRIFT-2343) Golang - Return a single error for all exceptions instead of multiple return values

[ https://issues.apache.org/jira/browse/THRIFT-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-2343: Attachment: 0002-Update-tutorial-to-reflect-changes-to-exceptions.patch

[jira] [Created] (THRIFT-2349) Golang - improve tutorial

Chris Bannister created THRIFT-2349: --- Summary: Golang - improve tutorial Key: THRIFT-2349 URL: https://issues.apache.org/jira/browse/THRIFT-2349 Project: Thrift Issue Type: Improvement

[jira] [Updated] (THRIFT-2349) Golang - improve tutorial

[ https://issues.apache.org/jira/browse/THRIFT-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-2349: Attachment: THRIFT-2349.patch Golang - improve tutorial -

[jira] [Updated] (THRIFT-2388) GoLang - Fix data races in simple_server and server_socket

[ https://issues.apache.org/jira/browse/THRIFT-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-2388: Attachment: 0001-Fix-data-races-in-simple_server-and-server_socket.patch GoLang - Fix

[jira] [Created] (THRIFT-2388) GoLang - Fix data races in simple_server and server_socket

Chris Bannister created THRIFT-2388: --- Summary: GoLang - Fix data races in simple_server and server_socket Key: THRIFT-2388 URL: https://issues.apache.org/jira/browse/THRIFT-2388 Project: Thrift

[jira] [Updated] (THRIFT-2388) GoLang - Fix data races in simple_server and server_socket

[ https://issues.apache.org/jira/browse/THRIFT-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-2388: Description: The documentation for Interrupt() on server_transport states that

[jira] [Commented] (THRIFT-2418) Go handler function panics on internal error

[ https://issues.apache.org/jira/browse/THRIFT-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942205#comment-13942205 ] Chris Bannister commented on THRIFT-2418: - Good spot, looks good to me. Go

[jira] [Updated] (THRIFT-2419) golang - Fix fmt.Errorf in generated code

[ https://issues.apache.org/jira/browse/THRIFT-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-2419: Attachment: 0001-Fix-fmt.Errorf-not-formatting-the-error.patch golang - Fix fmt.Errorf

[jira] [Created] (THRIFT-2419) golang - Fix fmt.Errorf in generated code

Chris Bannister created THRIFT-2419: --- Summary: golang - Fix fmt.Errorf in generated code Key: THRIFT-2419 URL: https://issues.apache.org/jira/browse/THRIFT-2419 Project: Thrift Issue Type:

[jira] [Commented] (THRIFT-2420) Go argument parser for methods without arguments does not skip fields

[ https://issues.apache.org/jira/browse/THRIFT-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943029#comment-13943029 ] Chris Bannister commented on THRIFT-2420: - Again good spot :) Makes sense to me.

[jira] [Commented] (THRIFT-2419) golang - Fix fmt.Errorf in generated code

[ https://issues.apache.org/jira/browse/THRIFT-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943032#comment-13943032 ] Chris Bannister commented on THRIFT-2419: - Yeah after your comment I figured I

[jira] [Commented] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959245#comment-13959245 ] Chris Bannister commented on THRIFT-2445: - Shouldnt this be part of test/go ?

[jira] [Commented] (THRIFT-2009) Go redeclaration error

[ https://issues.apache.org/jira/browse/THRIFT-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974138#comment-13974138 ] Chris Bannister commented on THRIFT-2009: - This change causes service methods

[jira] [Commented] (THRIFT-2009) Go redeclaration error

[ https://issues.apache.org/jira/browse/THRIFT-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974878#comment-13974878 ] Chris Bannister commented on THRIFT-2009: - Not yet, I think we should change

[jira] [Updated] (THRIFT-2488) Timeouts can leave client in unrecoverable state

[ https://issues.apache.org/jira/browse/THRIFT-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-2488: Affects Version/s: 0.9.1 Timeouts can leave client in unrecoverable state

[jira] [Created] (THRIFT-2488) Timeouts can leave client in unrecoverable state

Chris Bannister created THRIFT-2488: --- Summary: Timeouts can leave client in unrecoverable state Key: THRIFT-2488 URL: https://issues.apache.org/jira/browse/THRIFT-2488 Project: Thrift

[jira] [Updated] (THRIFT-2488) Timeouts can leave client in unrecoverable state

[ https://issues.apache.org/jira/browse/THRIFT-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-2488: Attachment: timeout.thrift testcase.go Timeouts can leave client in

[jira] [Commented] (THRIFT-2488) Timeouts can leave client in unrecoverable state

[ https://issues.apache.org/jira/browse/THRIFT-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975520#comment-13975520 ] Chris Bannister commented on THRIFT-2488: - You should get output along the lines

[jira] [Commented] (THRIFT-2502) Optimize go implementations of binary and compact protocols for speed

[ https://issues.apache.org/jira/browse/THRIFT-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983157#comment-13983157 ] Chris Bannister commented on THRIFT-2502: - This is awesome Optimize go

[jira] [Commented] (THRIFT-2598) Add check for minimum Go version to configure.ac

[ https://issues.apache.org/jira/browse/THRIFT-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051870#comment-14051870 ] Chris Bannister commented on THRIFT-2598: - It should be possible to work around

[jira] [Comment Edited] (THRIFT-2598) Add check for minimum Go version to configure.ac

[ https://issues.apache.org/jira/browse/THRIFT-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051870#comment-14051870 ] Chris Bannister edited comment on THRIFT-2598 at 7/3/14 8:19 PM:

[jira] [Commented] (THRIFT-2791) Allowing use of buffered sockets in go server

[ https://issues.apache.org/jira/browse/THRIFT-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183063#comment-14183063 ] Chris Bannister commented on THRIFT-2791: - Is this necessary as you can wrap the

[jira] [Created] (THRIFT-3533) Can not send nil pointer as service method argument

Chris Bannister created THRIFT-3533: --- Summary: Can not send nil pointer as service method argument Key: THRIFT-3533 URL: https://issues.apache.org/jira/browse/THRIFT-3533 Project: Thrift

[jira] [Commented] (THRIFT-3799) Make constants to use iota

[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344427#comment-15344427 ] Chris Bannister commented on THRIFT-3799: - I would say this is not a good idea, and is not

[jira] [Comment Edited] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090984#comment-15090984 ] Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:12 AM: --- In

[jira] [Comment Edited] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090984#comment-15090984 ] Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:11 AM: --- In

[jira] [Comment Edited] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090984#comment-15090984 ] Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:09 AM: --- In

[jira] [Comment Edited] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090984#comment-15090984 ] Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:09 AM: --- In

[jira] [Comment Edited] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090984#comment-15090984 ] Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:08 AM: --- In

[jira] [Comment Edited] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090984#comment-15090984 ] Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:11 AM: --- In

[jira] [Comment Edited] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090984#comment-15090984 ] Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:10 AM: --- In

[jira] [Comment Edited] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090984#comment-15090984 ] Chris Bannister edited comment on THRIFT-3533 at 1/10/16 11:10 AM: --- In

[jira] [Commented] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090984#comment-15090984 ] Chris Bannister commented on THRIFT-3533: - In python you can write this, service.method(None)

[jira] [Updated] (THRIFT-3575) Go compiler tries to use unexported library methods when using read_write_private

[ https://issues.apache.org/jira/browse/THRIFT-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-3575: Attachment: 0001-go-dont-use-reader-writer-names-for-lib-functions.patch > Go compiler

[jira] [Created] (THRIFT-3575) Go compiler tries to use unexported library methods when using read_write_private

Chris Bannister created THRIFT-3575: --- Summary: Go compiler tries to use unexported library methods when using read_write_private Key: THRIFT-3575 URL: https://issues.apache.org/jira/browse/THRIFT-3575

[jira] [Commented] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108954#comment-15108954 ] Chris Bannister commented on THRIFT-3533: - [~jensg] can you take a look at this patch, it causes

[jira] [Updated] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-3533: Attachment: 0001-go-compiler-handle-nil-fields-correctly.patch > Can not send nil pointer

[jira] [Updated] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-3533: Patch Info: Patch Available > Can not send nil pointer as service method argument >

[jira] [Comment Edited] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109649#comment-15109649 ] Chris Bannister edited comment on THRIFT-3533 at 1/20/16 10:56 PM: ---

[jira] [Comment Edited] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109649#comment-15109649 ] Chris Bannister edited comment on THRIFT-3533 at 1/20/16 10:50 PM: ---

[jira] [Commented] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109649#comment-15109649 ] Chris Bannister commented on THRIFT-3533: - Yeah that is a bit of a pain, I think that comes down

[jira] [Commented] (THRIFT-3805) Golang server susceptible to memory spike from malformed message

[ https://issues.apache.org/jira/browse/THRIFT-3805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275738#comment-15275738 ] Chris Bannister commented on THRIFT-3805: - The check for the buffer size should be, size <=

[jira] [Commented] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266835#comment-15266835 ] Chris Bannister commented on THRIFT-3533: - [~jensg] sorry for the delay, can you take a look at

[jira] [Updated] (THRIFT-3533) Can not send nil pointer as service method argument

[ https://issues.apache.org/jira/browse/THRIFT-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-3533: Attachment: 0001-THRIFT-3533-go-check-that-the-struct-is-nil-before-w.patch > Can not send

[jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: Attachment: 0001-go-pull-generated-send-recv-into-lib.patch > Pull generated send/recv

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124955#comment-16124955 ] Chris Bannister commented on THRIFT-4285: - This is a breaking change for the generated code as

[jira] [Created] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

Chris Bannister created THRIFT-4285: --- Summary: Pull generated send/recv into library to allow behaviour to be customised Key: THRIFT-4285 URL: https://issues.apache.org/jira/browse/THRIFT-4285

[jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: Attachment: 0001-go-pull-generated-send-recv-into-lib-2.patch removed unnecessary

[jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: Attachment: 0001-go-pull-generated-send-recv-into-lib-v3.patch Export TStandardClient as

[jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: Attachment: (was: 0001-go-pull-generated-send-recv-into-lib.patch) > Pull generated

[jira] [Comment Edited] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132000#comment-16132000 ] Chris Bannister edited comment on THRIFT-4285 at 8/18/17 10:05 AM: --- Fix

[jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: Attachment: 0001-go-pull-generated-send-recv-into-lib-v4.patch Fix typo, use tmp names for

[jira] [Comment Edited] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155962#comment-16155962 ] Chris Bannister edited comment on THRIFT-4285 at 9/6/17 8:16 PM: - Updated

[jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: Attachment: 0001-go-pull-generated-send-recv-into-lib-v7.patch Updated all tests

[jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: Attachment: (was: 0001-go-pull-generated-send-recv-into-lib-v5.patch) > Pull generated

[jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: Attachment: 0001-go-pull-generated-send-recv-into-lib-v5.patch Fix nil error with a set

[jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: Attachment: (was: 0001-go-pull-generated-send-recv-into-lib-2.patch) > Pull generated

[jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: Attachment: (was: 0001-go-pull-generated-send-recv-into-lib-v4.patch) > Pull generated

[jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: Attachment: (was: 0001-go-pull-generated-send-recv-into-lib-v3.patch) > Pull generated

[jira] [Updated] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bannister updated THRIFT-4285: Attachment: 0001-go-pull-generated-send-recv-into-lib-v6.patch Fixed and updated the tests