[
https://issues.apache.org/jira/browse/TINKERPOP-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133884#comment-16133884
]
ASF GitHub Bot commented on TINKERPOP-1754:
---
Github user asfgit closed the p
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/696
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
[
https://issues.apache.org/jira/browse/TINKERPOP-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Kuppitz closed TINKERPOP-1748.
-
Resolution: Fixed
Fix Version/s: 3.2.6
3.3.0
> Callout comme
[
https://issues.apache.org/jira/browse/TINKERPOP-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133629#comment-16133629
]
ASF GitHub Bot commented on TINKERPOP-1748:
---
Github user asfgit closed the p
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/694
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133385#comment-16133385
]
Martin Tapp commented on TINKERPOP-1753:
[~dkuppitz] Yeah, you're totally righ
[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133370#comment-16133370
]
ASF GitHub Bot commented on TINKERPOP-1753:
---
Github user okram commented on
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/697
Cleaner `if/else` clause.
```
return first instanceof Number && second instanceof Number ?
NumberHelper.compare((Number) second, (Number) first) :
Comparator.<~>naturalOr
[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133291#comment-16133291
]
Daniel Kuppitz commented on TINKERPOP-1753:
---
{quote}
but kinda slow hack
{qu
[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133280#comment-16133280
]
Martin Tapp commented on TINKERPOP-1753:
Much cleaner, excellent!
> OrderStep
[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133269#comment-16133269
]
ASF GitHub Bot commented on TINKERPOP-1753:
---
Github user dkuppitz commented
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/697
Alright, turned out it doesn't have a measurable performance impact.
```
if (first instanceof Number && second instanceof Number) {
return NumberHelper.compare((Number) second,
[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133213#comment-16133213
]
Martin Tapp commented on TINKERPOP-1753:
[~dkuppitz] Ok, got it. So should wor
Good point. I went ahead and created two releases, corresponding to TinkerPop
3.2.5
and TinkerPop 3.3.0-SNAPSHOT:
https://github.com/karthicks/gremlin-ogm/releases
The two versions are essentially the same, except for the TinkerPop version
that they
depend on.
Regards,
Karthick
On 2017-08-17
[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133139#comment-16133139
]
ASF GitHub Bot commented on TINKERPOP-1753:
---
Github user okram commented on
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/697
Eek. Yea. That `try/catch` sorta sucks. Can you do some performance testing
with and without they `try/catch`? Would you mind?
---
If your project is set up for it, you can reply to this email and
[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133015#comment-16133015
]
Daniel Kuppitz commented on TINKERPOP-1753:
---
This was your original traversa
[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132996#comment-16132996
]
Martin Tapp edited comment on TINKERPOP-1753 at 8/18/17 2:04 PM:
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132996#comment-16132996
]
Martin Tapp commented on TINKERPOP-1753:
In my case I add a list of Long value
[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132984#comment-16132984
]
ASF GitHub Bot commented on TINKERPOP-1753:
---
GitHub user dkuppitz opened a p
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/697
Btw, I will update `CHANGELOG` after the code freeze.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/TINKERPOP-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132985#comment-16132985
]
ASF GitHub Bot commented on TINKERPOP-1753:
---
Github user dkuppitz commented
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/697
TINKERPOP-1753 OrderStep not able to order by non-integer numbers
https://issues.apache.org/jira/browse/TINKERPOP-1753
Fixed ordering of collections / streams containing mixed number typ
[
https://issues.apache.org/jira/browse/TINKERPOP-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132213#comment-16132213
]
ASF GitHub Bot commented on TINKERPOP-1748:
---
Github user dkuppitz commented
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/694
Well, this PR only tackles the callout comments. Any other comment would
still break copy+paste. However, the cool thing about this solution is, that it
doesn't involve JavaScript, only a minor C
[
https://issues.apache.org/jira/browse/TINKERPOP-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132185#comment-16132185
]
ASF GitHub Bot commented on TINKERPOP-1754:
---
Github user spmallette commente
[
https://issues.apache.org/jira/browse/TINKERPOP-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132184#comment-16132184
]
ASF GitHub Bot commented on TINKERPOP-1748:
---
Github user spmallette commente
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/696
I plan to merge this via CTR - I don't feel like there's a need to vote on
this one. It's pretty straightforward.
---
If your project is set up for it, you can reply to this email and have you
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/694
This looks good - does this basically allow us to close:
https://issues.apache.org/jira/browse/TINKERPOP-1447
It doesn't do everything that ticket says, but that's about as goo
[
https://issues.apache.org/jira/browse/TINKERPOP-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132114#comment-16132114
]
ASF GitHub Bot commented on TINKERPOP-1754:
---
GitHub user artem-aliev opened
GitHub user artem-aliev opened a pull request:
https://github.com/apache/tinkerpop/pull/696
TINKERPOP-1754: Do not add non deserialisable exception to ScriptRecoâ¦
â¦rdReader IOExceptions
You can merge this pull request into a Git repository by running:
$ git pull https://git
[
https://issues.apache.org/jira/browse/TINKERPOP-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette reassigned TINKERPOP-1754:
---
Assignee: stephen mallette
Affects Version/s: (was: 3.3.0
Artem Aliev created TINKERPOP-1754:
--
Summary: Spark can not deserialise some ScriptRecordReader parse
exceptions
Key: TINKERPOP-1754
URL: https://issues.apache.org/jira/browse/TINKERPOP-1754
Project:
33 matches
Mail list logo
