[jira] [Closed] (TINKERPOP-1764) Generalize MatchStep to localize all barriers, not just reducing barriers.

2017-09-05 Thread Marko A. Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marko A. Rodriguez closed TINKERPOP-1764. - Resolution: Fixed Assignee: Marko A. Rodriguez Fix Version/s: 3

[jira] [Commented] (TINKERPOP-1764) Generalize MatchStep to localize all barriers, not just reducing barriers.

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154503#comment-16154503 ] ASF GitHub Bot commented on TINKERPOP-1764: --- Github user asfgit closed the p

[GitHub] tinkerpop pull request #702: TINKERPOP-1764: Generalize MatchStep to localiz...

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/702 ---

[jira] [Closed] (TINKERPOP-1760) OLAP compilation failing around ConnectiveStrategy

2017-09-05 Thread Marko A. Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marko A. Rodriguez closed TINKERPOP-1760. - Resolution: Fixed Fix Version/s: 3.2.7 > OLAP compilation failing aroun

[jira] [Closed] (TINKERPOP-1762) Make MatchStep analyze mid-clause variables for executing ordering purposes.

2017-09-05 Thread Marko A. Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marko A. Rodriguez closed TINKERPOP-1762. - Resolution: Fixed Fix Version/s: 3.2.7 > Make MatchStep analyze mid-cla

[GitHub] tinkerpop pull request #701: TINKERPOP-1762: Make MatchStep analyze mid-clau...

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/701 ---

[jira] [Commented] (TINKERPOP-1762) Make MatchStep analyze mid-clause variables for executing ordering purposes.

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154446#comment-16154446 ] ASF GitHub Bot commented on TINKERPOP-1762: --- Github user asfgit closed the p

[jira] [Commented] (TINKERPOP-1756) Provide a way to easily mock a RemoteConnection for tests

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154017#comment-16154017 ] ASF GitHub Bot commented on TINKERPOP-1756: --- Github user dkuppitz commented

[GitHub] tinkerpop issue #703: TINKERPOP-1756 Added an EmbeddedRemoteConnection.

2017-09-05 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/703 VOTE: +1 ---

[jira] [Closed] (TINKERPOP-1759) Improve hashcode and equals for Traverser implementations

2017-09-05 Thread Daniel Kuppitz (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Kuppitz closed TINKERPOP-1759. - Resolution: Fixed Fix Version/s: 3.3.1 3.2.7 > Improve hashc

[jira] [Commented] (TINKERPOP-1759) Improve hashcode and equals for Traverser implementations

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153976#comment-16153976 ] ASF GitHub Bot commented on TINKERPOP-1759: --- Github user asfgit closed the p

[GitHub] tinkerpop pull request #699: TINKERPOP-1759 Improve hashcode and equals for ...

2017-09-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/699 ---

[jira] [Commented] (TINKERPOP-1762) Make MatchStep analyze mid-clause variables for executing ordering purposes.

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153973#comment-16153973 ] ASF GitHub Bot commented on TINKERPOP-1762: --- Github user dkuppitz commented

[GitHub] tinkerpop issue #701: TINKERPOP-1762: Make MatchStep analyze mid-clause vari...

2017-09-05 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/701 VOTE: +1 ---

[jira] [Commented] (TINKERPOP-1759) Improve hashcode and equals for Traverser implementations

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153972#comment-16153972 ] ASF GitHub Bot commented on TINKERPOP-1759: --- Github user robertdale commente

[GitHub] tinkerpop issue #699: TINKERPOP-1759 Improve hashcode and equals for Travers...

2017-09-05 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/699 VOTE +1 ---

[jira] [Commented] (TINKERPOP-1764) Generalize MatchStep to localize all barriers, not just reducing barriers.

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153961#comment-16153961 ] ASF GitHub Bot commented on TINKERPOP-1764: --- Github user spmallette commente

[GitHub] tinkerpop issue #702: TINKERPOP-1764: Generalize MatchStep to localize all b...

2017-09-05 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/702 Nice upgrade docs - VOTE +1 ---

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153956#comment-16153956 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user spmallette commente

[GitHub] tinkerpop issue #695: TINKERPOP-1489 JavaScript GLV

2017-09-05 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/695 I rebased this today and added the nashorn scriptengine implementation for `GremlinScriptEngine`. I'd like to get us running tests with js the way we do with python since it's jsr223 compliant.

[jira] [Commented] (TINKERPOP-1692) Bump to Neo4j 3.2.3

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153943#comment-16153943 ] ASF GitHub Bot commented on TINKERPOP-1692: --- Github user spmallette commente

[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2

2017-09-05 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/680 All tests pass with `docker/build.sh -t -n -i` VOTE +1 ---

Re: io and graphson-v3

2017-09-05 Thread pieter gmail
Ok, at present there is only one SimpleModule, the default. I can make it v2 or v3 but not both. Lets say I make the SimpleModule support V2. Then when calling IoEdgeTest for     {"graphson-v3", true, true,     (Function) g -> g.io(IoCore.graphson()).reader().mapper(g.io(GraphSONIo.build(G

Re: io and graphson-v3

2017-09-05 Thread Stephen Mallette
I guess I'm trying to understand why it matters for purpose of the test. If you mix/match versions I can't think of why the test would care one way or the other. does sqlg serialize its id to a JSON Map? On Tue, Sep 5, 2017 at 11:19 AM, pieter gmail wrote: > I looked at TinkerGraph's implementat

Re: io and graphson-v3

2017-09-05 Thread pieter gmail
I looked at TinkerGraph's implementation. In fact I copied it. TinkerGraph does not have any special id serialization. In fact both its TinkerIoRegistryV3d0 andTinkerIoRegistryV2d0 registry uses TinkerModuleV2d0. In IoCustomTest tests you call g.io(GraphSONIo.build(GraphSONVersion.V2_0)).mapp

Re: io and graphson-v3

2017-09-05 Thread Stephen Mallette
You have registries for each version as well and default to v3. Please see TinkerGraph: https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraph.java#L198 If the user wants to override that then that's their c

Re: io and graphson-v3

2017-09-05 Thread pieter gmail
Afraid I still don't quite get it. How do I register the different SimpleModules depending on the version. Currently it starts in SqlgGraph, @Override public I io(final Io.Builder builder) {     return (I) builder.graph(this).onMapper(mapper -> mapper.addRegistry(SqlgIoRegistry.getInstance())

[jira] [Commented] (TINKERPOP-1759) Improve hashcode and equals for Traverser implementations

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153616#comment-16153616 ] ASF GitHub Bot commented on TINKERPOP-1759: --- Github user robertdale commente

[GitHub] tinkerpop pull request #699: TINKERPOP-1759 Improve hashcode and equals for ...

2017-09-05 Thread robertdale
Github user robertdale commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/699#discussion_r136983503 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_O_Traverser.java --- @@ -62,10 +62,12 @@ public void s

[DISCUSS] Add S2Graph to Listing

2017-09-05 Thread Stephen Mallette
The 0.2.0-incubating release of Apache S2Graph has TinkerPop support. They've just updated their documentation to include this information: https://github.com/apache/incubator-s2graph#tinkerpop-support I think they meet our index listing policy at this point and we can get them added to the home

Re: io and graphson-v3

2017-09-05 Thread Stephen Mallette
I think you should just create a new SimpleModule for each version - don't try to put them in the same SqlgSimpleModule. It's a naming convention that users will have to follow rather than something explicitly enforced through code. On Sun, Sep 3, 2017 at 3:20 PM, pieter gmail wrote: > Hi, > > I