I'm proposing the addition of a new types of map/list/set with specified
child types. There is no doubt about the need of a map which keys are
objects (like in groupCount()) and the benefits of using a g:Map over plain
json objects in GraphSON3.
> is that basically the core of the usability proble
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/716
We forgot to consider that, as we are strong named assembly, we must avoid
changing the assembly version for patch versions to minimize the need of
user-defined binding redirects.
In our
[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172953#comment-16172953
]
ASF GitHub Bot commented on TINKERPOP-1785:
---
Github user jorgebay commented
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/717
does this fix only go to master for some reason? or can it also go on tp32?
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172995#comment-16172995
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user spmallette commente
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/710
Rebased onto master, tests pass with `mvn clean install -P gremlin-dotnet`.
VOTE +1
I'll merge it once CI jobs finish.
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172999#comment-16172999
]
ASF GitHub Bot commented on TINKERPOP-1730:
---
Github user jorgebay commented
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/716
Thanks @jorgebay - i wasn't aware of that issue. How does it look now?
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173040#comment-16173040
]
ASF GitHub Bot commented on TINKERPOP-1785:
---
Github user spmallette commente
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/705#discussion_r139944078
--- Diff: CHANGELOG.asciidoc ---
@@ -26,6 +26,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
TinkerPop 3.2.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/705#discussion_r139944071
--- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc ---
@@ -88,6 +88,11 @@ to the list of locally computed clauses.
See:
link:https
[
https://issues.apache.org/jira/browse/TINKERPOP-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173046#comment-16173046
]
ASF GitHub Bot commented on TINKERPOP-1764:
---
Github user spmallette commente
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/705
Added a couple of minor nits as comments, but otherwise:
VOTE +1
@mpollmeier if you vote yourself, you'll have your 3 +1s and can merge.
please be sure to merge tp32 to master
It would be an option to turn off script processing, but if you're saying
that you believe that would almost never be possible (as most production
systems will use lambdas) then there probably isn't much point to adding
the option. Scripts will always just be there and users will have to
appropriat
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139960637
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/step/map/PageRankVertexProgramStep.java
---
@@ -47,7 +47,7
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139960786
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/ranking/pagerank/PageRankVertexProgram.java
---
@@ -155,61 +161,61 @@
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139962306
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/computer/ranking/pagerank/PageRankVertexProgramTest.java
---
@@ -38,7 +38,7 @@
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173145#comment-16173145
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user dkuppitz commented
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173147#comment-16173147
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user dkuppitz commented
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173146#comment-16173146
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user dkuppitz commented
>
> Like a good example of where I tend to get stuck with Gremlin is "math"
Exactly. It's mostly simple calculations using customer specific formulas.
Many calculations could be done using sack(), but .map { /* do the math */ }
is a) more flexible and b) faster as it's just a single step. String
Network security is out of scope. It's generally applicable. There's
nothing peculiar to Gremlin Server that would warrant its own section on
network security.
I could see where a security-first approach is taken and scripting would be
off by default. This forces the user to be somewhat more aware
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/716#discussion_r139970813
--- Diff: gremlin-dotnet/glv/Gremlin.Net.csproj.template ---
@@ -25,7 +25,9 @@ limitations under the License.
-${projectVers
[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173186#comment-16173186
]
ASF GitHub Bot commented on TINKERPOP-1785:
---
Github user jorgebay commented
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/716#discussion_r139976910
--- Diff: gremlin-dotnet/glv/Gremlin.Net.csproj.template ---
@@ -25,7 +25,9 @@ limitations under the License.
-${proj
[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173211#comment-16173211
]
ASF GitHub Bot commented on TINKERPOP-1785:
---
Github user FlorianHockmann com
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/716#discussion_r139980666
--- Diff: gremlin-dotnet/glv/Gremlin.Net.csproj.template ---
@@ -25,7 +25,9 @@ limitations under the License.
-${projectVe
[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173227#comment-16173227
]
ASF GitHub Bot commented on TINKERPOP-1785:
---
Github user spmallette commente
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139984575
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/step/map/PageRankVertexProgramStep.java
---
@@ -47,7 +47,7 @@
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173237#comment-16173237
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user okram commented on
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139984956
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/ranking/pagerank/PageRankVertexProgram.java
---
@@ -155,61 +161,61 @@ pu
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139985206
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/computer/ranking/pagerank/PageRankVertexProgramTest.java
---
@@ -38,7 +38,7 @@
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173240#comment-16173240
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user okram commented on
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173238#comment-16173238
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user okram commented on
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/717
@spmallette -- I'm putting this into `TP 3.3.x` because it is a breaking
change. I believe it is too late into `3.2.x` to introduce such changes.
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173243#comment-16173243
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user okram commented on
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/716#discussion_r139986227
--- Diff: gremlin-dotnet/glv/Gremlin.Net.csproj.template ---
@@ -25,7 +25,9 @@ limitations under the License.
-${proj
[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173247#comment-16173247
]
ASF GitHub Bot commented on TINKERPOP-1785:
---
Github user FlorianHockmann com
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/717
You know what we should do. It should be `maxIterations`. This way, if it
converges before hand, great. Done. If it doesn't, well, it will go for
`maxIterations` and then stop. This way `epsilon` an
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173258#comment-16173258
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user okram commented on
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/717
Pushed `maxIterations` concept.
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173276#comment-16173276
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user okram commented on
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/716#discussion_r139991264
--- Diff: gremlin-dotnet/glv/Gremlin.Net.csproj.template ---
@@ -25,7 +25,9 @@ limitations under the License.
-${projectVe
[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173287#comment-16173287
]
ASF GitHub Bot commented on TINKERPOP-1785:
---
Github user spmallette commente
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139991489
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/computer/ranking/pagerank/PageRankVertexProgramTest.java
---
@@ -38,7 +38,7 @@
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173289#comment-16173289
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user dkuppitz commented
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139991682
--- Diff: docs/src/upgrade/release-3.3.x.asciidoc ---
@@ -32,6 +32,43 @@ Please see the
link:https://github.com/apache/tinkerpop/blob/3.3.1/CHANGELOG.a
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette updated TINKERPOP-1783:
Labels: breaking (was: )
> PageRank gives incorrect results for graphs with sin
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173290#comment-16173290
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user spmallette commente
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139992366
--- Diff: docs/src/upgrade/release-3.3.x.asciidoc ---
@@ -32,6 +32,43 @@ Please see the
link:https://github.com/apache/tinkerpop/blob/3.3.1/CHANGELOG.asc
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173294#comment-16173294
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user okram commented on
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173299#comment-16173299
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user okram commented on
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/717#discussion_r139994557
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/computer/ranking/pagerank/PageRankVertexProgramTest.java
---
@@ -38,7 +38,7 @@
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/716
`dotnet pack gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj -c Release`
generates the package containing with assembly with the intended attributes.
VOTE +1
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173302#comment-16173302
]
ASF GitHub Bot commented on TINKERPOP-1785:
---
Github user jorgebay commented
I agree with Robert that the scripting-off option would work, but would
have to be the default. I've run into people who aren't particularly happy
about having to `def` variables because we've enabled a sandbox. I think
saying, "These are not enabled by default" in the docs would be a
necessity. Be
Is there and alternative on the GLV side? Could the GLV detect valueMap()
as the last step and make the conversion appropriately?
I haven't gone into deep thought on altering GraphSON in the manner you
describe, but without knowing other options it makes me feel uneasy to
think about. hehe
On W
[
https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173369#comment-16173369
]
stephen mallette commented on TINKERPOP-1731:
-
I just rebased this branch
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/716
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173453#comment-16173453
]
ASF GitHub Bot commented on TINKERPOP-1785:
---
Github user asfgit closed the p
[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1785.
---
Resolution: Done
Assignee: stephen mallette
Fix Version/s: 3.3.1
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/717
VOTE: +1
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173462#comment-16173462
]
ASF GitHub Bot commented on TINKERPOP-1783:
---
Github user dkuppitz commented
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/710
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173541#comment-16173541
]
ASF GitHub Bot commented on TINKERPOP-1730:
---
Github user asfgit closed the p
[
https://issues.apache.org/jira/browse/TINKERPOP-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Bay updated TINKERPOP-1730:
-
Fix Version/s: 3.3.1
> Gremlin .NET support for GraphSON 3.0
> ---
[
https://issues.apache.org/jira/browse/TINKERPOP-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Bay closed TINKERPOP-1730.
Resolution: Done
> Gremlin .NET support for GraphSON 3.0
> -
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/712
Rebased on tp32, but now one of the two CI builds failed due to a failing
test in `spark-gremlin`:
`SparkContextStorageCheck.shouldSupportDirectoryFileDistinction`. From what I
can see, t
[
https://issues.apache.org/jira/browse/TINKERPOP-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173734#comment-16173734
]
ASF GitHub Bot commented on TINKERPOP-1752:
---
Github user FlorianHockmann com
[
https://issues.apache.org/jira/browse/TINKERPOP-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173743#comment-16173743
]
ASF GitHub Bot commented on TINKERPOP-1752:
---
Github user spmallette commente
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/712
Travis is a flakey - I tend to think of a failure as a warning especially
when one passes and one fails. I wouldn't worry about it. If you did your own
build and all is good then no problem.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/705
---
Github user mpollmeier commented on the issue:
https://github.com/apache/tinkerpop/pull/705
Thanks @spmallette. I already voted +1 above. Made those changes, merged
(--no-ff) to tp32 and then merged tp32 to master (again --no-ff).
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/712
Ok, good to know.
In addition to the Gremlin.Net tests, all tests pass with `docker/build.sh
-t -i`.
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174307#comment-16174307
]
ASF GitHub Bot commented on TINKERPOP-1752:
---
Github user FlorianHockmann com
75 matches
Mail list logo
