Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
@pluradj I noticed that too. I was thinking that metaclass could be used to
intercept calls to groovy shell's Preferences class and gremlin console could
have its own Java Preferences node. Thi
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/384
I retested with the latest commits. Setting a preference value with spaces
worked, remotes worked nicely with `conf/remote-objects.yaml`. Nice work
@robertdale.
`mvn clean install -pl gre
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/384
someone might want to run:
```
mvn clean install -pl gremlin-console -DskipIntegrationTests=false
```
before merge (now that there are sufficient votes to do so)
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
The previous commit to fix :set with quoted spaces did break :remote
commands because the parser stripped the quotes. Since :set command is the only
one affected, I made a quick hack for it whi
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/384
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/384
The colorization stuff looks good.
One small problem I've run into is that you can't set a prompt string that
contains spaces. For example, I tried `:set result.prompt 'result => '` and go
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/384
awesome!! VOTE: +1 from me as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Good news, it works on Windows.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/384
_hoping I don't have to fire up that old machine_ :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/384
@pluradj sucks the wind out of the PR - hahaha
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/384
@robertdale did you test this on Windows?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/384
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
I'm done with changes. Carry on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
I think I'll leave templating for another jira ticket. :satisfied:
Currently, themes (really any `:set` commands) can be saved into files and
loaded with `:load my-gremlin.theme`.
---
If yo
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Great. What do you think about `:set color.template=black-background`,
`:set color.template=white-background`, etc. And then from there, those "MACRO"
command will trigger a series of set error, mes
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Disco disco! ANSI is enabled by default. This is actually not a change. It
was this way before this PR. No color scheme by default. If you want colors,
you have to set them yourself. Added co
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Thoughts:
1. I think there is a bit of an overdose of options here. Keep it simple.
2. We have to realize that not everyone has a black background as their
terminal. I use a light b
Github user alaam commented on the issue:
https://github.com/apache/tinkerpop/pull/384
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Attached groovy script that prints the color palette. usage: groovy
jansi-colors.txt
[jansi-colors.txt](https://github.com/apache/tinkerpop/files/427016/jansi-colors.txt)
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Oh nice, I like that.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
I'm definitely not the right person to pick a color scheme. Open for
suggestions or we can figure it out later. Committed the vertex, edge, path
coloring so you can see.
---
If your project i
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Awesome! I don't like the color choice, but it's good to see that it works.
How did you do it? Did you overwrite the respective `toString()` methods?
---
If your project is set up for it, you ca
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
I think a mockup of the desired coloring effect would be nice to have.
Currently elements just have toString called on them. I added a vertex.color
and edge.color for demonstration purposes. H
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/384
nice @robertdale - a final request from my end would be documentation.
perhaps a word or two added to the docs about these settings. I guess the
reference docs might be the best place for that:
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
## Color codes:
-BLACK
- RED
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/384
+1 for `:set`. Look at our other `sets` to get a consistent naming
convention, please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/384
+1 for use of `:set`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Would you really want a separate preferences (properties) file or rather
reuse the existing preferences mechanism (:set gremlin.console.errorMessage
red) ?
---
If your project is set up for i
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
There are some things that are out of our control because they are
inherited from groovy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user alaam commented on the issue:
https://github.com/apache/tinkerpop/pull/384
+1 for having this be a preferences file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Whoa. This is really cool. However, I think we should have a
`.gremlin_preferences` style file where we do this:
```
gremlin.console.errorMessage=red
gremlin.console.prompt=white
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Hm, now the console has some colors, that's nice, but `TINKERPOP-1037` is
actually about output coloring (which means to me, that results should have a
bit of syntax coloring, right?). What do we
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Screenshot:
---
If your project is set up for it, you c
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/384
Like I said, you did all the hard work. I just added color. Try this in
your console:
gremlin> "@|bold,green Hello |@ "
==>Hello
---
If your project is set up for it, y
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/384
that looks like all the same code i've written in the
past...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
35 matches
Mail list logo
